titanous-scrobbler 0.2.2 → 0.2.3

data/History.txt

@@ -1,3 +1,4 @@
+* v 0.2.3: changed the way things get escaped in hopes that it would fix some problems some were having
 * v 0.2.2: a bunch of changes from titanous, mostly refactoring
 * v 0.2.0: added support for scrobbling tracks and now playing submission (Titanous)
 * v 0.1.0: initial release

data/README.rdoc

@@ -104,4 +104,8 @@ Below is just a sampling of how easy this lib is to use.
                                      :track_number => 1)
 
     playing.submit!         
-    puts "Playing Submission Status: #{playing.status}"
+    puts "Playing Submission Status: #{playing.status}"
+    
+== Docs
+
+http://rdoc.info/projects/jnunemaker/scrobbler

data/examples/track.rb

@@ -1,6 +1,10 @@
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib', 'scrobbler'))
+require 'pp'
 
 track = Scrobbler::Track.new('Carrie Underwood', 'Before He Cheats')
 puts 'Fans'
 puts "=" * 4
-track.fans.each { |u| puts "(#{u.weight}) #{u.username}" }
+track.fans.each { |u| puts "(#{u.weight}) #{u.username}" }
+
+track = Scrobbler::Track.new('U2 & Green Day', 'The Saints Are Coming')
+pp track.tags

data/lib/scrobbler/rest.rb

@@ -21,8 +21,7 @@ module Scrobbler
   			url = URI.join(@base_url, resource)
 
   			if args
-  				# TODO: What about keys without value?
-  				url.query = args.map { |k,v| "%s=%s" % [URI.encode(k.to_s), URI.encode(v.to_s)] }.join("&")
+  				url.query = args.map { |k,v| "%s=%s" % [escape(k.to_s), escape(v.to_s)] }.join("&")
   			end
 
   			case method
@@ -42,6 +41,11 @@ module Scrobbler
   			res = http.start() { |conn| conn.request(req) }
   			res.body
   		end
+  		
+  		private
+  		  def escape(str)
+  		    URI.escape(str, Regexp.new("[^#{URI::PATTERN::UNRESERVED}]"))
+  		  end
   	end
   end
 end

data/lib/scrobbler/version.rb

@@ -1,3 +1,3 @@
 module Scrobbler
-  Version = '0.2.2'
+  Version = '0.2.3'
 end

data/scrobbler.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{scrobbler}
-  s.version = "0.2.2"
+  s.version = "0.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["John Nunemaker, Jonathan Rudenberg"]
-  s.date = %q{2008-12-23}
+  s.date = %q{2009-04-13}
   s.description = %q{wrapper for audioscrobbler (last.fm) web services}
   s.email = %q{nunemaker@gmail.com}
   s.extra_rdoc_files = ["lib/scrobbler/album.rb", "lib/scrobbler/artist.rb", "lib/scrobbler/base.rb", "lib/scrobbler/chart.rb", "lib/scrobbler/playing.rb", "lib/scrobbler/rest.rb", "lib/scrobbler/scrobble.rb", "lib/scrobbler/simpleauth.rb", "lib/scrobbler/tag.rb", "lib/scrobbler/track.rb", "lib/scrobbler/user.rb", "lib/scrobbler/version.rb", "lib/scrobbler.rb", "README.rdoc"]
@@ -31,11 +31,9 @@ Gem::Specification.new do |s|
     else
       s.add_dependency(%q<hpricot>, [">= 0.4.86"])
       s.add_dependency(%q<activesupport>, [">= 1.4.2"])
-      s.add_dependency(%q<echoe>, [">= 0"])
     end
   else
     s.add_dependency(%q<hpricot>, [">= 0.4.86"])
     s.add_dependency(%q<activesupport>, [">= 1.4.2"])
-    s.add_dependency(%q<echoe>, [">= 0"])
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: titanous-scrobbler
 version: !ruby/object:Gem::Version 
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors: 
 - John Nunemaker, Jonathan Rudenberg
@@ -9,11 +9,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-12-23 00:00:00 -08:00
+date: 2009-04-13 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: hpricot
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -23,6 +24,7 @@ dependencies:
     version: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -32,6 +34,7 @@ dependencies:
     version: 
 - !ruby/object:Gem::Dependency 
   name: echoe
+  type: :development
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: