tinybucket 1.0.1 → 1.1.0

data/spec/lib/tinybucket/client_spec.rb

@@ -16,12 +16,14 @@ RSpec.describe Tinybucket::Client do
 
       context 'without options' do
         subject { client.repos }
-        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
+        it { expect(subject).to be_instance_of(Tinybucket::Resource::Repos) }
+        it { expect(subject.instance_variable_get(:@owner)).to be_nil }
       end
       context 'with options' do
         subject { client.repos(options) }
         let(:options) { {} }
-        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
+        it { expect(subject).to be_instance_of(Tinybucket::Resource::Repos) }
+        it { expect(subject.instance_variable_get(:@owner)).to be_nil }
       end
     end
 
@@ -32,13 +34,15 @@ RSpec.describe Tinybucket::Client do
       context 'without options' do
         let(:request_path) { "/repositories/#{owner}" }
         subject { client.repos(owner) }
-        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
+        it { expect(subject).to be_instance_of(Tinybucket::Resource::Repos) }
+        it { expect(subject.instance_variable_get(:@owner)).to eq(owner) }
       end
       context 'with options' do
         let(:request_path) { "/repositories/#{owner}" }
         subject { client.repos(owner, options) }
         let(:options) { {} }
-        it { expect(subject).to be_instance_of(Tinybucket::Enumerator) }
+        it { expect(subject).to be_instance_of(Tinybucket::Resource::Repos) }
+        it { expect(subject.instance_variable_get(:@owner)).to eq(owner) }
       end
     end
 

data/spec/lib/tinybucket/model/build_status_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+
+RSpec.describe Tinybucket::Model::BuildStatus do
+  include ApiResponseMacros
+  include ModelMacros
+
+  let(:model_json) { load_json_fixture('build_status') }
+
+  let(:request_method) { :get }
+  let(:request_path) { nil }
+  let(:stub_options) { nil }
+
+  let(:commit_hash) { '1' }
+  let(:owner) { 'test_owner' }
+  let(:slug) { 'test_repo' }
+  let(:model) do
+    Tinybucket::Model::BuildStatus.new(model_json).tap do |m|
+      m.repo_owner = owner
+      m.repo_slug = slug
+      m.revision = commit_hash
+    end
+  end
+
+  before do
+    if request_path
+      opts = stub_options.present? ? stub_options : {}
+      stub_apiresponse(request_method, request_path, opts)
+    end
+  end
+
+  it_behaves_like 'model has acceptable_attributes',
+                  Tinybucket::Model::BuildStatus,
+                  load_json_fixture('build_status')
+
+  describe 'model can reloadable' do
+    let(:build_status) do
+      Tinybucket::Model::BuildStatus.new({}).tap do |m|
+        m.repo_owner = owner
+        m.repo_slug = slug
+        m.revision = commit_hash
+      end
+    end
+
+    before { @model = build_status }
+    it_behaves_like 'the model is reloadable'
+  end
+
+  describe '#update' do
+    let(:status_key) { 'test_status' }
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/1/statuses/build/#{status_key}"
+    end
+    let(:params) do
+      {
+        state: 'SUCCESSFUL',
+        name: 'test_repo test #10',
+        url: 'https://example.com/path/to/build/info',
+        description: 'Changes by test_owner'
+      }
+    end
+    let(:request_method) { :put }
+
+    subject { model.update(params) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Model::BuildStatus) }
+  end
+end

data/spec/lib/tinybucket/model/commit_spec.rb

@@ -51,7 +51,9 @@ RSpec.describe Tinybucket::Model::Commit do
       "/repositories/#{owner}/#{slug}/commit/1/comments"
     end
     subject { model.comments }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it 'return resource' do
+      expect(subject).to be_an_instance_of(Tinybucket::Resource::Commit::Comments)
+    end
   end
 
   describe '#comment' do
@@ -87,4 +89,20 @@ RSpec.describe Tinybucket::Model::Commit do
 
     it { expect(subject).to be_truthy }
   end
+
+  describe '#build_statuses' do
+    subject { model.build_statuses }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::Commit::BuildStatuses) }
+  end
+
+  describe '#build_status' do
+    let(:status_key) { 'test_status' }
+    let(:request_method) { :get }
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/1/statuses/build/#{status_key}"
+    end
+
+    subject { model.build_status(status_key) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Model::BuildStatus) }
+  end
 end

data/spec/lib/tinybucket/model/profile_spec.rb

@@ -35,18 +35,18 @@ RSpec.describe Tinybucket::Model::Profile do
   describe 'followers' do
     let(:request_path) { "/users/#{username}/followers" }
     subject { model.followers() }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::User::Followers) }
   end
 
   describe 'following' do
     let(:request_path) { "/users/#{username}/following" }
     subject { model.following }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::User::Following) }
   end
 
   describe 'repos' do
     let(:request_path) { "/repositories/#{username}" }
     subject { model.repos }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::User::Repos) }
   end
 end

data/spec/lib/tinybucket/model/pull_request_spec.rb

@@ -94,7 +94,7 @@ RSpec.describe Tinybucket::Model::PullRequest do
 
     subject { model.commits() }
 
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::PullRequest::Commits) }
   end
 
   describe 'comments' do
@@ -103,19 +103,7 @@ RSpec.describe Tinybucket::Model::PullRequest do
     end
 
     subject { model.comments }
-
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
-    it 'return comments which associate with this pull request' do
-      # extract iterator from enumerator.
-      iterator = subject.instance_variable_get(:@iterator)
-      # extract values from iterator.
-      values = iterator.instance_variable_get(:@values)
-
-      values.each do |comment|
-        expect(comment).to be_an_instance_of(Tinybucket::Model::Comment)
-        expect(comment.commented_to).to eq(model)
-      end
-    end
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::PullRequest::Comments) }
   end
 
   describe 'comment' do
@@ -138,8 +126,8 @@ RSpec.describe Tinybucket::Model::PullRequest do
       "/repositories/#{owner}/#{slug}/pullrequests/1/diff"
     end
     it { expect(subject).to be_instance_of(String) }
-
   end
+
   describe 'merge' do
     let(:request_method) { :post }
     let(:request_path) do

data/spec/lib/tinybucket/model/repository_spec.rb

@@ -52,47 +52,38 @@ RSpec.describe Tinybucket::Model::Repository do
 
     subject { model.pull_requests() }
 
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::PullRequests) }
   end
 
   describe '#pull_request' do
     let(:prid) { 1 }
 
-    describe 'with pull_request_id' do
-      subject { model.pull_request(prid) }
-      let(:request_path) do
-        "/repositories/#{owner}/#{slug}/pullrequests/#{prid}"
-      end
-      it 'return the specific pull_request model' do
-        expect(subject).to be_an_instance_of(Tinybucket::Model::PullRequest)
-        expect(subject.id).to eq(prid)
-      end
+    subject { model.pull_request(prid) }
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/pullrequests/#{prid}"
     end
-    describe 'without pull_request_id' do
-      subject { model.pull_request }
-      it 'return new pull_request model' do
-        expect(subject).to be_an_instance_of(Tinybucket::Model::PullRequest)
-        expect(subject.id).to be_nil
-      end
+    it 'return the specific pull_request model' do
+      expect(subject).to be_an_instance_of(Tinybucket::Model::PullRequest)
+      expect(subject.id).to eq(prid)
     end
   end
 
   describe '#watchers' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/watchers" }
     subject { model.watchers }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::Watchers) }
   end
 
   describe '#forks' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/forks" }
     subject { model.forks }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::Forks) }
   end
 
   describe '#commits' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/commits" }
     subject { model.commits }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Resource::Commits) }
   end
 
   describe '#commit' do
@@ -105,7 +96,10 @@ RSpec.describe Tinybucket::Model::Repository do
   describe '#branch_restrictions' do
     let(:request_path) { "/repositories/#{owner}/#{slug}/branch-restrictions" }
     subject { model.branch_restrictions }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it 'return resource model' do
+      expect(subject).to be_an_instance_of(
+        Tinybucket::Resource::BranchRestrictions)
+    end
   end
 
   describe '#branch_restriction' do

data/spec/lib/tinybucket/model/team_spec.rb

@@ -35,24 +35,36 @@ RSpec.describe Tinybucket::Model::Team do
   describe '#members' do
     let(:request_path) { "/teams/#{teamname}/members" }
     subject { model.members }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it 'return resource' do
+      expect(subject).to be_an_instance_of(
+        Tinybucket::Resource::Team::Members)
+    end
   end
 
   describe '#followers' do
     let(:request_path) { "/teams/#{teamname}/followers" }
     subject { model.followers() }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it 'return resource' do
+      expect(subject).to be_an_instance_of(
+        Tinybucket::Resource::Team::Followers)
+    end
   end
 
   describe '#following' do
     let(:request_path) { "/teams/#{teamname}/following" }
     subject { model.following }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it 'return resource' do
+      expect(subject).to be_an_instance_of(
+        Tinybucket::Resource::Team::Following)
+    end
   end
 
   describe '#repos' do
     let(:request_path) { "/teams/#{teamname}/repositories" }
     subject { model.repos }
-    it { expect(subject).to be_an_instance_of(Tinybucket::Enumerator) }
+    it 'return resource' do
+      expect(subject).to be_an_instance_of(
+        Tinybucket::Resource::Team::Repos)
+    end
   end
 end

data/spec/lib/tinybucket/resource/branch_restrictions_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+RSpec.describe Tinybucket::Resource::BranchRestrictions do
+  include ApiResponseMacros
+
+  let(:owner) { 'test_owner' }
+  let(:slug) { 'test_repo' }
+  let(:repo) do
+    Tinybucket::Model::Repository.new({}).tap do |m|
+      m.repo_owner = owner
+      m.repo_slug  = slug
+    end
+  end
+
+  let(:options) { {} }
+  let(:resource) { Tinybucket::Resource::BranchRestrictions.new(repo, options) }
+
+  describe 'constructor' do
+    subject { resource }
+    it 'create new instance' do
+      expect(subject).to be_an_instance_of(
+        Tinybucket::Resource::BranchRestrictions)
+    end
+  end
+
+  describe '#create' do
+    subject { resource.create({}) }
+    it { expect { subject.create }.to raise_error(NotImplementedError) }
+  end
+
+  describe '#find' do
+    let(:restriction_id) { '1' }
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/branch-restrictions/#{restriction_id}"
+    end
+    subject { resource.find(restriction_id, {}) }
+    before { stub_apiresponse(:get, request_path, {}) }
+    it 'return model' do
+      expect(subject).to be_an_instance_of(Tinybucket::Model::BranchRestriction)
+    end
+  end
+
+  describe 'Enumerable Methods' do
+    let(:request_path) { "/repositories/#{owner}/#{slug}/branch-restrictions" }
+    before { stub_enum_response(:get, request_path) }
+
+    describe '#take(1)' do
+      subject { resource.take(1) }
+      it { expect(subject).to be_an_instance_of(Array) }
+    end
+
+    describe '#each' do
+      it 'iterate models' do
+        resource.each do |m|
+          expect(m).to be_an_instance_of(Tinybucket::Model::BranchRestriction)
+        end
+      end
+    end
+  end
+end

data/spec/lib/tinybucket/resource/commit/build_statuses_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+RSpec.describe Tinybucket::Resource::Commit::BuildStatuses do
+  include ApiResponseMacros
+
+  let(:owner) { 'test_owner' }
+  let(:slug) { 'test_repo' }
+  let(:revision) { '1' }
+  let(:commit) do
+    Tinybucket::Model::Commit.new({}).tap do |m|
+      m.hash = revision
+      m.repo_owner = owner
+      m.repo_slug = slug
+    end
+  end
+
+  let(:options) { {} }
+  let(:resource) do
+    Tinybucket::Resource::Commit::BuildStatuses.new(commit, options)
+  end
+
+  let(:status_key) { 'test_status' }
+
+  describe '#find' do
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/#{revision}/statuses/build/#{status_key}"
+    end
+    subject { resource.find(status_key) }
+    before { stub_apiresponse(:get, request_path) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Model::BuildStatus) }
+  end
+
+  describe '#create' do
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/#{revision}/statuses/build"
+    end
+    let(:params) do
+      {
+        state: 'INPROGRESS',
+        name: 'test_repo test #10',
+        url: 'https://example.com/path/to/build/info',
+        description: 'Changes by test_owner'
+      }
+    end
+
+    before { stub_apiresponse(:post, request_path) }
+    subject { resource.create(status_key, params) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Model::BuildStatus) }
+  end
+end

data/spec/lib/tinybucket/resource/commit/comments_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+RSpec.describe Tinybucket::Resource::Commit::Comments do
+  include ApiResponseMacros
+
+  let(:owner) { 'test_owner' }
+  let(:slug) { 'test_repo' }
+  let(:revision) { '1' }
+  let(:commit) do
+    Tinybucket::Model::Commit.new({}).tap do |m|
+      m.hash = revision
+      m.repo_owner = owner
+      m.repo_slug = slug
+    end
+  end
+
+  let(:options) { {} }
+  let(:resource) { Tinybucket::Resource::Commit::Comments.new(commit, options) }
+
+  describe '#find' do
+    let(:comment_id) { '1' }
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/#{revision}/comments/#{comment_id}"
+    end
+    subject { resource.find(comment_id) }
+    before { stub_apiresponse(:get, request_path) }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Model::Comment) }
+  end
+
+  describe 'Enumerable Methods' do
+    let(:request_path) do
+      "/repositories/#{owner}/#{slug}/commit/#{revision}/comments"
+    end
+    before { stub_enum_response(:get, request_path) }
+
+    describe '#take(1)' do
+      subject { resource.take(1) }
+      it { expect(subject).to be_an_instance_of(Array) }
+    end
+
+    describe '#each' do
+      it 'iterate models' do
+        resource.each do |m|
+          expect(m).to be_an_instance_of(Tinybucket::Model::Comment)
+        end
+      end
+    end
+  end
+end