tiny_tds 1.0.4 → 3.2.0

data/patches/freetds/1.00.27/0002-Don-t-use-MSYS2-file-libws2_32.diff

@@ -0,0 +1,28 @@
+From 56e8972f66c3e948e2ad6885595c58fd23dcdb37 Mon Sep 17 00:00:00 2001
+From: Lars Kanis <kanis@comcard.de>
+Date: Thu, 6 Jul 2017 17:09:40 +0200
+Subject: [PATCH] Don't use MSYS2 file libws2_32.a for MINGW build
+
+This file is intended for MSYS2/cygwin builds and blocks OpenSSL
+detection of freetds on i686.
+---
+ configure    | 2 --
+ configure.ac | 2 --
+ 2 files changed, 4 deletions(-)
+
+diff --git a/configure b/configure
+index 9495a49..31eb01d 100644
+--- a/configure
++++ b/configure
+@@ -15915,8 +15915,6 @@ case $host in
+ 	tds_mingw=yes
+ 	if test "$host_cpu" = "x86_64"; then
+ 		LIBS="-lws2_32"
+-	elif test -r /usr/lib/w32api/libws2_32.a; then
+-		LIBS="-L/usr/lib/w32api -lws2_32"
+ 	else
+ 		LIBS="-lws2_32"
+ 	fi
+-- 
+2.6.2.windows.1
+

data/patches/libiconv/1.14/1-avoid-gets-error.patch

@@ -0,0 +1,17 @@
+--- a/srclib/stdio.in.h	2017-01-22 01:23:00.000000000 -0400
++++ b/srclib/stdio.in.h	2017-01-22 01:24:00.000000000 -0400
+@@ -695,8 +695,14 @@
+ /* It is very rare that the developer ever has full control of stdin,
+    so any use of gets warrants an unconditional warning.  Assume it is
+    always declared, since it is required by C89.  */
++#if defined(__GLIBC__) && !defined(__UCLIBC__)
++# ifdef __GLIBC_PREREQ 
++#  if !__GLIBC_PREREQ(2, 16)
+ _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
++#  endif
++# endif
++#endif
+ #endif
+ 
+ 
+ #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@

data/setup_cimgruby_dev.sh

@@ -0,0 +1,25 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+
+# this should mirror the steps outlined in the circleci yml
+echo "Installing mssql-tools..."
+sleep 5
+sudo -E ./test/bin/install-mssqltools.sh
+
+echo "Configurating tinytds test database..."
+sleep 5
+./test/bin/setup_tinytds_db.sh
+
+echo "Building openssl library..."
+sleep 5
+sudo -E ./test/bin/install-openssl.sh
+
+echo "Building freetds library..."
+sleep 5
+sudo -E ./test/bin/install-freetds.sh
+
+echo "Installing gems..."
+sleep 5
+bundle install

data/start_dev.sh

@@ -0,0 +1,21 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+
+# set volume read/write permissions to work both outside and inside container
+sudo ./test/bin/setup_volume_permissions.sh
+
+docker-compose up -d
+echo "Waiting for containers to start..."
+sleep 10
+
+# setup circleci ruby container for development
+docker exec cimg_ruby bash -c './setup_cimgruby_dev.sh'
+
+# enter container
+set +x
+echo "cimg/ruby container is ready for tiny_tds development.........."
+echo "To enter container run: docker exec -it cimg_ruby /bin/bash"
+echo "To build solution run: docker exec cimg_ruby bash -c 'bundle exec rake build'"
+echo "To test solution run: docker exec cimg_ruby bash -c 'bundle exec rake test'"

data/tasks/native_gem.rake

@@ -0,0 +1,16 @@
+CrossLibraries.each do |xlib|
+  platform = xlib.platform
+
+  desc "Build fat binary gem for platform #{platform}"
+  task "gem:native:#{platform}" do
+    require "rake_compiler_dock"
+
+    RakeCompilerDock.sh <<-EOT, platform: platform
+			bundle install &&
+			rake native:#{platform} pkg/#{SPEC.full_name}-#{platform}.gem MAKEOPTS=-j`nproc` RUBY_CC_VERSION=#{RakeCompilerDock.set_ruby_cc_version("~> 2.7", "~> 3.0")} MAKEFLAGS="V=1"
+    EOT
+  end
+
+  desc "Build the native binary gems"
+  multitask "gem:native" => "gem:native:#{platform}"
+end

data/tasks/package.rake

@@ -0,0 +1,6 @@
+require "rubygems/package_task"
+
+Gem::PackageTask.new(SPEC) do |pkg|
+  pkg.need_tar = false
+  pkg.need_zip = false
+end

data/tasks/ports.rake

@@ -0,0 +1,24 @@
+require_relative "../ext/tiny_tds/extconsts"
+
+namespace :ports do
+  libraries_to_compile = {
+    openssl: OPENSSL_VERSION,
+    libiconv: ICONV_VERSION,
+    freetds: FREETDS_VERSION
+  }
+
+  desc "Notes the actual versions for the compiled ports into a file"
+  task "version_file", [:gem_platform] do |_task, args|
+    args.with_defaults(gem_platform: RbConfig::CONFIG["arch"])
+
+    ports_version = {}
+
+    libraries_to_compile.each do |library, version|
+      ports_version[library] = version
+    end
+
+    ports_version[:platform] = args.gem_platform
+
+    File.write(".ports_versions", ports_version)
+  end
+end

data/tasks/test.rake

@@ -0,0 +1,7 @@
+require "rake/testtask"
+
+Rake::TestTask.new do |t|
+  t.libs << "test"
+  t.test_files = FileList["test/**/*_test.rb"]
+  t.verbose = true
+end

data/test/bin/install-freetds.sh

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+
+if [ -z "$FREETDS_VERSION" ]; then
+  FREETDS_VERSION=$(ruby -r "./ext/tiny_tds/extconsts.rb" -e "puts FREETDS_VERSION")
+fi
+
+wget http://www.freetds.org/files/stable/freetds-$FREETDS_VERSION.tar.gz
+tar -xzf freetds-$FREETDS_VERSION.tar.gz
+cd freetds-$FREETDS_VERSION
+./configure
+make
+sudo make install
+cd ..
+rm -rf freetds-$FREETDS_VERSION
+rm freetds-$FREETDS_VERSION.tar.gz

data/test/bin/install-mssql.ps1

@@ -0,0 +1,42 @@
+param ([int] $Version)
+
+$ProgressPreference = 'SilentlyContinue'
+
+$DownloadLinkTable = @{
+    2017 = "https://go.microsoft.com/fwlink/?linkid=829176";
+    2019 = "https://download.microsoft.com/download/7/c/1/7c14e92e-bdcb-4f89-b7cf-93543e7112d1/SQLEXPR_x64_ENU.exe";
+    2022 = "https://download.microsoft.com/download/3/8/d/38de7036-2433-4207-8eae-06e247e17b25/SQLEXPR_x64_ENU.exe";
+}
+
+$MajorVersionTable = @{
+    2017 = 14;
+    2019 = 15;
+    2022 = 16;
+}
+
+if (-not(Test-path "C:\Downloads")) {
+    mkdir "C:\Downloads"
+}
+
+$sqlInstallationFile = "C:\Downloads\sqlexpress.exe"
+if (-not(Test-path $sqlInstallationFile -PathType leaf)) {
+    Write-Host "Downloading SQL Express ..."
+    Invoke-WebRequest -Uri $DownloadLinkTable[$Version] -OutFile "C:\Downloads\sqlexpress.exe"
+}
+
+Write-Host "Installing SQL Express ..."
+Start-Process -Wait -FilePath "C:\Downloads\sqlexpress.exe" -ArgumentList /qs, /x:"C:\Downloads\setup"
+C:\Downloads\setup\setup.exe /q /ACTION=Install /INSTANCENAME=SQLEXPRESS /FEATURES=SQLEngine /UPDATEENABLED=0 /SQLSVCACCOUNT='NT AUTHORITY\System' /SQLSYSADMINACCOUNTS='BUILTIN\ADMINISTRATORS' /TCPENABLED=1 /NPENABLED=0 /IACCEPTSQLSERVERLICENSETERMS
+
+Write-Host "Configuring SQL Express ..."
+stop-service MSSQL`$SQLEXPRESS
+set-itemproperty -path "HKLM:\software\microsoft\microsoft sql server\mssql$($MajorVersionTable[$Version]).SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall" -name tcpdynamicports -value ''
+set-itemproperty -path "HKLM:\software\microsoft\microsoft sql server\mssql$($MajorVersionTable[$Version]).SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall" -name tcpport -value 1433
+set-itemproperty -path "HKLM:\software\microsoft\microsoft sql server\mssql$($MajorVersionTable[$Version]).SQLEXPRESS\mssqlserver\" -name LoginMode -value 2
+
+Write-Host "Starting SQL Express ..."
+start-service MSSQL`$SQLEXPRESS
+
+Write-Host "Configuring MSSQL for TinyTDS ..."
+& sqlcmd -i './test/sql/db-create.sql'
+& sqlcmd -i './test/sql/db-login.sql'

data/test/bin/install-mssqltools.sh

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+
+curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
+curl https://packages.microsoft.com/config/ubuntu/20.04/prod.list | sudo tee /etc/apt/sources.list.d/msprod.list
+sudo apt-get update
+sudo ACCEPT_EULA=Y apt-get -y install mssql-tools unixodbc-dev

data/test/bin/install-openssl.sh

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+
+if [ -z "$OPENSSL_VERSION" ]; then
+  OPENSSL_VERSION=$(ruby -r "./ext/tiny_tds/extconsts.rb" -e "puts OPENSSL_VERSION")
+fi
+
+wget https://www.openssl.org/source/openssl-$OPENSSL_VERSION.tar.gz
+tar -xzf openssl-$OPENSSL_VERSION.tar.gz
+cd openssl-$OPENSSL_VERSION
+./config --prefix=/opt/local --openssldir=/opt/local
+make
+make install_sw install_ssldirs
+cd ..
+rm -rf openssl-$OPENSSL_VERSION
+rm openssl-$OPENSSL_VERSION.tar.gz

data/test/bin/restore-from-native-gem.ps1

@@ -0,0 +1,10 @@
+$gemVersion = (Get-Content VERSION).Trim()
+$gemToUnpack = "./tiny_tds-$gemVersion-$env:RUBY_ARCHITECTURE.gem"
+
+Write-Host "Looking to unpack $gemToUnpack"
+gem unpack --target ./tmp "$gemToUnpack"
+
+# Restore precompiled code
+$source = (Resolve-Path ".\tmp\tiny_tds-$gemVersion-$env:RUBY_ARCHITECTURE\lib\tiny_tds").Path
+$destination = (Resolve-Path ".\lib\tiny_tds").Path
+Get-ChildItem $source -Recurse -Exclude "*.rb" | Copy-Item -Destination {Join-Path $destination $_.FullName.Substring($source.length)}

data/test/bin/setup_tinytds_db.sh

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+
+set -x
+set -e
+
+/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -i ./test/sql/db-create.sql
+/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -i ./test/sql/db-login.sql

data/test/bin/setup_volume_permissions.sh

@@ -0,0 +1,10 @@
+#!/usr/bin/env bash
+
+set -x
+
+sudo groupadd -g 3434 circleci_tinytds
+sudo usermod -a -G circleci_tinytds $USER
+sudo useradd circleci_tinytds -u 3434 -g 3434
+sudo usermod -a -G circleci_tinytds circleci_tinytds
+sudo chgrp -R circleci_tinytds .
+sudo chmod -R g+rwx .

data/test/client_test.rb

@@ -1,113 +1,123 @@
-# encoding: utf-8
-require 'test_helper'
+require "test_helper"
 
 class ClientTest < TinyTds::TestCase
-
-  describe 'With valid credentials' do
-
+  describe "with valid credentials" do
     before do
       @client = new_connection
     end
 
-    it 'must not be closed' do
+    it "must not be closed" do
       assert !@client.closed?
       assert @client.active?
     end
 
-    it 'allows client connection to be closed' do
+    it "allows client connection to be closed" do
       assert @client.close
       assert @client.closed?
       assert !@client.active?
-      action = lambda { @client.execute('SELECT 1 as [one]').each }
+      assert @client.dead?
+      action = lambda { @client.execute("SELECT 1 as [one]").each }
       assert_raise_tinytds_error(action) do |e|
-        assert_match %r{closed connection}i, e.message, 'ignore if non-english test run'
+        assert_match %r{closed connection}i, e.message, "ignore if non-english test run"
       end
     end
 
-    it 'has getters for the tds version information (brittle since conf takes precedence)' do
-      if sybase_ase?
-        assert_equal 7, @client.tds_version
-        assert_equal 'DBTDS_5_0 - 5.0 SQL Server', @client.tds_version_info
-      elsif @client.tds_73?
+    it "has getters for the tds version information (brittle since conf takes precedence)" do
+      if @client.tds_73?
         assert_equal 11, @client.tds_version
-        assert_equal 'DBTDS_7_3 - Microsoft SQL Server 2008', @client.tds_version_info
+        assert_equal "DBTDS_7_3 - Microsoft SQL Server 2008", @client.tds_version_info
       else
         assert_equal 9, @client.tds_version
-        assert_equal 'DBTDS_7_1/DBTDS_8_0 - Microsoft SQL Server 2000', @client.tds_version_info
+        assert_equal "DBTDS_7_1/DBTDS_8_0 - Microsoft SQL Server 2000", @client.tds_version_info
       end
     end
 
-    it 'uses UTF-8 client charset/encoding by default' do
-      assert_equal 'UTF-8', @client.charset
-      assert_equal Encoding.find('UTF-8'), @client.encoding
+    it "uses UTF-8 client charset/encoding by default" do
+      assert_equal "UTF-8", @client.charset
+      assert_equal Encoding.find("UTF-8"), @client.encoding
     end
 
-    it 'has a #escape method used for quote strings' do
+    it "has a #escape method used for quote strings" do
       assert_equal "''hello''", @client.escape("'hello'")
     end
 
-    it 'allows valid iconv character set' do
-      ['CP850', 'CP1252', 'ISO-8859-1'].each do |encoding|
-        client = new_connection(:encoding => encoding)
+    ["CP850", "CP1252", "ISO-8859-1"].each do |encoding|
+      it "allows valid iconv character set - #{encoding}" do
+        client = new_connection(encoding: encoding)
         assert_equal encoding, client.charset
         assert_equal Encoding.find(encoding), client.encoding
-        client.close
+      ensure
+        client&.close
       end
     end
 
-    it 'must be able to use :host/:port connection' do
-      host = ENV['TINYTDS_UNIT_HOST_TEST'] || ENV['TINYTDS_UNIT_HOST']
-      port = ENV['TINYTDS_UNIT_PORT_TEST'] || ENV['TINYTDS_UNIT_PORT'] || 1433
-      client = new_connection dataserver: nil, host: host, port: port
-      client.close
-    end unless sqlserver_azure?
-
+    unless sqlserver_azure?
+      it "must be able to use :host/:port connection" do
+        host = ENV["TINYTDS_UNIT_HOST_TEST"] || ENV["TINYTDS_UNIT_HOST"] || "localhost"
+        port = ENV["TINYTDS_UNIT_PORT_TEST"] || ENV["TINYTDS_UNIT_PORT"] || 1433
+        begin
+          client = new_connection dataserver: nil, host: host, port: port
+        ensure
+          client&.close
+        end
+      end
+    end
   end
 
-  describe 'With in-valid options' do
+  describe "With in-valid options" do
+    before(:all) do
+      init_toxiproxy
+    end
 
-    it 'raises an argument error when no :host given and :dataserver is blank' do
-      assert_raises(ArgumentError) { new_connection :dataserver => nil, :host => nil }
+    it "raises an argument error when no :host given and :dataserver is blank" do
+      assert_raises(ArgumentError) { new_connection dataserver: nil, host: nil }
     end
 
-    it 'raises an argument error when no :username is supplied' do
-      assert_raises(ArgumentError) { TinyTds::Client.new :username => nil }
+    it "raises an argument error when no :username is supplied" do
+      assert_raises(ArgumentError) { TinyTds::Client.new username: nil }
     end
 
-    it 'raises TinyTds exception with undefined :dataserver' do
-      options = connection_options :login_timeout => 1, :dataserver => 'DOESNOTEXIST'
+    it "raises TinyTds exception with undefined :dataserver" do
+      options = connection_options login_timeout: 1, dataserver: "DOESNOTEXIST"
       action = lambda { new_connection(options) }
       assert_raise_tinytds_error(action) do |e|
-        assert_equal 20012, e.db_error_number
-        assert_equal 2, e.severity
-        assert_match %r{server name not found in configuration files}i, e.message, 'ignore if non-english test run'
+        # Not sure why tese are different.
+        if ruby_darwin?
+          assert_equal 20009, e.db_error_number
+          assert_equal 9, e.severity
+          assert_match %r{is unavailable or does not exist}i, e.message, "ignore if non-english test run"
+        else
+          assert_equal 20012, e.db_error_number
+          assert_equal 2, e.severity
+          assert_match %r{server name not found in configuration files}i, e.message, "ignore if non-english test run"
+        end
       end
       assert_new_connections_work
     end
 
-    it 'raises TinyTds exception with long query past :timeout option' do
-      client = new_connection :timeout => 1
+    it "raises TinyTds exception with long query past :timeout option" do
+      client = new_connection timeout: 1
       action = lambda { client.execute("WaitFor Delay '00:00:02'").do }
       assert_raise_tinytds_error(action) do |e|
         assert_equal 20003, e.db_error_number
         assert_equal 6, e.severity
-        assert_match %r{timed out}i, e.message, 'ignore if non-english test run'
+        assert_match %r{timed out}i, e.message, "ignore if non-english test run"
       end
       assert_client_works(client)
       close_client(client)
       assert_new_connections_work
     end
 
-    it 'must not timeout per sql batch when not under transaction' do
-      client = new_connection :timeout => 2
+    it "must not timeout per sql batch when not under transaction" do
+      client = new_connection timeout: 2
       client.execute("WaitFor Delay '00:00:01'").do
       client.execute("WaitFor Delay '00:00:01'").do
       client.execute("WaitFor Delay '00:00:01'").do
       close_client(client)
     end
 
-    it 'must not timeout per sql batch when under transaction' do
-      client = new_connection :timeout => 2
+    it "must not timeout per sql batch when under transaction" do
+      client = new_connection timeout: 2
       begin
         client.execute("BEGIN TRANSACTION").do
         client.execute("WaitFor Delay '00:00:01'").do
@@ -119,99 +129,138 @@ class ClientTest < TinyTds::TestCase
       end
     end
 
-    it 'must run this test to prove we account for dropped connections' do
-      skip
-      begin
-        client = new_connection :login_timeout => 2, :timeout => 2
-        assert_client_works(client)
-        STDOUT.puts "Disconnect network!"
-        sleep 10
-        STDOUT.puts "This should not get stuck past 6 seconds!"
-        action = lambda { client.execute('SELECT 1 as [one]').each }
+    it "raises TinyTds exception with tcp socket network failure" do
+      client = new_connection timeout: 2, port: 1234, host: ENV["TOXIPROXY_HOST"]
+      assert_client_works(client)
+      action = lambda { client.execute("waitfor delay '00:00:05'").do }
+
+      # Use toxiproxy to close the TCP socket after 1 second.
+      # We want TinyTds to execute the statement, hit the timeout configured above, and then not be able to use the network to cancel
+      # the network connection needs to close after the sql batch is sent and before the timeout above is hit
+      Toxiproxy[:sqlserver_test].toxic(:slow_close, delay: 1000).apply do
         assert_raise_tinytds_error(action) do |e|
           assert_equal 20003, e.db_error_number
           assert_equal 6, e.severity
-          assert_match %r{timed out}i, e.message, 'ignore if non-english test run'
+          assert_match %r{timed out}i, e.message, "ignore if non-english test run"
         end
-      ensure
-        STDOUT.puts "Reconnect network!"
-        sleep 10
-        action = lambda { client.execute('SELECT 1 as [one]').each }
-        assert_raise_tinytds_error(action) do |e|
-          assert_equal 20047, e.db_error_number
-          assert_equal 1, e.severity
-          assert_match %r{dead or not enabled}i, e.message, 'ignore if non-english test run'
+      end
+    ensure
+      assert_new_connections_work
+    end
+
+    it "raises TinyTds exception with dead connection network failure" do
+      skip if ruby_windows?
+
+      begin
+        client = new_connection timeout: 2, port: 1234, host: ENV["TOXIPROXY_HOST"]
+        assert_client_works(client)
+        action = lambda { client.execute("waitfor delay '00:00:05'").do }
+
+        # Use toxiproxy to close the network connection after 1 second.
+        # We want TinyTds to execute the statement, hit the timeout configured above, and then not be able to use the network to cancel
+        # the network connection needs to close after the sql batch is sent and before the timeout above is hit
+        Toxiproxy[:sqlserver_test].toxic(:timeout, timeout: 1000).apply do
+          assert_raise_tinytds_error(action) do |e|
+            assert_equal 20047, e.db_error_number
+            assert_includes [1, 9], e.severity
+            assert_match %r{dead or not enabled}i, e.message, "ignore if non-english test run"
+          end
         end
-        close_client(client)
+      ensure
         assert_new_connections_work
       end
     end
 
-    it 'raises TinyTds exception with wrong :username' do
-      skip if ENV['CI'] && sqlserver_azure? # Some issue with db_error_number.
-      options = connection_options :username => 'willnotwork'
+    it "raises TinyTds exception with login timeout" do
+      action = lambda do
+        Toxiproxy[:sqlserver_test].toxic(:timeout, timeout: 0).apply do
+          new_connection login_timeout: 1, port: 1234, host: ENV["TOXIPROXY_HOST"]
+        end
+      end
+      assert_raise_tinytds_error(action) do |e|
+        assert_equal 20003, e.db_error_number
+        assert_equal 6, e.severity
+        assert_match %r{timed out}i, e.message, "ignore if non-english test run"
+      end
+    ensure
+      assert_new_connections_work
+    end
+
+    it "raises TinyTds exception with wrong :username" do
+      skip if ENV["CI"] && sqlserver_azure? # Some issue with db_error_number.
+      options = connection_options username: "willnotwork"
       action = lambda { new_connection(options) }
       assert_raise_tinytds_error(action) do |e|
-        assert_equal sybase_ase? ? 4002 : 18456, e.db_error_number
+        assert_equal 18456, e.db_error_number
         assert_equal 14, e.severity
-        assert_match %r{login failed}i, e.message, 'ignore if non-english test run'
+        assert_match %r{login failed}i, e.message, "ignore if non-english test run"
       end
       assert_new_connections_work
     end
-
   end
 
-  describe 'Private methods' do
-
+  describe "#parse_username" do
     let(:client) { @client = new_connection }
 
-    it '#parse_username returns username if azure is not true' do
-      username = 'user@abc123.database.windows.net'
-      client.send(:parse_username, username: username).must_equal username
+    it "returns username if azure is not true" do
+      _(
+        client.send(:parse_username, username: "user@abc123.database.windows.net")
+      ).must_equal "user@abc123.database.windows.net"
     end
 
-    it '#parse_username returns short username if azure is true' do
-      client.send(:parse_username,
-        username: 'user@abc123.database.windows.net',
-        host: 'abc123.database.windows.net',
-        azure: true
-      ).must_equal 'user@abc123'
+    it "returns short username if azure is true" do
+      _(
+        client.send(
+          :parse_username,
+          username: "user@abc123.database.windows.net",
+          host: "abc123.database.windows.net",
+          azure: true
+        )
+      ).must_equal "user@abc123"
     end
 
-    it '#parse_username returns full username if azure is false' do
-      client.send(:parse_username,
-        username: 'user@abc123.database.windows.net',
-        host: 'abc123.database.windows.net',
-        azure: false
-      ).must_equal 'user@abc123.database.windows.net'
+    it "returns full username if azure is false" do
+      _(
+        client.send(
+          :parse_username,
+          username: "user@abc123.database.windows.net",
+          host: "abc123.database.windows.net",
+          azure: false
+        )
+      ).must_equal "user@abc123.database.windows.net"
     end
 
-    it '#parse_username returns short username if passed and azure is true' do
-      client.send(:parse_username,
-        username: 'user@abc123',
-        host: 'abc123.database.windows.net',
-        azure: true
-      ).must_equal 'user@abc123'
+    it "returns short username if passed and azure is true" do
+      _(
+        client.send(
+          :parse_username,
+          username: "user@abc123",
+          host: "abc123.database.windows.net",
+          azure: true
+        )
+      ).must_equal "user@abc123"
     end
 
-    it '#parse_username returns username with servername if passed and azure is true' do
-      client.send(:parse_username,
-        username: 'user',
-        host: 'abc123.database.windows.net',
-        azure: true
-      ).must_equal 'user@abc123'
+    it "returns username with servername if passed and azure is true" do
+      _(
+        client.send(
+          :parse_username,
+          username: "user",
+          host: "abc123.database.windows.net",
+          azure: true
+        )
+      ).must_equal "user@abc123"
     end
 
-    it '#parse_username returns username with servername if passed and azure is false' do
-      client.send(:parse_username,
-        username: 'user',
-        host: 'abc123.database.windows.net',
-        azure: false
-      ).must_equal 'user'
+    it "returns username with servername if passed and azure is false" do
+      _(
+        client.send(
+          :parse_username,
+          username: "user",
+          host: "abc123.database.windows.net",
+          azure: false
+        )
+      ).must_equal "user"
     end
-
   end
-
-
 end
-