tiny_dyno 0.1.22 → 0.1.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0eeaba04a85bbf554f20bb8193bcc4a6701ff2ce
-  data.tar.gz: 52468e676a52ae2a190df1d84355bd04f47c4011
+  metadata.gz: 70bbda18ddd44e600dff1229f0372a9c130a5f69
+  data.tar.gz: 8e8d541dcc26084314b0426ef4f8a1a8b3b33f19
 SHA512:
-  metadata.gz: e6bd51cf221620d0efcd57de2989c8fd92bfe11f4609d3214cc8a5df29a2d6e1f5dfd10c180e602a3238df4c317d92d31dfd3354e19119e737aeb39de8f730cb
-  data.tar.gz: c7e5d45da48fb83ac6344d57e4d24708321fa4a2a022fb100b155aa22821fed82669501d615dd17114b33bf389efdcb59096235ac91a7eea4a65b8e2adb005a8
+  metadata.gz: 0d2ea804ada4339457b6b1e2c0a94c8bc90d1d3f15f51abed3edcb1d3d05c4054d17bc054a704b3308da70b5e6e255b8b5d446b6656a2623247bbc9a50bc547e
+  data.tar.gz: 960bc0007d4e60b4ae4ab6c95cf07c99ad1b08492b3f263a277254004441cec8f57f8cb7aa0307704e82806f112c7ef9f5b0a31a2f78d94b335f9b28083e52e7

data/CHANGES.md

@@ -1,3 +1,10 @@
+0.1.23 (2015-09-09)
+-------------------
+
+* New - add support to toggle validation of records on save
+* increase robustness of number type handling
+
+
 0.1.22 (2015-09-09)
 -------------------
 

data/lib/tiny_dyno/adapter/attributes.rb

@@ -43,18 +43,7 @@ module TinyDyno
               end
             when 'String' then { s: obj }
             when 'Symbol' then { s: obj.to_s }
-            when 'Numeric', 'Fixnum', 'Float', 'Integer'
-              if obj.to_i != 0 and obj != '0'
-                { n: obj.to_s }
-              elsif obj.to_i === 0 and obj == '0'
-                { n: obj.to_s }
-              elsif obj.is_a?(Integer)
-                { n: obj.to_s }
-              elsif obj.nil?
-                { null: true }
-              else
-                raise TinyDyno::Errors::InvalidValueType.new(klass: self.class, name: type, value: obj)
-              end
+            when 'Numeric', 'Fixnum', 'Float', 'Integer', 'BigDecimal' then numeric_format(type.to_s,obj)
             when 'StringIO', 'IO' then { b: obj }
             when 'Set' then format_set(obj)
             when 'TrueClass', 'FalseClass', 'TinyDyno::Boolean'
@@ -62,15 +51,42 @@ module TinyDyno
               raise TinyDyno::Errors::InvalidValueType.new(klass: self.class, name: type, value: obj) unless [true,false,nil].include?(obj)
               { bool: obj }
             when 'NilClass' then { null: true }
-            else
-              msg = "unsupported type, expected Hash, Array, Set, String, Numeric, "
-              msg << "IO, true, false, or nil, got #{obj.class.name}"
-              raise ArgumentError, msg
+          else
+            msg = "unsupported type, expected Hash, Array, Set, String, Numeric, "
+            msg << "IO, true, false, or nil, got #{obj.class.name}"
+            raise ArgumentError, msg
           end
-        end
+        end #format
 
         private
 
+        def numeric_format(type,obj)
+          case type
+            when 'Fixnum', 'Integer', 'Numeric'
+              if obj.class == BigDecimal
+                raise TinyDyno::Errors::NotTransparentlyCoercible.new(klass: self.class, name: type, value: obj) unless obj == BigDecimal.new(obj.to_s)
+                { n: obj.to_s }
+              elsif obj.class == String
+                raise TinyDyno::Errors::NotTransparentlyCoercible.new(klass: self.class, name: type, value: obj) unless obj.to_i.to_s == obj
+                { n: obj }
+              else
+                raise TinyDyno::Errors::NotTransparentlyCoercible.new(klass: self.class, name: type, value: obj) unless obj.to_i == obj.to_s.to_i
+                { n: obj.to_s }
+              end
+            when 'Float'
+              raise TinyDyno::Errors::InvalidValueType.new(klass: self.class, name: type, value: obj) unless obj.is_a?(Float)
+              raise TinyDyno::Errors::NotTransparentlyCoercible.new(klass: self.class, name: type, value: obj) unless obj == obj.to_s.to_f
+              { n: obj.to_s }
+            when 'BigDecimal'
+              raise TinyDyno::Errors::InvalidValueType.new(klass: self.class, name: type, value: obj) unless obj.is_a?(BigDecimal)
+              raise TinyDyno::Errors::NotTransparentlyCoercible.new(klass: self.class, name: type, value: obj) unless obj == BigDecimal.new(obj.to_s)
+              { n: obj.to_s}
+          else
+            msg = "unsupported type, expected Fixnum, Integer, Float, BigDecimal "
+            raise ArgumentError, msg
+          end
+        end #numeric_format
+
         def format_set(set)
           case set.first
             when String, Symbol then { ss: set.map(&:to_s) }
@@ -80,9 +96,9 @@ module TinyDyno
               msg = "set types only support String, Numeric, or IO objects"
               raise ArgumentError, msg
           end
-        end
+        end #format_set
 
-      end
+      end #AttributeValue
 
       class Unmarshaler
 
@@ -147,12 +163,9 @@ module TinyDyno
       raw_attribute = aws_attribute(field_type: field_type, value: value)
 
       case field_type.to_s
-        when 'Fixnum', 'Integer'
-          simple_value = doc_attribute(raw_attribute).to_i
-        when 'Float'
-          simple_value = doc_attribute(raw_attribute).to_f
-        when 'Numeric', 'String', 'Array', 'Hash', 'TinyDyno::Boolean' then
-          simple_value = doc_attribute(raw_attribute)
+        when 'Fixnum', 'Integer' then simple_value = doc_attribute(raw_attribute).to_i
+        when 'Float' then simple_value = doc_attribute(raw_attribute).to_f
+        when 'Numeric', 'String', 'Array', 'Hash', 'TinyDyno::Boolean' then simple_value = doc_attribute(raw_attribute)
       else
         raise ArgumentError, "unhandled type #{ field_type.inspect }"
       end

data/lib/tiny_dyno/errors/invalid_type_error.rb

@@ -24,3 +24,29 @@ module TinyDyno
   end
 end
 
+# encoding: utf-8
+module TinyDyno
+  module Errors
+
+    # This error is raised, when a query is performed with fields specified
+    # that are not HashKeys, which would result in a table scan
+    class NotTransparentlyCoercible < TinyDynoError
+
+      # Create the new error.
+      #
+      # @example Instantiate the error.
+      #   InvalidSelector.new(Person, "gender")
+      #
+      # @param [ Class ] klass The model class.
+      # @param [ String, Symbol ] name The name of the attribute.
+      #
+      # @since 3.0.0
+      def initialize(klass:, name:, value:)
+        super(
+            compose_message("can_not_coerce_transparently", { klass: klass.name, name: name, value: value })
+        )
+      end
+    end
+  end
+end
+

data/lib/tiny_dyno/persistable.rb

@@ -3,7 +3,9 @@ module TinyDyno
     extend ActiveSupport::Concern
 
     def save(options = {})
-      return false unless self.valid?
+      unless options.has_key?(:validate) && options[:validate] == false
+        return false unless self.valid?
+      end
       if new_record?
         if request_put_item(options)
           changes_applied

data/lib/tiny_dyno/version.rb

@@ -1,3 +1,3 @@
 module TinyDyno
-  VERSION = '0.1.22'
+  VERSION = '0.1.23'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tiny_dyno
 version: !ruby/object:Gem::Version
-  version: 0.1.22
+  version: 0.1.23
 platform: ruby
 authors:
 - Tobias Gerschner