tina4ruby 3.13.82 → 3.13.84

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c8f9a8a50b4bb94a8b19b81774ce30e7a9d64fca932c2eb6a49016dc0352171
-  data.tar.gz: 90066d82b0085d019c3118fe57d225eb78206fe44f55c235dd3e7d67d8451382
+  metadata.gz: a44456ebacba7cc7b8a9b8ffe8a973411c13f8055e3297a9bfb1cbb370d4397b
+  data.tar.gz: 1fce4c668f1439fd7c057a4b94e804670d7ce4672a0641f0a325e343e44bba3b
 SHA512:
-  metadata.gz: 042b4dbfa4faf371dde9eb25e3e4406170c46086c29f1ff67afecad0fb61c482605f4f912469251b8640545142eeb295dd7eb1797081137575d941ebccf3f9be
-  data.tar.gz: e5e303934c51d2fc83692817eef9f26382d5bbd5c1b735f6a0b3bcd65a13a7a902574b070cd86a1b60cf0e17a34788444507c5b8cd62c9d8a60aea626abff80f
+  metadata.gz: 9d18d9143115b94beb1f6a4c4e067702f3127c2f05b24dc29a0c9efe04419622d2bb3c8bf94a19c61d1dad38f75ba2cc76d3d15fd530e51ee22198990584173d
+  data.tar.gz: 506e937dc17782c347efc91af039b21ea9e73e76fd92457bc8eab345ab27a7f6bc454eafca2d999a930053494926450f5d615eb871463577f2b5983d127f5f6c

data/CHANGELOG.md

@@ -12,13 +12,6 @@ UNRELEASED work. When a version ships, its notes go to the release notes above.
 
 ## Unreleased
 
-### Added
-
-- **MQTT 3.1.1 client** (`Tina4::Mqtt` / `Tina4::MqttMessage`), zero-dependency (stdlib `socket` +
-  lazily-required `openssl`), verified against a real broker with no mocks. publish/subscribe/consume,
-  QoS 0/1, retained, Last Will, per-client TLS, QoS 2 refused loudly. Ruby ships all 97 shared
-  features plus its native ERB engine, for **98 built-in features**.
-
 ### Changed
 
 - Internal: the SQL dialect-translation file is renamed
@@ -28,6 +21,34 @@ UNRELEASED work. When a version ships, its notes go to the release notes above.
   filename alignment, not an API change. Only code that bypassed the gem's own entry point with
   a direct `require "tina4/sql_translation"` needs to update the path.
 
+### Fixed
+
+- **`tina4 deploy docker` produced images that could not start.** Of the eight
+  Dockerfile generators in the stack (four templates in the `tina4` CLI plus one
+  in each framework's own CLI), exactly one was correct. Python named
+  `python -m tina4_python.cli`, a package with no `__main__.py`, so the container
+  died on startup; PHP ran `php index.php <addr>`, but `App::run(?host, port)`
+  never reads argv so the address was dropped and production never engaged;
+  Node named a path that exists only inside the tina4-nodejs monorepo and
+  depended on tsx, which `npm ci --omit=dev` strips. Every generator now names a
+  published entry point and requests production. Verified by scaffolding,
+  generating, building and running a container for all four languages.
+- **`serve` no longer kills PID 1.** The port-reclaim step read `lsof -ti`
+  without validating it. Where lsof prints a different shape, a non-numeric field
+  coerced to 0 or 1 -- and signalling PID 0 hits every process in the caller's
+  own process group. In a container the server IS PID 1, so it killed itself
+  (Node logged "Killed existing process on port 7148 (PID: 1 ...)" then exited
+  143; PHP logged the same attempt and survived by luck). Reclaiming is now
+  skipped inside a container, only all-digit PIDs are accepted, and PID 0, PID 1
+  and the current process are never signalled.
+- **The Ruby image builds.** The builder stage was `ruby:3.3-slim`, which has no
+  compiler, so `bundle install` failed with `Gem::Ext::BuildError` on the first
+  native extension (date, json, nio4r, sqlite3 are all in the default set). The
+  builder is now the full `ruby:3.3` image and the slim runtime installs
+  `libsqlite3-0`. Bundler's `deployment true` is gone: it demands a lockfile
+  matching the image's bundler exactly, so a lockfile from a newer bundler on a
+  developer machine hard-failed the build.
+
 ## Earlier history (pre-3.x)
 
 Kept for reference only. The versions below are from the 0.x line, long before the unified

data/lib/tina4/cli.rb

@@ -340,18 +340,81 @@ module Tina4
     end
 
     # Kill any process listening on the given port. Returns true if killed.
+    # True when this process is running inside a container.
+    #
+    # Reclaiming a port makes sense on a dev machine, where a previous
+    # `tina4 serve` may still hold it. Inside a container the server IS the
+    # container, so there is no stale sibling to reclaim from -- and trying is
+    # actively dangerous (see #kill_process_on_port).
+    def in_container?
+      return true if File.exist?("/.dockerenv") || File.exist?("/run/.containerenv")
+
+      blob = File.read("/proc/1/cgroup")
+      blob.include?("docker") || blob.include?("containerd") || blob.include?("kubepods")
+    rescue SystemCallError
+      false
+    end
+
+    # Kill any process listening on `port`. Returns true if anything was killed.
+    #
+    # Every PID is validated before use. `pid.to_i` on a non-numeric field
+    # yields 0, and Process.kill("TERM", 0) signals EVERY process in the
+    # caller's own process group -- the server kills itself. That is exactly
+    # what happened in a container: "Killed existing process on port 7148
+    # (PID: 1 ...)" followed by exit 143.
+    #
+    # So: skip entirely in a container, accept only all-digit PIDs, and never
+    # signal 0 (our process group), 1 (init), or ourselves.
+    # The PIDs from `lsof -ti` output that are safe to signal.
+    #
+    # Pure so the safety rule can be tested directly. An unvalidated parse is a
+    # footgun with real teeth: where lsof prints a different shape than -ti
+    # implies, a non-numeric field becomes 0, and signalling PID 0 hits EVERY
+    # process in the caller's own process group -- the server kills itself.
+    #
+    # Accept only all-digit tokens; never PID 0 (our group), PID 1 (init),
+    # ourselves, or our own process group.
+    def selectable_pids(lsof_output, me, my_group = nil)
+      pids = []
+      lsof_output.split(/\s+/).each do |token|
+        next unless token.match?(/\A\d+\z/)   # never coerce junk into a PID
+
+        pid = token.to_i
+        next if pid <= 1 || pid == me           # 0 = our group, 1 = init, me = suicide
+        next if !my_group.nil? && pid == my_group
+
+        pids << pid unless pids.include?(pid)
+      end
+      pids
+    end
+
     def kill_process_on_port(port)
+      return false if in_container?
+
       result = `lsof -ti :#{port} 2>/dev/null`.strip
       return false if result.empty?
 
-      pids = result.split("\n")
-      pids.each do |pid|
-        Process.kill("TERM", pid.to_i)
-      rescue Errno::ESRCH, Errno::EPERM
-        # Process already gone or no permission
+      me = Process.pid
+      my_group = begin
+        Process.getpgrp
+      rescue StandardError
+        nil
+      end
+
+      killed = []
+      selectable_pids(result, me, my_group).each do |pid|
+        begin
+          Process.kill("TERM", pid)
+          killed << pid.to_s
+        rescue Errno::ESRCH, Errno::EPERM
+          # Process already gone or no permission
+        end
       end
+
+      return false if killed.empty?
+
       sleep 0.5
-      puts "  Killed existing process on port #{port} (PID: #{pids.join(', ')})"
+      puts "  Killed existing process on port #{port} (PID: #{killed.join(', ')})"
       true
     rescue Errno::ENOENT
       false
@@ -3136,7 +3199,7 @@ module Tina4
           ENV SWAGGER_DESCRIPTION="Auto-generated API documentation"
 
           # Start the server on all interfaces
-          CMD ["bundle", "exec", "tina4ruby", "start", "-p", "7147", "-h", "0.0.0.0"]
+          CMD ["bundle", "exec", "tina4ruby", "start", "-p", "7147", "-h", "0.0.0.0", "--production"]
         DOCKERFILE
       end
 

data/lib/tina4/rack_app.rb

@@ -418,6 +418,19 @@ module Tina4
     def try_static(path, env = nil)
       return nil if path.include?("..")
 
+      # The framework ships the Swagger UI as STATIC assets under
+      # lib/tina4/public/swagger/. Static serving is independent of the gated
+      # /swagger handler, so without this check the UI stays reachable in
+      # production via '/swagger/index.html' or '/swagger/oauth2-redirect.html'
+      # even when swagger is disabled -- silently bypassing
+      # TINA4_SWAGGER_ENABLED / TINA4_DEBUG. (A bare '/swagger' and '/swagger/'
+      # are already intercepted by the gated handler, which is why this leak hid.)
+      normalised_path = path.start_with?("/") ? path : "/#{path}"
+      if (normalised_path == "/swagger" || normalised_path.start_with?("/swagger/")) &&
+         !Tina4::Swagger.enabled?
+        return nil
+      end
+
       @static_roots.each do |root|
         full_path = File.join(root, path)
         if File.file?(full_path)

data/lib/tina4/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Tina4
-  VERSION = "3.13.82"
+  VERSION = "3.13.84"
 end

data/lib/tina4.rb

@@ -156,6 +156,25 @@ module Tina4
     # models with a Symbol/String `self.db` resolve against it.
     def databases = (@databases ||= {})
 
+    # Build the startup banner's optional surface lines (issue #99).
+    #
+    # Only advertise a surface that is actually REACHABLE. In production, or with
+    # TINA4_DEBUG off, /swagger and /__dev return 404 -- printing them anyway
+    # both misleads an operator into believing a dev surface is exposed and sends
+    # a developer to a dead link.
+    #
+    # Kept as a pure function of (port, two booleans) so the contract is unit
+    # testable without booting a server and grepping stdout. Parity: Python
+    # banner_surface_lines, PHP App::bannerSurfaceLines, Node bannerSurfaceLines.
+    #
+    # @return [Array<String>] zero, one or two ready-to-puts banner rows.
+    def banner_surface_lines(port, swagger_enabled:, dev_admin_enabled:)
+      lines = []
+      lines << "  Swagger:   http://localhost:#{port}/swagger" if swagger_enabled
+      lines << "  Dashboard: http://localhost:#{port}/__dev" if dev_admin_enabled
+      lines
+    end
+
     def print_banner(host: "0.0.0.0", port: 7147, server_name: nil)
       # TINA4_SUPPRESS — short-circuit ALL banner output for headless / CI runs.
       return if Tina4::Env.is_truthy(ENV["TINA4_SUPPRESS"])
@@ -187,8 +206,12 @@ module Tina4
       puts "  Simple. Fast. Human. | Built for AI. Built for you."
       puts ""
       puts "  Server:    http://#{display}:#{port} (#{server_name})"
-      puts "  Swagger:   http://localhost:#{port}/swagger"
-      puts "  Dashboard: http://localhost:#{port}/__dev"
+      # Only advertise a surface that is actually reachable (issue #99).
+      banner_surface_lines(
+        port,
+        swagger_enabled: Tina4::Swagger.enabled?,
+        dev_admin_enabled: is_debug
+      ).each { |line| puts line }
       puts "  Debug:     #{is_debug ? 'ON' : 'OFF'} (Log level: #{log_level})"
       puts ""
     rescue

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tina4ruby
 version: !ruby/object:Gem::Version
-  version: 3.13.82
+  version: 3.13.84
 platform: ruby
 authors:
 - Tina4 Team
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-07-23 00:00:00.000000000 Z
+date: 2026-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -136,6 +136,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.8'
+- !ruby/object:Gem::Dependency
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: base64
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement