timetree 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dd2a9142e5ee6614ec6e97f691d61a2b054d0db7616487efa84f7ecfa89aab82
-  data.tar.gz: f41663400a01d61da7e4cb26ef302c415ff238f8bc58c1b54b1d10156934ab6d
+  metadata.gz: cd742156da72043bdb3d549064a3ea4c560fc8ef2c60c340c53647b6cc0ea43b
+  data.tar.gz: 828100939eadee2275fa189f34dfe9fdd86b58113941cee0eaaabea26a161753
 SHA512:
-  metadata.gz: a7793feb335fcee92f1c19733206a67b3f2e94fcef7e809701db8fd31e80835689f4dbb604422223fcd9c2c6848a5a8ea8ece93dc401cfe65a2b99234c1dde65
-  data.tar.gz: ce9319e7839ce5663e2b15723b5492825332bab5265e7d57ba3d9bd84c59dd3a2b999ffb5de1c77c941e215c226a43699c4b5267aab790539c19e3ce11eb4a8d
+  metadata.gz: f13a82f70529e872f34026d733875f05ef783c9dc5b89b23b6fc989b3256acf6f5640a8c5a377707b6adec96aa04a659cfab8ebd8a83bc9866a626179566a772
+  data.tar.gz: 38bf4a08b7e0bb92275ed0a9d20cf31f1623ba5955a560f3491625080e1b0ffdf2075c5e753d916f5aba64f860465582bf46f01a391af15b6c8c712211f9c168

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# 0.2.1
+
+- do refactor
+  - use `respond_to?(setter)` instead of `instance_methods.include?(setter)`.
+  - use getter method instead of instant variables if defined it.
+
 # 0.2.0
 
 - organize model classes.

data/lib/timetree/api_error.rb

@@ -23,7 +23,7 @@ module TimeTree
     end
 
     def inspect
-      "\#<#{self.class}:#{object_id} title:#{@title}, status:#{@status}>"
+      "\#<#{self.class}:#{object_id} title:#{title}, status:#{status}>"
     end
   end
 end

data/lib/timetree/client.rb

@@ -240,10 +240,10 @@ module TimeTree
     def inspect
       limit_info = nil
       if defined?(@ratelimit_limit) && @ratelimit_limit
-        limit_info = " ratelimit:#{@ratelimit_remaining}/#{@ratelimit_limit}"
+        limit_info = " ratelimit:#{ratelimit_remaining}/#{ratelimit_limit}"
       end
       if defined?(@ratelimit_reset_at) && @ratelimit_reset_at
-        limit_info = "#{limit_info}, reset_at:#{@ratelimit_reset_at.strftime('%m/%d %R')}"
+        limit_info = "#{limit_info}, reset_at:#{ratelimit_reset_at.strftime('%m/%d %R')}"
       end
       "\#<#{self.class}:#{object_id}#{limit_info}>"
     end

data/lib/timetree/configuration.rb

@@ -11,9 +11,8 @@ module TimeTree
     attr_accessor :logger
 
     def initialize
-      logger = Logger.new(STDOUT)
-      logger.level = :warn
-      @logger = logger
+      @logger = Logger.new(STDOUT)
+      @logger.level = :warn
     end
   end
 end

data/lib/timetree/http_command.rb

@@ -15,10 +15,10 @@ module TimeTree
     # @param path [String] String or URI to access.
     # @param params [Hash] Hash of URI query unencoded key/value pairs.
     def get(path, params = {})
-      logger.info "GET #{connection.build_url("#{@host}#{path}", params)}"
+      @logger.info "GET #{connection.build_url("#{@host}#{path}", params)}"
       res = connection.get path, params
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
@@ -30,7 +30,7 @@ module TimeTree
       headers = { 'Content-Type' => 'application/json' }
       res = connection.run_request :post, path, body_params.to_json, headers
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
@@ -38,11 +38,11 @@ module TimeTree
     # @param body_params [Hash]
     # The request bodythat will eventually be converted to JSON.
     def put(path, body_params = {})
-      logger.debug "PUT #{@host}#{path} body:#{body_params}"
+      @logger.debug "PUT #{@host}#{path} body:#{body_params}"
       headers = { 'Content-Type' => 'application/json' }
       res = connection.run_request :put, path, body_params.to_json, headers
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
@@ -52,14 +52,12 @@ module TimeTree
       @logger.debug "DELETE #{@host}#{path} params:#{params}"
       res = connection.delete path, params
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
     private
 
-    attr_reader :logger
-
     def connection
       Faraday.new(
         url: @host,

data/lib/timetree/models/base_model.rb

@@ -78,10 +78,8 @@ module TimeTree
       return unless attributes.is_a? Hash
       return if attributes.empty?
 
-      setter_methods = self.class.instance_methods.select { |method| method.to_s.end_with? '=' }
       attributes.each do |key, value|
-        setter = "#{key.to_sym}=".to_sym
-        next unless setter_methods.include? setter
+        next unless respond_to?("#{key}=".to_sym)
 
         if defined?(self.class::TIME_FIELDS) && self.class::TIME_FIELDS.include?(key)
           value = Time.parse value
@@ -126,7 +124,7 @@ module TimeTree
 
         @_relation_data_dic[type][id]
       }
-      @relationships.each do |key, id_data|
+      relationships.each do |key, id_data|
         relation_data = nil
         if id_data.is_a? Array
           relation_data = []

data/lib/timetree/models/event.rb

@@ -123,8 +123,8 @@ module TimeTree
     private
 
     def relationships_params
-      current_label = label ? { type: 'label', id: label.id } : @relationships[:label]
-      current_attendees = attendees ? attendees.map { |u| { type: 'user', id: u.id } } : @relationships[:attendees]
+      current_label = label ? { type: 'label', id: label.id } : relationships[:label]
+      current_attendees = attendees ? attendees.map { |u| { type: 'user', id: u.id } } : relationships[:attendees]
       {
         label: { data: current_label },
         attendees: { data: current_attendees }

data/lib/timetree/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TimeTree
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: timetree
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Kenji Koshikawa
@@ -189,7 +189,7 @@ metadata:
   homepage_uri: https://github.com/koshilife/timetree-api-ruby-client
   source_code_uri: https://github.com/koshilife/timetree-api-ruby-client
   changelog_uri: https://github.com/koshilife/timetree-api-ruby-client/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/timetree/0.2.0
+  documentation_uri: https://www.rubydoc.info/gems/timetree/0.2.1
 post_install_message: 
 rdoc_options: []
 require_paths: