timetree 0.1.4 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6fd16ab1a54faf7be5a951aa8472e997f791ab3dc1bdb06d1588f0630920c2a1
-  data.tar.gz: 0c2ba91f9b256c5011f053cdf831d35c905486097a6cb832635d25261fe3f77a
+  metadata.gz: cd742156da72043bdb3d549064a3ea4c560fc8ef2c60c340c53647b6cc0ea43b
+  data.tar.gz: 828100939eadee2275fa189f34dfe9fdd86b58113941cee0eaaabea26a161753
 SHA512:
-  metadata.gz: 01db118d26095eed595b67747f51cd2203fc767378b1b2c39f5ef4985098bf53ba53a2c60d836717924281b603af09f24700bc9ac3ef1d4b63a0b71495baa932
-  data.tar.gz: 29ff89e03d4d9919fbd981f4b34b0fa2ae0a6df5ca57a61b29a50497fd56b3888739139ebd48c554ac120f5aa9369eb8e3658cefcddad19207ea1b42490a1112
+  metadata.gz: f13a82f70529e872f34026d733875f05ef783c9dc5b89b23b6fc989b3256acf6f5640a8c5a377707b6adec96aa04a659cfab8ebd8a83bc9866a626179566a772
+  data.tar.gz: 38bf4a08b7e0bb92275ed0a9d20cf31f1623ba5955a560f3491625080e1b0ffdf2075c5e753d916f5aba64f860465582bf46f01a391af15b6c8c712211f9c168

data/.github/workflows/gem-push.yml

@@ -0,0 +1,37 @@
+name: Ruby Gem
+
+on:
+  push:
+    branches: [master]
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby 2.6
+        uses: actions/setup-ruby@v1
+        with:
+          ruby-version: 2.6
+
+      - name: Build and test
+        run: |
+          gem install bundler
+          bundle install --jobs 4 --retry 3
+          bundle exec rake test
+        env:
+          CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}
+
+      - name: Publish to RubyGems
+        run: |
+          mkdir -p $HOME/.gem
+          touch $HOME/.gem/credentials
+          chmod 0600 $HOME/.gem/credentials
+          printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+          gem build *.gemspec
+          gem push *.gem
+        continue-on-error: true
+        env:
+          GEM_HOST_API_KEY: ${{secrets.RUBYGEMS_AUTH_TOKEN}}

data/.github/workflows/test.yml

@@ -0,0 +1,21 @@
+name: Test
+
+on: pull_request
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.6
+      - name: Build and test
+        run: |
+          gem install bundler
+          bundle install --jobs 4 --retry 3
+          bundle exec rake test
+        env:
+          CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}

data/.gitignore

@@ -7,5 +7,4 @@
 /spec/reports/
 /tmp/
 
-coverage
-Gemfile.lock
+Gemfile.lock

data/CHANGELOG.md

@@ -1,3 +1,26 @@
+# 0.2.1
+
+- do refactor
+  - use `respond_to?(setter)` instead of `instance_methods.include?(setter)`.
+  - use getter method instead of instant variables if defined it.
+
+# 0.2.0
+
+- organize model classes.
+
+# 0.1.7
+
+- refs #16 correct a mistake codecov badge url on README
+
+# 0.1.6
+
+- refs #16 add code coverage to readme.
+- refs #17 update deprecated `version` for `ruby-version` on gem-push.yml.
+
+# 0.1.5
+
+- refs #6 setup GitHub Actions.
+
 # 0.1.4
 
 - updates comments.

data/README.md

@@ -1,6 +1,9 @@
 # Simple TimeTree APIs client
 
+[![Test](https://github.com/koshilife/timetree-api-ruby-client/workflows/Test/badge.svg)](https://github.com/koshilife/timetree-api-ruby-client/actions?query=workflow%3ATest)
+[![codecov](https://codecov.io/gh/koshilife/timetree-api-ruby-client/branch/master/graph/badge.svg)](https://codecov.io/gh/koshilife/timetree-api-ruby-client)
 [![Gem Version](https://badge.fury.io/rb/timetree.svg)](http://badge.fury.io/rb/timetree)
+[![license](https://img.shields.io/github/license/koshilife/timetree-api-ruby-client)](https://github.com/koshilife/timetree-api-ruby-client/blob/master/LICENSE.txt)
 
 ## About
 

data/bin/console

@@ -1,14 +1,7 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "timetree"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
+require 'bundler/setup'
+require 'timetree'
+require 'irb'
 IRB.start(__FILE__)

data/bin/setup

@@ -4,5 +4,3 @@ IFS=$'\n\t'
 set -vx
 
 bundle install
-
-# Do any other automated setup that you need to do here

data/lib/timetree.rb

@@ -5,6 +5,7 @@ loader = Zeitwerk::Loader.for_gem
 loader.inflector.inflect(
   'timetree' => 'TimeTree'
 )
+loader.collapse('**/models')
 loader.setup
 
 # module for TimeTree apis client

data/lib/timetree/api_error.rb

@@ -23,7 +23,7 @@ module TimeTree
     end
 
     def inspect
-      "\#<#{self.class}:#{object_id} title:#{@title}, status:#{@status}>"
+      "\#<#{self.class}:#{object_id} title:#{title}, status:#{status}>"
     end
   end
 end

data/lib/timetree/client.rb

@@ -240,10 +240,10 @@ module TimeTree
     def inspect
       limit_info = nil
       if defined?(@ratelimit_limit) && @ratelimit_limit
-        limit_info = " ratelimit:#{@ratelimit_remaining}/#{@ratelimit_limit}"
+        limit_info = " ratelimit:#{ratelimit_remaining}/#{ratelimit_limit}"
       end
       if defined?(@ratelimit_reset_at) && @ratelimit_reset_at
-        limit_info = "#{limit_info}, reset_at:#{@ratelimit_reset_at.strftime('%m/%d %R')}"
+        limit_info = "#{limit_info}, reset_at:#{ratelimit_reset_at.strftime('%m/%d %R')}"
       end
       "\#<#{self.class}:#{object_id}#{limit_info}>"
     end

data/lib/timetree/configuration.rb

@@ -11,9 +11,8 @@ module TimeTree
     attr_accessor :logger
 
     def initialize
-      logger = Logger.new(STDOUT)
-      logger.level = :warn
-      @logger = logger
+      @logger = Logger.new(STDOUT)
+      @logger.level = :warn
     end
   end
 end

data/lib/timetree/http_command.rb

@@ -15,10 +15,10 @@ module TimeTree
     # @param path [String] String or URI to access.
     # @param params [Hash] Hash of URI query unencoded key/value pairs.
     def get(path, params = {})
-      logger.info "GET #{connection.build_url("#{@host}#{path}", params)}"
+      @logger.info "GET #{connection.build_url("#{@host}#{path}", params)}"
       res = connection.get path, params
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
@@ -30,7 +30,7 @@ module TimeTree
       headers = { 'Content-Type' => 'application/json' }
       res = connection.run_request :post, path, body_params.to_json, headers
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
@@ -38,11 +38,11 @@ module TimeTree
     # @param body_params [Hash]
     # The request bodythat will eventually be converted to JSON.
     def put(path, body_params = {})
-      logger.debug "PUT #{@host}#{path} body:#{body_params}"
+      @logger.debug "PUT #{@host}#{path} body:#{body_params}"
       headers = { 'Content-Type' => 'application/json' }
       res = connection.run_request :put, path, body_params.to_json, headers
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
@@ -52,14 +52,12 @@ module TimeTree
       @logger.debug "DELETE #{@host}#{path} params:#{params}"
       res = connection.delete path, params
       @client.update_ratelimit(res)
-      logger.debug "Response status:#{res.status}, body:#{res.body}"
+      @logger.debug "Response status:#{res.status}, body:#{res.body}"
       res
     end
 
     private
 
-    attr_reader :logger
-
     def connection
       Faraday.new(
         url: @host,

data/lib/timetree/{base_model.rb → models/base_model.rb}

@@ -78,10 +78,8 @@ module TimeTree
       return unless attributes.is_a? Hash
       return if attributes.empty?
 
-      setter_methods = self.class.instance_methods.select { |method| method.to_s.end_with? '=' }
       attributes.each do |key, value|
-        setter = "#{key.to_sym}=".to_sym
-        next unless setter_methods.include? setter
+        next unless respond_to?("#{key}=".to_sym)
 
         if defined?(self.class::TIME_FIELDS) && self.class::TIME_FIELDS.include?(key)
           value = Time.parse value
@@ -126,7 +124,7 @@ module TimeTree
 
         @_relation_data_dic[type][id]
       }
-      @relationships.each do |key, id_data|
+      relationships.each do |key, id_data|
         relation_data = nil
         if id_data.is_a? Array
           relation_data = []

data/lib/timetree/{event.rb → models/event.rb}

@@ -123,8 +123,8 @@ module TimeTree
     private
 
     def relationships_params
-      current_label = label ? { type: 'label', id: label.id } : @relationships[:label]
-      current_attendees = attendees ? attendees.map { |u| { type: 'user', id: u.id } } : @relationships[:attendees]
+      current_label = label ? { type: 'label', id: label.id } : relationships[:label]
+      current_attendees = attendees ? attendees.map { |u| { type: 'user', id: u.id } } : relationships[:attendees]
       {
         label: { data: current_label },
         attendees: { data: current_attendees }

data/lib/timetree/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TimeTree
-  VERSION = '0.1.4'
+  VERSION = '0.2.1'
 end

data/timetree.gemspec

@@ -33,9 +33,10 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'zeitwerk', '~> 2.3.0'
 
   spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'codecov', '~> 0.1.17'
   spec.add_development_dependency 'minitest', '~> 5.14.0'
   spec.add_development_dependency 'minitest-reporters', '~> 1.4.2'
   spec.add_development_dependency 'rake', '~> 12.0'
-  spec.add_development_dependency 'webmock', '~> 3.7.6'
   spec.add_development_dependency 'simplecov', '~> 0.18.5'
+  spec.add_development_dependency 'webmock', '~> 3.7.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: timetree
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.1
 platform: ruby
 authors:
 - Kenji Koshikawa
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-30 00:00:00.000000000 Z
+date: 2020-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.17
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.1.17
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -109,33 +123,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '12.0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.6
+        version: 0.18.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.6
+        version: 0.18.5
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.5
+        version: 3.7.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.5
+        version: 3.7.6
 description: Client for accessing TimeTree APIs
 email:
 - koshikawa2009@gmail.com
@@ -143,9 +157,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/gem-push.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocom.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -155,16 +170,16 @@ files:
 - bin/console
 - bin/setup
 - lib/timetree.rb
-- lib/timetree/activity.rb
 - lib/timetree/api_error.rb
-- lib/timetree/base_model.rb
-- lib/timetree/calendar.rb
 - lib/timetree/client.rb
 - lib/timetree/configuration.rb
-- lib/timetree/event.rb
 - lib/timetree/http_command.rb
-- lib/timetree/label.rb
-- lib/timetree/user.rb
+- lib/timetree/models/activity.rb
+- lib/timetree/models/base_model.rb
+- lib/timetree/models/calendar.rb
+- lib/timetree/models/event.rb
+- lib/timetree/models/label.rb
+- lib/timetree/models/user.rb
 - lib/timetree/version.rb
 - timetree.gemspec
 homepage: https://github.com/koshilife/timetree-api-ruby-client
@@ -174,7 +189,7 @@ metadata:
   homepage_uri: https://github.com/koshilife/timetree-api-ruby-client
   source_code_uri: https://github.com/koshilife/timetree-api-ruby-client
   changelog_uri: https://github.com/koshilife/timetree-api-ruby-client/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/timetree/0.1.4
+  documentation_uri: https://www.rubydoc.info/gems/timetree/0.2.1
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -190,7 +205,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Client for accessing TimeTree APIs

data/.travis.yml

@@ -1,6 +0,0 @@
----
-language: ruby
-cache: bundler
-rvm:
-  - 2.6.3
-before_install: gem install bundler -v 2.1.4