timetrap 1.12.0 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 932d2f57b36aa208733e8f99532073b97c224c2e
-  data.tar.gz: c7664fc5641cbcb202d9d368a97ec48e46fa20de
+  metadata.gz: bbc0d7f0e44a53e45a15d6aa657371644c9c12e0
+  data.tar.gz: ed4fee1b239512ff12507f976b822b5a8f3a64b7
 SHA512:
-  metadata.gz: e7e215bbf435d29824abae93dd2d33bdab1e98ea8fba91400a3f34e3d9b6a04f12749fa426b7e12d3db863edf648a527077d364aa074798d2e9ef2863a970fab
-  data.tar.gz: 8ca27f988fa422d5044964cae9dff471acd34e4d8f6fd0dbdfd5ef40c6dee1160ffb3fee2d563497a3213724bd9b1eb61d3a181707a0d66ff344747ad157f779
+  metadata.gz: bb06b383210f57f21129a7881b632a3e80eafa966470cd38df94d2d742e619a8e4937ea4e981ea6e3a7c454e9f5f4c379ca128685abf40a62988861095be15ed
+  data.tar.gz: ff020f3440853d565980b0209807045f48111ad61a18ef21e47228f111007e916d70aa85a9865190828b8772af96228484d16d3a51e07c2a87fd120ec7017613

data/lib/timetrap/cli.rb

@@ -246,7 +246,7 @@ COMMAND is one of:
         if args['-z']
           note = [entry.note, get_note_from_external_editor].join(Config['append_notes_delimiter'])
           entry.update :note => note
-        elsif args.size == 0 # no arguments supplied
+        elsif editing_a_note?
           entry.update :note => get_note_from_external_editor(entry.note)
         end
       else
@@ -492,6 +492,15 @@ COMMAND is one of:
      file.unlink
     end
 
+    def editing_a_note?
+      return true if args.size == 0
+
+      args.each do |(k,_v)|
+        return false unless ["--id", "-i"].include?(k)
+      end
+      true
+    end
+
     extend Helpers::AutoLoad
     def format_entries(entries)
       load_formatter(args['-f'] || Config['default_formatter']).new(Array(entries)).output

data/lib/timetrap/version.rb

@@ -1,3 +1,3 @@
 module Timetrap
-  VERSION = '1.12.0'
+  VERSION = '1.13.0'
 end

data/spec/timetrap_spec.rb

@@ -273,6 +273,39 @@ describe Timetrap do
             expect(capture).to eq("running entry")
           end
 
+
+          it "should edit a non running entry with an external editor" do |example|
+            not_running = Timetrap::Timer.active_entry
+            Timetrap::Timer.stop(Timetrap::Timer.current_sheet)
+            Timetrap::Timer.start "another entry", nil
+
+            # create a few more entries to ensure we're not falling back on "last
+            # checked out of" feature.
+            Timetrap::Timer.stop(Timetrap::Timer.current_sheet)
+            Timetrap::Timer.start "another entry", nil
+
+            Timetrap::Timer.stop(Timetrap::Timer.current_sheet)
+
+            Timetrap::CLI.stub(:system) do |editor_command|
+              path = editor_command.match(/#{note_editor_command} (?<path>.*)/)
+              File.write(path[:path], "id passed note")
+            end
+
+            invoke "edit --id #{not_running.id}"
+
+            not_running.refresh.note.should == "id passed note"
+          end
+
+          it "should not call the editor if there are arguments other than --id" do
+            not_running = Timetrap::Timer.active_entry
+            Timetrap::Timer.stop(Timetrap::Timer.current_sheet)
+            Timetrap::Timer.start "another entry", nil
+
+            Timetrap::Timer.stop(Timetrap::Timer.current_sheet)
+            expect(Timetrap::CLI).not_to receive(:system)
+            invoke "edit --id #{not_running.id} --start \"yesterday 10am\""
+          end
+
           context "appending" do
             it "should open an editor for editing the note with -z" do |example|
               Timetrap::CLI.stub(:system) do |editor_command|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: timetrap
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
 platform: ruby
 authors:
 - Sam Goldstein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-19 00:00:00.000000000 Z
+date: 2016-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler