timet 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9174050872f06486ce9307f0aa9ab28decce4345f7169cc0537741028a8cfcae
-  data.tar.gz: 2eaa910c4a79265fe273bdeb9ff0cffb4f5e5330f8849c1ccc197d1ee5e5edbb
+  metadata.gz: f538523396dc470f91334a3abe44915e63dec009a60901a1ae4ef7b432a9a37f
+  data.tar.gz: 262da1d62b413102d4ff33932fa7fb05c10c4b13abcb832d6382683d2d314d8d
 SHA512:
-  metadata.gz: 61d368a8f2e30693c6c29abff6ae067001798b0b30c3012cfbce4fe0ced2d31ce0e89e76fe716e026b361d391ca0d13d58e29e61db6231fb23cbaed2e7cfd8fa
-  data.tar.gz: '0299cb83c55d19053a98dcb795da56e485b14e7b45b10e7c45ed8f1ecc03218d0966a2f5b7a28c1d0939f1455d6e14978caa2cfb8a9bfc8509681f8d7fc813ae'
+  metadata.gz: 4d1d90414bda675c2f09827ec99c63b4e86e04f826e969d07af15a757e29b1cb868d412d17b7995012b1091173cd50e2093009600bb55888b06ffd1c1a4397e0
+  data.tar.gz: cad0f0569224af29941301173dcfa1045c4419db21265b5cdb2d64e5e14f9eeca52d5ada931be7fed1757305ba55bb05823111d974a40c2e57ca0a25c4f8cff7

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 ## [Unreleased]
 
+## [1.5.2] - 2024-12-12
+
+**Improvements:**
+
+- Added command validation during application initialization to ensure only valid arguments are processed.
+- Updated the `insert_item` method in the `Database` class to accept parameters via `*args` for better flexibility.
+- Updated dependencies:
+  - `aws-partitions` to `1.1021.0`
+  - `rubocop` to `1.69.2`
+  - `rubocop-rspec` to `3.3.0`
+  - `sqlite3` to `2.4.1`
+
+**Bug Fixes:**
+
+- Fixed potential issues with invalid arguments causing the application to crash during initialization.
+
 ## [1.5.1] - 2024-12-07
 
 **Improvements:**
@@ -7,6 +23,7 @@
 - Extracted the logic for syncing items by ID into a separate method `sync_items_by_id` for better readability and maintainability.
 - Improved the writing of missing environment variables to the .env file in the S3Supabase module by ensuring the file content ends with a newline character.
 - Refactored the `all_items` method to use `beginning_of_day` for today's timestamp, improving the accuracy of the timestamp calculation.
+- Fix `beginning_of_day`
 
 **Bug Fixes:**
 

data/lib/timet/application.rb

@@ -25,11 +25,6 @@ module Timet
     include ApplicationHelper
     include TimeHelper
 
-    def initialize(*args)
-      super
-      @db = Database.new
-    end
-
     FIELD_INDEX = {
       'notes' => 4,
       'tag' => 3,
@@ -39,8 +34,38 @@ module Timet
 
     VALID_STATUSES_FOR_INSERTION = %i[no_items complete].freeze
 
+    VALID_ARGUMENTS = %w[
+      cancel
+      delete
+      edit
+      help
+      resume
+      start
+      stop
+      summary
+      sync
+      version
+    ].freeze
+
     BUCKET = 'timet'
 
+    def initialize(*args)
+      super
+
+      # Initialize database without validation in test environment
+      if defined?(RSpec)
+        @db = Database.new
+      else
+        command_name = args[2][:current_command].name
+        if VALID_ARGUMENTS.include?(command_name)
+          @db = Database.new
+        else
+          puts 'Invalid arguments provided. Please check your input.'
+          exit(1)
+        end
+      end
+    end
+
     desc "start [tag] --notes='' --pomodoro=[min]",
          'Start time tracking for a task labeled with the provided [tag], notes and "pomodoro time"
         in minutes (optional).

data/lib/timet/database.rb

@@ -94,9 +94,9 @@ module Timet
     #   insert_item(1633072800, 'work', 'Completed task X')
     #
     # @note The method executes SQL to insert a new row into the 'items' table.
-    def insert_item(*args, pomodoro: nil, updated_at: nil, created_at: nil)
+    def insert_item(*args)
       # Unpacking args into meaningful variables for clarity
-      start, tag, notes = args
+      start, tag, notes, pomodoro, updated_at, created_at = args
       execute_sql('INSERT INTO items (start, tag, notes, pomodoro, updated_at, created_at) VALUES (?, ?, ?, ?, ?, ?)',
                   [start, tag, notes, pomodoro, updated_at, created_at])
     end
@@ -187,7 +187,7 @@ module Timet
     # @note The method executes SQL to fetch all items from the 'items' table that have a start time greater than
     # or equal to today.
     def all_items
-      today = Time.now.beginning_of_day.to_i
+      today = TimeHelper.beginning_of_day.to_i
       execute_sql('SELECT * FROM items WHERE start >= ? AND (deleted IS NULL OR deleted = 0) ORDER BY start DESC',
                   [today])
     end

data/lib/timet/time_helper.rb

@@ -232,5 +232,20 @@ module Timet
       end
       hour_blocks
     end
+
+    # Returns a Time object representing the start of the given day (midnight).
+    #
+    # @param time [Time] The time for which to find the beginning of day (defaults to current time).
+    # @return [Time] A new Time object set to midnight (00:00:00) of the given day.
+    #
+    # @example Get beginning of current day
+    #   TimeHelper.beginning_of_day # => 2024-12-07 00:00:00
+    #
+    # @example Get beginning of specific day
+    #   time = Time.new(2024, 12, 7, 15, 30, 45)
+    #   TimeHelper.beginning_of_day(time) # => 2024-12-07 00:00:00
+    def self.beginning_of_day(time = Time.now)
+      Time.new(time.year, time.month, time.day)
+    end
   end
 end

data/lib/timet/version.rb

@@ -6,6 +6,6 @@ module Timet
   # @return [String] The version number in the format 'major.minor.patch'.
   #
   # @example Get the version of the Timet application
-  #   Timet::VERSION # => '1.5.1'
-  VERSION = '1.5.1'
+  #   Timet::VERSION # => '1.5.2'
+  VERSION = '1.5.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: timet
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Frank Vielma
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-07 00:00:00.000000000 Z
+date: 2024-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor