timely-app 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c82f58f7c3e0713310beb5653d74487822d9f96bb883ae15805c5987896a589e
-  data.tar.gz: d90c62ee9a7baa1b29468f70997a7b1e5e6236d8553c9d92abfc082855595292
+  metadata.gz: 9d8ce8174d129b5c2273101c2c00911260f27c6ace3f2cf674920a5b7b3c20b1
+  data.tar.gz: bc5c6f0bb086d3091e820f28ea278786ee4a54562df0bc5b9e151610d7a9b49e
 SHA512:
-  metadata.gz: cf7b4edda75f282566b4f38c3e48c88f716056055734dae4bd2a08016e5d1e9d7d148922fc4ddcd5625fde5740376cb6e0088bf0c8a558c5d78e6e4723f84668
-  data.tar.gz: 3cdb10455d12dbc9f265ea500bccb965775e2d767ae8e798bea35a356ce8065036c0402e60016ff7feb2ea2de2198ea75b901592ac3c45993e3f55c953662ba7
+  metadata.gz: 20abf6c65cf3558f079ed82e1b95245a66fac3e7301bdf6f3a8039e7ad20044efce9dddc2dee3c054ba8a18dbdc25437b8de934a37784f9521ce7c30cf34a6be
+  data.tar.gz: a84b5732a9a539ee9a2133f370748ee32d2dbff90cf916dc5a2bfa08817e1f90ce53dee7acafef8e887de6a5a40de763e2b250cb7bcc9ac72662fd18d70e3069

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # CHANGELOG
 
+## 1.3.3 (2026-10-29)
+
+- Preserve HTTP error types when the server returns malformed or unexpected JSON.
+- Keep authorization codes and response contents out of failed sign-in diagnostics.
+- Cancel release preparation when confirmation input is closed.
+- Exit sign-in when the authorization code prompt is closed or blank.
+
 ## 1.3.2 (2026-07-25)
 
 - BREAKING: Require Ruby 3.4 or newer

data/lib/timely-app/cli.rb

@@ -1,3 +1,6 @@
+require "securerandom"
+require "yaml"
+
 module TimelyApp
   class CLI
     attr_reader :options, :client
@@ -37,7 +40,7 @@ module TimelyApp
       token = fetch_oauth_token(auth_client, client_id, client_secret, code)
       persist_or_print_token(token)
     rescue TimelyApp::Error => error
-      handle_auth_failure(error, code)
+      handle_auth_failure(error)
     end
 
     private
@@ -57,7 +60,12 @@ module TimelyApp
       puts "Visit this URL in your browser:"
       puts auth_url
       puts "\nEnter authorization code here:"
-      gets.chomp
+      code = gets&.chomp
+      if code.nil? || code.empty?
+        puts "Authorization code is required"
+        exit 1
+      end
+      code
     end
 
     def oauth_redirect_uri
@@ -84,15 +92,13 @@ module TimelyApp
       else
         puts "\nAccess token:\n#{token.access_token}\n"
       end
-      puts "Token details: #{token.to_h}" if options[:verbose]
+      puts "Authentication succeeded" if options[:verbose]
     end
 
-    def handle_auth_failure(error, code)
+    def handle_auth_failure(error)
       puts "Authentication failed"
       if options[:verbose]
-        puts "Code: #{code}"
         puts "Response code: #{error.response.code}"
-        puts "Response: #{error.response.body}"
       end
       exit 1
     end
@@ -102,9 +108,16 @@ module TimelyApp
     end
 
     def read_config_file
-      if File.exist?(config_file_path)
-        YAML.load_file(config_file_path)
-      end
+      return unless File.exist?(config_file_path)
+
+      config = YAML.safe_load_file(
+        config_file_path,
+        permitted_classes: [Symbol, Time],
+        aliases: false
+      )
+      return {} unless config.is_a?(Hash)
+
+      config.to_h { |key, value| [key.to_s, value] }
     end
 
     def fetch_account_id
@@ -124,9 +137,30 @@ module TimelyApp
 
     def save_config_file(**options)
       config = read_config_file || {}
-      config.merge!(options)
-      File.write(config_file_path, config.to_yaml)
+      config.merge!(options.to_h { |key, value| [key.to_s, value] })
+      write_config_file(config.to_yaml)
       puts "Saved to #{config_file_path}"
     end
+
+    def write_config_file(content)
+      temporary_path = "#{config_file_path}.#{Process.pid}.#{SecureRandom.hex(8)}.tmp"
+
+      File.open(temporary_path, File::WRONLY | File::CREAT | File::EXCL, 0o600) do |file|
+        file.write(content)
+        file.flush
+        file.fsync
+      end
+      File.rename(temporary_path, config_file_path)
+      File.chmod(0o600, config_file_path)
+      sync_config_directory
+    ensure
+      File.delete(temporary_path) if temporary_path && File.exist?(temporary_path)
+    end
+
+    def sync_config_directory
+      File.open(File.dirname(config_file_path), File::RDONLY, &:fsync)
+    rescue Errno::EINVAL
+      nil
+    end
   end
 end

data/lib/timely-app/client.rb

@@ -10,6 +10,11 @@ require "json"
 
 module TimelyApp
   class Client
+    DEFAULT_OPEN_TIMEOUT = 5
+    DEFAULT_READ_TIMEOUT = 30
+    FILTERED_VALUE = "[FILTERED]"
+    SENSITIVE_FIELD = /authorization|code|credential|password|secret|token/i
+
     attr_accessor :account_id
 
     def initialize(options = {})
@@ -18,9 +23,7 @@ module TimelyApp
       @user_agent = options.fetch(:user_agent) { "timely-app/#{VERSION} ruby/#{RUBY_VERSION}" }
 
       @host = "api.timelyapp.com"
-
-      @http = Net::HTTP.new(@host, Net::HTTP.https_default_port)
-      @http.use_ssl = true
+      @http = build_http(options)
 
       @account_id = options[:account_id]
       @verbose = options[:verbose] || !ENV["VERBOSE"].nil? || false
@@ -32,6 +35,14 @@ module TimelyApp
 
     private
 
+    def build_http(options)
+      http = Net::HTTP.new(@host, Net::HTTP.https_default_port)
+      http.use_ssl = true
+      http.open_timeout = options.fetch(:open_timeout, DEFAULT_OPEN_TIMEOUT)
+      http.read_timeout = options.fetch(:read_timeout, DEFAULT_READ_TIMEOUT)
+      http
+    end
+
     def verbose?
       @verbose == true
     end
@@ -74,8 +85,29 @@ module TimelyApp
     def log_verbose_exchange(http_request, response)
       return unless verbose?
 
-      puts ">> request: #{http_request.method} #{http_request.path} #{http_request.body}"
-      puts "<< response: #{http_request.method} #{http_request.path} #{response.code} #{response.body}"
+      puts ">> request: #{http_request.method} #{http_request.path} #{filtered_body(http_request.body)}"
+      puts "<< response: #{http_request.method} #{http_request.path} #{response.code} #{filtered_body(response.body)}"
+    end
+
+    def filtered_body(body)
+      return if body.nil? || body.empty?
+
+      JSON.generate(filter_sensitive_values(JSON.parse(body)))
+    rescue JSON::ParserError
+      FILTERED_VALUE
+    end
+
+    def filter_sensitive_values(value)
+      case value
+      when Hash
+        value.to_h { |key, nested_value|
+          [key, key.match?(SENSITIVE_FIELD) ? FILTERED_VALUE : filter_sensitive_values(nested_value)]
+        }
+      when Array
+        value.map { |nested_value| filter_sensitive_values(nested_value) }
+      else
+        value
+      end
     end
   end
 end

data/lib/timely-app/response.rb

@@ -27,13 +27,20 @@ module TimelyApp
     end
 
     def error(response)
-      if response.content_type == "application/json"
-        body = JSON.parse(response.body)
-        message = body&.dig("errors", "message") || body&.dig("error_description")
-        error_class(response).new(message, response: response, errors: body&.dig("errors"))
-      else
-        error_class(response).new(response: response)
-      end
+      body = error_body(response)
+      errors = body["errors"]
+      message = errors.is_a?(Hash) ? errors["message"] : nil
+      message ||= body["error_description"]
+      error_class(response).new(message, response: response, errors: errors)
+    end
+
+    def error_body(response)
+      return {} unless response.content_type == "application/json"
+
+      body = JSON.parse(response.body.to_s)
+      body.is_a?(Hash) ? body : {}
+    rescue JSON::ParserError
+      {}
     end
 
     def error_class(object)

data/lib/timely-app.rb

@@ -1,3 +1,7 @@
+module TimelyApp
+  VERSION = "1.3.3"
+end
+
 require "timely-app/client"
 require "timely-app/client/accounts"
 require "timely-app/client/auth"
@@ -13,7 +17,4 @@ require "timely-app/client/teams"
 require "timely-app/client/user_capacities"
 require "timely-app/client/users"
 require "timely-app/client/webhooks"
-
-module TimelyApp
-  VERSION = "1.3.2"
-end
+require "timely-app/cli"

data/timely-app.gemspec

@@ -30,9 +30,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rspec-core", "~> 3"
   gem.add_development_dependency "polyrun", ">= 2.2.0"
   gem.add_development_dependency "rspec-expectations", "~> 3"
-  gem.add_development_dependency "rspec_junit_formatter", "~> 0.6"
-  gem.add_development_dependency "simplecov", "~> 0.22"
-  gem.add_development_dependency "simplecov-cobertura", "~> 3"
   gem.add_development_dependency "webmock", "~> 3"
   gem.add_development_dependency "pry", "~> 0.15"
   gem.add_development_dependency "standard", "~> 1.52"
@@ -41,6 +38,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "standard-rspec", "~> 0.3"
   gem.add_development_dependency "rubocop-rspec", "~> 3.8"
   gem.add_development_dependency "rubocop-thread_safety", "~> 0.7"
-  gem.add_development_dependency "rbs", "~> 3"
+  gem.add_development_dependency "rbs", "~> 4"
   gem.add_development_dependency "appraisal", "~> 2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: timely-app
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - Andrei Makarov
@@ -51,48 +51,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
-- !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.22'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.22'
-- !ruby/object:Gem::Dependency
-  name: simplecov-cobertura
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -211,14 +169,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement