timely-app 1.3.1 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39b5789f35dad839ca62c03bd156cdc9248aa0d289abdadeef5a3e4defe1fe46
-  data.tar.gz: 74efd8e824d9d7d6f82f7833957aee8da21d705c7136001aabf72736e93d202b
+  metadata.gz: 9d8ce8174d129b5c2273101c2c00911260f27c6ace3f2cf674920a5b7b3c20b1
+  data.tar.gz: bc5c6f0bb086d3091e820f28ea278786ee4a54562df0bc5b9e151610d7a9b49e
 SHA512:
-  metadata.gz: 7d5baa1765e2dd3dd038e11f8f498c157d49275b807f028766d0863529e7a2168369a5ded2f633c28107bb7937aecc3c10e30422e26ce947d44ce473b1feb7fb
-  data.tar.gz: 4d3c9074a7a56f9412324e3aa513206729fd80af9e539badcb5168b58f0f70dc0518a587ddd4f786f2b129955841061867acc2f10f6af5f9d8e40cad1af99db3
+  metadata.gz: 20abf6c65cf3558f079ed82e1b95245a66fac3e7301bdf6f3a8039e7ad20044efce9dddc2dee3c054ba8a18dbdc25437b8de934a37784f9521ce7c30cf34a6be
+  data.tar.gz: a84b5732a9a539ee9a2133f370748ee32d2dbff90cf916dc5a2bfa08817e1f90ce53dee7acafef8e887de6a5a40de763e2b250cb7bcc9ac72662fd18d70e3069

data/CHANGELOG.md

@@ -1,41 +1,60 @@
-# 1.3.0
+# CHANGELOG
 
-* Set minimum ruby version requirement to 2.5.0
+## 1.3.3 (2026-10-29)
 
-# 1.2.0
+- Preserve HTTP error types when the server returns malformed or unexpected JSON.
+- Keep authorization codes and response contents out of failed sign-in diagnostics.
+- Cancel release preparation when confirmation input is closed.
+- Exit sign-in when the authorization code prompt is closed or blank.
 
-* Fix version definition
+## 1.3.2 (2026-07-25)
 
-# 1.1.1
+- BREAKING: Require Ruby 3.4 or newer
+- Fix `get_clients` to call `/1.1/:account_id/clients` instead of `/1.1/accounts`
+- Move `TimelyApp::Cli` under `lib/`
 
-* Update gem configuration
+## 1.3.1 (2023-09-30)
 
-# 1.1.0
+- Refresh gemfile lock
 
-* Update ruby version to 3.2.2
-* Update dependencies
+## 1.3.0 (2023-08-30)
 
-# 1.0.5
+- Set minimum ruby version requirement to 2.5.0
 
-* Fix verbose mode check
+## 1.2.0 (2023-08-29)
 
-# 1.0.4
+- Fix version definition
 
-* Update CLI to check input properly and handle command arguments
+## 1.1.1 (2023-08-29)
 
-# 1.0.3
+- Update gem configuration
 
-* Fix gemspec
+## 1.1.0 (2023-08-15)
 
-# 1.0.2
+- Update ruby version to 3.2.2
+- Update dependencies
 
-* Add basic CLI script `timely-app`
+## 1.0.5 (2023-03-02)
 
-# 1.0.1
+- Fix verbose mode check
 
-* Fix oauth token request
-* Add example web service for CLI authorization
+## 1.0.4 (2023-02-14)
 
-# 1.0.0
+- Update CLI to check input properly and handle command arguments
 
-* Initial version
+## 1.0.3 (2023-02-14)
+
+- Fix gemspec
+
+## 1.0.2 (2023-02-14)
+
+- Add basic CLI script `timely-app`
+
+## 1.0.1 (2023-02-14)
+
+- Fix oauth token request
+- Add example web service for CLI authorization
+
+## 1.0.0 (2023-02-14)
+
+- Initial version

data/README.md

@@ -1,19 +1,25 @@
 # timely-app
 
-[![Gem Version](https://badge.fury.io/rb/timely-app.svg)](https://badge.fury.io/rb/timely-app) [![Test Status](https://github.com/amkisko/timely-app/actions/workflows/test.yml/badge.svg)](https://github.com/amkisko/timely-app/actions/workflows/test.yml) [![codecov](https://codecov.io/gh/amkisko/timely_app.rb/graph/badge.svg?token=QL3A7ATCRK)](https://codecov.io/gh/amkisko/timely_app.rb)
+[![Gem Version](https://badge.fury.io/rb/timely-app.svg)](https://badge.fury.io/rb/timely-app) [![Test Status](https://github.com/amkisko/timely-app/actions/workflows/test.yml/badge.svg)](https://github.com/amkisko/timely-app/actions/workflows/test.yml) [![codecov](https://codecov.io/gh/amkisko/timely_app.rb/graph/badge.svg?token=QL3A7ATCRK)](https://app.codecov.io/github/amkisko/timely_app.rb)
 
 Ruby client for the [Timely API](https://dev.timelyapp.com).
 
 Sponsored by [Kisko Labs](https://www.kiskolabs.com).
 
+<a href="https://www.kiskolabs.com">
+  <img src="kisko.svg" width="200" alt="Sponsored by Kisko Labs" />
+</a>
+
 ## Install
 
 Using Bundler:
+
 ```sh
 bundle add timely-app
 ```
 
 Using RubyGems:
+
 ```sh
 gem install timely-app
 ```
@@ -99,6 +105,19 @@ gem build timely-app.gemspec
 gem push timely-app-*.gem
 ```
 
+## Links
+
+- [GitHub](https://github.com/amkisko/timely_app.rb)
+- [GitLab](https://gitlab.com/amkisko/timely_app.rb)
+- [RubyGems](https://rubygems.org/gems/timely-app)
+- [Versions Atom](https://rubygems.org/gems/timely-app/versions.atom) (feed id `5816973660388`)
+- [libraries.io](https://libraries.io/rubygems/timely-app)
+- [Deps.dev](https://deps.dev/rubygems/timely-app)
+- [SonarCloud](https://sonarcloud.io/project/overview?id=amkisko_timely_app.rb)
+- [Snyk](https://snyk.io/test/github/amkisko/timely_app.rb)
+- [Codecov](https://app.codecov.io/github/amkisko/timely_app.rb)
+- [OpenSSF Scorecard](https://scorecard.dev/viewer/?uri=github.com/amkisko/timely_app.rb)
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/bin/timely-app

@@ -4,121 +4,6 @@ require "yaml"
 require "optparse"
 require "timely-app"
 
-module TimelyApp
-  class CLI
-    attr_reader :options, :client
-
-    def initialize(options = {})
-      @options = options
-      @client = TimelyApp::Client.new(
-        access_token: options[:access_token] || fetch_access_token,
-        account_id: options[:account_id] || fetch_account_id,
-        verbose: options[:verbose]
-      )
-    end
-
-    def get_config(key)
-      read_config_file&.fetch(key, nil)
-    end
-
-    def set_config(key, value)
-      save_config_file(key => value)
-    end
-
-    def command_exists?(cmd)
-      return false if cmd.nil? || cmd.empty?
-
-      client.respond_to?(cmd)
-    end
-
-    def call(cmd, *args)
-      client.send(cmd, *args)
-    end
-
-    def auth(client_id, client_secret)
-      if !client_id || !client_secret
-        puts "Usage: timely-app auth CLIENT_ID CLIENT_SECRET"
-        exit 1
-      end
-
-      auth_client = TimelyApp::Client.new(verbose: options[:verbose])
-      auth_url = auth_client.get_oauth_authorize_url(
-        client_id: client_id,
-        redirect_uri: "urn:ietf:wg:oauth:2.0:oob"
-      )
-      puts "Visit this URL in your browser:"
-      puts auth_url
-      puts "\nEnter authorization code here:"
-      code = gets.chomp
-      begin
-        token = auth_client.post_oauth_token(
-          client_id: client_id,
-          client_secret: client_secret,
-          code: code,
-          redirect_uri: "urn:ietf:wg:oauth:2.0:oob",
-          grant_type: "authorization_code"
-        )
-        if options[:save]
-          save_config_file(
-            access_token: token.access_token,
-            refresh_token: token.refresh_token,
-            created_at: token.created_at
-          )
-        else
-          puts "\nAccess token:\n#{token.access_token}\n"
-        end
-        if options[:verbose]
-          puts "Token details: #{token.to_h}"
-        end
-      rescue TimelyApp::Error => e
-        puts "Authentication failed"
-        if options[:verbose]
-          puts "Code: #{code}"
-          puts "Response code: #{e.response.code}"
-          puts "Response: #{e.response.body}"
-        end
-        exit 1
-      end
-    end
-
-    private
-
-    def config_file_path
-      Dir.home + "/.timelyrc"
-    end
-
-    def read_config_file
-      if File.exist?(config_file_path)
-        YAML.load_file(config_file_path)
-      end
-    end
-
-    def fetch_account_id
-      read_config_file&.fetch("account_id", nil)
-    end
-
-    def fetch_access_token
-      read_config_file&.fetch("access_token", nil)
-    end
-
-    def check_access_token
-      if !fetch_access_token
-        puts "No access token found. Run `timely-app auth` to get one."
-        exit 1
-      end
-    end
-
-    def save_config_file(**options)
-      config = read_config_file || {}
-      config.merge!(options)
-      File.open(config_file_path, "w") do |f|
-        f.write(config.to_yaml)
-      end
-      puts "Saved to #{config_file_path}"
-    end
-  end
-end
-
 options = {}
 OptionParser.new do |opts|
   opts.banner = "Usage: timely-app [command] [options]"
@@ -141,8 +26,8 @@ cli = TimelyApp::CLI.new(options)
 cmd = ARGV.shift
 case cmd
 when "auth"
-  client_id = ARGV.shift || ENV.fetch('TIMELY_CLIENT_ID')
-  client_secret = ARGV.shift || ENV.fetch('TIMELY_CLIENT_SECRET')
+  client_id = ARGV.shift || ENV.fetch("TIMELY_CLIENT_ID")
+  client_secret = ARGV.shift || ENV.fetch("TIMELY_CLIENT_SECRET")
   ARGV.clear
   if client_id && client_secret
     cli.auth(client_id, client_secret)
@@ -161,7 +46,10 @@ when "config"
   end
 else
   if cli.command_exists?(cmd)
-    args = ARGV.reduce({}){ |h, arg| k, v = arg.split("="); h[k] = v; h }
+    args = ARGV.each_with_object({}) { |arg, h|
+      k, v = arg.split("=")
+      h[k] = v
+    }
     ARGV.clear
     response = cli.call(cmd, *args)
     case response

data/lib/timely-app/cli.rb

@@ -0,0 +1,166 @@
+require "securerandom"
+require "yaml"
+
+module TimelyApp
+  class CLI
+    attr_reader :options, :client
+
+    def initialize(options = {})
+      @options = options
+      @client = TimelyApp::Client.new(
+        access_token: options[:access_token] || fetch_access_token,
+        account_id: options[:account_id] || fetch_account_id,
+        verbose: options[:verbose]
+      )
+    end
+
+    def get_config(key)
+      read_config_file&.fetch(key, nil)
+    end
+
+    def set_config(key, value)
+      save_config_file(key => value)
+    end
+
+    def command_exists?(cmd)
+      return false if cmd.nil? || cmd.empty?
+
+      client.respond_to?(cmd)
+    end
+
+    def call(cmd, *args)
+      client.send(cmd, *args)
+    end
+
+    def auth(client_id, client_secret)
+      validate_auth_credentials!(client_id, client_secret)
+
+      auth_client = TimelyApp::Client.new(verbose: options[:verbose])
+      code = authorize_via_browser(auth_client, client_id)
+      token = fetch_oauth_token(auth_client, client_id, client_secret, code)
+      persist_or_print_token(token)
+    rescue TimelyApp::Error => error
+      handle_auth_failure(error)
+    end
+
+    private
+
+    def validate_auth_credentials!(client_id, client_secret)
+      return if client_id && client_secret
+
+      puts "Usage: timely-app auth CLIENT_ID CLIENT_SECRET"
+      exit 1
+    end
+
+    def authorize_via_browser(auth_client, client_id)
+      auth_url = auth_client.get_oauth_authorize_url(
+        client_id: client_id,
+        redirect_uri: oauth_redirect_uri
+      )
+      puts "Visit this URL in your browser:"
+      puts auth_url
+      puts "\nEnter authorization code here:"
+      code = gets&.chomp
+      if code.nil? || code.empty?
+        puts "Authorization code is required"
+        exit 1
+      end
+      code
+    end
+
+    def oauth_redirect_uri
+      "urn:ietf:wg:oauth:2.0:oob"
+    end
+
+    def fetch_oauth_token(auth_client, client_id, client_secret, code)
+      auth_client.post_oauth_token(
+        client_id: client_id,
+        client_secret: client_secret,
+        code: code,
+        redirect_uri: oauth_redirect_uri,
+        grant_type: "authorization_code"
+      )
+    end
+
+    def persist_or_print_token(token)
+      if options[:save]
+        save_config_file(
+          access_token: token.access_token,
+          refresh_token: token.refresh_token,
+          created_at: token.created_at
+        )
+      else
+        puts "\nAccess token:\n#{token.access_token}\n"
+      end
+      puts "Authentication succeeded" if options[:verbose]
+    end
+
+    def handle_auth_failure(error)
+      puts "Authentication failed"
+      if options[:verbose]
+        puts "Response code: #{error.response.code}"
+      end
+      exit 1
+    end
+
+    def config_file_path
+      Dir.home + "/.timelyrc"
+    end
+
+    def read_config_file
+      return unless File.exist?(config_file_path)
+
+      config = YAML.safe_load_file(
+        config_file_path,
+        permitted_classes: [Symbol, Time],
+        aliases: false
+      )
+      return {} unless config.is_a?(Hash)
+
+      config.to_h { |key, value| [key.to_s, value] }
+    end
+
+    def fetch_account_id
+      read_config_file&.fetch("account_id", nil)
+    end
+
+    def fetch_access_token
+      read_config_file&.fetch("access_token", nil)
+    end
+
+    def check_access_token
+      unless fetch_access_token
+        puts "No access token found. Run `timely-app auth` to get one."
+        exit 1
+      end
+    end
+
+    def save_config_file(**options)
+      config = read_config_file || {}
+      config.merge!(options.to_h { |key, value| [key.to_s, value] })
+      write_config_file(config.to_yaml)
+      puts "Saved to #{config_file_path}"
+    end
+
+    def write_config_file(content)
+      temporary_path = "#{config_file_path}.#{Process.pid}.#{SecureRandom.hex(8)}.tmp"
+
+      File.open(temporary_path, File::WRONLY | File::CREAT | File::EXCL, 0o600) do |file|
+        file.write(content)
+        file.flush
+        file.fsync
+      end
+      File.rename(temporary_path, config_file_path)
+      File.chmod(0o600, config_file_path)
+      sync_config_directory
+    ensure
+      File.delete(temporary_path) if temporary_path && File.exist?(temporary_path)
+    end
+
+    def sync_config_directory
+      File.open(File.dirname(config_file_path), File::RDONLY, &:fsync)
+    rescue Errno::EINVAL
+      nil
+    end
+  end
+end

data/lib/timely-app/client/accounts.rb

@@ -4,7 +4,7 @@
 module TimelyApp
   class Client
     def get_accounts
-      get('/1.1/accounts')
+      get("/1.1/accounts")
     end
 
     def get_account_activities(account_id, **params)

data/lib/timely-app/client/auth.rb

@@ -6,7 +6,7 @@ module TimelyApp
     def get_oauth_authorize_url(client_id:, redirect_uri:)
       host_uri_join(
         "/1.1/oauth/authorize",
-        response_type: 'code',
+        response_type: "code",
         redirect_uri: redirect_uri,
         client_id: client_id
       )

data/lib/timely-app/client/clients.rb

@@ -8,7 +8,7 @@ module TimelyApp
     end
 
     def get_clients(**params)
-      get('/1.1/accounts', params)
+      get("/1.1/#{account_id}/clients", **params)
     end
 
     def get_client(id)

data/lib/timely-app/client.rb

@@ -1,29 +1,32 @@
 # frozen_string_literal: true
 
-require 'timely-app/errors'
-require 'timely-app/link_header'
-require 'timely-app/params'
-require 'timely-app/record'
-require 'timely-app/response'
-require 'net/http'
-require 'json'
+require "timely-app/errors"
+require "timely-app/link_header"
+require "timely-app/params"
+require "timely-app/record"
+require "timely-app/response"
+require "net/http"
+require "json"
 
 module TimelyApp
   class Client
+    DEFAULT_OPEN_TIMEOUT = 5
+    DEFAULT_READ_TIMEOUT = 30
+    FILTERED_VALUE = "[FILTERED]"
+    SENSITIVE_FIELD = /authorization|code|credential|password|secret|token/i
+
     attr_accessor :account_id
 
     def initialize(options = {})
-      @auth_header = 'Authorization'
+      @auth_header = "Authorization"
       @auth_value = "Bearer #{options[:access_token]}"
       @user_agent = options.fetch(:user_agent) { "timely-app/#{VERSION} ruby/#{RUBY_VERSION}" }
 
-      @host = 'api.timelyapp.com'
-
-      @http = Net::HTTP.new(@host, Net::HTTP.https_default_port)
-      @http.use_ssl = true
+      @host = "api.timelyapp.com"
+      @http = build_http(options)
 
       @account_id = options[:account_id]
-      @verbose = options[:verbose] || !ENV['VERBOSE'].nil? || false
+      @verbose = options[:verbose] || !ENV["VERBOSE"].nil? || false
     end
 
     def get(path, params = nil)
@@ -32,12 +35,20 @@ module TimelyApp
 
     private
 
+    def build_http(options)
+      http = Net::HTTP.new(@host, Net::HTTP.https_default_port)
+      http.use_ssl = true
+      http.open_timeout = options.fetch(:open_timeout, DEFAULT_OPEN_TIMEOUT)
+      http.read_timeout = options.fetch(:read_timeout, DEFAULT_READ_TIMEOUT)
+      http
+    end
+
     def verbose?
       @verbose == true
     end
 
     def host_uri_join(path, params)
-      URI::join("https://#{@host}", Params.join(path, params)).to_s
+      URI.join("https://#{@host}", Params.join(path, params)).to_s
     end
 
     def post(path, attributes)
@@ -53,24 +64,50 @@ module TimelyApp
     end
 
     def request(http_request, body_object = nil)
-      http_request['User-Agent'] = @user_agent
+      apply_request_headers(http_request, body_object)
+      response = @http.request(http_request)
+      log_verbose_exchange(http_request, response)
+      raise Response.error(response) unless response.is_a?(Net::HTTPSuccess)
+
+      Response.parse(response)
+    end
+
+    def apply_request_headers(http_request, body_object)
+      http_request["User-Agent"] = @user_agent
       http_request[@auth_header] = @auth_value
 
-      if body_object
-        http_request['Content-Type'] = 'application/json'
-        http_request.body = JSON.generate(body_object)
-      end
+      return unless body_object
 
-      response = @http.request(http_request)
+      http_request["Content-Type"] = "application/json"
+      http_request.body = JSON.generate(body_object)
+    end
 
-      if verbose?
-        puts ">> request: #{http_request.method} #{http_request.path} #{http_request.body}"
-        puts "<< response: #{http_request.method} #{http_request.path} #{response.code} #{response.body}"
-      end
+    def log_verbose_exchange(http_request, response)
+      return unless verbose?
 
-      raise Response.error(response) unless response.is_a?(Net::HTTPSuccess)
+      puts ">> request: #{http_request.method} #{http_request.path} #{filtered_body(http_request.body)}"
+      puts "<< response: #{http_request.method} #{http_request.path} #{response.code} #{filtered_body(response.body)}"
+    end
 
-      Response.parse(response)
+    def filtered_body(body)
+      return if body.nil? || body.empty?
+
+      JSON.generate(filter_sensitive_values(JSON.parse(body)))
+    rescue JSON::ParserError
+      FILTERED_VALUE
+    end
+
+    def filter_sensitive_values(value)
+      case value
+      when Hash
+        value.to_h { |key, nested_value|
+          [key, key.match?(SENSITIVE_FIELD) ? FILTERED_VALUE : filter_sensitive_values(nested_value)]
+        }
+      when Array
+        value.map { |nested_value| filter_sensitive_values(nested_value) }
+      else
+        value
+      end
     end
   end
 end

data/lib/timely-app/link_header.rb

@@ -1,5 +1,5 @@
-require 'timely-app/record'
-require 'uri'
+require "timely-app/record"
+require "uri"
 
 module TimelyApp
   module LinkHeader

data/lib/timely-app/params.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
-require 'cgi'
+
+require "cgi"
 
 module TimelyApp
   module Params
@@ -8,17 +9,17 @@ module TimelyApp
     def join(path, params = nil)
       return path if params.nil? || params.empty?
 
-      path + '?' + encode(params)
+      path + "?" + encode(params)
     end
 
     def encode(params)
-      params.map { |k, v| "#{escape(k)}=#{array_escape(v)}" }.join('&')
+      params.map { |k, v| "#{escape(k)}=#{array_escape(v)}" }.join("&")
     end
 
     private
 
     def array_escape(object)
-      Array(object).map { |value| escape(value) }.join(',')
+      Array(object).map { |value| escape(value) }.join(",")
     end
 
     def escape(component)

data/lib/timely-app/record.rb

@@ -14,13 +14,13 @@ module TimelyApp
 
     def method_missing(name, *args, &block)
       if @attributes.has_key?(name) && args.empty? && block.nil?
-        return @attributes[name]
+        @attributes[name]
       else
-        super name, *args, &block
+        super
       end
     end
 
-    def respond_to_missing?(name, include_private = false)
+    def respond_to_missing?(name, _include_private = false)
       @attributes.has_key?(name)
     end