timecode 0.1.9 → 0.2.0

data/History.txt

@@ -1,3 +1,7 @@
+=== 0.2.0 / 2009-02-26
+
+* Properly handle integers starting with 0 in Tiecode.parse (zef)
+
 === 0.1.9 / 2009-02-23
 
 * Do not be biased when rounding out frames on from_seconds

data/SPECS.txt

@@ -90,6 +90,7 @@
 * raise when trying to parse DF timecode
 * raise on improper format
 * raise on empty argument
+* properly handle 09 and 08 as part of complete TC pattern
 
 == Timecode.soft_parse should
 * parse the timecode
@@ -99,4 +100,4 @@
 * parse from a 4x4bits packed 32bit unsigned int
 * properly convert itself back to 4x4 bits 32bit unsigned int
 
-68 specifications (112 requirements), 0 failures
+69 specifications (113 requirements), 0 failures

data/lib/timecode.rb

@@ -12,7 +12,7 @@
 #     :mapping => [%w(source_tc_frames total), %w(tape_fps fps)]
 
 class Timecode
-  VERSION = '0.1.9'
+  VERSION = '0.2.0'
 
   include Comparable
   
@@ -82,7 +82,7 @@ class Timecode
         raise Error, "We do not support drop-frame TC"
       # 00:00:00:00
       elsif (input =~ COMPLETE_TC_RE)
-        atoms_and_fps = input.scan(COMPLETE_TC_RE).to_a.flatten.map{|e| Integer(e)} + [with_fps]
+        atoms_and_fps = input.scan(COMPLETE_TC_RE).to_a.flatten.map{|e| e.to_i} + [with_fps]
         return at(*atoms_and_fps)
       # 00:00:00.0
       elsif input =~ FRACTIONAL_TC_RE

data/test/test_timecode.rb

@@ -156,6 +156,14 @@ context "A Timecode of zero should" do
   end
 end
 
+context "Timecode.from_seconds should" do
+  specify "properly process this specific case for a float framerate" do
+    float_secs = 89.99165971643036
+    float_fps = 23.9898
+    lambda{ Timecode.from_seconds(float_secs, float_fps) }.should.not.raise
+  end
+end
+
 context "Timecode#to_seconds should" do
   specify "return a float" do
     Timecode.new(0).to_seconds.should.be.kind_of Float
@@ -397,6 +405,10 @@ context "Timecode.parse should" do
   specify "raise on empty argument" do
     lambda { Timecode.parse("   \n\n  ", 25) }.should.raise Timecode::CannotParse
   end
+  
+  specify "properly handle 09 and 08 as part of complete TC pattern" do
+    Timecode.parse( "09:08:09:08", 25).total.should.equal 822233
+  end
 end
 
 context "Timecode.soft_parse should" do
@@ -412,6 +424,7 @@ context "Timecode.soft_parse should" do
   end
 end
 
+
 context "Timecode with unsigned integer conversions should" do
   
   specify "parse from a 4x4bits packed 32bit unsigned int" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: timecode
 version: !ruby/object:Gem::Version 
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors: 
 - Julik
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-02-23 00:00:00 +01:00
+date: 2009-08-29 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency