time_splitter 0.5.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83c4a402a05a74a22687e44114460cf340c73eb8
-  data.tar.gz: 2abde10a75986d39028fa19cc95f4ad6db88a273
+  metadata.gz: e95cb957e2b377227f2267ded2a018b24ec88aa9
+  data.tar.gz: 8a56421b51019ea0a86a494f071b47e4d953c8f2
 SHA512:
-  metadata.gz: aa52cdbe485b91bfd9f4224d25fb6fbecdd780ddd6cdf317234a03a552646a0e351b1b49897282f28f81e229156ed9ca6b0ecac79b1d2c936764debc836860a6
-  data.tar.gz: 3742fd82de7c316b7f5eaf792798376a92b03753a4ae2392230c2e442629b58dd5786f490e0675d4c3ec5cac72cbcc2419c91f2265c4e3d2b5deac4ce30fce66
+  metadata.gz: 2846d29799635f3d33faaa61678c6e8fb04034a7b0e7f0cddaa896da92cbf6f4ddf9e79bbed2f7200ac7ae6f87dffb4736974439c5e8152096f778df8f001dd9
+  data.tar.gz: 12ebd84275f87d033f08c1c78d36b64d6e92938db113deeb2e6bc01499f718445b22b9b3239123587d46572af101a23105218c21b3e466e3b747f3a8ae471ba1

data/README.md

@@ -38,7 +38,7 @@ In your view:
   <%= f.input :starts_at_date, as: :string, input_html: { class: 'datepicker' } %>
   <%= f.input :starts_at_hour, collection: 0..24 %>
   <%= f.input :starts_at_min, collection: [0, 15, 30, 45] %>
-  <%= f.input :starts_at_time, as: :time_select
+  <%= f.input :starts_at_time, as: :time
   <%= ... %>
 <% end %>
 ```
@@ -49,13 +49,24 @@ If you are using Rails < 4.0 and/or are not using StrongParameters, you must add
 
 ## Options
 
-You can specify the date format for the view:
+By default, the read accessors provided by TimeSplitter are as follows:
+```ruby
+starts_at_date #=> Date
+starts_at_time #=> Time or Timey class used in :default option
+starts_at_hour #=> Fixnum
+starts_at_min  #=> Fixnum
+```
+
+You can override the default read format for date and time if you so choose, though doing so may not work well with certain form input types.
 
 ```ruby
-split_accessor :starts_at, format: "%D"
+split_accessor :starts_at, date_format: "%D", time_format: "%I:%M%p"
+
+starts_at_date #=> String "2013-10-13"
+starts_at_time #=> String "01:44PM"
 ```
 
-See `Time#strftime` for formats. Default is `"%F"`.
+See `Time#strftime` for formats.
 
 You can specify multiple datetime fields to split:
 
@@ -70,7 +81,7 @@ split_accessor :starts_at, default: -> { DateTime.current }
 
 # model = Model.new(starts_at_time: '09:00')
 # model.starts_at
-# => Thu, 10 Oct 2013 09:00:00 -0400 
+# => Thu, 10 Oct 2013 09:00:00 -0400 # DateTime
 ```
 
 The default time object is `Time.new(0, 1, 1, 0, 0, 0, '+00:00')`.

data/lib/time_splitter/accessors.rb

@@ -1,7 +1,7 @@
 module TimeSplitter
   module Accessors
     def split_accessor(*attrs)
-      options = { format: "%F" }.merge!(attrs.extract_options!)
+      options = attrs.extract_options!
 
       attrs.each do |attr|
         # Maps the setter for #{attr}_time to accept multipart-parameters for Time
@@ -41,7 +41,8 @@ module TimeSplitter
 
         # Readers
         define_method("#{attr}_date") do
-          self.send(attr).try :strftime, options[:format]
+          date = self.send(attr).try :to_date
+          date && options[:date_format] ? date.strftime(options[:date_format]) : date
         end
 
         define_method("#{attr}_hour") do
@@ -53,7 +54,8 @@ module TimeSplitter
         end
 
         define_method("#{attr}_time") do
-          self.send(attr)
+          time = self.send(attr)
+          time && options[:time_format] ? time.strftime(options[:time_format]) : time
         end
       end
     end

data/lib/time_splitter/version.rb

@@ -1,3 +1,3 @@
 module TimeSplitter
-  VERSION = "0.5.0"
+  VERSION = "1.0.0"
 end

data/spec/time_splitter/accessors_spec.rb

@@ -29,7 +29,7 @@ describe TimeSplitter::Accessors do
         it 'sets the date on the new default' do
           model.starts_at_date = '2222-5-6'
           expect(model.starts_at).to eq DateTime.new(2222, 5, 6, 4, 5, 0, '+7')
-          expect(model.starts_at_date).to eq '2222-05-06'
+          expect(model.starts_at_date).to eq Date.new(2222, 5, 6)
         end
 
         it 'sets the hour on the new default' do
@@ -57,7 +57,7 @@ describe TimeSplitter::Accessors do
         end
 
         it "lets you modify the format" do
-          Model.split_accessor(:starts_at, format: "%D")
+          Model.split_accessor(:starts_at, date_format: "%D")
           expect(model.starts_at_date).to be_nil
         end
 
@@ -114,6 +114,11 @@ describe TimeSplitter::Accessors do
           expect(model.starts_at_time).to be_nil
         end
 
+        it "lets you modify the time format" do
+          Model.split_accessor(:starts_at, time_format: "%I:%M%p")
+          expect(model.starts_at_time).to be_nil
+        end
+
         it 'sets the hour and minute of #starts_at' do
           model.starts_at_time = '08:33'
           expect(model.starts_at).to eq Time.new(0, 1, 1, 8, 33, 0, '+00:00')
@@ -130,12 +135,12 @@ describe TimeSplitter::Accessors do
       before { model.starts_at = Time.new(2222, 12, 22, 13, 44, 0, '+00:00') }
 
       describe "#starts_at_date" do
-        it "returns the model's starts_at date as string" do
-          expect(model.starts_at_date).to eq "2222-12-22"
+        it "returns the model's starts_at date" do
+          expect(model.starts_at_date).to eq Date.new(2222, 12, 22)
         end
 
         it "lets you modify the format" do
-          Model.split_accessor(:starts_at, format: "%D")
+          Model.split_accessor(:starts_at, date_format: "%D")
           expect(model.starts_at_date).to eq "12/22/22"
         end
 
@@ -192,6 +197,11 @@ describe TimeSplitter::Accessors do
           expect(model.starts_at_time).to eq Time.new(2222, 12, 22, 13, 44, 0, '+00:00')
         end
 
+        it "lets you modify the time format" do
+          Model.split_accessor(:starts_at, time_format: "%I:%M%p")
+          expect(model.starts_at_time).to eq "01:44PM"
+        end
+
         it 'sets the hour and minute of #starts_at' do
           model.starts_at_time = '08:33'
           expect(model.starts_at).to eq Time.new(2222, 12, 22, 8, 33, 0, '+00:00')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: time_splitter
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Michi Huber
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-10 00:00:00.000000000 Z
+date: 2013-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport