time_splitter 0.3.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b0e7a2efa2624f9e9b93089303e8c975201499d0
-  data.tar.gz: 48bb238c11c35ac0aa3fdefdd9c2d37eec96d976
+  metadata.gz: 83c4a402a05a74a22687e44114460cf340c73eb8
+  data.tar.gz: 2abde10a75986d39028fa19cc95f4ad6db88a273
 SHA512:
-  metadata.gz: 8a29b021ceedb61e9fb73db2e1e7263b94fe71873301a038ac7fe92b44232ef7176b224cede11ed0ddc3d18ce2762c217b59af072a5454b590db077126156366
-  data.tar.gz: a146932e7285df2d5cfe939c12f06a671a18aa5b09b1d01ecccceb62a722021ef6453716ccd633ba3bcf83b0b5b895410ab09708b5cbec4a4c058eeb9fc94e60
+  metadata.gz: aa52cdbe485b91bfd9f4224d25fb6fbecdd780ddd6cdf317234a03a552646a0e351b1b49897282f28f81e229156ed9ca6b0ecac79b1d2c936764debc836860a6
+  data.tar.gz: 3742fd82de7c316b7f5eaf792798376a92b03753a4ae2392230c2e442629b58dd5786f490e0675d4c3ec5cac72cbcc2419c91f2265c4e3d2b5deac4ce30fce66

data/README.md

@@ -62,3 +62,18 @@ You can specify multiple datetime fields to split:
 ```ruby
 split_accessor :starts_at, :ends_at, :expires_at, format: "%D"
 ```
+
+You can specify a default timey object to write. If `starts_at` is `nil`, which it would be at the time of a `new` or `create` call, TimeSplitter will use the default value as the basepoint for modification.
+
+```ruby
+split_accessor :starts_at, default: -> { DateTime.current }
+
+# model = Model.new(starts_at_time: '09:00')
+# model.starts_at
+# => Thu, 10 Oct 2013 09:00:00 -0400 
+```
+
+The default time object is `Time.new(0, 1, 1, 0, 0, 0, '+00:00')`.
+
+Note that TimeSplitter does not handle seconds at this time, and from testing it appears they are set to zero when modifying them.
+

data/lib/time_splitter/accessors.rb

@@ -1,7 +1,7 @@
 module TimeSplitter
   module Accessors
     def split_accessor(*attrs)
-      opts = { format: "%F" }.merge!(attrs.extract_options!)
+      options = { format: "%F" }.merge!(attrs.extract_options!)
 
       attrs.each do |attr|
         # Maps the setter for #{attr}_time to accept multipart-parameters for Time
@@ -12,7 +12,7 @@ module TimeSplitter
         # default value for +#{attr}+ to modify without explicitely overriding
         # the attr_reader. Defaults to a Time object with all fields set to 0.
         define_method("#{attr}_or_new") do
-          self.send(attr) || Time.new(0)
+          self.send(attr) || options.fetch(:default, ->{ Time.new(0, 1, 1, 0, 0, 0, "+00:00") }).call
         end
 
         # Writers
@@ -41,7 +41,7 @@ module TimeSplitter
 
         # Readers
         define_method("#{attr}_date") do
-          self.send(attr).try :strftime, opts[:format]
+          self.send(attr).try :strftime, options[:format]
         end
 
         define_method("#{attr}_hour") do
@@ -53,7 +53,7 @@ module TimeSplitter
         end
 
         define_method("#{attr}_time") do
-          self.send(attr).try :to_time
+          self.send(attr)
         end
       end
     end

data/lib/time_splitter/version.rb

@@ -1,3 +1,3 @@
 module TimeSplitter
-  VERSION = "0.3.1"
+  VERSION = "0.5.0"
 end

data/spec/time_splitter/accessors_spec.rb

@@ -23,6 +23,34 @@ describe TimeSplitter::Accessors do
 
   describe "split datetime methods" do
     context 'when #starts_at is nil' do
+      describe 'overriding the default time' do
+        before { Model.split_accessor :starts_at, default: ->{ DateTime.new(1111, 2, 3, 4, 5, 0, '+7') } }
+
+        it 'sets the date on the new default' do
+          model.starts_at_date = '2222-5-6'
+          expect(model.starts_at).to eq DateTime.new(2222, 5, 6, 4, 5, 0, '+7')
+          expect(model.starts_at_date).to eq '2222-05-06'
+        end
+
+        it 'sets the hour on the new default' do
+          model.starts_at_hour = 9
+          expect(model.starts_at).to eq DateTime.new(1111, 2, 3, 9, 5, 0, '+7')
+          expect(model.starts_at_hour).to eq 9
+        end
+
+        it 'sets the minute on the new default' do
+          model.starts_at_min = 20
+          expect(model.starts_at).to eq DateTime.new(1111, 2, 3, 4, 20, 0, '+7')
+          expect(model.starts_at_min).to eq 20
+        end
+
+        it 'sets the time on the new default' do
+          model.starts_at_time = '09:22'
+          expect(model.starts_at).to eq DateTime.new(1111, 2, 3, 9, 22, 0, '+7')
+          expect(model.starts_at_time).to eq DateTime.new(1111, 2, 3, 9, 22, 0, '+7')
+        end
+      end
+
       describe "#starts_at_date" do
         it "returns nil" do
           expect(model.starts_at_date).to be_nil
@@ -35,12 +63,12 @@ describe TimeSplitter::Accessors do
 
         it "sets the appropiate parts of #starts_at" do
           model.starts_at_date = Time.new(1111, 1, 1)
-          expect(model.starts_at).to eq Time.new(1111, 1, 1, 0, 0, 0)
+          expect(model.starts_at).to eq Time.new(1111, 1, 1, 0, 0, 0, '+00:00')
         end
 
         it "can set from a string" do
           model.starts_at_date = "1111-01-01"
-          expect(model.starts_at).to eq Time.new(1111, 1, 1, 0, 0, 0)
+          expect(model.starts_at).to eq Time.new(1111, 1, 1, 0, 0, 0, '+00:00')
         end
 
         it "is nil if the string is empty" do
@@ -56,7 +84,7 @@ describe TimeSplitter::Accessors do
 
         it "sets the hour of starts_at" do
           model.starts_at_hour = 11
-          expect(model.starts_at).to eq Time.new(0, 1, 1, 11, 0, 0)
+          expect(model.starts_at).to eq Time.new(0, 1, 1, 11, 0, 0, '+00:00')
         end
 
         it "is nil if the string is empty" do
@@ -72,7 +100,7 @@ describe TimeSplitter::Accessors do
 
         it "sets the minute of #starts_at" do
           model.starts_at_min = 55
-          expect(model.starts_at).to eq Time.new(0, 1, 1, 0, 55, 0)
+          expect(model.starts_at).to eq Time.new(0, 1, 1, 0, 55, 0, '+00:00')
         end
 
         it "is nil if the string is empty" do
@@ -88,7 +116,7 @@ describe TimeSplitter::Accessors do
 
         it 'sets the hour and minute of #starts_at' do
           model.starts_at_time = '08:33'
-          expect(model.starts_at).to eq Time.new(0, 1, 1, 8, 33, 0)
+          expect(model.starts_at).to eq Time.new(0, 1, 1, 8, 33, 0, '+00:00')
         end
 
         it 'is nil if the string is empty' do
@@ -99,7 +127,7 @@ describe TimeSplitter::Accessors do
     end
 
     context 'when modifying #starts_at' do
-      before { model.starts_at = Time.new(2222, 12, 22, 13, 44, 0) }
+      before { model.starts_at = Time.new(2222, 12, 22, 13, 44, 0, '+00:00') }
 
       describe "#starts_at_date" do
         it "returns the model's starts_at date as string" do
@@ -113,17 +141,17 @@ describe TimeSplitter::Accessors do
 
         it "sets the appropiate parts of #starts_at" do
           model.starts_at_date = Time.new(1111, 1, 1)
-          expect(model.starts_at).to eq Time.new(1111, 1, 1, 13, 44, 0)
+          expect(model.starts_at).to eq Time.new(1111, 1, 1, 13, 44, 0, '+00:00')
         end
 
         it "can set from a string" do
           model.starts_at_date = "1111-01-01"
-          expect(model.starts_at).to eq Time.new(1111, 1, 1, 13, 44, 0)
+          expect(model.starts_at).to eq Time.new(1111, 1, 1, 13, 44, 0, '+00:00')
         end
 
         it "uses the default if the string is empty" do
           model.starts_at_date = ""
-          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0)
+          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0, '+00:00')
         end
       end
 
@@ -134,12 +162,12 @@ describe TimeSplitter::Accessors do
 
         it "sets the hour of starts_at" do
           model.starts_at_hour = 11
-          expect(model.starts_at).to eq Time.new(2222, 12, 22, 11, 44, 0)
+          expect(model.starts_at).to eq Time.new(2222, 12, 22, 11, 44, 0, '+00:00')
         end
 
         it "uses the default if the string is empty" do
           model.starts_at_hour = ""
-          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0)
+          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0, '+00:00')
         end
       end
 
@@ -150,28 +178,28 @@ describe TimeSplitter::Accessors do
 
         it "sets the minute of #starts_at" do
           model.starts_at_min = 55
-          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 55, 0)
+          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 55, 0, '+00:00')
         end
 
         it "uses the default if the string is empty" do
           model.starts_at_min = ""
-          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0)
+          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0, '+00:00')
         end
       end
 
       describe '#starts_at_time' do
         it 'returns the time' do
-          expect(model.starts_at_time).to eq Time.new(2222, 12, 22, 13, 44, 0)
+          expect(model.starts_at_time).to eq Time.new(2222, 12, 22, 13, 44, 0, '+00:00')
         end
 
         it 'sets the hour and minute of #starts_at' do
           model.starts_at_time = '08:33'
-          expect(model.starts_at).to eq Time.new(2222, 12, 22, 8, 33, 0)
+          expect(model.starts_at).to eq Time.new(2222, 12, 22, 8, 33, 0, '+00:00')
         end
 
         it 'uses the default if the string is empty' do
           model.starts_at_time = ''
-          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0)
+          expect(model.starts_at).to eq Time.new(2222, 12, 22, 13, 44, 0, '+00:00')
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: time_splitter
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Michi Huber
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-29 00:00:00.000000000 Z
+date: 2013-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -79,7 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.5
+rubygems_version: 2.1.7
 signing_key: 
 specification_version: 4
 summary: Use `datetime_accessor :starts_at` to provide `starts_at_date`, `starts_at_time`,