time_pilot 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1035c965584954a3de7fbee71027d0d081c2c8a99521f1590fd9f6ad00f84438
-  data.tar.gz: 01bc1de61e0911ca0e60f464d2869028a9b22556ea0f6c5ec71163d5d3b4b979
+  metadata.gz: c6553820e8f6b3c0a0432cbc93853d738c185d241d4600054c6004bf6bb72c8b
+  data.tar.gz: 6a15e38e9b53dd74c3d46b2117f6c357136b1119ea1c1d29b20950e79d27ce52
 SHA512:
-  metadata.gz: 5d477c3f65330966a93de7ba0088b24771f38d6cbc9a280a1dfa6382d30ce01fe025df2f31d9aa734a366587e545f2bc2e7e7d85aeb9220c77513603ab9ecc36
-  data.tar.gz: 2f790748fcdcd320ee06fdfafacef5facd3400dce9a807f1f6998647622b3155519b865e8f9a6f139491d3b9a291f1947b49c866568774362fa9b990d3416dec
+  metadata.gz: 3e3ae4b4ff917dd411dc82fd56e32be43c297e7b3b0116f34dbd902d171a73c5e2a5965e1770f52933652868bd1f405a73044c128ece0d101bb5561bd6ca1e00
+  data.tar.gz: 1e0e68b17d22063b01aaea0ad9580e654590635e2e909d7b9c7de68b9c66350fbf51ba0afd0582ac8a7c990e89e59ef9443e2a878795e636029d3df1b802af51

data/.github/workflows/ruby.yml

@@ -0,0 +1,33 @@
+name: Testing
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.6', '2.7', '3.0']
+    services:
+      redis:
+        image: redis
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 6379:6379
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rake

data/.gitignore

@@ -1,2 +1,3 @@
 *.gem
 Gemfile.lock
+.idea

data/.tool-versions

@@ -0,0 +1 @@
+ruby 3.0.2

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2014 Matthijs Langenberg and Mark Oude Veldhuis
+Copyright (c) 2014-2021 Matthijs Langenberg and Mark Oude Veldhuis
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,4 +1,4 @@
-# TimePilot [![Build Status](https://travis-ci.org/nedap/time_pilot.svg)](https://travis-ci.org/nedap/time_pilot) ![Code Climate](https://codeclimate.com/repos/538c225ae30ba00d55006394/badges/1741b217ec9818699a37/gpa.png)
+# TimePilot [![Testing](https://github.com/nedap/time_pilot/actions/workflows/ruby.yml/badge.svg)](https://github.com/nedap/time_pilot/actions/workflows/ruby.yml) ![Code Climate](https://codeclimate.com/repos/538c225ae30ba00d55006394/badges/1741b217ec9818699a37/gpa.png)
 
 TimePilot is a RubyGem that makes it possible to define features that can be enabled for a certain group of users. It requires very little configuration, and is designed to work stand-alone on any object. TimePilot uses Redis for storage.
 

data/docker-compose.yml

@@ -0,0 +1,6 @@
+version: '3'
+services:
+  redis:
+    image: "redis:latest"
+    ports:
+      - 6379:6379

data/lib/time_pilot/time_pilot.rb

@@ -90,9 +90,9 @@ module TimePilot
     end
 
     def pilot_member_in_any_group?(feature_name)
-      TimePilot.redis.pipelined do
+      TimePilot.redis.pipelined do |pipeline|
         self.class.time_pilot_groups.each do |group|
-          TimePilot.redis.sismember(
+          pipeline.sismember(
             TimePilot.key("#{feature_name}:#{group}_ids"),
             send(pilot_method_for_group(group))
           )

data/lib/time_pilot/version.rb

@@ -1,3 +1,3 @@
 module TimePilot
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.0.1'.freeze
 end

data/test/time_pilot_test.rb

@@ -1,10 +1,13 @@
-require_relative '../lib/time_pilot'
-require 'minitest/autorun'
+# frozen_string_literal: true
+
+require_relative "../lib/time_pilot"
+require "minitest/autorun"
 
 class Company
   include TimePilot::Features
   is_pilot_group
   attr_reader :id
+
   def initialize(id)
     @id = id
   end
@@ -14,6 +17,7 @@ class Team
   include TimePilot::Features
   is_pilot_group overridden_by: :company
   attr_reader :company_id, :id
+
   def initialize(company_id, id)
     @company_id = company_id
     @id = id
@@ -22,8 +26,9 @@ end
 
 class Employee
   include TimePilot::Features
-  is_pilot_group overridden_by: [:company, :team]
+  is_pilot_group overridden_by: %i[company team]
   attr_reader :company_id, :team_id, :id
+
   def initialize(company_id, team_id, id)
     @company_id = company_id
     @team_id = team_id
@@ -32,11 +37,11 @@ class Employee
 end
 
 TimePilot.configure do |c|
-  c.feature 'planning'
+  c.feature "planning"
 end
 
 TimePilot.configure do |c|
-  c.feature 'secret_feature'
+  c.feature "secret_feature"
 end
 
 describe TimePilot do
@@ -50,102 +55,102 @@ describe TimePilot do
     @jane = Employee.new(@nedap.id, @healthcare.id, 22)
   end
 
-  it 'allows multiple configure blocks to add features' do
-    TimePilot.features.must_equal ['planning', 'secret_feature']
-    @acme.planning_enabled?.must_equal false
-    @acme.secret_feature_enabled?.must_equal false
+  it "allows multiple configure blocks to add features" do
+    _(TimePilot.features).must_equal %w[planning secret_feature]
+    _(@acme.planning_enabled?).must_equal false
+    _(@acme.secret_feature_enabled?).must_equal false
   end
 
-  it 'defines a getter on company' do
-    TimePilot.redis.sadd 'timepilot:planning:company_ids', @acme.id
-    @acme.planning_enabled?.must_equal true
-    @acme.instance_variable_get("@planning_enabled").must_equal true
+  it "defines a getter on company" do
+    TimePilot.redis.sadd "timepilot:planning:company_ids", @acme.id
+    _(@acme.planning_enabled?).must_equal true
+    _(@acme.instance_variable_get("@planning_enabled")).must_equal true
   end
 
-  it 'defines an enabler on company' do
+  it "defines an enabler on company" do
     @nedap.enable_planning
-    TimePilot.redis.sismember("timepilot:planning:company_ids", @nedap.id).must_equal true
+    _(TimePilot.redis.sismember("timepilot:planning:company_ids", @nedap.id)).must_equal true
   end
 
-  it 'defines a disabler on employee' do
+  it "defines a disabler on employee" do
     @nedap.enable_planning
-    @nedap.planning_enabled?.must_equal true
-    @nedap.instance_variable_get("@planning_enabled").must_equal true
+    _(@nedap.planning_enabled?).must_equal true
+    _(@nedap.instance_variable_get("@planning_enabled")).must_equal true
     @nedap.disable_planning
-    @nedap.planning_enabled?.must_equal false
-    @nedap.instance_variable_get("@planning_enabled").must_equal false
+    _(@nedap.planning_enabled?).must_equal false
+    _(@nedap.instance_variable_get("@planning_enabled")).must_equal false
   end
 
-  it 'defines a getter on team' do
-    TimePilot.redis.sadd 'timepilot:planning:team_ids', @healthcare.id
-    @healthcare.planning_enabled?.must_equal true
+  it "defines a getter on team" do
+    TimePilot.redis.sadd "timepilot:planning:team_ids", @healthcare.id
+    _(@healthcare.planning_enabled?).must_equal true
   end
 
-  it 'defines an enabler on team' do
+  it "defines an enabler on team" do
     @retail.enable_planning
-    TimePilot.redis.sismember("timepilot:planning:team_ids", @retail.id).must_equal true
+    _(TimePilot.redis.sismember("timepilot:planning:team_ids", @retail.id)).must_equal true
   end
 
-  it 'defines a disabler on team' do
+  it "defines a disabler on team" do
     @retail.enable_planning
-    @retail.planning_enabled?.must_equal true
-    @retail.instance_variable_get("@planning_enabled").must_equal true
+    _(@retail.planning_enabled?).must_equal true
+    _(@retail.instance_variable_get("@planning_enabled")).must_equal true
     @retail.disable_planning
-    @retail.planning_enabled?.must_equal false
-    @retail.instance_variable_get("@planning_enabled").must_equal false
+    _(@retail.planning_enabled?).must_equal false
+    _(@retail.instance_variable_get("@planning_enabled")).must_equal false
   end
 
-  it 'defines a getter on employee' do
-    TimePilot.redis.sadd 'timepilot:planning:employee_ids', @john.id
-    @john.planning_enabled?.must_equal true
-    @john.instance_variable_get("@planning_enabled").must_equal true
+  it "defines a getter on employee" do
+    TimePilot.redis.sadd "timepilot:planning:employee_ids", @john.id
+    _(@john.planning_enabled?).must_equal true
+    _(@john.instance_variable_get("@planning_enabled")).must_equal true
   end
 
-  it 'defines an enabler on employee' do
+  it "defines an enabler on employee" do
     @jane.enable_planning
-    TimePilot.redis.sismember("timepilot:planning:employee_ids", @jane.id).must_equal true
+    _(TimePilot.redis.sismember("timepilot:planning:employee_ids", @jane.id)).must_equal true
   end
 
-  it 'defines a disabler on employee' do
+  it "defines a disabler on employee" do
     @jane.enable_planning
-    @jane.planning_enabled?.must_equal true
-    @jane.instance_variable_get("@planning_enabled").must_equal true
+    _(@jane.planning_enabled?).must_equal true
+    _(@jane.instance_variable_get("@planning_enabled")).must_equal true
     @jane.disable_planning
-    @jane.planning_enabled?.must_equal false
-    @jane.instance_variable_get("@planning_enabled").must_equal false
+    _(@jane.planning_enabled?).must_equal false
+    _(@jane.instance_variable_get("@planning_enabled")).must_equal false
   end
 
-  it 'defines a cardinality count on the classes' do
+  it "defines a cardinality count on the classes" do
     @nedap.enable_planning
     @john.enable_planning
     @jane.enable_planning
-    Company.pilot_feature_cardinality(:planning).must_equal 1
-    Team.pilot_feature_cardinality(:planning).must_equal 0
-    Employee.pilot_feature_cardinality(:planning).must_equal 2
+    _(Company.pilot_feature_cardinality(:planning)).must_equal 1
+    _(Team.pilot_feature_cardinality(:planning)).must_equal 0
+    _(Employee.pilot_feature_cardinality(:planning)).must_equal 2
   end
 
-  it 'registers classes that include TimePilot::Features' do
-    TimePilot.group_classes.must_include Company
-    TimePilot.group_classes.must_include Team
-    TimePilot.group_classes.must_include Employee
+  it "registers classes that include TimePilot::Features" do
+    _(TimePilot.group_classes).must_include Company
+    _(TimePilot.group_classes).must_include Team
+    _(TimePilot.group_classes).must_include Employee
   end
 
-  specify 'company overrides team' do
+  specify "company overrides team" do
     @nedap.enable_planning
-    @retail.planning_enabled?.must_equal true
-    @retail.instance_variable_get("@planning_enabled").must_equal true
+    _(@retail.planning_enabled?).must_equal true
+    _(@retail.instance_variable_get("@planning_enabled")).must_equal true
   end
 
-  specify 'team overrides employee' do
+  specify "team overrides employee" do
     @healthcare.enable_planning
-    @john.planning_enabled?.must_equal true
-    @john.instance_variable_get("@planning_enabled").must_equal true
+    _(@john.planning_enabled?).must_equal true
+    _(@john.instance_variable_get("@planning_enabled")).must_equal true
   end
 
-  specify 'company overrides employee' do
+  specify "company overrides employee" do
     @nedap.enable_planning
-    @jane.planning_enabled?.must_equal true
-    @jane.instance_variable_get("@planning_enabled").must_equal true 
+    _(@jane.planning_enabled?).must_equal true
+    _(@jane.instance_variable_get("@planning_enabled")).must_equal true
   end
 end
 
@@ -154,9 +159,9 @@ class CamelCasedModel
   is_pilot_group
 end
 
-describe TimePilot, 'converting CamelCase to camel_case' do
+describe TimePilot, "converting CamelCase to camel_case" do
   it do
-    CamelCasedModel.time_pilot_groups.must_equal ['camel_cased_model']
+    _(CamelCasedModel.time_pilot_groups).must_equal ["camel_cased_model"]
   end
 end
 
@@ -176,34 +181,33 @@ describe TimePilot do
     end
   end
 
-  specify 'calls redis only once' do
+  specify "calls redis only once" do
     @mock.expect(:pipelined, [true])
 
-    @acme.planning_enabled?.must_equal true
+    _(@acme.planning_enabled?).must_equal true
     # Call the feature a second time
     # If it calls redis you will get
     # MockExpectationError: No more expects available for :pipelined: []
-    @acme.planning_enabled?.must_equal true
+    _(@acme.planning_enabled?).must_equal true
   end
 
-  specify 'does not call redis to get status after disabling' do
-    @mock.expect(:srem, true, ['timepilot:planning:company_ids', @acme.id])
+  specify "does not call redis to get status after disabling" do
+    @mock.expect(:srem, true, ["timepilot:planning:company_ids", @acme.id])
 
     @acme.disable_planning
     # Call the feature again it should hit the instance variable
     # If it calls redis you will get
     # MockExpectationError: No more expects available for :pipelined: []
-    @acme.planning_enabled?.must_equal false
+    _(@acme.planning_enabled?).must_equal false
   end
 
-  specify 'does not call redis to get status after enabling' do
-    @mock.expect(:sadd, true, ['timepilot:planning:company_ids', @acme.id])
+  specify "does not call redis to get status after enabling" do
+    @mock.expect(:sadd, true, ["timepilot:planning:company_ids", @acme.id])
 
     @acme.enable_planning
     # Call the feature again it should hit the instance variable
     # If it calls redis you will get
     # MockExpectationError: No more expects available for :pipelined: []
-    @acme.planning_enabled?.must_equal true
+    _(@acme.planning_enabled?).must_equal true
   end
 end
-

data/web/views/index.html.erb

@@ -1,23 +1,25 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
   <meta charset="utf8">
   <meta name="viewport" content="width=device-width, initial-scale=1">
   <title>Time Pilot Web</title>
 
   <link rel="stylesheet" href="<%= root_path %>stylesheets/pure-min.css">
-  <style type="text/css">
-    h1 {
-      text-align: center;
-    }
-    body {
-      font-family: "HelveticaNeue-Light", "Helvetica Neue Light", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif;
-      font-weight: 300;
-    }
-    .centered {
-      margin-left: auto;
-      margin-right: auto;
-    }
+  <style >
+      h1 {
+          text-align: center;
+      }
+
+      body {
+          font-family: "HelveticaNeue-Light", "Helvetica Neue Light", "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif;
+          font-weight: 300;
+      }
+
+      .centered {
+          margin-left: auto;
+          margin-right: auto;
+      }
   </style>
 </head>
 <body>
@@ -26,20 +28,22 @@
     <h1>Time Pilot Web</h1>
     <table class="pure-table pure-table-horizontal pure-table-striped centered">
       <thead>
-        <tr>
-          <th>Feature</th><th>Group</th><th>Count</th>
-        </tr>
+      <tr>
+        <th>Feature</th>
+        <th>Group</th>
+        <th>Count</th>
+      </tr>
       </thead>
       <tbody>
-<% @total_count.each do |feature, groups| %>
-  <% groups.each do |group, count| %>
-        <tr>
-          <td><%= feature %></td>
-          <td><%= group %></td>
-          <td><%= count %></td>
-        </tr>
-  <% end %>
-<% end %>
+      <% @total_count.each do |feature, groups| %>
+        <% groups.each do |group, count| %>
+          <tr>
+            <td><%= feature %></td>
+            <td><%= group %></td>
+            <td><%= count %></td>
+          </tr>
+        <% end %>
+      <% end %>
       </tbody>
     </table>
   </div>

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: time_pilot
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - "@mlangenberg"
 - "@markoudev"
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-09-19 00:00:00.000000000 Z
+date: 2022-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -61,13 +61,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".tool-versions"
 - AUTHORS
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
+- docker-compose.yml
 - lib/time_pilot.rb
 - lib/time_pilot/configuration.rb
 - lib/time_pilot/time_pilot.rb
@@ -84,7 +86,7 @@ homepage: https://github.com/nedap/time_pilot
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -99,9 +101,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.2.26
+signing_key:
 specification_version: 4
 summary: Configure enabled features for a specific set of users.
 test_files: []

data/.travis.yml

@@ -1,7 +0,0 @@
-language: ruby
-rvm:
-  - 2.0
-  - 2.1
-  - 2.2
-services:
-  - redis-server