time_pilot 0.1.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3b6d20c82889dfce170d8168c8db232fcd61c703
-  data.tar.gz: 86af86c17563c51b7ef3f2be04610363f592de69
+SHA256:
+  metadata.gz: 1035c965584954a3de7fbee71027d0d081c2c8a99521f1590fd9f6ad00f84438
+  data.tar.gz: 01bc1de61e0911ca0e60f464d2869028a9b22556ea0f6c5ec71163d5d3b4b979
 SHA512:
-  metadata.gz: 99701db558c49b80d094c5f305061bd7813f7c46005fae1be51ac7febd9ada7044854e2e446f36e572f1bfea68e323a3f17a69fb03be266c48e08580b2796d79
-  data.tar.gz: 02b59644df562992cbe371516fc07ab8241c28291ee30caf8e993893c7de7ad8e74a8e11ce131e064fc9acb541a40af881087fb016b53e7bd9ce53d700c9c2fa
+  metadata.gz: 5d477c3f65330966a93de7ba0088b24771f38d6cbc9a280a1dfa6382d30ce01fe025df2f31d9aa734a366587e545f2bc2e7e7d85aeb9220c77513603ab9ecc36
+  data.tar.gz: 2f790748fcdcd320ee06fdfafacef5facd3400dce9a807f1f6998647622b3155519b865e8f9a6f139491d3b9a291f1947b49c866568774362fa9b990d3416dec

data/lib/time_pilot/time_pilot.rb

@@ -16,21 +16,23 @@ module TimePilot
   def self.configure
     @config ||= Configuration.new
     yield @config
-    @config.features.each { |f| define_feature_method(f) }
+    @config.features.each { |f| define_feature_methods(f) }
   end
 
-  def self.define_feature_method(feature_name)
+  def self.define_feature_methods(feature_name)
     Features.module_eval do
-      define_method "enable_#{feature_name}" do
-        pilot_enable_feature(feature_name)
-      end
+      unless method_defined?("enable_#{feature_name}")
+        define_method "enable_#{feature_name}" do
+          pilot_enable_feature(feature_name)
+        end
 
-      define_method "disable_#{feature_name}" do
-        pilot_disable_feature(feature_name)
-      end
+        define_method "disable_#{feature_name}" do
+          pilot_disable_feature(feature_name)
+        end
 
-      define_method "#{feature_name}_enabled?" do
-        pilot_feature_enabled?(feature_name)
+        define_method "#{feature_name}_enabled?" do
+          pilot_feature_enabled?(feature_name)
+        end
       end
     end
   end
@@ -70,22 +72,36 @@ module TimePilot
     def pilot_enable_feature(feature_name)
       key_name = "#{feature_name}:#{self.class.to_s.underscore}_ids"
       TimePilot.redis.sadd TimePilot.key(key_name), id
+      instance_variable_set("@#{feature_name}_enabled", true)
     end
 
     def pilot_disable_feature(feature_name)
       key_name = "#{feature_name}:#{self.class.to_s.underscore}_ids"
       TimePilot.redis.srem TimePilot.key(key_name), id
+      instance_variable_set("@#{feature_name}_enabled", false)
     end
 
     def pilot_feature_enabled?(feature_name)
+      unless instance_variable_defined?("@#{feature_name}_enabled")
+        instance_variable_set("@#{feature_name}_enabled",
+                              pilot_member_in_any_group?(feature_name))
+      end
+      instance_variable_get("@#{feature_name}_enabled")
+    end
+
+    def pilot_member_in_any_group?(feature_name)
       TimePilot.redis.pipelined do
         self.class.time_pilot_groups.each do |group|
-          method = group.to_s == self.class.to_s.underscore ? 'id' : group + '_id'
-          TimePilot.redis.sismember TimePilot.key("#{feature_name}:#{group}_ids"), send(method)
+          TimePilot.redis.sismember(
+            TimePilot.key("#{feature_name}:#{group}_ids"),
+            send(pilot_method_for_group(group))
+          )
         end
       end.include? true
     end
 
+    def pilot_method_for_group(group_name)
+      group_name.to_s == self.class.to_s.underscore ? 'id' : group_name + '_id'
+    end
   end
-
 end

data/lib/time_pilot/version.rb

@@ -1,3 +1,3 @@
 module TimePilot
-  VERSION = '0.1.1'
+  VERSION = '1.0.0'.freeze
 end

data/test/time_pilot_test.rb

@@ -59,6 +59,7 @@ describe TimePilot do
   it 'defines a getter on company' do
     TimePilot.redis.sadd 'timepilot:planning:company_ids', @acme.id
     @acme.planning_enabled?.must_equal true
+    @acme.instance_variable_get("@planning_enabled").must_equal true
   end
 
   it 'defines an enabler on company' do
@@ -69,8 +70,10 @@ describe TimePilot do
   it 'defines a disabler on employee' do
     @nedap.enable_planning
     @nedap.planning_enabled?.must_equal true
+    @nedap.instance_variable_get("@planning_enabled").must_equal true
     @nedap.disable_planning
     @nedap.planning_enabled?.must_equal false
+    @nedap.instance_variable_get("@planning_enabled").must_equal false
   end
 
   it 'defines a getter on team' do
@@ -86,13 +89,16 @@ describe TimePilot do
   it 'defines a disabler on team' do
     @retail.enable_planning
     @retail.planning_enabled?.must_equal true
+    @retail.instance_variable_get("@planning_enabled").must_equal true
     @retail.disable_planning
     @retail.planning_enabled?.must_equal false
+    @retail.instance_variable_get("@planning_enabled").must_equal false
   end
 
   it 'defines a getter on employee' do
     TimePilot.redis.sadd 'timepilot:planning:employee_ids', @john.id
     @john.planning_enabled?.must_equal true
+    @john.instance_variable_get("@planning_enabled").must_equal true
   end
 
   it 'defines an enabler on employee' do
@@ -103,8 +109,10 @@ describe TimePilot do
   it 'defines a disabler on employee' do
     @jane.enable_planning
     @jane.planning_enabled?.must_equal true
+    @jane.instance_variable_get("@planning_enabled").must_equal true
     @jane.disable_planning
     @jane.planning_enabled?.must_equal false
+    @jane.instance_variable_get("@planning_enabled").must_equal false
   end
 
   it 'defines a cardinality count on the classes' do
@@ -125,16 +133,19 @@ describe TimePilot do
   specify 'company overrides team' do
     @nedap.enable_planning
     @retail.planning_enabled?.must_equal true
+    @retail.instance_variable_get("@planning_enabled").must_equal true
   end
 
   specify 'team overrides employee' do
     @healthcare.enable_planning
     @john.planning_enabled?.must_equal true
+    @john.instance_variable_get("@planning_enabled").must_equal true
   end
 
   specify 'company overrides employee' do
     @nedap.enable_planning
     @jane.planning_enabled?.must_equal true
+    @jane.instance_variable_get("@planning_enabled").must_equal true 
   end
 end
 
@@ -148,3 +159,51 @@ describe TimePilot, 'converting CamelCase to camel_case' do
     CamelCasedModel.time_pilot_groups.must_equal ['camel_cased_model']
   end
 end
+
+describe TimePilot do
+  before do
+    @acme = Company.new(1)
+
+    @mock = MiniTest::Mock.new
+    TimePilot.configure do |config|
+      config.redis(@mock)
+    end
+  end
+
+  after do
+    TimePilot.configure do |config|
+      config.redis(Redis.new)
+    end
+  end
+
+  specify 'calls redis only once' do
+    @mock.expect(:pipelined, [true])
+
+    @acme.planning_enabled?.must_equal true
+    # Call the feature a second time
+    # If it calls redis you will get
+    # MockExpectationError: No more expects available for :pipelined: []
+    @acme.planning_enabled?.must_equal true
+  end
+
+  specify 'does not call redis to get status after disabling' do
+    @mock.expect(:srem, true, ['timepilot:planning:company_ids', @acme.id])
+
+    @acme.disable_planning
+    # Call the feature again it should hit the instance variable
+    # If it calls redis you will get
+    # MockExpectationError: No more expects available for :pipelined: []
+    @acme.planning_enabled?.must_equal false
+  end
+
+  specify 'does not call redis to get status after enabling' do
+    @mock.expect(:sadd, true, ['timepilot:planning:company_ids', @acme.id])
+
+    @acme.enable_planning
+    # Call the feature again it should hit the instance variable
+    # If it calls redis you will get
+    # MockExpectationError: No more expects available for :pipelined: []
+    @acme.planning_enabled?.must_equal true
+  end
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: time_pilot
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 1.0.0
 platform: ruby
 authors:
 - "@mlangenberg"
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-27 00:00:00.000000000 Z
+date: 2018-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -100,7 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Configure enabled features for a specific set of users.