time_of_day_attr 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 918454e7a1335742ab83a0756f6a736976f997a1
-  data.tar.gz: 5c8561a4f1d40431c167c1b75eed948bf56e1043
+  metadata.gz: ab0ac090f636ee04c329736bd7f775f40fd65ba4
+  data.tar.gz: d7feee73d836a73b72f857b474b0489bea6a9e5c
 SHA512:
-  metadata.gz: e27f14a0adf5295b5d0681963d932e40ae79f1999e4055e8ae497bd63be7809c084d37e3489b51a0319774136105ce4ba05206829502a2b7d0fa11ff1aaea871
-  data.tar.gz: 967e0f9f3f3e5ef2f459112fdb3652dbea0eed12e96d506b381fc08a5b9d3e70e86b0d01cf271bfd3518cead2e8beebf3c792fb1a2a08cb4903b9a9d44630969
+  metadata.gz: 1110a3aec230b82a7483d0cc31d410e61a7f9c294a44f22b7d34bf1463fd5ae36e9ca78932672ca0dd623f72b49359efb5aaadeed1eec64c4a8775edc8d47079
+  data.tar.gz: 9867243a77fbc695403ddee5b8c8e55d49ea14df4ae5bb9967fd327e2860ad3201ba64c4840c4861f82ec6f3db19e3e5e6ca68d1790310c231f4c94fae0a1e1d

data/lib/time_of_day_attr/active_record_ext.rb

@@ -18,9 +18,10 @@ module TimeOfDayAttr
                 end
               end
               delocalized_value = delocalized_values.compact.first
-              raise(ArgumentError, "invalid time of day #{value} for formats #{options[:formats].join(', ')}") unless delocalized_value
+              super(delocalized_value)
+            else
+              super(value)
             end
-            super(delocalized_value || value)
           end
         end
       end

data/lib/time_of_day_attr/version.rb

@@ -1,3 +1,3 @@
 module TimeOfDayAttr
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 end

data/test/time_of_day_attr_test.rb

@@ -40,19 +40,14 @@ class TimeOfDayAttrTest < ActiveSupport::TestCase
     assert_equal 61200, business_hour.closing
   end
 
-  test 'time of day attr setter should raise invalid formats' do
-    assert_raise ArgumentError do
-      business_hour = BusinessHour.new(opening: 'Nine', closing: 'Five')
-    end
-    business_hour = BusinessHour.new
+  test 'time of day attr setter should ignore invalid formats' do
+    business_hour = BusinessHour.new(opening: 'Nine', closing: 'Five')
     assert_nil business_hour.opening
     assert_nil business_hour.closing
     business_hour.opening = '9'
     assert_equal 32400, business_hour.opening
-    assert_raise ArgumentError do
-      business_hour.opening = 'Nine'
-    end
-    assert_equal 32400, business_hour.opening
+    business_hour.opening = 'Nine'
+    assert_nil business_hour.opening
     business_hour.opening = '9:30'
     assert_equal 34200, business_hour.opening
     business_hour.opening = 55800

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: time_of_day_attr
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Clemens Teichmann