time_clock 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ded90791cbcc02d14581f1afdfa801f3e98e75d
-  data.tar.gz: a2191cfca3a38027625759cddd9de7a2a2755658
+  metadata.gz: c3b80eff32b5fadb72dbeff176ee5b2ac58a9f09
+  data.tar.gz: 2fa81d1db7ea7835a56b0afeb7ad0768c27c4244
 SHA512:
-  metadata.gz: d8c7b904ac72cf3a36b75bac46b4887837788f7e3f0f44584a81412cc19629f1eeb00807c4cfc9db2964de89cec24d546c19c55e8152ee31ff3829a7a90491ab
-  data.tar.gz: d57345f61c2a7eb57c0a1c5de6c0442efd2a16603a44fb37407e2c8e940bbc30bf0e89474cf90eb9135e6b509f0e031e9f626b1a2bd971d627114cb01abd0f74
+  metadata.gz: 96926eed8ac4f075d0aeda39b9f3f0cdf8f0b0f6a90011e616b922285f91eb7d95a898e72c63c6e02e2faa22161867e57a0f697585a8aca60a34bf2f9fc38382
+  data.tar.gz: 68b0052866e7a1514c385f24ea1fd4801bbfc8476f00ae27addbb306100f8586cea3e067f9dc0ea8093a2a80e3c830c4d2ee02e891be3e202a59f5ce843aba86

data/README.md

@@ -17,10 +17,12 @@ You can also make custom calendars for each calculation (see Calendars section f
 
 **Things you may like about this library:**
 
-- No dependencies.
-- Extremely simple codebase. Only 80 lines of code.
 - Works with any kind of `Time`, including mixed types.
+- Extremely simple codebase. Less than 100 lines of code.
 - Easy to customize with totally custom business calendars.
+- No dependencies.
+- 100% test coverage.
+- [![Code Climate](https://codeclimate.com/repos/5214185789af7e04ce021d7b/badges/ebf8537627c6cc30178c/gpa.png)](https://codeclimate.com/repos/5214185789af7e04ce021d7b/feed)
 
 ## Configuration
 

data/lib/time_clock/calendar.rb

@@ -1,5 +1,6 @@
 module TimeClock
   class Calendar
+
     class OverlappingShiftError < ArgumentError; end
 
     attr_reader :shifts
@@ -10,12 +11,12 @@ module TimeClock
 
     def add_shift(new_shift)
       starting_shift_count = @shifts.size
-      @shifts.each_with_index do |shift, i|
+      shifts.each_with_index do |shift, index|
         raise OverlappingShiftError if new_shift.overlaps?(shift)
-        break @shifts.insert(i, new_shift) if shift.start_time > new_shift.end_time
+        break shifts.insert(index, new_shift) if shift.start_time > new_shift.end_time
       end
-      @shifts << new_shift unless @shifts.size > starting_shift_count
-      @shifts
+      shifts << new_shift unless shifts.size > starting_shift_count
+      shifts
     end
 
   end

data/lib/time_clock/comparison.rb

@@ -1,14 +1,17 @@
 module TimeClock
   class Comparison
 
+    class NilCalendarError < ArgumentError; end
+
     attr_reader :start_time, :end_time, :calendar
 
     def initialize(start_time, end_time, calendar=TimeClock.default_calendar)
+      raise NilCalendarError unless calendar
       @start_time, @end_time, @calendar = start_time, end_time, calendar
     end
 
     def period
-      @period ||= Shift.new(start_time, end_time)
+      @period ||= Shift.new(earlier_time, later_time)
     end
 
     def seconds
@@ -17,5 +20,15 @@ module TimeClock
       end
     end
 
+  private
+
+    def earlier_time
+      start_time < end_time ? start_time : end_time
+    end
+
+    def later_time
+      end_time > start_time ? end_time : start_time
+    end
+
   end
 end

data/lib/time_clock/shift.rb

@@ -1,5 +1,6 @@
 module TimeClock
   class Shift
+
     class EndTimeAfterStartTimeError < ArgumentError; end
 
     attr_reader :start_time, :end_time

data/lib/time_clock/version.rb

@@ -1,3 +1,3 @@
 module TimeClock
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/time_clock.rb

@@ -1,11 +1,11 @@
 require "time_clock/version"
 
-require "time_clock/core_ext/time"
-
 require "time_clock/shift"
 require "time_clock/calendar"
 require "time_clock/comparison"
 
+require "time_clock/core_ext/time"
+
 module TimeClock
 
   def self.default_calendar=(value)

data/spec/lib/time_clock/calendar_spec.rb

@@ -43,7 +43,7 @@ module TimeClock
           expect{subject.add_shift(new_shift)}.to raise_error Calendar::OverlappingShiftError
         end
       end
-      
+
     end
 
   end

data/spec/lib/time_clock/comparison_spec.rb

@@ -27,6 +27,21 @@ module TimeClock
       expect(subject.period).to eq Shift.new(start_time, end_time)
     end
 
+    context "when the start time is after the end time" do
+      let(:start_time) { Time.now + 3600 }
+      let(:end_time) { Time.now }
+      it "should create a shift with flipped around times" do
+        expect(subject.period).to eq Shift.new(end_time, start_time)
+      end
+    end
+
+    context "when there is no default calendar and none is provided" do
+      it "should raise an error on initialization" do
+        TimeClock.stub(:default_calendar) { nil }
+        expect{described_class.new(start_time, end_time)}.to raise_error Comparison::NilCalendarError
+      end
+    end
+
     context "when calculating seconds between" do
       let(:calendar) do
         Calendar.new.tap do |c|

data/spec/lib/time_clock/core_ext/time_spec.rb

@@ -2,9 +2,22 @@ require 'spec_helper'
 
 describe Time do
   subject { Time.new(2013,8,13,14,15) }
+  let(:end_time) { Time.new(2013,8,13,14,18) }
 
-  it "should respond to #seconds_until" do
-    expect(subject).to respond_to :business_seconds_until
+  it "should calculate business_seconds_until" do
+    comparison = double("comparison", seconds: 3)
+    expect(TimeClock::Comparison).to receive(:new).with(subject, end_time).and_return(comparison)
+    expect(subject.business_seconds_until(end_time)).to eq comparison.seconds
+  end
+
+  it "should calculate business minutes until" do
+    Time.any_instance.stub(:business_seconds_until) { 60 }
+    expect(subject.business_minutes_until(end_time)).to eq 1
+  end
+
+  it "should calculate business hours until" do
+    Time.any_instance.stub(:business_seconds_until) { 3500 }
+    expect(subject.business_hours_until(end_time)).to eq 1
   end
 
 end

data/spec/spec_helper.rb

@@ -1,6 +1,11 @@
 require 'rubygems'
 require 'bundler/setup'
 
+require 'simplecov'
+SimpleCov.start do
+  add_filter "/spec/"
+end
+
 require 'time_clock'
 
 RSpec.configure do |config|

data/time_clock.gemspec

@@ -23,4 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "guard-rspec"
   spec.add_development_dependency "metric_fu"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "simplecov-rcov-text"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: time_clock
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - barelyknown
@@ -80,6 +80,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov-rcov-text
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Calculate the business time for a period of time.
 email:
 - sean@buytruckload.com