time_bandits 0.0.9 → 0.1.0

data/.gitignore

@@ -3,3 +3,5 @@ Gemfile.lock
 pkg/*
 *.gem
 .bundle
+.DS_Store
+.rvmrc

data/lib/time_bandits.rb

@@ -18,6 +18,7 @@ module TimeBandits
 
   mattr_accessor :time_bandits
   self.time_bandits = []
+
   def self.add(bandit)
     self.time_bandits << bandit unless self.time_bandits.include?(bandit)
   end
@@ -34,6 +35,12 @@ module TimeBandits
     time_bandits.map{|b| b.runtime}.join(", ")
   end
 
+  def self.metrics
+    metrics = {}
+    time_bandits.each{|b| metrics.merge! b.metrics}
+    metrics
+  end
+
   def self.benchmark(title="Completed in", logger=Rails.logger)
     reset
     result = nil
@@ -42,7 +49,7 @@ module TimeBandits
       begin
         result = yield
       rescue Exception => e
-        logger.error "Exception: #{e}"
+        logger.error "Exception: #{e}:\n#{e.backtrace[0..5].join("\n")}"
       end
     end
     consumed # needs to be called for DB time consumer

data/lib/time_bandits/monkey_patches/action_controller_rails2.rb

@@ -3,7 +3,6 @@
 #
 # the original rails stack looks like this:
 #
-# ApplicationController#process_with_unload_user
 # ActionController::SessionManagement#process_with_session_management_support
 # ActionController::Filters#process_with_filters
 # ActionController::Base#process
@@ -17,7 +16,6 @@
 #
 # with the plugin installed, the stack looks like this:
 #
-# ApplicationController#process_with_unload_user
 # ActionController::SessionManagement#process_with_session_management_support
 # ActionController::Filters#process_with_filters
 # ActionController::Base#process
@@ -31,6 +29,23 @@
 # =========================================================================================================
 
 module ActionController #:nodoc:
+
+  class Base
+    # this ugly hack is used to get the started_at and ip information into time bandits metrics
+    def request_origin
+      # this *needs* to be cached!
+      # otherwise you'd get different results if calling it more than once
+      @request_origin ||=
+        begin
+          remote_ip = request.remote_ip
+          t = Time.now
+          started_at = "#{t.to_s(:db)}.#{t.usec}"
+          request.env["time_bandits.metrics"] = {:ip => remote_ip, :started_at => started_at}
+          "#{remote_ip} at #{started_at}"
+        end
+    end
+  end
+
   module TimeBanditry #:nodoc:
     def self.included(base)
       base.class_eval do
@@ -88,6 +103,7 @@ module ActionController #:nodoc:
 
         logger.info(log_message)
         response.headers["X-Runtime"] = "#{sprintf("%.0f", seconds * 1000)}ms"
+        merge_metrics(seconds)
       else
         perform_action_without_time_bandits
       end
@@ -114,6 +130,7 @@ module ActionController #:nodoc:
 
         logger.info(log_message)
         response.headers["X-Runtime"] = "#{sprintf("%.0f", seconds * 1000)}ms"
+        merge_metrics(seconds)
       else
         rescue_action_without_time_bandits(exception)
       end
@@ -121,6 +138,16 @@ module ActionController #:nodoc:
 
     private
 
+    def merge_metrics(total_time_seconds)
+      basic_request_metrics = {
+        :total_time => total_time_seconds * 1000,
+        :view_time => (@view_runtime||0) * 1000,
+        :code => response.status.to_i,
+        :action => "#{self.class.name}\##{action_name}",
+      }
+      request.env["time_bandits.metrics"].merge!(TimeBandits.metrics).merge!(basic_request_metrics)
+    end
+
     def view_runtime
       "View: %.3f" % ((@view_runtime||0) * 1000)
     end

data/lib/time_bandits/monkey_patches/memcache-client.rb

@@ -24,6 +24,14 @@ class MemCache
     sprintf "MC: %.3f(%dr,%dm)", @@cache_latency * 1000, @@cache_touches, @@cache_misses
   end
 
+  def self.metrics
+    {
+      :memcache_time => @@cache_latency * 1000,
+      :memcache_calls => @@cache_touches,
+      :memcache_misses => @@cache_misses
+    }
+  end
+
   def get_with_benchmark(key, raw = false)
     val = nil
     @@cache_latency += Benchmark.realtime{ val=get_without_benchmark(key, raw) }

data/lib/time_bandits/monkey_patches/memcached.rb

@@ -6,27 +6,38 @@ require 'memcached'
 raise "Memcached needs to be loaded before monkey patching it" unless defined?(Memcached)
 
 class Memcached
-  @@cache_latency = 0.0
-  @@cache_touches = 0
-  @@cache_misses = 0
 
   def self.reset_benchmarks
     @@cache_latency = 0.0
-    @@cache_touches = 0
+    @@cache_calls = 0
     @@cache_misses = 0
+    @@cache_reads = 0
+    @@cache_writes = 0
   end
+  self.reset_benchmarks
 
   def self.get_benchmarks
-    [@@cache_latency, @@cache_touches, @@cache_misses]
+    [@@cache_latency, @@cache_calls, @@cache_reads, @@cache_misses, @@cache_writes]
   end
 
   def self.cache_runtime
-    sprintf "MC: %.3f(%dr,%dm)", @@cache_latency * 1000, @@cache_touches, @@cache_misses
+    sprintf "MC: %.3f(%dr,%dm,%dw,%dc)", @@cache_latency * 1000, @@cache_reads, @@cache_misses, @@cache_writes, @@cache_calls
+  end
+
+  def self.metrics
+    {
+      :memcache_time   => @@cache_latency * 1000,
+      :memcache_calls  => @@cache_calls,
+      :memcache_misses => @@cache_misses,
+      :memcache_reads  => @@cache_reads,
+      :memcache_writes => @@cache_writes
+    }
   end
 
   def get_with_benchmark(key, marshal = true)
-    @@cache_touches += 1
+    @@cache_calls += 1
     if key.is_a?(Array)
+      @@cache_reads += (num_keys = key.size)
       results = []
       @@cache_latency += Benchmark.realtime do
         begin
@@ -34,10 +45,11 @@ class Memcached
         rescue Memcached::NotFound
         end
       end
-      @@cache_misses += key.size - results.size
+      @@cache_misses += num_keys - results.size
       results
     else
       val = nil
+      @@cache_reads += 1
       @@cache_latency += Benchmark.realtime do
         begin
           val = get_without_benchmark(key, marshal)
@@ -51,5 +63,22 @@ class Memcached
   alias_method :get_without_benchmark, :get
   alias_method :get, :get_with_benchmark
 
+  def set_with_benchmark(*args)
+    @@cache_calls += 1
+    @@cache_writes += 1
+    result = nil
+    exception = nil
+    @@cache_latency += Benchmark.realtime do
+      begin
+        set_without_benchmark(*args)
+      rescue Exception => exception
+      end
+    end
+    raise exception if exception
+    result
+  end
+  alias_method :set_without_benchmark, :set
+  alias_method :set, :set_with_benchmark
+
 end
 

data/lib/time_bandits/time_consumers/database.rb

@@ -36,6 +36,14 @@ module TimeBandits
         sprintf "ActiveRecord: %.3fms(%dq,%dh)", *info
       end
 
+      def metrics
+        {
+          :db_calls => @call_count,
+          :db_sql_query_cache_hits  => @query_cache_hits,
+          :db_time => @consumed * 1000
+        }
+      end
+
       private
 
       def reset_stats

data/lib/time_bandits/time_consumers/database_rails2.rb

@@ -36,6 +36,14 @@ module TimeBandits
         sprintf "DB: %.3f(%d,%d)", @consumed * 1000, @call_count, @query_cache_hits
       end
 
+      def metrics
+        {
+          :db_calls => @call_count,
+          :db_sql_query_cache_hits  => @query_cache_hits,
+          :db_time => @consumed * 1000
+        }
+      end
+
       private
       def all_connections
         ActiveRecord::Base.connection_handler.connection_pools.values.map{|pool| pool.connections}.flatten

data/lib/time_bandits/time_consumers/garbage_collection.rb

@@ -87,12 +87,31 @@ module TimeBandits
           GCFORMAT % [consumed_gc_time * 1000, collections, heap_growth, heap_slots, allocated_objects, allocated_size, live_data_set_size]
         end
 
+        def metrics
+          {
+            :gc_time => consumed_gc_time * 1000,
+            :gc_calls => collections,
+            :heap_growth => heap_growth,
+            :heap_size => GC.heap_slots,
+            :allocated_objects => allocated_objects,
+            :allocated_bytes => allocated_size,
+            :live_data_set_size => live_data_set_size
+          }
+        end
+
       else
 
         def runtime
           "GC: %.3f(%d)" % [consumed_gc_time * 1000, collections]
         end
 
+        def metrics
+          {
+            :gc_time => consumed_gc_time * 1000,
+            :gc_calls => collections
+          }
+        end
+
       end
     end
   end

data/lib/time_bandits/time_consumers/mem_cache.rb

@@ -19,6 +19,10 @@ module TimeBandits
         def runtime
           ::MemCache.cache_runtime
         end
+
+        def metrics
+          ::MemCache.metrics
+        end
       end
     end
   end

data/lib/time_bandits/time_consumers/memcached.rb

@@ -19,6 +19,10 @@ module TimeBandits
         def runtime
           ::Memcached.cache_runtime
         end
+
+        def metrics
+          ::Memcached.metrics
+        end
       end
     end
   end

data/lib/time_bandits/version.rb

@@ -1,3 +1,3 @@
 module TimeBandits
-  VERSION = "0.0.9"
+  VERSION = "0.1.0"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: time_bandits
 version: !ruby/object:Gem::Version 
-  hash: 13
-  prerelease: false
+  hash: 27
+  prerelease: 
   segments: 
   - 0
+  - 1
   - 0
-  - 9
-  version: 0.0.9
+  version: 0.1.0
 platform: ruby
 authors: 
 - Stefan Kaes
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-18 00:00:00 +02:00
+date: 2011-08-28 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -99,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Custom performance logging for Rails