timber 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67a6b728488478b5dac3b7525be7fca8d29915b6
-  data.tar.gz: ec34cec6ee781e3e88a7ed48749fc549785d4dc7
+  metadata.gz: a6efcc9b1ff96b7bfea713d3e87e36b7bfc061fd
+  data.tar.gz: 6ef8b32449171a85062421fc42da7c4417b7fdf8
 SHA512:
-  metadata.gz: 33e67d6373e18bb258b2a23093a86811d9fd9a32eb81489e12283ab1b40246eb17b7dab3129ad21525f0f7b0137c104ef598adcce514516b87613fe60cfe4efd
-  data.tar.gz: dec3368bd0670bb855d0a6bf880d8ba3c3196fb5ebeb0af79e6f0a6951522420797693d232fbabc9e801e5d255a440027c8694a3a7d5b64af8eff16257ca332b
+  metadata.gz: 79c590f521790d5f24349bdfb2cd9058cd78b18955bfa61164338d75b70cb7e58a24594a31f93780af6a1f27bbafd124c5a3249d3dac9d331debfb3181792e63
+  data.tar.gz: 6e284e8801b5e9643fe36e65200f1425c2da8ab078a6bb60f29339323da86ef371f7ca8a32634f8f7d22932672422e35bc4883e59f814ae06d131503a08ec076

data/lib/timber/events/exception.rb

@@ -41,9 +41,20 @@ module Timber
         def parse_backtrace_line(line)
           # using split for performance reasons
           file, line, function_part = line.split(":", 3)
-          _prefix, function_pre = function_part.split("`", 2)
-          function = Util::Object.try(function_pre, :chomp, "'")
-          {file: file, line: line.to_i, function: function}
+
+          parsed_line = {file: file}
+
+          if line
+            parsed_line[:line] = line.to_i
+          end
+
+          if function_part
+            _prefix, function_pre = function_part.split("`", 2)
+            function = Util::Object.try(function_pre, :chomp, "'")
+            parsed_line[:function] = function
+          end
+
+          parsed_line
         end
     end
   end

data/lib/timber/version.rb

@@ -1,3 +1,3 @@
 module Timber
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/timber/events/exception_spec.rb

@@ -11,5 +11,24 @@ describe Timber::Events::Exception, :rails_23 => true do
       exception_event = described_class.new(name: "RuntimeError", exception_message: "Boom", backtrace: backtrace)
       expect(exception_event.backtrace).to eq([{:file=>"/path/to/file1.rb", :line=>26, :function=>"function1"}, {:file=>"path/to/file2.rb", :line=>86, :function=>"function2"}])
     end
+
+    it "parses valid lines" do
+      backtrace = [
+        "/path/to/file1.rb:26:in `function1'",
+        "path/to/file2.rb:86" # function names are optional
+      ]
+
+      exception_event = described_class.new(name: "RuntimeError", exception_message: "Boom", backtrace: backtrace)
+      expect(exception_event.backtrace).to eq([{:file=>"/path/to/file1.rb", :line=>26, :function=>"function1"}, {:file=>"path/to/file2.rb", :line=>86}])
+    end
+
+    it "handles malformed lines" do
+      backtrace = [
+        "malformed"
+      ]
+
+      exception_event = described_class.new(name: "RuntimeError", exception_message: "Boom", backtrace: backtrace)
+      expect(exception_event.backtrace).to eq([{:file=>"malformed"}])
+   end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: timber
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Timber Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-23 00:00:00.000000000 Z
+date: 2017-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: msgpack