tim 0.1.2 → 0.2.0

data/spec/factories/tim/image_version.rb

@@ -16,5 +16,9 @@ module Tim
         FactoryGirl.create_list(:target_image, 2, :image_version => image_version)
       end
     end
+
+    factory :image_version_import, :parent => :image_version do
+      association :base_image, :factory => :base_image_import
+    end
   end
 end

data/spec/factories/tim/provider_image.rb

@@ -1,9 +1,12 @@
 FactoryGirl.define do
   factory :provider_image, :class => Tim::ProviderImage do
-    association :target_image, :factory => :target_image
   end
 
   factory :provider_image_with_full_tree, :parent => :provider_image do
     association :target_image, :factory => :target_image_with_full_tree
   end
+
+  factory :provider_image_import, :parent => :provider_image do
+    association :target_image, :factory => :target_image_import
+  end
 end

data/spec/factories/tim/target_image.rb

@@ -1,10 +1,14 @@
 FactoryGirl.define do
   factory :target_image, :class => Tim::TargetImage do
-    association :image_version, :factory => :image_version
     target 'Mock'
+    build_method 'BARE_METAL'
   end
 
   factory :target_image_with_full_tree, :parent => :target_image do
     association :image_version, :factory => :image_version_with_full_tree
   end
-end
+
+  factory :target_image_import, :parent => :target_image do
+    association :image_version, :factory => :image_version_import
+  end
+end

data/spec/filters/resource_link_filter_spec.rb

@@ -0,0 +1,158 @@
+require 'spec_helper'
+
+module Tim
+  describe ResourceLinkFilter do
+
+    describe "#transform_resource_links" do
+
+      before do
+        @controller = stub({
+          :request => stub({
+            :format => :xml
+          })
+        })
+        @controller.stub(:params).and_return(params)
+      end
+
+      context "successful transformation" do
+
+        before do
+          ResourceLinkFilter.new(resource_links).before(@controller)
+        end
+
+        context "for a simple link" do
+          let(:params) do {
+              :catalog => {
+                :id => 123
+              }
+            }
+          end
+          let(:resource_links) { :catalog }
+
+          it "transforms the link" do
+            params[:catalog].should == nil
+            params[:catalog_id].should == 123
+          end
+        end
+
+        context "for a nested link" do
+          let(:params) do
+            {
+              :catalog => {
+                :pool => {
+                  :id => 123
+                }
+              }
+            }
+          end
+          let(:resource_links) { { :catalog => :pool } }
+
+          it "transforms the link" do
+            params[:catalog][:pool].should == nil
+            params[:catalog][:pool_id].should == 123
+          end
+        end
+
+        context "for multiple nested links" do
+          let(:params) do
+            {
+              :catalog => {
+                :pool => {
+                  :id => 123
+                },
+                :something => {
+                  :id => 456
+                }
+              }
+            }
+          end
+          let(:resource_links) { { :catalog => [:pool, :something] } }
+
+          it "transforms the links" do
+            params[:catalog][:pool].should == nil
+            params[:catalog][:pool_id].should == 123
+            params[:catalog][:something].should == nil
+            params[:catalog][:something_id].should == 456
+          end
+        end
+
+        context "for combined single- and double-nested links" do
+          let(:params) do
+            {
+              :catalog => {
+                :pool => {
+                  :id => 123
+                },
+                :something => {
+                  :double_nested_1 => {
+                    :id => 456
+                  },
+                  :double_nested_2 => {
+                    :id => 789
+                  }
+                }
+              }
+            }
+          end
+          let(:resource_links) do
+            {
+              :catalog => [
+                :pool,
+                { :something => [:double_nested_1, :double_nested_2] }
+              ]
+            }
+          end
+
+          it "transforms the links" do
+            params[:catalog][:pool].should == nil
+            params[:catalog][:pool_id].should == 123
+            params[:catalog][:something][:double_nested_1].should == nil
+            params[:catalog][:something][:double_nested_1_id].should == 456
+            params[:catalog][:something][:double_nested_2].should == nil
+            params[:catalog][:something][:double_nested_2_id].should == 789
+          end
+        end
+
+      end
+  
+      context "when missing 'id' attribute in the link" do
+        let(:params) do
+          {
+            :catalog => {}
+          }
+        end
+        let(:resource_links) { :catalog }
+
+        it "does not transform anything" do
+          params[:catalog].should == {}
+          params[:catalog_id].should == nil
+        end
+      end
+
+      context "when missing the whole link" do
+        let(:params) { {} }
+        let(:resource_links) { :catalog }
+
+        it "does not transform anything" do
+          params[:catalog].should == nil
+          params[:catalog_id].should == nil
+        end
+      end
+
+      context "when not XML request" do
+        let(:params) { {} }
+
+        before do
+          @controller.stub_chain(:request, :format).and_return(:html)
+        end
+
+        it "does not touch params" do
+          @controller.should_not_receive(:params)
+          ResourceLinkFilter.new(:something).before(@controller)
+        end
+      end
+
+    end
+
+  end
+end

data/spec/models/base_image_spec.rb

@@ -4,16 +4,16 @@ module Tim
   describe BaseImage do
     describe "Model relationships" do
       it 'should have many image versions' do
-        base_image = BaseImage.new
+        base_image = FactoryGirl.build(:base_image_with_template)
         2.times do
           base_image.image_versions << ImageVersion.new
         end
-        base_image.save!
+        base_image.save
         BaseImage.find(base_image).image_versions.size.should == 2
       end
 
       it "should have one template" do
-        base_image = BaseImage.new
+        base_image = FactoryGirl.build(:base_image)
         base_image.template = FactoryGirl.build(:template)
         base_image.save!
         BaseImage.find(base_image).template.should == base_image.template
@@ -22,14 +22,14 @@ module Tim
 
     describe "Dummy model relationships" do
       it "should have one pool family" do
-        base_image = BaseImage.new
+        base_image = FactoryGirl.build(:base_image_with_template)
         base_image.pool_family = PoolFamily.new
         base_image.save!
         BaseImage.find(base_image).pool_family.should == base_image.pool_family
       end
 
       it "should have one user" do
-        base_image = BaseImage.new
+        base_image = FactoryGirl.build(:base_image_with_template)
         base_image.user = User.new
         base_image.save!
         BaseImage.find(base_image).user.should == base_image.user

data/spec/models/dummy/pool_family_spec.rb

@@ -5,7 +5,7 @@ describe PoolFamily do
     it 'should have many base images' do
       pool_family = PoolFamily.new
       2.times do
-        pool_family.base_images << Tim::BaseImage.new
+        pool_family.base_images << FactoryGirl.build(:base_image_with_template)
       end
       pool_family.save!
       PoolFamily.find(pool_family).base_images.size.should == 2

data/spec/models/dummy/provider_account_spec.rb

@@ -4,12 +4,14 @@ describe ProviderAccount do
   describe "Dummy Model relationships" do
     before(:each) do
       Tim::ProviderImage.any_instance.stub(:create_factory_provider_image).and_return(true)
+      Tim::TargetImage.any_instance.stub(:create_factory_target_image).and_return(true)
+      Tim::ProviderImage.any_instance.stub(:imported?).and_return(false)
     end
 
     it 'should have many provider images' do
       provider_account = ProviderAccount.new
       2.times do
-        provider_account.provider_images << Tim::ProviderImage.new
+        provider_account.provider_images << FactoryGirl.build(:provider_image_with_full_tree)
       end
       provider_account.save!
       ProviderAccount.find(provider_account).provider_images.size.should == 2

data/spec/models/dummy/provider_type_spec.rb

@@ -4,12 +4,13 @@ describe ProviderType do
   describe "Dummy Model relationships" do
     before (:each) do
       Tim::TargetImage.any_instance.stub(:create_factory_target_image).and_return(true)
+      Tim::TargetImage.any_instance.stub(:imported?).and_return(false)
     end
 
     it 'should have many target images' do
       provider_type = ProviderType.new
       2.times do
-        provider_type.target_images << Tim::TargetImage.new
+        provider_type.target_images << FactoryGirl.build(:target_image_with_full_tree)
       end
       provider_type.save!
       ProviderType.find(provider_type).target_images.size.should == 2

data/spec/models/dummy/user_spec.rb

@@ -5,7 +5,7 @@ describe User do
     it 'should have many base images' do
       user = User.new
       2.times do
-        user.base_images << Tim::BaseImage.new
+        user.base_images << FactoryGirl.build(:base_image_with_template)
       end
       user.save!
       User.find(user).base_images.size.should == 2

data/spec/models/image_version_spec.rb

@@ -5,19 +5,20 @@ module Tim
     describe "Model relationships" do
       before (:each) do
         TargetImage.any_instance.stub(:create_factory_target_image).and_return(true)
+        Tim::TargetImage.any_instance.stub(:imported?).and_return(false)
       end
 
       it 'should have one base image' do
         image_version = ImageVersion.new
-        image_version.base_image = BaseImage.new
+        image_version.base_image = FactoryGirl.build(:base_image_with_template)
         image_version.save!
         ImageVersion.find(image_version).base_image.should == image_version.base_image
       end
 
       it 'should have many target images' do
-        image_version = ImageVersion.new
+        image_version = FactoryGirl.build(:image_version_with_full_tree)
         2.times do
-          image_version.target_images << TargetImage.new
+          image_version.target_images << FactoryGirl.build(:target_image)
         end
         image_version.save!
         ImageVersion.find(image_version).target_images.size.should == 2

data/spec/models/provider_image_spec.rb

@@ -4,12 +4,14 @@ module Tim
   describe ProviderImage do
     before (:each) do
       TargetImage.any_instance.stub(:create_factory_target_image).and_return(true)
+      Tim::ProviderImage.any_instance.stub(:imported?).and_return(false)
+      Tim::TargetImage.any_instance.stub(:imported?).and_return(false)
     end
 
     describe "Model relationships" do
       it 'should have one target image' do
-        provider_image = ProviderImage.new
-        provider_image.target_image = TargetImage.new
+        provider_image = FactoryGirl.build(:provider_image)
+        provider_image.target_image = FactoryGirl.build(:target_image_with_full_tree)
         provider_image.stub(:create_factory_provider_image).and_return(true)
         provider_image.save!
         ProviderImage.find(provider_image).target_image.should == provider_image.target_image
@@ -18,7 +20,7 @@ module Tim
 
     describe "Dummy model relationships" do
       it "should have one provider account" do
-        provider_image = ProviderImage.new
+        provider_image = FactoryGirl.build(:provider_image_with_full_tree)
         provider_image.provider_account = ProviderAccount.new
         provider_image.stub(:create_factory_provider_image).and_return(true)
         provider_image.save!
@@ -39,7 +41,7 @@ module Tim
           target = mock(:target)
           target.stub(:target).and_return("mock")
 
-          pi = FactoryGirl.build(:provider_image)
+          pi = FactoryGirl.build(:provider_image_with_full_tree)
           pi.target_image.target = target
           pi.should_receive(:populate_factory_fields)
           pi.save
@@ -60,9 +62,30 @@ module Tim
           pi.progress.should == "10"
           pi.provider.should == "MockSphere"
           pi.external_image_id.should == "mock-123456"
-          pi.provider_account_id.should == "mock-account-123"
+          pi.factory_provider_account_id.should == "mock-account-123"
+        end
+
+        it "should not make a request to factory if the base image is imported" do
+          Tim::ProviderImage.any_instance.stub(:imported?).and_return(true)
+          ti = FactoryGirl.build(:provider_image_import)
+          ti.should_not_receive(:create_factory_provider_image)
+          ti.save
         end
 
+        it "should make a request to factory if the target image build type is SNAPSHOT" do
+          ti = FactoryGirl.build(:provider_image)
+          ti.should_not_receive(:create_factory_provider_image)
+          ti.save
+        end
+
+        it "should raise ImagefactoryConnectionRefused exception when it can"\
+          " not connect to Imagefactory" do
+          expect {
+            Tim::ImageFactory::ProviderImage.stub(:new).and_raise(Errno::ECONNREFUSED)
+            provider_image = FactoryGirl.build(:provider_image_with_full_tree)
+            provider_image.send(:create_factory_provider_image)
+          }.to raise_error(Tim::Error::ImagefactoryConnectionRefused)
+        end
       end
     end
   end

data/spec/models/target_image_spec.rb

@@ -3,19 +3,22 @@ require 'spec_helper'
 module Tim
   describe TargetImage do
 
+    before (:each) do
+      Tim::TargetImage.any_instance.stub(:imported?).and_return(false)
+    end
     #TODO FIX: A bug in RSpec V2.1 means that any_instance propogates across context therefore we are  stubbing each 
     #target_image.   This bug is fixed in RSpec V2.6 
     describe "Model relationships" do
       it 'should have one images version' do
-        target_image = TargetImage.new
+        target_image = FactoryGirl.build(:target_image)
         target_image.stub(:create_factory_target_image).and_return(true)
-        target_image.image_version = ImageVersion.new
+        target_image.image_version = FactoryGirl.build(:image_version_with_full_tree)
         target_image.save!
         TargetImage.find(target_image).image_version.should == target_image.image_version
       end
 
       it 'should have many provider images' do
-        target_image = TargetImage.new
+        target_image = FactoryGirl.build(:target_image_with_full_tree)
         target_image.stub(:create_factory_target_image).and_return(true)
         ProviderImage.any_instance.stub(:create_factory_provider_image).and_return(true)
         2.times do
@@ -28,7 +31,7 @@ module Tim
 
     describe "Dummy model relationships" do
       it "should have one provider type" do
-        target_image = TargetImage.new
+        target_image = FactoryGirl.build(:target_image_with_full_tree)
         target_image.stub(:create_factory_target_image).and_return(true)
         target_image.provider_type = ProviderType.new
         target_image.save!
@@ -67,8 +70,75 @@ module Tim
           ti.status.should == "NEW"
           ti.status_detail.should == "Building"
           ti.progress.should == "0"
+          ti.image_version.factory_base_image_id.should == '2cc3b024-5fe7-4b0b-934b-c5d463b990b0'
+        end
+
+        it "should not make a request to factory if the base image is imported" do
+          Tim::TargetImage.any_instance.stub(:imported?).and_return(true)
+          ti = FactoryGirl.build(:target_image_import)
+          ti.should_not_receive(:create_factory_target_image)
+          ti.save
+        end
+
+        it "should not make a request to factory if the target image is build method is SNAPSHOT" do
+          ti = FactoryGirl.build(:target_image_import, :build_method => "SNAPSHOT")
+          ti.should_not_receive(:create_factory_target_image)
+          ti.save
+        end
+
+        it "should send base image id to factory if it is set on image version" do
+          image_version = FactoryGirl.build(:image_version_with_full_tree,
+                                            :factory_base_image_id => "1234")
+          target_image = FactoryGirl.build(:target_image,
+                                           :image_version => image_version)
+          target_image.stub(:populate_factory_fields)
+          mock_target_image = double("factory_target_image")
+          Tim::ImageFactory::TargetImage.stub(:new).and_return(mock_target_image)
+          mock_target_image.should_receive(:parameters=)
+          mock_target_image.should_receive(:base_image_id=)
+          mock_target_image.should_receive(:save!)
+          target_image.save
+        end
+
+        it "should send template to factory if factory base image id is not set on image version" do
+          image_version = FactoryGirl.build(:image_version_with_full_tree)
+          target_image = FactoryGirl.build(:target_image,
+                                           :image_version => image_version)
+          target_image.stub(:populate_factory_fields)
+          mock_target_image = double("factory_target_image")
+          Tim::ImageFactory::TargetImage.stub(:new).and_return(mock_target_image)
+          mock_target_image.should_receive(:parameters=)
+          mock_target_image.should_receive(:template=)
+          mock_target_image.should_receive(:save!)
+          target_image.save
+        end
+
+        it "should raise ImagefactoryConnectionRefused exception when it can"\
+          " not connect to Imagefactory" do
+          expect {
+            Tim::ImageFactory::TargetImage.stub(:new).and_raise(Errno::ECONNREFUSED)
+            target_image = TargetImage.new
+            target_image.send(:create_factory_target_image)
+          }.to raise_error(Tim::Error::ImagefactoryConnectionRefused)
+        end
+
+        it "should set default factory data when importing" do
+          target_image = FactoryGirl.build(:target_image_with_full_tree)
+          target_image.stub(:imported?).and_return(true)
+          target_image.save!
+          target_image.progress.should == "COMPLETE"
+          target_image.status.should == "COMPLETE"
+          target_image.status_detail.should == "Imported Image"
         end
 
+        it "should set default factory data when creating snapshot" do
+          target_image = FactoryGirl.build(:target_image_with_full_tree)
+          target_image.stub(:snapshot?).and_return(true)
+          target_image.save!
+          target_image.progress.should == "COMPLETE"
+          target_image.status.should == "COMPLETE"
+          target_image.status_detail.should == "Snapshot Image"
+        end
       end
     end
   end