tikkie-api 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 55cfd884d7806c214f743001ae9630fe2c4c8f68299706b089bda175218f3e4f
-  data.tar.gz: 3a85b046ec52e04e67bf17c7c5ba325bf519d86971b661d2e1982c353534ebc6
+  metadata.gz: 10c4a5614f612f5644d20fc71952d57c7104086e8a2ab377183fea972a9f21fd
+  data.tar.gz: 66e49070354bc7fff4dd78ca1da2b37e404e47ba324502ecf22b7a68f4644a9a
 SHA512:
-  metadata.gz: 8bae92cd6c752733f04abf01c254228e724531c11c77d623cf955569034b8c8dd9d7ec4e58e28e0c06ce13d2093014605886f6fe75cab63ab079987a2f506f92
-  data.tar.gz: f61d4b03695dc6741d0cac68dedf9b413e48be017a0c1e41a2b5cecf8e7215ff8b0c80f35ee1fc7a35c41da12edb6b77b7b21b5509807997f1a4d37d5c5551ed
+  metadata.gz: e0c1ff2ba7627421270620a60a8510d8958261e0239f3650fc7f6e82242d846bf712051b65d3c5c7ede981b91b46fbb8b970e85f5a4d6a870becc18eed77db84
+  data.tar.gz: b5ca9fed8e11d329c76f3d90ea877f77b3c376e9b7b04897868fb21adc2b007fd00b0681276713f81b81d15948d2311adf12b309059c9be98a27012fa2583400

data/.rubocop.yml

@@ -26,6 +26,9 @@ Style/Documentation:
 Style/GuardClause:
   Enabled: false
 
+Style/IfUnlessModifier:
+  Enabled: false
+
 Style/SafeNavigation:
   Enabled: false
 

data/.travis.yml

@@ -1,8 +1,11 @@
 sudo: false
 language: ruby
+cache: bundler
+before_install:
+  - gem update --system
+  - gem update bundler
 rvm:
-  - 2.2.10
-  - 2.3.7
-  - 2.4.4
-  - 2.5.1
-before_install: gem install bundler -v 1.16.1
+  - 2.3.8
+  - 2.4.5
+  - 2.5.3
+  - 2.6.1

data/Gemfile

@@ -7,4 +7,4 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in tikkie-api.gemspec
 gemspec
 
-gem 'rubocop', '~> 0.52.0'
+gem 'rubocop', '~> 0.63.1'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    tikkie-api (0.1.1)
+    tikkie-api (0.2.0)
       jwt (>= 1.0)
 
 GEM
@@ -9,16 +9,17 @@ GEM
   specs:
     addressable (2.5.2)
       public_suffix (>= 2.0.2, < 4.0)
-    ast (2.3.0)
+    ast (2.4.0)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
     hashdiff (0.3.7)
+    jaro_winkler (1.5.2)
     jwt (2.1.0)
-    parallel (1.12.1)
-    parser (2.4.0.2)
-      ast (~> 2.3)
-    powerpack (0.1.1)
+    parallel (1.13.0)
+    parser (2.6.0.0)
+      ast (~> 2.4.0)
+    powerpack (0.1.2)
     public_suffix (3.0.1)
     rainbow (3.0.0)
     rake (10.5.0)
@@ -35,17 +36,18 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.0)
-    rubocop (0.52.1)
+    rubocop (0.63.1)
+      jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.4.0.2, < 3.0)
+      parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.9.0)
+      unicode-display_width (~> 1.4.0)
+    ruby-progressbar (1.10.0)
     safe_yaml (1.0.4)
     timecop (0.9.1)
-    unicode-display_width (1.3.0)
+    unicode-display_width (1.4.1)
     webmock (2.3.2)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
@@ -58,10 +60,10 @@ DEPENDENCIES
   bundler (~> 1.16)
   rake (~> 10.0)
   rspec (~> 3.0)
-  rubocop (~> 0.52.0)
+  rubocop (~> 0.63.1)
   tikkie-api!
   timecop (~> 0.9)
   webmock (~> 2.3)
 
 BUNDLED WITH
-   1.16.1
+   1.17.2

data/README.md

@@ -113,20 +113,22 @@ To retrieve a single payment request:
 payment_request = client.payment_requests.get("platform_token", "user_token", "payment_request_token")
 ```
 
-Create a new payment request for an existing user:
+Create a new payment request (i.e. Tikkie) for an existing user:
 
 ```ruby
 payment_request = client.payment_requests.create("platform_token", "user_token", "bank_account_token",
-  amount: "5.00",
+  amount: "5.00",               # optional
   currency: "EUR",
   description: "Test",
-  external_id: "Invoice 12345"  # optional
+  external_id: "Invoice 12345"  # mandatory only when platform_usage is set to `FOR_MYSELF`
 )
 
 tikkie_url = payment_request.payment_request_url
 payment_request_token = payment_request.payment_request_token
 ```
 
+The parameter `amount` is optional. When omitted, it will create a payment request with an open amount, where the payer can decide on the amount.
+
 ### Error handling
 
 All responses to an API request include the methods `success?` and `error?` to determine whether the API call was successful or not. When the API request was not successful, the method `errors` will return details about the error response.

data/lib/tikkie/api/requests/payment_requests.rb

@@ -33,11 +33,12 @@ module Tikkie
 
         def create(platform_token, user_token, bank_account_token, options = {})
           params = {
-            amountInCents: to_cents(options.fetch(:amount)),
             currency: options.fetch(:currency),
-            description: options.fetch(:description),
-            externalId: options[:external_id]
+            description: options.fetch(:description)
           }
+          params[:amountInCents] = to_cents(options[:amount]) if options.key?(:amount)
+          params[:externalId] = options[:external_id] if options.key?(:external_id)
+
           response = @request.post("/tikkie/platforms/#{platform_token}/users/#{user_token}/bankaccounts/#{bank_account_token}/paymentrequests", params)
 
           Tikkie::Api::Responses::PaymentRequestCreated.new(response)
@@ -46,7 +47,7 @@ module Tikkie
         private
 
         def to_cents(amount)
-          decimal = BigDecimal.new(amount.to_s)
+          decimal = BigDecimal(amount.to_s)
           decimal *= 100 # to cents
           decimal.to_i
         end

data/lib/tikkie/api/responses/payment.rb

@@ -17,7 +17,7 @@ module Tikkie
         end
 
         def amount
-          decimal = BigDecimal.new(data[:amountInCents])
+          decimal = BigDecimal(data[:amountInCents])
           decimal /= 100.0
           decimal
         end

data/lib/tikkie/api/responses/payment_request.rb

@@ -13,7 +13,7 @@ module Tikkie
         end
 
         def amount
-          decimal = BigDecimal.new(data[:amountInCents])
+          decimal = BigDecimal(data[:amountInCents])
           decimal /= 100.0
           decimal
         end

data/lib/tikkie/api/version.rb

@@ -2,6 +2,6 @@
 
 module Tikkie
   module Api
-    VERSION = "0.1.1"
+    VERSION = "0.2.0"
   end
 end

data/tikkie-api.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "tikkie/api/version"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tikkie-api
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Kentaa BV
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-17 00:00:00.000000000 Z
+date: 2019-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jwt
@@ -160,8 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Ruby library for communicating with the Tikkie API