ticketmaster-github 0.6.10 → 0.7.0

data/VERSION

@@ -1 +1 @@
-0.6.10
+0.7.0

data/lib/provider/ticket.rb

@@ -12,7 +12,7 @@ module TicketMaster::Provider
         if object.first
           object = object.first
           unless object.is_a? Hash
-            hash = {:id => object.id,
+            hash = {:id => object.number,
                     :status => object.state,
                     :description => object.body,
                     :user => object.user,
@@ -82,7 +82,9 @@ module TicketMaster::Provider
       def self.open(project_id, *options)
         body = options.first.delete(:body)
         title = options.first.delete(:title)
-        TicketMaster::Provider::Github.api.create_issue(project_id, title, body, options.first)
+        new_issue = TicketMaster::Provider::Github.api.create_issue(project_id, title, body, options.first)
+        new_issue.merge!(:project_id => project_id)
+        self.new new_issue
       end
 
       def created_at
@@ -102,9 +104,11 @@ module TicketMaster::Provider
       end
 
       def save
-        t = Ticket.find_by_id(project_id, number)
-        return false if t.title == title and t.body == body
-        Ticket.new(project_id, TicketMaster::Provider::Github.api.update_issue(project_id, number, title, body))
+        issue = Ticket.find_by_id(project_id, number)
+        return false if issue.title == title and issue.body == body
+        ticket_update = TicketMaster::Provider::Github.api.update_issue(project_id, number, title, body)
+        ticket_update.merge!(:project_id => project_id)
+        Ticket.new ticket_update
         true
       end
 

data/spec/comment_spec.rb

@@ -1,27 +1,29 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe "Ticketmaster::Provider::Github::Comment" do
-  
+
   before(:each) do
     @github = TicketMaster.new(:github, {:login => 'ticketmaster-user', :password => 'Tm123456'})
     stub_get('https://ticketmaster-user:Tm123456@api.github.com/users/ticketmaster-user/repos', 'projects.json')
     stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo/issues','issues.json')
     stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo/issues?state=closed','closed_issues.json')
+    stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo/issues/1/comments', 'comments.json')
+    stub_post('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo/issues/1/comments', 'comments/3951282.json')
     @project = @github.projects.first
     @ticket = @project.tickets.first
     @klass = TicketMaster::Provider::Github::Comment
     @api = Octokit::Client
   end
-  
+
   it "should be able to load all comments" do
-    stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo/issues/1/comments', 'comments.json')
     @comments = @ticket.comments
     @comments.should be_an_instance_of(Array)
     @comments.first.should be_an_instance_of(@klass)
   end
-  
+
   it "should be able to create a new comment" do  
-    pending 
+    comment = @ticket.comment!(:body => 'new comment')
+    comment.should be_an_instance_of(@klass)
   end
-  
+
 end

data/spec/fixtures/comments/3951282.json

@@ -0,0 +1,14 @@
+  {
+    "url": "https://api.github.com/repos/ticketmaster-user/tmtest-repo/issues/comments/3951282",
+    "created_at": "2012-02-13T22:49:55Z",
+    "body": "for testing",
+    "updated_at": "2012-02-13T22:49:55Z",
+    "id": 3951282,
+    "user": {
+      "url": "https://api.github.com/users/ticketmaster-user",
+      "gravatar_id": "42bd18419413dfbd6e7ec4fefdec94ae",
+      "login": "ticketmaster-user",
+      "avatar_url": "https://secure.gravatar.com/avatar/42bd18419413dfbd6e7ec4fefdec94ae?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
+      "id": 1434902
+    }
+  }

data/spec/fixtures/issues/new_ticket.json

@@ -0,0 +1 @@
+{"issue":{"comments":1,"position":1.0,"number":1,"state":"open","updated_at":"2012/02/13 14:49:55 -0800","labels":[],"user":"ticketmaster-user","body":"","title":"for testing","html_url":"https://github.com/ticketmaster-user/tmtest-repo/issues/1","created_at":"2012/02/13 14:45:27 -0800","votes":0,"gravatar_id":"42bd18419413dfbd6e7ec4fefdec94ae"}}

data/spec/ticket_spec.rb

@@ -3,22 +3,26 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 describe "Ticketmaster::Provider::Github::Ticket" do
   before(:each) do
     @github = TicketMaster.new(:github, {:login => 'ticketmaster-user', :password => 'Tm123456'})
-    stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo', 'project.json')
     @project = @github.project('tmtest-repo')
     @ticket_id = 1
     @klass = TicketMaster::Provider::Github::Ticket
-  end
 
-  it "should be able to load all tickets" do
+    # mocking requests
+    stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo', 'project.json')
     stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo/issues', 'issues.json')
     stub_get('https://ticketmaster-user:Tm123456@api.github.com/repos/ticketmaster-user/tmtest-repo/issues?state=closed', 'closed_issues.json')
+    stub_get('https://ticketmaster-user:Tm123456@github.com/api/v2/json/issues/show/ticketmaster-user/tmtest-repo/1', 'issues/1.json')
+    stub_post('https://ticketmaster-user:Tm123456@github.com/api/v2/json/issues/edit/ticketmaster-user/tmtest-repo/1', 'issues/1.json')
+    stub_post('https://ticketmaster-user:Tm123456@github.com/api/v2/json/issues/open/ticketmaster-user/tmtest-repo', 'issues/new_ticket.json')
+  end
+
+  it "should be able to load all tickets" do
     @tickets = @project.tickets
     @tickets.should be_an_instance_of(Array)
     @tickets.first.should be_an_instance_of(@klass)
   end
 
   it "should be able to load tickets from an array of ids" do
-    stub_get('https://ticketmaster-user:Tm123456@github.com/api/v2/json/issues/show/ticketmaster-user/tmtest-repo/1', 'issues/1.json')
     @tickets = @project.tickets([@ticket_id])
     @tickets.should be_an_instance_of(Array)
     @tickets.first.should be_an_instance_of(@klass)
@@ -30,14 +34,22 @@ describe "Ticketmaster::Provider::Github::Ticket" do
     @tickets.first.should be_an_instance_of(@klass)
   end
 
-  it "should retrieve tickets from a private repo" do 
-
-  end
-
   it "should find a ticket by id(number)" do
     @ticket = @project.ticket(@ticket_id)
     @ticket.should be_an_instance_of(@klass)
     @ticket.title.should be_eql('for testing')
   end
 
+  it "should update a ticket" do 
+    @ticket = @project.ticket(@ticket_id)
+    @ticket.save.should be_false
+    @ticket.title = "Testing"
+    @ticket.save.should be_true
+  end
+
+  it "should create a ticket" do 
+    ticket = @project.ticket!(:title => 'new ticket', :body => 'testing')
+    ticket.should be_an_instance_of(@klass)
+  end
+
 end

data/spec/ticketmaster-github_spec.rb

@@ -11,13 +11,6 @@ describe "Ticketmaster::Provider::Github" do
     @github.should be_a_kind_of(TicketMaster::Provider::Github)
   end
 
-  it "should show attempted authenticated if a token is present" do
-    pending
-    @github = TicketMaster.new(:github, {:login => 'juanespinosa', :token => 'asdfghk'})
-    @github.authorize
-    TicketMaster::Provider::Github.api.authenticated?.should be_true
-  end
-
   context 'when calling #valid?' do
     it 'should test #total_private_repos number' do
       user = mock 'user'

data/ticketmaster-github.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "ticketmaster-github"
-  s.version = "0.6.10"
+  s.version = "0.7.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["HybridGroup"]
-  s.date = "2012-03-06"
+  s.date = "2012-03-07"
   s.description = "This provides an interface with github through the ticketmaster gem."
   s.email = "hong.quach@abigfisch.com"
   s.extra_rdoc_files = [
@@ -36,8 +36,10 @@ Gem::Specification.new do |s|
     "spec/comment_spec.rb",
     "spec/fixtures/closed_issues.json",
     "spec/fixtures/comments.json",
+    "spec/fixtures/comments/3951282.json",
     "spec/fixtures/issues.json",
     "spec/fixtures/issues/1.json",
+    "spec/fixtures/issues/new_ticket.json",
     "spec/fixtures/project.json",
     "spec/fixtures/projects.json",
     "spec/fixtures/repositories.json",
@@ -50,7 +52,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/kiafaldorius/ticketmaster-github"
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.15"
+  s.rubygems_version = "1.8.17"
   s.summary = "The github provider for ticketmaster"
 
   if s.respond_to? :specification_version then

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ticketmaster-github
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 3
   prerelease: 
   segments: 
   - 0
-  - 6
-  - 10
-  version: 0.6.10
+  - 7
+  - 0
+  version: 0.7.0
 platform: ruby
 authors: 
 - HybridGroup
@@ -15,9 +15,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-03-06 00:00:00 Z
+date: 2012-03-07 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
+  name: ticketmaster
+  prerelease: false
+  type: :runtime
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -30,10 +33,10 @@ dependencies:
         - 7
         version: 0.6.7
   version_requirements: *id001
-  name: ticketmaster
+- !ruby/object:Gem::Dependency 
+  name: octokit
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency 
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -46,10 +49,10 @@ dependencies:
         - 5
         version: 0.6.5
   version_requirements: *id002
-  name: octokit
+- !ruby/object:Gem::Dependency 
+  name: jeweler
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency 
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -62,10 +65,10 @@ dependencies:
         - 4
         version: 1.6.4
   version_requirements: *id003
-  name: jeweler
-  prerelease: false
-  type: :runtime
 - !ruby/object:Gem::Dependency 
+  name: rspec
+  prerelease: false
+  type: :development
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -78,10 +81,10 @@ dependencies:
         - 0
         version: 1.3.0
   version_requirements: *id004
-  name: rspec
+- !ruby/object:Gem::Dependency 
+  name: fakeweb
   prerelease: false
   type: :development
-- !ruby/object:Gem::Dependency 
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -94,9 +97,6 @@ dependencies:
         - 0
         version: 1.3.0
   version_requirements: *id005
-  name: fakeweb
-  prerelease: false
-  type: :development
 description: This provides an interface with github through the ticketmaster gem.
 email: hong.quach@abigfisch.com
 executables: []
@@ -126,8 +126,10 @@ files:
 - spec/comment_spec.rb
 - spec/fixtures/closed_issues.json
 - spec/fixtures/comments.json
+- spec/fixtures/comments/3951282.json
 - spec/fixtures/issues.json
 - spec/fixtures/issues/1.json
+- spec/fixtures/issues/new_ticket.json
 - spec/fixtures/project.json
 - spec/fixtures/projects.json
 - spec/fixtures/repositories.json
@@ -166,7 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.15
+rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: The github provider for ticketmaster