ticket-replicator 1.1.0 → 1.2.0

data/spec/ticket/replicator/row_loader_spec.rb

@@ -42,7 +42,7 @@ module Ticket
           it do
             expect(loader).to receive(:create_ticket)
 
-            loader.ticket
+            loader.send(:ticket)
           end
         end
 
@@ -52,7 +52,7 @@ module Ticket
           it do
             expect(loader).to receive(:fetch_ticket)
 
-            loader.ticket
+            loader.send(:ticket)
           end
         end
       end
@@ -108,7 +108,7 @@ module Ticket
         it do
           expect(jira_project).to receive(:replicated_tickets).and_return(replicated_tickets)
 
-          expect(loader.fetch_ticket).to be(:a_ticket)
+          expect(loader.send(:fetch_ticket)).to be(:a_ticket)
         end
       end
 
@@ -128,7 +128,7 @@ module Ticket
           expect(issue_accessor).to receive(:build).and_return(jira_ticket)
           expect(Ticket).to receive(:new).with(jira_auto_tool, jira_ticket).and_return(:ticket)
 
-          expect(loader.create_ticket).to eq(:ticket)
+          expect(loader.send(:create_ticket)).to eq(:ticket)
         end
       end
 
@@ -149,26 +149,14 @@ module Ticket
             ticket: ticket,
             :ticket_fields_need_to_be_updated? => ticket_fields_need_to_be_updated?
           )
-
-          allow(jira_project)
-            .to receive_messages(resolutions: {
-                                   "Done" => nil, "Won't Do" => nil, "Duplicate" => nil, "Cannot Reproduce" => nil
-                                 })
         end
 
         context "when the previously replicated needs to be updated " do
           let(:ticket_fields_need_to_be_updated?) { true }
 
           it do
-            expect(jira_ticket).to receive(:save!).with({
-                                                          fields: {
-                                                            project: { key: "PROJKEY" },
-                                                            issuetype: { name: "Bug" },
-                                                            resolution: { name: "Done" },
-                                                            priority: { name: "Low" },
-                                                            summary: "PREFIX | summary"
-                                                          }
-                                                        })
+            allow(loader).to receive_messages(attributes_for_save: { fields: { a: "b" } })
+            expect(jira_ticket).to receive(:save!).with({ fields: { a: "b" } })
 
             expect(jira_ticket).to receive(:fetch)
 
@@ -188,6 +176,71 @@ module Ticket
         end
       end
 
+      describe "#attributes_for_save" do
+        let(:loader) { described_class.send(:new, jira_project, row) }
+
+        let(:row) do
+          { id: "123", priority: "Low", resolution: "Done", status: "Open", summary: "PREFIX | summary",
+            team: "A Team" }
+        end
+
+        before do
+          allow(jira_project)
+            .to receive_messages(resolutions: {
+                                   "Done" => nil, "Won't Do" => nil, "Duplicate" => nil, "Cannot Reproduce" => nil
+                                 })
+
+          allow(loader).to receive_messages(exclude_resolution?: exclude_resolution?)
+        end
+
+        context "when the resolution is not excluded" do
+          let(:exclude_resolution?) { false }
+
+          it do
+            expect(loader.send(:attributes_for_save)).to eq({
+                                                              fields: {
+                                                                project: { key: "PROJKEY" },
+                                                                issuetype: { name: "Bug" },
+                                                                priority: { name: "Low" },
+                                                                resolution: { name: "Done" },
+                                                                summary: "PREFIX | summary"
+                                                              }
+                                                            })
+          end
+        end
+
+        context "when excluding the resolution" do
+          let(:exclude_resolution?) { true }
+
+          it do
+            expect(loader.send(:attributes_for_save)).to eq({
+                                                              fields: {
+                                                                project: { key: "PROJKEY" },
+                                                                issuetype: { name: "Bug" },
+                                                                priority: { name: "Low" },
+                                                                summary: "PREFIX | summary"
+                                                              }
+                                                            })
+          end
+        end
+      end
+
+      describe "#exclude_resolution?" do
+        before { allow(ENV).to receive(:[]).with("TICKET_REPLICATOR_DISABLE_RESOLUTION_LOADING").and_return(env_value) }
+
+        context "when the environment variable is not set to true" do
+          let(:env_value) { nil }
+
+          it { expect(loader.send(:exclude_resolution?)).to be_falsey }
+        end
+
+        context "when the environment variable is set to true" do
+          let(:env_value) { "true" }
+
+          it { expect(loader.send(:exclude_resolution?)).to be_truthy }
+        end
+      end
+
       describe "#build_ticket_link_attributes" do
         it "builds the link attributes with a default application" do
           expect(described_class.send(:build_ticket_link_attributes,
@@ -222,21 +275,21 @@ module Ticket
           let(:ticket_previously_replicated?) { false }
           let(:ticket_fields_changed?) { false }
 
-          it { expect(loader.ticket_fields_need_to_be_updated?).to be_truthy }
+          it { expect(loader.send(:ticket_fields_need_to_be_updated?)).to be_truthy }
         end
 
         context "when the fields changed since last replication" do
           let(:ticket_previously_replicated?) { true }
           let(:ticket_fields_changed?) { true }
 
-          it { expect(loader.ticket_fields_need_to_be_updated?).to be_truthy }
+          it { expect(loader.send(:ticket_fields_need_to_be_updated?)).to be_truthy }
         end
 
         context "when the fields did not change since last replication" do
           let(:ticket_previously_replicated?) { true }
           let(:ticket_fields_changed?) { false }
 
-          it { expect(loader.ticket_fields_need_to_be_updated?).to be_falsey }
+          it { expect(loader.send(:ticket_fields_need_to_be_updated?)).to be_falsey }
         end
       end
 
@@ -246,57 +299,89 @@ module Ticket
         end
 
         let(:loader) { described_class.send(:new, jira_project, row) }
-        let(:jira_ticket) { double(JIRA::Resource::Issue, summary: current_summary, priority: current_priority) }
+
+        let(:jira_ticket) do
+          double(JIRA::Resource::Issue,
+                 summary: current_summary,
+                 priority: current_priority,
+                 resolution: current_resolution)
+        end
 
         before do
           expect(loader).to receive(:ticket).at_least(:once).and_return(jira_ticket)
         end
 
-        context "when both summary and priority changed" do
+        context "when summary, priority and resolution changed" do
           let(:current_summary) { "PREFIX | different summary" }
           let(:current_priority) { "High" }
+          let(:current_resolution) { "Won't Do" }
 
-          it { expect(loader.ticket_fields_changed?).to be_truthy }
+          it { expect(loader.send(:ticket_fields_changed?)).to be_truthy }
         end
 
         context "when only summary changed" do
           let(:current_summary) { "PREFIX | different summary" }
           let(:current_priority) { "Low" }
+          let(:current_resolution) { "" }
 
-          it { expect(loader.ticket_fields_changed?).to be_truthy }
+          it { expect(loader.send(:ticket_fields_changed?)).to be_truthy }
         end
 
         context "when only priority changed" do
           let(:current_summary) { "PREFIX | summary" }
           let(:current_priority) { "High" }
+          let(:current_resolution) { "" }
 
-          it { expect(loader.ticket_fields_changed?).to be_truthy }
+          it { expect(loader.send(:ticket_fields_changed?)).to be_truthy }
+        end
+
+        context "when only resolution changed" do
+          let(:current_summary) { "PREFIX | summary" }
+          let(:current_priority) { "Low" }
+          let(:current_resolution) { "Done" }
+
+          before do
+            allow(loader).to receive_messages(exclude_resolution?: exclude_resolution?)
+          end
+
+          context "when the resolution is not excluded" do
+            let(:exclude_resolution?) { false }
+
+            it { expect(loader.send(:ticket_fields_changed?)).to be_truthy }
+          end
+
+          context "when excluding the resolution" do
+            let(:exclude_resolution?) { true }
+
+            it { expect(loader.send(:ticket_fields_changed?)).to be_falsey }
+          end
         end
 
         context "when neither summary nor priority changed" do
           let(:current_summary) { "PREFIX | summary" }
           let(:current_priority) { "Low" }
+          let(:current_resolution) { "" }
 
-          it { expect(loader.ticket_fields_changed?).to be_falsey }
+          it { expect(loader.send(:ticket_fields_changed?)).to be_falsey }
         end
       end
 
       describe "#ticket_previously_replicated?" do
         let(:loader) { described_class.send(:new, jira_project, row) }
-        let(:replicated_tickets) { { "123" => "a_ticket" } }
+        let(:replicated_tickets) { { "123" => "a_ticket", "880" => "another_ticket" } }
 
         before { expect(jira_project).to receive(:replicated_tickets).and_return(replicated_tickets) }
 
         context "when previously replicated" do
           let(:row) { { id: "123" } }
 
-          it { expect(loader.ticket_previously_replicated?).to be_truthy }
+          it { expect(loader.send(:ticket_previously_replicated?)).to be_truthy }
         end
 
         context "when previously replicated" do
           let(:row) { { id: "456" } }
 
-          it { expect(loader.ticket_previously_replicated?).to be_falsey }
+          it { expect(loader.send(:ticket_previously_replicated?)).to be_falsey }
         end
       end
 
@@ -317,7 +402,7 @@ module Ticket
         let(:expected_link) { build_link("https://url/to/source/ticket/123", "Source Ticket 123") }
 
         describe "#source_ticket_link_title" do
-          it { expect(loader.source_ticket_link_title).to eq("Source Ticket 123") }
+          it { expect(loader.send(:source_ticket_link_title)).to eq("Source Ticket 123") }
         end
 
         describe "#update_source_ticket_remote_link" do
@@ -333,7 +418,7 @@ module Ticket
             it "setups the link" do
               expect(remotelink).to receive(:save!).with(expected_link)
 
-              loader.update_source_ticket_remote_link
+              loader.send(:update_source_ticket_remote_link)
             end
           end
 
@@ -347,7 +432,7 @@ module Ticket
               expect(source_ticket_link).to receive(:delete)
               expect(remotelink).to receive(:save!).with(expected_link)
 
-              loader.update_source_ticket_remote_link
+              loader.send(:update_source_ticket_remote_link)
             end
           end
 
@@ -357,7 +442,7 @@ module Ticket
             it "no link creation happens" do
               expect(remotelink).not_to receive(:save!)
 
-              loader.update_source_ticket_remote_link
+              loader.send(:update_source_ticket_remote_link)
             end
           end
         end
@@ -370,7 +455,7 @@ module Ticket
           context "when link has yet to be created" do
             let(:remote_link) { nil }
 
-            it { expect(loader.source_ticket_link_needs_update?).to be_truthy }
+            it { expect(loader.send(:source_ticket_link_needs_update?)).to be_truthy }
           end
 
           context "when link already exists" do
@@ -387,14 +472,14 @@ module Ticket
                 let(:existing_url) { "https://__OLD_URL__/to/source/ticket/1234" }
                 let(:existing_title) { "Source Ticket 123" }
 
-                it { expect(loader.source_ticket_link_needs_update?).to be_truthy }
+                it { expect(loader.send(:source_ticket_link_needs_update?)).to be_truthy }
               end
 
               context "when title has changed" do
                 let(:existing_url) { "https://url/to/source/ticket/123" }
                 let(:existing_title) { "__OLD TITLE__Source Ticket 1234" }
 
-                it { expect(loader.source_ticket_link_needs_update?).to be_truthy }
+                it { expect(loader.send(:source_ticket_link_needs_update?)).to be_truthy }
               end
             end
 
@@ -412,7 +497,9 @@ module Ticket
                     { "id" => 10_443, "self" => "https://url/to/source/ticket/123/remotelink/10443" } }
               end
 
-              it("only checks the needed attributes") { expect(loader.source_ticket_link_needs_update?).to be_falsey }
+              it("only checks the needed attributes") {
+                expect(loader.send(:source_ticket_link_needs_update?)).to be_falsey
+              }
             end
           end
         end
@@ -428,7 +515,7 @@ module Ticket
             expect(loader).to receive(:ticket).at_least(:once).and_return(ticket)
             expect(ticket).to receive(:transition_to).with("Testing")
 
-            loader.transition_ticket_to_the_expected_status
+            loader.send(:transition_ticket_to_the_expected_status)
           end
         end
       end