tic_tac_toe_nhu 0.0.5 → 0.0.11

data/spec/mocks/player_factory.rb

@@ -1,11 +1,10 @@
 require 'surrogate/rspec'
-require 'tic_tac_toe/values'
 
 class MockPlayerFactory
   Surrogate.endow(self)
 
-  define(:human) {|name = "human", value = TicTacToe::VALUES[0]|}
-  define(:computer) {|value = TicTacToe::VALUES[1]|}
+  define(:human) {|name = "Sue", value = "X"|}
+  define(:computer) {|board, value = "X", opponent="O"|}
 end
 
 describe TicTacToe::PlayerFactory do

data/spec/mocks/strategy/dynamic.rb

@@ -9,7 +9,7 @@ class MockDynamicStrategy
     @moves << move
   end
 
-  def move(*board)
+  def move
     @moves.shift
   end
 

data/spec/tic_tac_toe/game_factory_spec.rb

@@ -0,0 +1,78 @@
+require 'tic_tac_toe/spec_helper'
+require 'tic_tac_toe/game_factory'
+require 'tic_tac_toe/player_factory'
+require 'mocks/player_factory'
+
+describe TicTacToe::GameFactory do
+
+  before(:each) do
+    @board = "board"
+    @player_factory = MockPlayerFactory.new
+    @game_factory = TicTacToe::GameFactory.new(@player_factory)
+  end
+
+  it "ensures MockPlayerFactory has the same interface as PlayerFactory" do
+    MockPlayerFactory.should be_substitutable_for(TicTacToe::PlayerFactory)
+  end
+
+  it "returns 4 types of games" do
+    @game_factory.types.size.should == 4
+  end
+
+  it "sets the board in the game" do
+    game = @game_factory.create(1, @board)
+    game.board.should == @board
+  end
+
+  it "returns human vs computer game" do
+    human = "human"
+    computer = "computer"
+    @player_factory.will_have_human human
+    @player_factory.will_have_computer computer
+
+    game = @game_factory.create(1, @board)
+    game.current_player.should == human
+
+    @player_factory.was asked_for :computer
+    @player_factory.was asked_for :human
+  end
+
+  it "returns computer vs human game" do
+    human = "human"
+    computer = "computer"
+    @player_factory.will_have_human human
+    @player_factory.will_have_computer computer
+
+    game = @game_factory.create(2, @board)
+    game.current_player.should == computer
+
+    @player_factory.was asked_for :computer
+    @player_factory.was asked_for :human
+  end
+
+  it "returns user vs user game" do
+    human1 = "mary"
+    human2 = "alice"
+    @player_factory.will_have_human human1, human2
+
+    game = @game_factory.create(3, @board)
+    game.current_player.should == human1
+
+    @player_factory.was asked_for(:human).times(2)
+  end
+
+  it "returns computer vs computer game" do
+    computer1 = "computer1"
+    computer2 = "computer2"
+    @player_factory.will_have_computer computer2, computer1
+
+    game = @game_factory.create(4, @board)
+    game.current_player.should == computer2
+
+    @player_factory.was asked_for(:computer).times(2)
+  end
+
+  it "raises an error when the game type doesn't exist" do
+    lambda{@game_factory.create(5, @board)}.should raise_error(ArgumentError)
+  end
+end

data/spec/tic_tac_toe/game_spec.rb

@@ -1,99 +1,113 @@
 require 'tic_tac_toe/spec_helper'
 require 'tic_tac_toe/game'
-
-require 'mocks/game_state_factory'
-require 'mocks/game_state'
-require 'mocks/ui/console'
-require 'mocks/player'
+require 'tic_tac_toe/board'
+require 'tic_tac_toe/player'
+require 'mocks/strategy/dynamic'
 
 describe TicTacToe::Game do
-  attr_reader :game, :ui, :game_state, :game_state_factory
-
   before(:each) do
-    @game_state = MockGameState.factory
-    @game_state_factory = MockGameStateFactory.factory create: game_state
-    @ui = MockConsole.factory
-    @game = TicTacToe::Game.new(@ui, @game_state_factory)
-  end
+    @board = TicTacToe::Board.new
+
+    @player1_strategy = MockDynamicStrategy.new
+    @player1 = TicTacToe::Player.new("Todd", "X", @player1_strategy)
+
+    @player2_strategy = MockDynamicStrategy.new
+    @player2 = TicTacToe::Player.new("John", "O", @player2_strategy)
 
-  it "displays a welcome message" do
-    game.start
-    ui.was told_to(:display_welcome_message)
+    @game = TicTacToe::Game.new(@board, @player1, @player2)
   end
 
-  describe "create game state" do
-    it "asks user for a game type" do
-      game.start
-      @ui.was asked_for(:game_type)
+  context "marking board" do
+    it "mark the board with user input when caller doesn't pass in a move" do
+      @player1_strategy.add_move(1)
+      @game.make_move
+      @board.unique_marked_values.should include(@player1.value)
     end
 
-    it "asks game state factory to create a game with input game type" do
-      game_type = 4
-      ui.will_have_game_type 4
-      game.start
-      @game_state_factory.was told_to(:create).with(game_type)
+    it "does not mark the board if user doesn't return an input and caller didn't pass in a move" do
+      @player1_strategy.add_move(nil)
+      @game.make_move
+      @board.unique_marked_values.should_not include(@player1.value)
     end
 
-    it "asks ui for game type again if the input is incorrect" do
-      game_state_factory.will_create ArgumentError.new, game_state
-      game.start
-      ui.was asked_for(:game_type).times(2)
+    it "marks the board with the move passed in" do
+      @player1_strategy.add_move(1)
+      move = 2
+      @game.make_move(move)
+      @board.available_moves.should_not include(move)
     end
-  end
-
-  describe "play game" do
-    attr_reader :player
 
-    before(:each) do
-      @player = MockPlayer.new
-      game_state.will_game_over? false, true
-      game_state.will_have_current_player @player
+    it "marks the board with player move when move passed in is nil" do
+      @player1_strategy.add_move(1)
+      @game.make_move(nil)
+      @board.available_moves.should_not include(1)
     end
 
-    it "displays the board" do
-      game.start
-      ui.was told_to(:display_board)
+    it "marks the board with current player value when the move passed in" do
+      move = 2
+      @game.make_move(move)
+      @board.unique_marked_values.should include(@player1.value)
     end
+  end
 
-    it "tells ui to display player turn" do
-      game.start
-      ui.was told_to(:display_player_turn).with(player)
+  describe "return winner player based on the value return from rules" do
+    it "is Todd when value is X" do
+      mark_board([0, 1, 2], @player1.value)
+      @game.winner.should == @player1
     end
 
-    it "told player to move" do
-      game.start
-      player.was told_to(:move)
+    it "is John when it is O" do
+      mark_board([0, 1, 2], @player2.value)
+      @game.winner.should == @player2
     end
 
-    it "tells player to move again if there is an error" do
-      player.will_move TicTacToe::MoveNotAvailableError.new, nil
-      game.start
-      player.was told_to(:move).times(2)
+    it "is nil when no one wins" do
+      @game.winner.should be_nil
     end
+  end
 
-    it "changes the player after a player move" do
-      game.start
-      game_state.was told_to(:change_player)
+  describe "changes player" do
+    it "doesn't change player if player 1 doesn't return a move" do
+      @game.current_player.should == @player1
+      @player1_strategy.add_move(nil)
+
+      @game.make_move
+      @game.current_player.should == @player1
     end
 
+    it "changes to player 2 after player 1 moves" do
+      @game.current_player.should == @player1
+      @player1_strategy.add_move(1)
+
+      @game.make_move
+      @game.current_player.should == @player2
+    end
   end
 
-  describe "end game" do
-    it "display a board at the end of the game" do
-      game.start
-      ui.was told_to(:display_board)
+  describe "game over" do
+    it "is over when there is a winner" do
+      mark_board([0, 1, 2], @player2.value)
+      @game.should be_over
+    end
+
+    it "is over when there is a tied" do
+      mark_board((0...9).to_a, "i")
+      @game.should be_over
+    end
+
+    it "is not over when there is no mark on the board" do
+      @game.should_not be_over
     end
 
-    it "asks ui to display a winner if there is a winner" do
-      winner = "Winner"
-      game_state.will_have_winner winner
-      game.start
-      ui.was told_to(:display_winner).with(winner)
+    it "is not over when there is no winner or a tied" do
+      mark_board([1, 2], @player1.value)
+      @game.should_not be_over
     end
+  end
 
-    it "asks ui to display a draw" do
-      game.start
-      ui.was told_to(:display_tied_game)
+  def mark_board(moves, value)
+    moves.each do |m|
+      @board.mark(m, value)
     end
   end
 end

data/spec/tic_tac_toe/player_factory_mock.rb

@@ -0,0 +1,10 @@
+class PlayerFactoryMock
+
+  def human(name = "User", value = "X")
+    "Human"
+  end
+
+  def computer(board, value = "O", opponent_value = "X")
+    "Computer"
+  end
+end

data/spec/tic_tac_toe/player_factory_spec.rb

@@ -2,7 +2,6 @@ require 'tic_tac_toe/spec_helper'
 require 'tic_tac_toe/player_factory'
 require 'tic_tac_toe/strategy/minimax'
 require 'tic_tac_toe/strategy/console_user'
-require 'tic_tac_toe/values'
 
 describe TicTacToe::PlayerFactory do
 
@@ -33,22 +32,27 @@ describe TicTacToe::PlayerFactory do
   end
 
   context "computer player" do
+    before(:each) do
+      @board = "fake board"
+    end
+
     it "returns a computer player with given value" do
       computer_value = "Danny"
-      player = @factory.computer(computer_value)
+      opponent_value = "Bill"
+      player = @factory.computer(@board, computer_value, opponent_value)
       player.value.should == computer_value
     end
 
     it "checks default strategy" do
-      @factory.computer.strategy.should be_kind_of(TicTacToe::Strategy::Minimax)
+      @factory.computer(@board).strategy.should be_kind_of(TicTacToe::Strategy::Minimax)
     end
 
     it "checks default name" do
-      @factory.computer.name.should == "Computer"
+      @factory.computer(@board).name.should == "Computer"
     end
 
     it "checks default value" do
-      @factory.computer.value.should == "O"
+      @factory.computer(@board).value.should == "O"
     end
   end
 

data/spec/tic_tac_toe/player_spec.rb

@@ -1,33 +1,32 @@
 require 'tic_tac_toe/spec_helper'
 require 'tic_tac_toe/player'
-require 'tic_tac_toe/board'
-require 'tic_tac_toe/values'
 require 'mocks/strategy/dynamic'
 
 describe TicTacToe::Player do
-  before(:each) do
-    @move = 4
-    @value = TicTacToe::VALUES[0]
-    @name = "blu"
-    @strategy = MockDynamicStrategy.new([@move])
-    @player = TicTacToe::Player.new(@name, @value, @strategy)
-  end
 
   it "gets name" do
-    @player.name.should == @name
+    name = "bruce"
+    player = TicTacToe::Player.new(name, nil, nil)
+    player.name.should == name
   end
 
   it "gets player value" do
-    @player.value.should == @value
+    value = "X"
+    player = TicTacToe::Player.new(nil, value, nil)
+    player.value.should == value
   end
 
-  it "gets strategy" do
-    @player.strategy.should == @strategy
+  it "gets player's move" do
+    move = 4
+    strategy = MockDynamicStrategy.new([4])
+    player = TicTacToe::Player.new(nil, nil, strategy)
+    player.move.should == move
   end
 
-  it "makes move" do
-    board = TicTacToe::Board.new
-    @player.move(board)
-    board.available_moves.should_not include(@move)
+  it "gets strategy" do
+    strategy = MockDynamicStrategy.new([4])
+    player = TicTacToe::Player.new(nil, nil, strategy)
+    player.strategy.should == strategy
+
   end
 end

data/spec/tic_tac_toe/runner_spec.rb

@@ -0,0 +1,95 @@
+require 'tic_tac_toe/spec_helper'
+require 'tic_tac_toe/runner'
+require 'tic_tac_toe/player'
+require 'tic_tac_toe/game'
+require 'tic_tac_toe/rules'
+require 'tic_tac_toe/board'
+require 'mocks/game'
+require 'mocks/game_factory'
+require 'mocks/ui/console'
+require 'mocks/strategy/dynamic'
+require 'mocks/rules'
+
+describe TicTacToe::Runner do
+  before(:each) do
+    @ui = MockConsole.factory
+    @todd = TicTacToe::Player.new("Todd", "X", MockDynamicStrategy.new([1,2,3]))
+    @game = MockGame.factory current_player: @todd, winner: @todd
+    @game_factory = MockGameFactory.factory create: @game
+    @controller = TicTacToe::Runner.new(@ui, @game_factory)
+  end
+
+  describe "starts game" do
+    it "displays welcome message" do
+      @controller.start
+      @ui.was told_to(:display_welcome_message)
+    end
+
+    it "asked ui to get game type" do
+      @controller.start
+      @ui.was asked_for(:game_type)
+    end
+
+    it "creates a game based on user input" do
+      @controller.start
+      @game_factory.was told_to(:create)
+    end
+
+    it "asks ui for game type again if the input is incorrect" do
+      @game_factory.will_create ArgumentError.new, @game
+      @controller.start
+    end
+  end
+
+  describe "play game" do
+    before(:each) do
+      @game.will_over? false, true
+    end
+
+    it "display board" do
+      @controller.start
+      @ui.was told_to(:display_board)
+    end
+
+    it "displays whose turn it is" do
+      @controller.start
+      @ui.was told_to(:display_player_turn).with(@todd)
+    end
+
+    it "tells game to make a move" do
+      @game.will_over? false, true
+      @controller.start
+      @game.was told_to(:make_move)
+    end
+
+    it "asks for game move until game is over" do
+      @game.will_over? false, false, false, true
+      @controller.start
+      @game.was told_to(:make_move).times(3)
+    end
+
+    it "displays message when square is not available" do
+      @game.will_make_move TicTacToe::MoveNotAvailableError.new
+      @controller.start
+      @ui.was told_to(:display_square_not_available)
+    end
+  end
+
+  describe "end game" do
+    it "displays the board when the game is over" do
+      @controller.start
+      @ui.was told_to(:display_board)
+    end
+
+    it "notifies user when player wins" do
+      @controller.start
+      @ui.was told_to(:display_winner).with(@todd)
+    end
+
+    it "notifies user when it's a tied game" do
+      @game.will_have_winner nil
+      @controller.start
+      @ui.was told_to(:display_tied_game)
+    end
+  end
+end

data/spec/tic_tac_toe/strategy/console_user_spec.rb

@@ -13,7 +13,7 @@ describe TicTacToe::Strategy::ConsoleUser do
     it "prompts the user for a move" do
       @output.should_receive(:puts).with("Please enter a square number that is not marked: ")
       @input.should_receive(:gets).and_return("3")
-      @strategy.move(@board)
+      @strategy.move
     end
 
     it "returns a number when user enters a number" do