thunderbird 0.1.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 06e03c762e9bef79479708b14604743fe03e509a742ecb60abb5302a2fd16788
-  data.tar.gz: 76d815453006b03948af39ac113ad07db3783d16904a39f71ee00c53fff2d44d
+  metadata.gz: b00596eb313f59ff0067a1cdbc9f3c177d955c8c3d53dfc25ca997852063f108
+  data.tar.gz: a1d8a4616d516454cb2e3b7ce61661285ba9f09073f1b9b5c38a6710a3fda46c
 SHA512:
-  metadata.gz: a61253e0d2559831f38f39d83fe5fa091846930f8b6ca6a6fe5317bb1aeada74e2cb3a480c39a604c85e648801a95904fcb6aeb9c9b896049214c76db5771b74
-  data.tar.gz: 4a5b2825eef339f31e2b9d33ced437e38430711478286d2eb081415648dab451fe547ffa159b97bcdfbe32b16b198b281d9b0e9bff4767bdb32539da9267c566
+  metadata.gz: cfee0f4a65980836566ef8935dfa9c1bf055d8315f909a76ca3a3a1686afe021988600a0d9613ddf546b28587d12aef88107d68612b48d5e3dc2464859e79866
+  data.tar.gz: 960916c4437ab68df3893816abba8b734bab5237f98190543278bd65af93fbc2730b0b985e90752fc19207cd9476c3d034be0bb450c90a7739dcaf90c416b3ed

data/lib/thunderbird/install.rb

@@ -9,13 +9,13 @@ class Thunderbird
     attr_reader :entries
 
     # entries are lines from profile.ini
-    def initialize(title, entries)
+    def initialize(title:, entries:)
       @title = title
       @entries = entries
     end
 
     def default
-      Thunderbird::Profiles.new.profile_for_path(entries[:Default])
+      Profiles.new.profile_for_path(entries[:Default])
     end
   end
 end

data/lib/thunderbird/local_folder.rb

@@ -1,21 +1,21 @@
 # frozen_string_literal: true
 
-require "thunderbird/profile"
 require "thunderbird/subdirectory"
 
 class Thunderbird
   # A local folder is a file containing emails
+  # It is not a "live" folder that is sync-able with an online account
   class LocalFolder
     attr_reader :path
     attr_reader :profile
 
-    def initialize(profile, path)
+    def initialize(profile:, path:)
       @profile = profile
       @path = path
     end
 
     def set_up
-      return if path_elements.empty?
+      return false if path_elements.empty?
 
       return true if !in_subdirectory?
 
@@ -26,7 +26,7 @@ class Thunderbird
       if in_subdirectory?
         File.join(subdirectory.full_path, folder_name)
       else
-        folder_name
+        path
       end
     end
 
@@ -35,7 +35,7 @@ class Thunderbird
     end
 
     def msf_path
-      "#{path}.msf"
+      "#{full_path}.msf"
     end
 
     def msf_exists?
@@ -51,7 +51,7 @@ class Thunderbird
     def subdirectory
       return nil if !in_subdirectory?
 
-      Thunderbird::Subdirectory.new(profile, subdirectory_path)
+      Subdirectory.new(path: subdirectory_path, root: profile.local_folders_path)
     end
 
     def path_elements

data/lib/thunderbird/profile.rb

@@ -9,7 +9,7 @@ class Thunderbird
     attr_reader :entries
 
     # entries are lines from profile.ini
-    def initialize(title, entries)
+    def initialize(title:, entries:)
       @title = title
       @entries = entries
     end

data/lib/thunderbird/profiles.rb

@@ -10,19 +10,19 @@ class Thunderbird
     def profile_for_path(path)
       title, entries = blocks.find { |_name, entries| entries[:Path] == path }
 
-      Thunderbird::Profile.new(title, entries) if title
+      Thunderbird::Profile.new(title: title, entries: entries) if title
     end
 
     def profile(name)
       title, entries = blocks.find { |_name, entries| entries[:Name] == name }
 
-      Thunderbird::Profile.new(title, entries) if title
+      Thunderbird::Profile.new(title: title, entries: entries) if title
     end
 
     def installs
       @installs ||= begin
         pairs = blocks.filter { |name, _entries| name.start_with?("Install") }
-        pairs.map { |title, entries| Thunderbird::Install.new(title, entries) }
+        pairs.map { |title, entries| Thunderbird::Install.new(title: title, entries: entries) }
       end
     end
 

data/lib/thunderbird/subdirectory.rb

@@ -8,10 +8,10 @@ class Thunderbird
     # `path` is the UI path, it doesn't have the '.sbd' extensions
     # that are present in the real, file system path
     attr_reader :path
-    attr_reader :profile
+    attr_reader :root
 
-    def initialize(profile, path)
-      @profile = profile
+    def initialize(root:, path:)
+      @root = root
       @path = path
     end
 
@@ -35,7 +35,7 @@ class Thunderbird
     # subdirectory relative path is 'Foo.sbd/Bar.sbd/Baz.sbd'
     def full_path
       relative_path = File.join(subdirectories)
-      File.join(profile.local_folders_path, relative_path)
+      File.join(root, relative_path)
     end
 
     private
@@ -51,15 +51,15 @@ class Thunderbird
     def parent
       return nil if !sub_sub_directory?
 
-      self.class.new(profile, File.join(path_elements[0..-2]))
+      self.class.new(root: root, path: File.join(path_elements[0..-2]))
     end
 
     # placeholder relative path is 'Foo.sbd/Bar.sbd/Baz'
     def placeholder
       @placeholder = begin
         relative_path = File.join(subdirectories[0..-2], path_elements[-1])
-        path = File.join(profile.local_folders_path, relative_path)
-        Thunderbird::SubdirectoryPlaceholder.new(path)
+        path = File.join(root, relative_path)
+        Thunderbird::SubdirectoryPlaceholder.new(path: path)
       end
     end
 
@@ -82,13 +82,22 @@ class Thunderbird
     def check
       case
       when exists? && !placeholder.exists?
-        Kernel.puts "Can't set up folder '#{full_path}': '#{full_path}' exists, but '#{placeholder.path}' is missing"
+        Kernel.puts(
+          "Can't set up folder '#{full_path}': " \
+          "'#{full_path}' exists, but '#{placeholder.path}' is missing"
+        )
         false
       when placeholder.exists? && !placeholder.regular?
-        Kernel.puts "Can't set up folder '#{full_path}': '#{placeholder.path}' exists, but it is not a regular file"
+        Kernel.puts(
+          "Can't set up folder '#{full_path}': " \
+          "'#{placeholder.path}' exists, but it is not a regular file"
+        )
         false
       when exists? && !directory?
-        Kernel.puts "Can't set up folder '#{full_path}': '#{full_path}' exists, but it is not a directory"
+        Kernel.puts(
+          "Can't set up folder '#{full_path}': " \
+          "'#{full_path}' exists, but it is not a directory"
+        )
         false
       else
         true

data/lib/thunderbird/subdirectory_placeholder.rb

@@ -6,7 +6,7 @@ class Thunderbird
   class SubdirectoryPlaceholder
     attr_reader :path
 
-    def initialize(path)
+    def initialize(path:)
       @path = path
     end
 

data/lib/thunderbird/version.rb

@@ -3,8 +3,8 @@
 class Thunderbird
   module Version
     MAJOR    = 0
-    MINOR    = 1
-    REVISION = 1
+    MINOR    = 3
+    REVISION = 0
     PRE      = nil
     VERSION  = [MAJOR, MINOR, REVISION, PRE].compact.map(&:to_s).join(".")
   end

data/lib/thunderbird.rb

@@ -1,7 +1,12 @@
 # frozen_string_literal: true
 
 require "os"
-require_relative "thunderbird/version"
+
+# Require all files so they get counted in coverage
+Dir.chdir(__dir__) do
+  glob = File.join("**", "*.rb")
+  Dir[glob].sort.each { |f| require_relative f }
+end
 
 # Root information
 class Thunderbird

data/thunderbird.gemspec

@@ -11,18 +11,16 @@ Gem::Specification.new do |spec|
   spec.summary = "Conveniences for interacting with Mozilla Thunderbird"
   spec.homepage = "https://github.com/joeyates/thunderbird"
   spec.license = "MIT"
-  spec.required_ruby_version = ">= 2.5"
+  spec.required_ruby_version = ">= 2.7"
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/joeyates/thunderbird"
   spec.metadata["changelog_uri"] = "https://github.com/joeyates/thunderbird/blob/main/CHANGELOG.md"
   spec.metadata["rubygems_mfa_required"] = "true"
 
-  spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject do |f|
-      (f == __FILE__) || f.match(%r{\A(?:(?:test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
-    end
-  end
+  spec.files = Dir.glob("lib/**/*.rb")
+  spec.files += ["thunderbird.gemspec"]
+  spec.files += %w(LICENSE.txt README.md)
   spec.bindir = "exe"
   spec.executables = []
   spec.require_paths = ["lib"]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thunderbird
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Joe Yates
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-02-06 00:00:00.000000000 Z
+date: 2024-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: os
@@ -31,14 +31,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".rspec"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
-- CHANGELOG.md
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
 - lib/thunderbird.rb
 - lib/thunderbird/install.rb
 - lib/thunderbird/local_folder.rb
@@ -64,14 +58,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Conveniences for interacting with Mozilla Thunderbird

data/.rspec

@@ -1,3 +0,0 @@
---format documentation
---color
---require spec_helper

data/.rubocop.yml

@@ -1,181 +0,0 @@
-inherit_from: .rubocop_todo.yml
-
-AllCops:
-  TargetRubyVersion: 2.5
-  Exclude:
-    - "bin/stubs/*"
-    - "vendor/**/*"
-
-Gemspec/DateAssignment:
-  Enabled: true
-
-Gemspec/RequireMFA:
-  Enabled: true
-
-Layout/LineEndStringConcatenationIndentation:
-  Enabled: true
-
-Layout/SpaceBeforeBrackets:
-  Enabled: true
-
-Lint/AmbiguousAssignment:
-  Enabled: true
-
-Lint/AmbiguousOperatorPrecedence:
-  Enabled: true
-
-Lint/AmbiguousRange:
-  Enabled: true
-
-Lint/DeprecatedConstants:
-  Enabled: true
-
-Lint/DuplicateBranch:
-  Enabled: true
-
-Lint/DuplicateRegexpCharacterClassElement:
-  Enabled: true
-
-Lint/EmptyBlock:
-  Enabled: true
-
-Lint/EmptyClass:
-  Enabled: true
-
-Lint/EmptyInPattern:
-  Enabled: true
-
-Lint/IncompatibleIoSelectWithFiberScheduler:
-  Enabled: true
-
-Lint/LambdaWithoutLiteralBlock:
-  Enabled: true
-
-Lint/NoReturnInBeginEndBlocks:
-  Enabled: true
-
-Lint/NumberedParameterAssignment:
-  Enabled: true
-
-Lint/OrAssignmentToConstant:
-  Enabled: true
-
-Lint/RedundantDirGlobSort:
-  Enabled: true
-
-Lint/RequireRelativeSelfPath:
-  Enabled: true
-
-Lint/SymbolConversion:
-  Enabled: true
-
-Lint/ToEnumArguments:
-  Enabled: true
-
-Lint/TripleQuotes:
-  Enabled: true
-
-Lint/UnexpectedBlockArity:
-  Enabled: true
-
-Lint/UnmodifiedReduceAccumulator:
-  Enabled: true
-
-Lint/UselessRuby2Keywords:
-  Enabled: true
-
-Naming/BlockForwarding:
-  Enabled: true
-
-Security/IoMethods:
-  Enabled: true
- 
-Style/AccessorGrouping:
-  Enabled: true
-  EnforcedStyle: separated
-
-Style/ArgumentsForwarding:
-  Enabled: true
-
-Style/CollectionCompact:
-  Enabled: true
-
-Style/DocumentDynamicEvalDefinition:
-  Enabled: true
-
-Style/EmptyCaseCondition:
-  Enabled: false
-
-Style/EndlessMethod:
-  Enabled: true
-
-Style/FileRead:
-  Enabled: true
-
-Style/FileWrite:
-  Enabled: true
-
-Style/HashConversion:
-  Enabled: true
-
-Style/HashExcept:
-  Enabled: true
-
-Style/IfWithBooleanLiteralBranches:
-  Enabled: true
-
-Style/InPatternThen:
-  Enabled: true
-
-Style/MapToHash:
-  Enabled: true
-
-Style/MultilineInPatternThen:
-  Enabled: true
-
-Style/NegatedIf:
-  Enabled: false
-
-Style/NegatedIfElseCondition:
-  Enabled: true
-
-Style/NilLambda:
-  Enabled: true
-
-Style/NumberedParameters:
-  Enabled: true
-
-Style/NumberedParametersLimit:
-  Enabled: true
-
-Style/OpenStructUse:
-  Enabled: true
-
-Style/QuotedSymbols:
-  Enabled: true
-
-Style/RedundantArgument:
-  Enabled: true
-
-Style/RedundantSelfAssignmentBranch:
-  Enabled: true
-
-Style/SelectByRegexp:
-  Enabled: true
-
-Style/StringChars:
-  Enabled: true
-
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-Style/StringLiteralsInInterpolation:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-Style/SwapValues:
-  Enabled: true
-
-Layout/LineLength:
-  Max: 120

data/.rubocop_todo.yml

@@ -1,17 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2022-02-06 20:52:48 UTC using RuboCop version 1.25.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 2
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
-Metrics/AbcSize:
-  Max: 25
-
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
-Metrics/MethodLength:
-  Max: 25

data/CHANGELOG.md

@@ -1,3 +0,0 @@
-## [0.1.0] - 2022-02-06
-
-- Initial release

data/Gemfile

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-source "https://rubygems.org"
-
-# Specify your gem's dependencies in thunderbird.gemspec
-gemspec
-
-gem "rake", "~> 13.0"
-
-gem "rspec", "~> 3.0"
-
-gem "rubocop", "~> 1.21"

data/Rakefile

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:spec)
-
-require "rubocop/rake_task"
-
-RuboCop::RakeTask.new
-
-task default: %i[spec rubocop]