thumbtack 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dfceebca8bd2653fbb6a32085aa3449e3a872c1d
-  data.tar.gz: f3be0d3c15e9f9ca487bba144f9192fe300941b2
+  metadata.gz: 865dedec8bc24d93f1134a1a4b0515decd1ab4cb
+  data.tar.gz: 55d72d32a1a29eeee1578fb3736ba20f643f721d
 SHA512:
-  metadata.gz: 57742f4274a670de859c45b9e4373176205d01ba219a1d8b0eccc3443ef61a8f171881c37917a8bb7a174fc531171c89163df9e7b65172f52c5bc2eef703c6e8
-  data.tar.gz: 392b5f79e1ecd490bf8fa7c336f48c150ba47b19c7f8c010c6be8eea4c8327d3239c3279fd5d4b95ce1fec6b1f3552a56e80581992740895c35e7a1e7d7dba8f
+  metadata.gz: 5eb64b30a1a0f11dc500e9e48017467f807026e6526278c046602424a65fdc1bbd419f634a46323b86994181d6d80de59fe91f67312f9717695bb1c12ce0288d
+  data.tar.gz: 4d9462b77cfe56905794db3e876c93bd20a487a4ed5d510de210f37c714a5efeea55c60bd12eb5fe6b1f75ca787075262965ca8afc4d6dd2c95d9dfcb27cfb63

data/lib/thumbtack/note.rb

@@ -47,7 +47,7 @@ module Thumbtack
     #
     # @api public
     def created_at
-      Types::DateTime.from_note_parameter(@created_at)
+      Types::DateTime.deserialize_from_note(@created_at)
     end
 
     # The time at which the note was last updated
@@ -59,7 +59,7 @@ module Thumbtack
     #
     # @api public
     def updated_at
-      Types::DateTime.from_note_parameter(@updated_at)
+      Types::DateTime.deserialize_from_note(@updated_at)
     end
 
     # 20 character hexadecimal SHA1 hash of the note text

data/lib/thumbtack/note_summary.rb

@@ -47,7 +47,7 @@ module Thumbtack
     #
     # @api public
     def created_at
-      Types::DateTime.from_note_parameter(@created_at)
+      Types::DateTime.deserialize_from_note(@created_at)
     end
 
     # The time at which the note was last updated
@@ -59,7 +59,7 @@ module Thumbtack
     #
     # @api public
     def updated_at
-      Types::DateTime.from_note_parameter(@updated_at)
+      Types::DateTime.deserialize_from_note(@updated_at)
     end
 
     # 20 character hexadecimal SHA1 hash of the note text

data/lib/thumbtack/post.rb

@@ -79,7 +79,7 @@ module Thumbtack
     #
     # @api public
     def time
-      Types::DateTime.from_parameter(@time)
+      Types::DateTime.deserialize(@time)
     end
 
     # If true, this post is public
@@ -91,7 +91,7 @@ module Thumbtack
     #
     # @api public
     def shared
-      Types::Boolean.from_parameter(@shared)
+      Types::Boolean.deserialize(@shared)
     end
 
     # If true, this post is marked unread
@@ -103,7 +103,7 @@ module Thumbtack
     #
     # @api public
     def toread
-      Types::Boolean.from_parameter(@toread)
+      Types::Boolean.deserialize(@toread)
     end
 
     # The tags for this post, space-seperated
@@ -115,7 +115,7 @@ module Thumbtack
     #
     # @api public
     def tags
-      Types::Tags.from_parameter(@tags)
+      Types::Tags.deserialize(@tags)
     end
 
     # Creates a new Post from a Hash

data/lib/thumbtack/posts.rb

@@ -25,7 +25,7 @@ module Thumbtack
     # @see https://pinboard.in/api/#posts_update
     def update
       response = @client.get('/posts/update')
-      Types::DateTime.from_parameter response.fetch('update_time')
+      Types::DateTime.deserialize response.fetch('update_time')
     end
 
     # Add a bookmark
@@ -249,7 +249,7 @@ module Thumbtack
     # @api private
     def dates_with_counts_from(response)
       entries = response.fetch('dates', EMPTY_HASH).map do |date, count|
-        [Types::Date.from_parameter(date), count.to_i]
+        [Types::Date.deserialize(date), count.to_i]
       end
       Hash[entries]
     end

data/lib/thumbtack/specification.rb

@@ -26,7 +26,7 @@ module Thumbtack
         arguments.map do |name, value|
           type_handler = @type_handlers.fetch(name)
           type_handler.validate(value)
-          [name, type_handler.to_parameter(value)]
+          [name, type_handler.serialize(value)]
         end
       ]
     end

data/lib/thumbtack/types/boolean.rb

@@ -32,7 +32,7 @@ module Thumbtack
       #
       # @return [String]
       #   'yes' if value is true, 'no' otherwise
-      def self.to_parameter(value)
+      def self.serialize(value)
         case value
         when TrueClass
           'yes'
@@ -47,7 +47,7 @@ module Thumbtack
       #   Either 'yes' or 'no'
       #
       # @return [Boolean]
-      def self.from_parameter(parameter)
+      def self.deserialize(parameter)
         case parameter
         when 'yes'
           true

data/lib/thumbtack/types/date.rb

@@ -33,7 +33,7 @@ module Thumbtack
       #
       # @return [String]
       #   the date with format yyyy-mm-dd
-      def self.to_parameter(value)
+      def self.serialize(value)
         value.xmlschema
       end
 
@@ -43,7 +43,7 @@ module Thumbtack
       #   the date with format yyyy-mm-dd
       #
       # @return [Date]
-      def self.from_parameter(parameter)
+      def self.deserialize(parameter)
         ::Date.xmlschema(parameter)
       end
     end

data/lib/thumbtack/types/date_time.rb

@@ -11,8 +11,10 @@ module Thumbtack
       EARLIEST = ::DateTime.new(1, 1, 1)
       # The latest allowable time
       LATEST = ::DateTime.new(2100, 1, 1)
-      # Pinboard's date format
+      # Pinboard's date time format
       FORMAT = '%Y-%m-%dT%H:%M:%SZ'.freeze
+      # Pinboard's date time format for notes
+      NOTE_FORMAT = '%Y-%m-%d %H:%M:%S'.freeze
 
       # Validate a time
       #
@@ -35,7 +37,7 @@ module Thumbtack
       #
       # @return [String]
       #   the time formatted yyyy-mm-ddTHH:MM:SSZ.
-      def self.to_parameter(value)
+      def self.serialize(value)
         value.strftime(FORMAT)
       end
 
@@ -45,7 +47,7 @@ module Thumbtack
       #   the time formatted yyyy-mm-ddTHH:MM:SSZ
       #
       # @return [DateTime]
-      def self.from_parameter(parameter)
+      def self.deserialize(parameter)
         ::DateTime.strptime(parameter)
       end
 
@@ -55,8 +57,8 @@ module Thumbtack
       #   the time formatted yyyy-mm-dd HH:MM:SS
       #
       # @return [DateTime]
-      def self.from_note_parameter(parameter)
-        ::DateTime.strptime(parameter, '%Y-%m-%d %H:%M:%S')
+      def self.deserialize_from_note(parameter)
+        ::DateTime.strptime(parameter, NOTE_FORMAT)
       end
     end
   end

data/lib/thumbtack/types/identity.rb

@@ -19,7 +19,7 @@ module Thumbtack
       #   the value to return
       #
       # @return [value]
-      def self.to_parameter(value)
+      def self.serialize(value)
         value
       end
 
@@ -29,7 +29,7 @@ module Thumbtack
       #   the parameter to return
       #
       # @return [parameter]
-      def self.from_parameter(parameter)
+      def self.deserialize(parameter)
         parameter
       end
     end

data/lib/thumbtack/types/tags.rb

@@ -40,7 +40,7 @@ module Thumbtack
       #
       # @return [String]
       #   space-separated list of tags
-      def self.to_parameter(value)
+      def self.serialize(value)
         Array(value).map(&:strip).join(SEPARATOR)
       end
 
@@ -50,7 +50,7 @@ module Thumbtack
       #   space-separated list of tags
       #
       # @return [Array<String>]
-      def self.from_parameter(parameter)
+      def self.deserialize(parameter)
         parameter.split(SEPARATOR)
       end
 

data/lib/thumbtack/version.rb

@@ -2,5 +2,5 @@
 
 module Thumbtack
   # Gem version
-  VERSION = '1.1.0'.freeze
+  VERSION = '1.1.1'.freeze
 end

data/test/test_helper.rb

@@ -13,7 +13,7 @@ end
 
 def mock_client_action(url, params)
   client = Minitest::Mock.new
-  client.expect(:action, { 'result' => 'done' }, [url, params].compact)
+  client.expect(:action, { 'result' => 'done' }, [url, params])
   client
 end
 

data/test/thumbtack/specification_test.rb

@@ -6,7 +6,7 @@ class SpecificationTest < Minitest::Test
   def test_parameters
     type_handler = Minitest::Mock.new
     type_handler.expect(:validate, type_handler, ['value'])
-    type_handler.expect(:to_parameter, 'parameterized', ['value'])
+    type_handler.expect(:serialize, 'parameterized', ['value'])
 
     assert_equal(
       { key: 'parameterized' },

data/test/thumbtack/types/boolean_test.rb

@@ -16,13 +16,13 @@ class BooleanTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
-    assert_equal 'yes', Types::Boolean.to_parameter(true)
-    assert_equal 'no', Types::Boolean.to_parameter(false)
+  def test_serialize
+    assert_equal 'yes', Types::Boolean.serialize(true)
+    assert_equal 'no', Types::Boolean.serialize(false)
   end
 
-  def test_from_parameter
-    assert_equal true, Types::Boolean.from_parameter('yes')
-    assert_equal false, Types::Boolean.from_parameter('no')
+  def test_deserialize
+    assert_equal true, Types::Boolean.deserialize('yes')
+    assert_equal false, Types::Boolean.deserialize('no')
   end
 end

data/test/thumbtack/types/date_test.rb

@@ -15,13 +15,13 @@ class DateTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
+  def test_serialize
     assert_equal '2010-12-11',
-                 Types::Date.to_parameter(::Date.new(2010, 12, 11))
+                 Types::Date.serialize(::Date.new(2010, 12, 11))
   end
 
-  def test_from_parameter
+  def test_deserialize
     assert_equal ::Date.new(2010, 12, 11),
-                 Types::Date.from_parameter('2010-12-11')
+                 Types::Date.deserialize('2010-12-11')
   end
 end

data/test/thumbtack/types/date_time_test.rb

@@ -15,19 +15,19 @@ class DateTimeTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
+  def test_serialize
     assert_equal '2010-12-11T19:48:02Z',
-                 Types::DateTime.to_parameter(
+                 Types::DateTime.serialize(
                    ::DateTime.new(2010, 12, 11, 19, 48, 2))
   end
 
-  def test_from_parameter
+  def test_deserialize
     assert_equal ::DateTime.new(2010, 12, 11, 19, 48, 2),
-                 Types::DateTime.from_parameter('2010-12-11T19:48:02Z')
+                 Types::DateTime.deserialize('2010-12-11T19:48:02Z')
   end
 
-  def test_from_note_parameter
+  def test_deserialize_from_note
     assert_equal ::DateTime.new(2010, 12, 11, 19, 48, 2),
-                 Types::DateTime.from_note_parameter('2010-12-11 19:48:02')
+                 Types::DateTime.deserialize_from_note('2010-12-11 19:48:02')
   end
 end

data/test/thumbtack/types/identity_test.rb

@@ -7,12 +7,12 @@ class IdentityTest < Minitest::Test
     assert_equal Types::Identity, Types::Identity.validate('any value')
   end
 
-  def test_to_parameter
-    assert_equal 'any value', Types::Identity.to_parameter('any value')
+  def test_serialize
+    assert_equal 'any value', Types::Identity.serialize('any value')
   end
 
-  def test_from_parameter
+  def test_deserialize
     assert_equal 'any parameter',
-                 Types::Identity.from_parameter('any parameter')
+                 Types::Identity.deserialize('any parameter')
   end
 end

data/test/thumbtack/types/integer_test.rb

@@ -16,11 +16,11 @@ class IntegerTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
-    assert_equal 42, Types::Integer.to_parameter(42)
+  def test_serialize
+    assert_equal 42, Types::Integer.serialize(42)
   end
 
-  def test_from_parameter
-    assert_equal 42, Types::Integer.from_parameter(42)
+  def test_deserialize
+    assert_equal 42, Types::Integer.deserialize(42)
   end
 end

data/test/thumbtack/types/md5_test.rb

@@ -16,13 +16,13 @@ class MD5Test < Minitest::Test
     end
   end
 
-  def test_to_parameter
+  def test_serialize
     assert_equal '437b930db84b8079c2dd804a71936b5f',
-                 Types::MD5.to_parameter('437b930db84b8079c2dd804a71936b5f')
+                 Types::MD5.serialize('437b930db84b8079c2dd804a71936b5f')
   end
 
-  def test_from_parameter
+  def test_deserialize
     assert_equal '437b930db84b8079c2dd804a71936b5f',
-                 Types::MD5.from_parameter('437b930db84b8079c2dd804a71936b5f')
+                 Types::MD5.deserialize('437b930db84b8079c2dd804a71936b5f')
   end
 end

data/test/thumbtack/types/tags_test.rb

@@ -17,13 +17,13 @@ class TagsTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
-    assert_equal 'one', Types::Tags.to_parameter('one')
-    assert_equal 'one two', Types::Tags.to_parameter(%w(one two))
-    assert_equal 'padding', Types::Tags.to_parameter([' padding '])
+  def test_serialize
+    assert_equal 'one', Types::Tags.serialize('one')
+    assert_equal 'one two', Types::Tags.serialize(%w(one two))
+    assert_equal 'padding', Types::Tags.serialize([' padding '])
   end
 
-  def test_from_parameter
-    assert_equal %w(one two), Types::Tags.from_parameter('one two')
+  def test_deserialize
+    assert_equal %w(one two), Types::Tags.deserialize('one two')
   end
 end

data/test/thumbtack/types/text_test.rb

@@ -12,11 +12,11 @@ class TextTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
-    assert_equal 'text', Types::Text.to_parameter('text')
+  def test_serialize
+    assert_equal 'text', Types::Text.serialize('text')
   end
 
-  def test_from_parameter
-    assert_equal 'text', Types::Text.from_parameter('text')
+  def test_deserialize
+    assert_equal 'text', Types::Text.deserialize('text')
   end
 end

data/test/thumbtack/types/title_test.rb

@@ -12,11 +12,11 @@ class TitleTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
-    assert_equal 'title', Types::Title.to_parameter('title')
+  def test_serialize
+    assert_equal 'title', Types::Title.serialize('title')
   end
 
-  def test_from_parameter
-    assert_equal 'title', Types::Title.from_parameter('title')
+  def test_deserialize
+    assert_equal 'title', Types::Title.deserialize('title')
   end
 end

data/test/thumbtack/types/url_test.rb

@@ -11,13 +11,13 @@ class URLTest < Minitest::Test
     end
   end
 
-  def test_to_parameter
+  def test_serialize
     value = 'http://pinboard.in'
-    assert_equal value, Types::URL.to_parameter(value)
+    assert_equal value, Types::URL.serialize(value)
   end
 
-  def test_from_parameter
+  def test_deserialize
     value = 'http://pinboard.in'
-    assert_equal value, Types::URL.from_parameter(value)
+    assert_equal value, Types::URL.deserialize(value)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thumbtack
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Nate Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-14 00:00:00.000000000 Z
+date: 2015-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.7
+        version: 0.4.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.7
+        version: 0.4.8
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.7.0
+        version: 5.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.7.0
+        version: 5.8.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -156,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: The best Pinboard API client