thumbtack 1.0.0 → 1.1.0

data/test/thumbtack/specification_test.rb

@@ -8,7 +8,8 @@ class SpecificationTest < Minitest::Test
     type_handler.expect(:validate, type_handler, ['value'])
     type_handler.expect(:to_parameter, 'parameterized', ['value'])
 
-    assert_equal({ key: 'parameterized' },
+    assert_equal(
+      { key: 'parameterized' },
       Specification.new(key: type_handler).parameters(key: 'value'))
     type_handler.verify
   end

data/test/thumbtack/suggestion_test.rb

@@ -5,12 +5,12 @@ require 'test_helper'
 class NoteSummaryTest < Minitest::Test
   def test_from_array
     array = [
-      { 'popular' => ['ifttt'] },
-      { 'recommended' => ['ifttt', 'twitter'] }
+      { 'popular' => %w(ifttt) },
+      { 'recommended' => %w(ifttt twitter) }
     ]
     suggestion = Suggestion.from_array(array)
 
-    assert_equal ['ifttt'], suggestion.popular
-    assert_equal ['ifttt', 'twitter'], suggestion.recommended
+    assert_equal %w(ifttt), suggestion.popular
+    assert_equal %w(ifttt twitter), suggestion.recommended
   end
 end

data/test/thumbtack/tags_test.rb

@@ -4,34 +4,38 @@ require 'test_helper'
 
 class TagsTest < Minitest::Test
   def test_update
-    client = mock_client_get('/tags/get',
-                         nil,
-                         {
-                           'activedesktop' => '1',
-                           'business' => '1',
-                           'radio' => '3',
-                           'xml' => '5',
-                           'xp' => '1',
-                           'xpi' => '1',
-                         })
+    client = mock_client_get(
+      '/tags/get',
+      nil,
+      'activedesktop' => '1',
+      'business' => '1',
+      'radio' => '3',
+      'xml' => '5',
+      'xp' => '1',
+      'xpi' => '1'
+    )
     tags = Tags.new(client)
 
-    assert_equal({
-      'activedesktop' => 1,
-      'business' => 1,
-      'radio' => 3,
-      'xml' => 5,
-      'xp' => 1,
-      'xpi' => 1,
-    }, tags.get)
+    assert_equal(
+      {
+        'activedesktop' => 1,
+        'business' => 1,
+        'radio' => 3,
+        'xml' => 5,
+        'xp' => 1,
+        'xpi' => 1
+      },
+      tags.get
+    )
 
     client.verify
   end
 
   def test_delete
-    client = mock_client_action('/tags/delete',
-                         { tag: 'argentina' },
-                         { 'result_code' => 'done' })
+    client = mock_client_action(
+      '/tags/delete',
+      tag: 'argentina'
+    )
     tags = Tags.new(client)
 
     assert_equal tags, tags.delete('argentina')
@@ -39,9 +43,11 @@ class TagsTest < Minitest::Test
   end
 
   def test_rename
-    client = mock_client_action('/tags/rename',
-                         { old: 'argentina', new: 'evita' },
-                         { 'result_code' => 'done' })
+    client = mock_client_action(
+      '/tags/rename',
+      old: 'argentina',
+      new: 'evita'
+    )
     tags = Tags.new(client)
 
     assert_equal tags, tags.rename('argentina', 'evita')

data/test/thumbtack/types/date_test.rb

@@ -17,11 +17,11 @@ class DateTest < Minitest::Test
 
   def test_to_parameter
     assert_equal '2010-12-11',
-      Types::Date.to_parameter(::Date.new(2010, 12, 11))
+                 Types::Date.to_parameter(::Date.new(2010, 12, 11))
   end
 
   def test_from_parameter
     assert_equal ::Date.new(2010, 12, 11),
-      Types::Date.from_parameter('2010-12-11')
+                 Types::Date.from_parameter('2010-12-11')
   end
 end

data/test/thumbtack/types/date_time_test.rb

@@ -17,16 +17,17 @@ class DateTimeTest < Minitest::Test
 
   def test_to_parameter
     assert_equal '2010-12-11T19:48:02Z',
-      Types::DateTime.to_parameter(::DateTime.new(2010, 12, 11, 19, 48, 2))
+                 Types::DateTime.to_parameter(
+                   ::DateTime.new(2010, 12, 11, 19, 48, 2))
   end
 
   def test_from_parameter
     assert_equal ::DateTime.new(2010, 12, 11, 19, 48, 2),
-      Types::DateTime.from_parameter('2010-12-11T19:48:02Z')
+                 Types::DateTime.from_parameter('2010-12-11T19:48:02Z')
   end
 
   def test_from_note_parameter
     assert_equal ::DateTime.new(2010, 12, 11, 19, 48, 2),
-      Types::DateTime.from_note_parameter('2010-12-11 19:48:02')
+                 Types::DateTime.from_note_parameter('2010-12-11 19:48:02')
   end
 end

data/test/thumbtack/types/identity_test.rb

@@ -13,6 +13,6 @@ class IdentityTest < Minitest::Test
 
   def test_from_parameter
     assert_equal 'any parameter',
-      Types::Identity.from_parameter('any parameter')
+                 Types::Identity.from_parameter('any parameter')
   end
 end

data/test/thumbtack/types/md5_test.rb

@@ -5,7 +5,7 @@ require 'test_helper'
 class MD5Test < Minitest::Test
   def test_validate
     assert_equal Types::MD5,
-      Types::MD5.validate('437b930db84b8079c2dd804a71936b5f')
+                 Types::MD5.validate('437b930db84b8079c2dd804a71936b5f')
 
     assert_raises(ValidationError) do
       Types::MD5.validate('0' * 33)
@@ -18,11 +18,11 @@ class MD5Test < Minitest::Test
 
   def test_to_parameter
     assert_equal '437b930db84b8079c2dd804a71936b5f',
-      Types::MD5.to_parameter('437b930db84b8079c2dd804a71936b5f')
+                 Types::MD5.to_parameter('437b930db84b8079c2dd804a71936b5f')
   end
 
   def test_from_parameter
     assert_equal '437b930db84b8079c2dd804a71936b5f',
-      Types::MD5.from_parameter('437b930db84b8079c2dd804a71936b5f')
+                 Types::MD5.from_parameter('437b930db84b8079c2dd804a71936b5f')
   end
 end

data/test/thumbtack/types/tags_test.rb

@@ -19,11 +19,11 @@ class TagsTest < Minitest::Test
 
   def test_to_parameter
     assert_equal 'one', Types::Tags.to_parameter('one')
-    assert_equal 'one two', Types::Tags.to_parameter(['one', 'two'])
+    assert_equal 'one two', Types::Tags.to_parameter(%w(one two))
     assert_equal 'padding', Types::Tags.to_parameter([' padding '])
   end
 
   def test_from_parameter
-    assert_equal ['one', 'two'], Types::Tags.from_parameter('one two')
+    assert_equal %w(one two), Types::Tags.from_parameter('one two')
   end
 end

data/test/thumbtack/types/text_test.rb

@@ -5,10 +5,10 @@ require 'test_helper'
 class TextTest < Minitest::Test
   def test_validate
     assert_equal Types::Text, Types::Text.validate('')
-    assert_equal Types::Text, Types::Text.validate('x' * 65536)
+    assert_equal Types::Text, Types::Text.validate('x' * 65_536)
 
     assert_raises(ValidationError) do
-      Types::Text.validate('x' * 65537)
+      Types::Text.validate('x' * 65_537)
     end
   end
 

data/test/thumbtack/user_test.rb

@@ -4,18 +4,22 @@ require 'test_helper'
 
 class UserTest < Minitest::Test
   def test_secret
-    client = mock_client_get('/user/secret',
-                         nil,
-                         { 'result' => '6493a84f72d86e7de130' })
+    client = mock_client_get(
+      '/user/secret',
+      nil,
+      'result' => '6493a84f72d86e7de130'
+    )
     user = User.new(client)
 
     assert_equal '6493a84f72d86e7de130', user.secret
   end
 
   def test_api_token
-    client = mock_client_get('/user/api_token',
-                         nil,
-                         { 'result' => 'XOG86E7JIYMI' })
+    client = mock_client_get(
+      '/user/api_token',
+      nil,
+      'result' => 'XOG86E7JIYMI'
+    )
     user = User.new(client)
 
     assert_equal 'XOG86E7JIYMI', user.api_token

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thumbtack
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Nate Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-02 00:00:00.000000000 Z
+date: 2015-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -24,34 +24,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.7
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.3.5
+        version: 5.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.3.5
+        version: 5.7.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.3.2
+        version: 10.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.3.2
+        version: 10.4.2
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -74,6 +88,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/thumbtack.rb
+- lib/thumbtack/adapters/basic_adapter.rb
 - lib/thumbtack/client.rb
 - lib/thumbtack/hash_to_digest.rb
 - lib/thumbtack/note.rb
@@ -83,8 +98,8 @@ files:
 - lib/thumbtack/posts.rb
 - lib/thumbtack/specification.rb
 - lib/thumbtack/suggestion.rb
+- lib/thumbtack/symbolize_keys.rb
 - lib/thumbtack/tags.rb
-- lib/thumbtack/types.rb
 - lib/thumbtack/types/boolean.rb
 - lib/thumbtack/types/date.rb
 - lib/thumbtack/types/date_time.rb
@@ -101,7 +116,7 @@ files:
 - lib/thumbtack/version.rb
 - test/test_helper.rb
 - test/thumbtack/client_test.rb
-- test/thumbtack/integration/client_test.rb
+- test/thumbtack/integration/basic_adapter_test.rb
 - test/thumbtack/note_summary_test.rb
 - test/thumbtack/note_test.rb
 - test/thumbtack/notes_test.rb
@@ -133,7 +148,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -141,14 +156,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.3.0
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: The best Pinboard API client
 test_files:
 - test/test_helper.rb
 - test/thumbtack/client_test.rb
-- test/thumbtack/integration/client_test.rb
+- test/thumbtack/integration/basic_adapter_test.rb
 - test/thumbtack/note_summary_test.rb
 - test/thumbtack/note_test.rb
 - test/thumbtack/notes_test.rb

data/lib/thumbtack/types.rb

@@ -1,9 +0,0 @@
-# encoding: utf-8
-
-module Thumbtack
-  # Handlers for each of the data types in the Pinboard API
-  #
-  # @see https://pinboard.in/api/#data
-  module Types
-  end
-end

data/test/thumbtack/integration/client_test.rb

@@ -1,29 +0,0 @@
-# encoding: utf-8
-
-require 'test_helper'
-
-module Integration
-  class ClientTest < Minitest::Test
-    def setup
-      path = File.expand_path('../../../auth_token.txt', __FILE__)
-      auth_token = File.open(path).read.strip
-      @username, @token = auth_token.split(':')
-      @client = Client.new(@username, @token)
-    end
-
-    def test_requests_return_parsed_json
-      response = @client.get('/user/api_token')
-      assert_equal({ 'result' => @token }, response)
-    end
-
-    def test_request_query_parameters
-      response = @client.get('/posts/recent', tag: 'thumbtack-test-query-params')
-      assert_equal([] , response['posts'])
-    end
-
-    def test_action_command_method
-      response = @client.action('/tags/delete', tag: 'thumbtack-test-command')
-      assert_equal(@client, response)
-    end
-  end
-end