thumbtack 0.0.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: af013ae7caf72e5d517bd5ce42ef097a804fca78
-  data.tar.gz: 35a058f9bc768ab4fadf48882993d3393dd5c627
+  metadata.gz: 223435e3e89fab503c5c9e5e42cb6debb6f29a5d
+  data.tar.gz: 769a2c552c39a0e87d35ef21c12afb475ab5029b
 SHA512:
-  metadata.gz: 73795d3553e3e56dd4cbd6d83cb9e9e47f90750c46963f703811d7a53a6e8019ab8aebf3693f8fe675219e6a8a05adb6779bbd3e2a7af917434a8af740407c85
-  data.tar.gz: a33adcc946c096f2e8dccfc3a34a166eec774a4006b396fd2a02a0107750424c7f7b495f3cb0be4c9437fcb7b34c53a78d7d6218d5d79a81e7e03661e6e52c8f
+  metadata.gz: 86c48c48a0008be9f3cea5d1143c42a7ea87915fd7a92459affc82823d26e355828942974ac9c7af81819998f6d6695c2dd26bb31eb225ef133f34802704c98e
+  data.tar.gz: 1a5f9d3a0d61918bcd5d4e546deb18dfe2808a281f96eec5e4ee6bfd41f15d3a739b925c55e609f3a338eea2ee7e94aed53fabfb55c34b77cd8a61c26787fb3b

data/lib/thumbtack.rb

@@ -2,6 +2,17 @@
 
 # A simple Pinboard API wrapper
 module Thumbtack
+  # Raised when the API rate limit has been reached
+  class RateLimitError < StandardError; end
+
+  # Raised when given an invalid parameter
+  class ValidationError < StandardError; end
+
+  # Raised when given an error from a Pinboard result code
+  #
+  # @see https://pinboard.in/api/#errors
+  class ResultError < StandardError; end
+
   # An empty Hash to use for default options
   EMPTY_HASH = {}.freeze
 
@@ -15,6 +26,8 @@ require 'net/http'
 require 'uri'
 
 require 'thumbtack/types'
+require 'thumbtack/types/range_validation'
+require 'thumbtack/types/length_validation'
 require 'thumbtack/types/boolean'
 require 'thumbtack/types/date'
 require 'thumbtack/types/date_time'
@@ -31,6 +44,7 @@ require 'thumbtack/suggestion'
 require 'thumbtack/posts'
 require 'thumbtack/tags'
 require 'thumbtack/user'
+require 'thumbtack/hash_to_digest'
 require 'thumbtack/note'
 require 'thumbtack/note_summary'
 require 'thumbtack/notes'

data/lib/thumbtack/client.rb

@@ -3,9 +3,6 @@
 module Thumbtack
   # Wraps each interaction with the Pinboard API
   class Client
-    # Raised when the API rate limit has been reached
-    class RateLimitError < StandardError; end
-
     # The status code for rate limited responses from the Pinboard API
     TOO_MANY_REQUESTS_CODE = '429'.freeze
 
@@ -14,6 +11,9 @@ module Thumbtack
 
     # Username used by the client to make authenticated requests
     #
+    # @example
+    #   client.username  # => 'maciej'
+    #
     # @return [String]
     #
     # @api public
@@ -21,6 +21,9 @@ module Thumbtack
 
     # Token used by the client to make authenticated requests
     #
+    # @example
+    #   client.token  # => 'C9044F4047891CEA74FE'
+    #
     # @return [String]
     #
     # @api public
@@ -61,10 +64,31 @@ module Thumbtack
       uri.query = URI.encode_www_form(params.merge(base_params))
 
       response = Net::HTTP.get_response(uri)
-      fail Client::RateLimitError if response.code == TOO_MANY_REQUESTS_CODE
+      fail RateLimitError if response.code == TOO_MANY_REQUESTS_CODE
       JSON.parse(response.body)
     end
 
+    # Perform an action request against the Pinboard API
+    #
+    # @param [String] path
+    #   the path to fetch from, relative to from the base Pinboard API URL
+    #
+    # @param [Hash] params
+    #   query parameters to append to the URL
+    #
+    # @return [Hash] the response parsed from the JSON
+    #
+    # @raise [RateLimitError] if the response is rate-limited
+    # @raise [ResultError] if the result code isn't "done"
+    #
+    # @api private
+    # @see https://pinboard.in/api/#errors
+    def action(path, params = EMPTY_HASH)
+      response = get(path, params)
+      fail ResultError, response['result'] unless response['result'] == 'done'
+      self
+    end
+
     # Access posts-related API calls
     #
     # @example

data/lib/thumbtack/hash_to_digest.rb

@@ -0,0 +1,22 @@
+module Thumbtack
+  # Handles renaming the hash attribute to digest from response hashes.
+  #
+  # @api private
+  class HashToDigest
+    # Rename any attribute called hash to digest
+    #
+    # @example
+    #   HashToDigest.rename('hash' => '1234')  # => { :digest => '1234' }
+    #
+    # @param [Hash{String => Object}]
+    #   reponse hash
+    #
+    # @return [Hash{Symbol => Object}]
+    #   a hash with any key named hash renamed to digest
+    def self.rename(hash)
+      attrs = hash.dup
+      digest = attrs.delete('hash')
+      Hash[attrs.map { |k, v| [k.to_sym, v] }].merge(digest: digest)
+    end
+  end
+end

data/lib/thumbtack/note.rb

@@ -20,6 +20,9 @@ module Thumbtack
 
     # The identifier for the note
     #
+    # @example
+    #   note.id  # => '8e5d6964bb810e0050b0'
+    #
     # @return [String]
     #
     # @api public
@@ -27,6 +30,9 @@ module Thumbtack
 
     # The title of the note
     #
+    # @example
+    #   note.title  # => 'StarCraft beta coming this week!'
+    #
     # @return [String]
     #
     # @api public
@@ -34,20 +40,33 @@ module Thumbtack
 
     # The time at which the note was created
     #
-    # @return [String]
+    # @example
+    #   note.created_at  # => #<DateTime: 2014-08-13T19:53:16+00:00...
+    #
+    # @return [DateTime]
     #
     # @api public
-    attr_reader :created_at
+    def created_at
+      Types::DateTime.from_note_parameter(@created_at)
+    end
 
     # The time at which the note was last updated
     #
-    # @return [String]
+    # @example
+    #   note.updated_at  # => #<DateTime: 2014-08-13T19:53:16+00:00...
+    #
+    # @return [DateTime]
     #
     # @api public
-    attr_reader :updated_at
+    def updated_at
+      Types::DateTime.from_note_parameter(@updated_at)
+    end
 
     # 20 character hexadecimal SHA1 hash of the note text
     #
+    # @example
+    #   note.digest  # => '0c9c30f60cadabd31415'
+    #
     # @return [String]
     #
     # @api public
@@ -55,6 +74,9 @@ module Thumbtack
 
     # The text of the note
     #
+    # @example
+    #   note.text  # => 'It was clear that readers showing up...
+    #
     # @return [String]
     #
     # @api public
@@ -62,6 +84,9 @@ module Thumbtack
 
     # The length of the note text
     #
+    # @example
+    #   note.length  # => 153
+    #
     # @return [Integer]
     #
     # @api public
@@ -77,9 +102,7 @@ module Thumbtack
     # @api private
     # @see Client#get
     def self.from_hash(hash)
-      attrs = hash.dup
-      digest = attrs.delete('hash')
-      new(Hash[attrs.map { |k, v| [k.to_sym, v] }].merge(digest: digest))
+      new(HashToDigest.rename(hash))
     end
 
     # Initialize a Note

data/lib/thumbtack/note_summary.rb

@@ -20,6 +20,9 @@ module Thumbtack
 
     # The identifier for the note
     #
+    # @example
+    #   note.id  # => '8e5d6964bb810e0050b0'
+    #
     # @return [String]
     #
     # @api public
@@ -27,6 +30,9 @@ module Thumbtack
 
     # The title of the note
     #
+    # @example
+    #   note.title  # => 'StarCraft beta coming this week!'
+    #
     # @return [String]
     #
     # @api public
@@ -34,20 +40,33 @@ module Thumbtack
 
     # The time at which the note was created
     #
-    # @return [String]
+    # @example
+    #   note.created_at  # => #<DateTime: 2014-08-13T19:53:16+00:00...
+    #
+    # @return [DateTime]
     #
     # @api public
-    attr_reader :created_at
+    def created_at
+      Types::DateTime.from_note_parameter(@created_at)
+    end
 
     # The time at which the note was last updated
     #
-    # @return [String]
+    # @example
+    #   note.updated_at  # => #<DateTime: 2014-08-13T19:53:16+00:00...
+    #
+    # @return [DateTime]
     #
     # @api public
-    attr_reader :updated_at
+    def updated_at
+      Types::DateTime.from_note_parameter(@updated_at)
+    end
 
     # 20 character hexadecimal SHA1 hash of the note text
     #
+    # @example
+    #   note.digest  # => '0c9c30f60cadabd31415'
+    #
     # @return [String]
     #
     # @api public
@@ -55,6 +74,9 @@ module Thumbtack
 
     # The length of the note text
     #
+    # @example
+    #   note.length  # => 153
+    #
     # @return [Integer]
     #
     # @api public
@@ -70,9 +92,7 @@ module Thumbtack
     # @api private
     # @see Client#get
     def self.from_hash(hash)
-      attrs = hash.dup
-      digest = attrs.delete('hash')
-      new(Hash[attrs.map { |k, v| [k.to_sym, v] }].merge(digest: digest))
+      new(HashToDigest.rename(hash))
     end
 
     # Initialize a NoteSummary

data/lib/thumbtack/post.rb

@@ -13,7 +13,7 @@ module Thumbtack
       :description,
       :extended,
       :meta,
-      :hash,
+      :digest,
       :time,
       :shared,
       :toread,
@@ -22,6 +22,9 @@ module Thumbtack
 
     # The url of the post
     #
+    # @example
+    #   post.href  # => 'http://pinboard.in'
+    #
     # @return [String]
     #
     # @api public
@@ -29,6 +32,9 @@ module Thumbtack
 
     # The title of the post
     #
+    # @example
+    #   post.description  # => 'Pinboard'
+    #
     # @return [String]
     #
     # @api public
@@ -36,12 +42,18 @@ module Thumbtack
 
     # The description of the post
     #
+    # @example
+    #   post.extended  # => 'antisocial bookmarking'
+    #
     # @return [String]
     #
     # @api public
     attr_reader :extended
 
-    # 32 character hexadecimal MD5 hash tag 'version' of the post
+    # 32 character hexadecimal MD5 hash change signature for the post
+    #
+    # @example
+    #   post.meta  # => '92959a96fd69146c5fe7cbde6e5720f2'
     #
     # @return [String]
     #
@@ -50,38 +62,61 @@ module Thumbtack
 
     # 32 character hexadecimal MD5 hash of the post URL
     #
+    # @example
+    #   post.digest  # => '92959a96fd69146c5fe7cbde6e5720f2'
+    #
     # @return [String]
     #
     # @api public
-    attr_reader :hash
+    attr_reader :digest
 
     # The time at which the post was created
     #
-    # @return [String]
+    # @example
+    #   post.time  # => #<DateTime: 2014-09-17T13:45:27+00:00...
+    #
+    # @return [DateTime]
     #
     # @api public
-    attr_reader :time
+    def time
+      Types::DateTime.from_parameter(@time)
+    end
 
     # If true, this post is public
     #
+    # @example
+    #   post.shared  # => true
+    #
     # @return [Boolean]
     #
     # @api public
-    attr_reader :shared
+    def shared
+      Types::Boolean.from_parameter(@shared)
+    end
 
     # If true, this post is marked unread
     #
+    # @example
+    #   post.toread  # => false
+    #
     # @return [Boolean]
     #
     # @api public
-    attr_reader :toread
+    def toread
+      Types::Boolean.from_parameter(@toread)
+    end
 
     # The tags for this post, space-seperated
     #
-    # @return [String]
+    # @example
+    #   post.tags  # => ['bookmarks', 'tools']
+    #
+    # @return [Array<String>]
     #
     # @api public
-    attr_reader :tags
+    def tags
+      Types::Tags.from_parameter(@tags)
+    end
 
     # Creates a new Post from a Hash
     #
@@ -93,7 +128,7 @@ module Thumbtack
     # @api private
     # @see Client#get
     def self.from_hash(hash)
-      new(Hash[hash.map { |key, value| [key.to_sym, value] }])
+      new(HashToDigest.rename(hash))
     end
 
     # Initialize a Post

data/lib/thumbtack/posts.rb

@@ -68,7 +68,7 @@ module Thumbtack
         shared: Types::Boolean,
         toread: Types::Boolean
       ).parameters({ url: url, description: description }.merge(options))
-      @client.get('/posts/add', parameters)
+      @client.action('/posts/add', parameters)
       self
     end
 
@@ -87,7 +87,7 @@ module Thumbtack
     # @see https://pinboard.in/api/#posts_delete
     def delete(url)
       parameters = Specification.new(url: Types::URL).parameters(url: url)
-      @client.get('/posts/delete', parameters)
+      @client.action('/posts/delete', parameters)
       self
     end
 
@@ -235,6 +235,11 @@ module Thumbtack
 
     private
 
+    # Create Post objects from posts response
+    #
+    # @return [Array<Post>]
+    #
+    # @api private
     def posts_from(response)
       response.fetch('posts', EMPTY_ARRAY).map do |post_hash|
         Post.from_hash(post_hash)

data/lib/thumbtack/specification.rb

@@ -14,8 +14,7 @@ module Thumbtack
       @type_handlers = type_handlers
     end
 
-    # Validate and translate user-provided parameters to their
-    # Pinboard-supported values
+    # Validate and translate client parameters to their Pinboard values
     #
     # @param [Hash{Symbol => Object}] arguments
     #   parameter names associated with their values

data/lib/thumbtack/suggestion.rb

@@ -17,6 +17,9 @@ module Thumbtack
 
     # A list of popular tags for URL
     #
+    # @example
+    #   suggestion.popular  # => ['blog', 'blogs', 'people']
+    #
     # @return [Array<String>]
     #
     # @api public
@@ -24,6 +27,9 @@ module Thumbtack
 
     # A list of recommended tags for the URL
     #
+    # @example
+    #   suggestion.recommended  # => ['blog', 'blogs', 'writing'...
+    #
     # @return [Array<String>]
     #
     # @api public

data/lib/thumbtack/tags.rb

@@ -44,7 +44,7 @@ module Thumbtack
     # @see https://pinboard.in/api/#tags_delete
     def delete(tag)
       parameters = Specification.new(tag: Types::Tags).parameters(tag: tag)
-      @client.get('/tags/delete', parameters)
+      @client.action('/tags/delete', parameters)
       self
     end
 
@@ -68,7 +68,7 @@ module Thumbtack
         old: Types::Tags,
         new: Types::Tags
       ).parameters(old: old, new: new)
-      @client.get('/tags/rename', parameters)
+      @client.action('/tags/rename', parameters)
       self
     end
   end

data/lib/thumbtack/types.rb

@@ -5,7 +5,5 @@ module Thumbtack
   #
   # @see https://pinboard.in/api/#data
   module Types
-    # Raised when given an argument that does not satisfy the type constraints
-    class ValidationError < StandardError; end
   end
 end

data/lib/thumbtack/types/date.rb

@@ -22,10 +22,7 @@ module Thumbtack
       # @raise [Types::ValidationError]
       #   if the date is not between 0001-01-01 and 2100-01-01
       def self.validate(value)
-        unless value > EARLIEST && value < LATEST
-          fail ValidationError,
-               "#{value} must be between 0001-01-01 and 2100-01-01"
-        end
+        RangeValidation.validate value, EARLIEST..LATEST
         self
       end
 

data/lib/thumbtack/types/date_time.rb

@@ -24,10 +24,7 @@ module Thumbtack
       # @raise [Types::ValidationError]
       #   if the time is not between 0001-01-01 00:00:00 and 2100-01-01 00:00:00
       def self.validate(value)
-        unless value > EARLIEST && value < LATEST
-          fail ValidationError,
-               "#{value} must be between 0001-01-01 and 2100-01-01"
-        end
+        RangeValidation.validate value, EARLIEST..LATEST
         self
       end
 
@@ -51,6 +48,16 @@ module Thumbtack
       def self.from_parameter(parameter)
         ::DateTime.strptime(parameter)
       end
+
+      # Convert a parameter from Pinboard's notes to a datetime value
+      #
+      # @param [String] parameter
+      #   the time formatted yyyy-mm-dd HH:MM:SS
+      #
+      # @return [DateTime]
+      def self.from_note_parameter(parameter)
+        ::DateTime.strptime(parameter, '%Y-%m-%d %H:%M:%S')
+      end
     end
   end
 end

data/lib/thumbtack/types/identity.rb

@@ -15,6 +15,9 @@ module Thumbtack
 
       # Value is returned unconverted
       #
+      # @param [Object] value
+      #   the value to return
+      #
       # @return [value]
       def self.to_parameter(value)
         value
@@ -22,6 +25,9 @@ module Thumbtack
 
       # Parameter is returned unconverted
       #
+      # @param [Object] parameter
+      #   the parameter to return
+      #
       # @return [parameter]
       def self.from_parameter(parameter)
         parameter

data/lib/thumbtack/types/integer.rb

@@ -21,9 +21,7 @@ module Thumbtack
       # @raise [Types::ValidationError]
       #   if the value is not between 0 and 2^32
       def self.validate(value)
-        unless value >= MIN && value <= MAX
-          fail ValidationError, "#{value} must be in range 0..2^32"
-        end
+        RangeValidation.validate value, MIN..MAX
         self
       end
     end

data/lib/thumbtack/types/length_validation.rb

@@ -0,0 +1,27 @@
+module Thumbtack
+  module Types
+    # Handles validation of values within a certain range
+    # Pinboard
+    #
+    # @api private
+    class LengthValidation
+      # Validate a value
+      #
+      # @param [Object] length
+      #   the maximum length
+      # @param [Object] value
+      #   the value to validate
+      #
+      # @return [undefined]
+      #
+      # @raise [Types::ValidationError]
+      #   if the value is not between 0001-01-01 and 2100-01-01
+      def self.validate(value, length)
+        unless value.length <= length
+          fail ValidationError,
+               "#{value} cannot be greater than #{length} characters"
+        end
+      end
+    end
+  end
+end

data/lib/thumbtack/types/range_validation.rb

@@ -0,0 +1,30 @@
+module Thumbtack
+  module Types
+    # Handles validation of values within a certain range
+    # Pinboard
+    #
+    # @api private
+    class RangeValidation
+      # Validate a value
+      #
+      # @example
+      #   RangeValidation.validate((1..2), 3)  # => ValidationError raised
+      #
+      # @param [Object] value
+      #   the value to validate
+      # @param [Range] range
+      #   the range of valid values
+      #
+      # @return [undefined]
+      #
+      # @raise [Types::ValidationError]
+      #   if the value is not between 0001-01-01 and 2100-01-01
+      def self.validate(value, range)
+        unless range.cover?(value)
+          fail ValidationError,
+               "#{value} must be between #{range.begin} and #{range.end}"
+        end
+      end
+    end
+  end
+end

data/lib/thumbtack/types/text.rb

@@ -19,10 +19,7 @@ module Thumbtack
       # @raise [Types::ValidationError]
       #   if the value is longer than 65536 characters
       def self.validate(value)
-        unless value.length <= MAXIMUM_LENGTH
-          fail ValidationError,
-               "#{value} cannot be greater than #{MAXIMUM_LENGTH} characters"
-        end
+        LengthValidation.validate value, MAXIMUM_LENGTH
         self
       end
     end

data/lib/thumbtack/types/title.rb

@@ -19,10 +19,7 @@ module Thumbtack
       # @raise [Types::ValidationError]
       #   if the value is longer than 255 characters
       def self.validate(value)
-        unless value.length <= MAXIMUM_LENGTH
-          fail ValidationError,
-               "#{value} cannot be greater than #{MAXIMUM_LENGTH} characters"
-        end
+        LengthValidation.validate value, MAXIMUM_LENGTH
         self
       end
     end

data/lib/thumbtack/version.rb

@@ -2,5 +2,5 @@
 
 module Thumbtack
   # Gem version
-  VERSION = '0.0.3'.freeze
+  VERSION = '1.0.0'.freeze
 end

data/test/test_helper.rb

@@ -5,10 +5,16 @@ CodeClimate::TestReporter.start
 require 'thumbtack'
 require 'minitest/autorun'
 
-def mock_client(url, params, response)
+def mock_client_get(url, params, response)
   client = Minitest::Mock.new
   client.expect(:get, response, [url, params].compact)
   client
 end
 
+def mock_client_action(url, params, response)
+  client = Minitest::Mock.new
+  client.expect(:action, response, [url, params].compact)
+  client
+end
+
 include Thumbtack

data/test/thumbtack/integration/client_test.rb

@@ -17,8 +17,13 @@ module Integration
     end
 
     def test_request_query_parameters
-      response = @client.get('/tags/delete', tag: 'thumbtack-test-query-params')
-      assert_equal({ 'result' => 'done' }, response)
+      response = @client.get('/posts/recent', tag: 'thumbtack-test-query-params')
+      assert_equal([] , response['posts'])
+    end
+
+    def test_action_command_method
+      response = @client.action('/tags/delete', tag: 'thumbtack-test-command')
+      assert_equal(@client, response)
     end
   end
 end

data/test/thumbtack/note_summary_test.rb

@@ -17,8 +17,8 @@ class NoteSummaryTest < Minitest::Test
     assert_equal '8e5d6964bb810e0050b0', note.id
     assert_equal 'StarCraft beta coming this week!', note.title
     assert_equal '0c9c30f60cadabd31415', note.digest
-    assert_equal '2010-02-11 03:46:56', note.created_at
-    assert_equal '2010-02-11 03:47:47', note.updated_at
+    assert_equal DateTime.new(2010, 2, 11, 3, 46, 56), note.created_at
+    assert_equal DateTime.new(2010, 2, 11, 3, 47, 47), note.updated_at
     assert_equal 19, note.length
   end
 end

data/test/thumbtack/note_test.rb

@@ -18,8 +18,8 @@ class NoteTest < Minitest::Test
     assert_equal '8e5d6964bb810e0050b0', note.id
     assert_equal 'StarCraft beta coming this week!', note.title
     assert_equal '0c9c30f60cadabd31415', note.digest
-    assert_equal '2010-02-11 03:46:56', note.created_at
-    assert_equal '2010-02-11 03:47:47', note.updated_at
+    assert_equal DateTime.new(2010, 2, 11, 3, 46, 56), note.created_at
+    assert_equal DateTime.new(2010, 2, 11, 3, 47, 47), note.updated_at
     assert_equal 19, note.length
     assert_equal 'This is a test note', note.text
   end

data/test/thumbtack/notes_test.rb

@@ -4,7 +4,7 @@ require 'test_helper'
 
 class NotesTest < Minitest::Test
   def test_list
-    client = mock_client('/notes/list',
+    client = mock_client_get('/notes/list',
                          nil,
                          {
                            'count' => 2,
@@ -36,7 +36,7 @@ class NotesTest < Minitest::Test
   end
 
   def test_get
-    client = mock_client('/notes/8e5d6964bb810e0050b0',
+    client = mock_client_get('/notes/8e5d6964bb810e0050b0',
                          nil,
                          {
                            'id' => '8e5d6964bb810e0050b0',

data/test/thumbtack/post_test.rb

@@ -13,7 +13,7 @@ class PostTest < Minitest::Test
       'time' => '2014-06-29T16:57:45Z',
       'shared' => 'yes',
       'toread' => 'no',
-      'tags' => 'test123'
+      'tags' => 'test123 another'
     }
     post = Post.from_hash(hash)
 
@@ -21,10 +21,10 @@ class PostTest < Minitest::Test
     assert_equal 'example.org', post.description
     assert_equal '', post.extended
     assert_equal '46ca40b9b92ee0ea1284785a5d2a9b38', post.meta
-    assert_equal 'dab521de65f9250b4cca7383feef67dc', post.hash
-    assert_equal '2014-06-29T16:57:45Z', post.time
-    assert_equal 'yes', post.shared
-    assert_equal 'no', post.toread
-    assert_equal 'test123', post.tags
+    assert_equal 'dab521de65f9250b4cca7383feef67dc', post.digest
+    assert_equal DateTime.new(2014, 6, 29, 16, 57, 45), post.time
+    assert_equal true, post.shared
+    assert_equal false, post.toread
+    assert_equal ['test123', 'another'], post.tags
   end
 end

data/test/thumbtack/posts_test.rb

@@ -4,7 +4,7 @@ require 'test_helper'
 
 class PostsTest < Minitest::Test
   def test_update
-    client = mock_client('/posts/update',
+    client = mock_client_get('/posts/update',
                          nil,
                          { 'update_time' => '2014-06-26T19:01:33Z' })
     posts = Posts.new(client)
@@ -14,7 +14,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_add
-    client = mock_client('/posts/add',
+    client = mock_client_action('/posts/add',
                          { url: 'http://example.org',
                            description: 'example.org' },
                          { 'result_code' => 'done' })
@@ -25,7 +25,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_add_with_tags
-    client = mock_client('/posts/add',
+    client = mock_client_action('/posts/add',
                          { url: 'http://example.org',
                            description: 'example.org',
                            tags: 'thumbtack test' },
@@ -38,7 +38,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_delete
-    client = mock_client('/posts/delete',
+    client = mock_client_action('/posts/delete',
                          { url: 'http://example.org' },
                          { 'result_code' => 'done' })
     posts = Posts.new(client)
@@ -48,7 +48,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_get
-    client = mock_client('/posts/get',
+    client = mock_client_get('/posts/get',
                          { url: 'http://example.org' },
                          {
                            'date' => '2014-06-29T16:57:45Z',
@@ -74,7 +74,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_recent
-    client = mock_client('/posts/recent',
+    client = mock_client_get('/posts/recent',
                          {tag: 'webdev'},
                          {
                            'date' => '2014-06-29T16:57:45Z',
@@ -100,7 +100,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_all
-    client = mock_client('/posts/all',
+    client = mock_client_get('/posts/all',
                          {tag: 'webdev'},
                          [{
                            'href' => 'http://example.org',
@@ -122,7 +122,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_suggest
-    client = mock_client('/posts/suggest',
+    client = mock_client_get('/posts/suggest',
                          {url: 'http://blog.com'},
                          [
                            { 'popular' => ['blog', 'blogs', 'people'] },
@@ -137,7 +137,7 @@ class PostsTest < Minitest::Test
   end
 
   def test_dates
-    client = mock_client('/posts/dates',
+    client = mock_client_get('/posts/dates',
                          {tag: 'argentina'},
                          {
                            'user' => 'user',

data/test/thumbtack/tags_test.rb

@@ -4,7 +4,7 @@ require 'test_helper'
 
 class TagsTest < Minitest::Test
   def test_update
-    client = mock_client('/tags/get',
+    client = mock_client_get('/tags/get',
                          nil,
                          {
                            'activedesktop' => '1',
@@ -29,7 +29,7 @@ class TagsTest < Minitest::Test
   end
 
   def test_delete
-    client = mock_client('/tags/delete',
+    client = mock_client_action('/tags/delete',
                          { tag: 'argentina' },
                          { 'result_code' => 'done' })
     tags = Tags.new(client)
@@ -39,7 +39,7 @@ class TagsTest < Minitest::Test
   end
 
   def test_rename
-    client = mock_client('/tags/rename',
+    client = mock_client_action('/tags/rename',
                          { old: 'argentina', new: 'evita' },
                          { 'result_code' => 'done' })
     tags = Tags.new(client)

data/test/thumbtack/types/boolean_test.rb

@@ -7,11 +7,11 @@ class BooleanTest < Minitest::Test
     assert_equal Types::Boolean, Types::Boolean.validate(true)
     assert_equal Types::Boolean, Types::Boolean.validate(false)
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Boolean.validate('nope')
     end
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Boolean.validate(nil)
     end
   end

data/test/thumbtack/types/date_test.rb

@@ -6,11 +6,11 @@ class DateTest < Minitest::Test
   def test_validate
     assert_equal Types::Date, Types::Date.validate(::Date.today)
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Date.validate ::Date.new(0, 1, 1)
     end
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Date.validate ::Date.new(2101, 1, 1)
     end
   end

data/test/thumbtack/types/date_time_test.rb

@@ -6,11 +6,11 @@ class DateTimeTest < Minitest::Test
   def test_validate
     assert_equal Types::DateTime, Types::DateTime.validate(::DateTime.now)
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::DateTime.validate ::DateTime.new(0, 1, 1)
     end
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::DateTime.validate ::DateTime.new(2101, 1, 1)
     end
   end
@@ -24,4 +24,9 @@ class DateTimeTest < Minitest::Test
     assert_equal ::DateTime.new(2010, 12, 11, 19, 48, 2),
       Types::DateTime.from_parameter('2010-12-11T19:48:02Z')
   end
+
+  def test_from_note_parameter
+    assert_equal ::DateTime.new(2010, 12, 11, 19, 48, 2),
+      Types::DateTime.from_note_parameter('2010-12-11 19:48:02')
+  end
 end

data/test/thumbtack/types/integer_test.rb

@@ -7,11 +7,11 @@ class IntegerTest < Minitest::Test
     assert_equal Types::Integer, Types::Integer.validate(0)
     assert_equal Types::Integer, Types::Integer.validate(2**32)
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Integer.validate(-1)
     end
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Integer.validate(2**32 + 1)
     end
   end

data/test/thumbtack/types/md5_test.rb

@@ -7,11 +7,11 @@ class MD5Test < Minitest::Test
     assert_equal Types::MD5,
       Types::MD5.validate('437b930db84b8079c2dd804a71936b5f')
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::MD5.validate('0' * 33)
     end
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::MD5.validate('gggggggggggggggggggggggggggggggg')
     end
   end

data/test/thumbtack/types/tags_test.rb

@@ -8,11 +8,11 @@ class TagsTest < Minitest::Test
     assert_equal Types::Tags, Types::Tags.validate(['argentina'])
     assert_equal Types::Tags, Types::Tags.validate(['.private'])
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Tags.validate [('x' * 256)]
     end
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Tags.validate ['comma,']
     end
   end

data/test/thumbtack/types/text_test.rb

@@ -7,7 +7,7 @@ class TextTest < Minitest::Test
     assert_equal Types::Text, Types::Text.validate('')
     assert_equal Types::Text, Types::Text.validate('x' * 65536)
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Text.validate('x' * 65537)
     end
   end

data/test/thumbtack/types/title_test.rb

@@ -7,7 +7,7 @@ class TitleTest < Minitest::Test
     assert_equal Types::Title, Types::Title.validate('')
     assert_equal Types::Title, Types::Title.validate('x' * 255)
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::Title.validate('x' * 256)
     end
   end

data/test/thumbtack/types/url_test.rb

@@ -6,7 +6,7 @@ class URLTest < Minitest::Test
   def test_validate
     assert_equal Types::URL, Types::URL.validate('http://pinboard.in')
 
-    assert_raises(Types::ValidationError) do
+    assert_raises(ValidationError) do
       Types::URL.validate('scp://pinboard.in')
     end
   end

data/test/thumbtack/user_test.rb

@@ -4,7 +4,7 @@ require 'test_helper'
 
 class UserTest < Minitest::Test
   def test_secret
-    client = mock_client('/user/secret',
+    client = mock_client_get('/user/secret',
                          nil,
                          { 'result' => '6493a84f72d86e7de130' })
     user = User.new(client)
@@ -13,7 +13,7 @@ class UserTest < Minitest::Test
   end
 
   def test_api_token
-    client = mock_client('/user/api_token',
+    client = mock_client_get('/user/api_token',
                          nil,
                          { 'result' => 'XOG86E7JIYMI' })
     user = User.new(client)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thumbtack
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 1.0.0
 platform: ruby
 authors:
 - Nate Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-29 00:00:00.000000000 Z
+date: 2014-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - lib/thumbtack.rb
 - lib/thumbtack/client.rb
+- lib/thumbtack/hash_to_digest.rb
 - lib/thumbtack/note.rb
 - lib/thumbtack/note_summary.rb
 - lib/thumbtack/notes.rb
@@ -89,7 +90,9 @@ files:
 - lib/thumbtack/types/date_time.rb
 - lib/thumbtack/types/identity.rb
 - lib/thumbtack/types/integer.rb
+- lib/thumbtack/types/length_validation.rb
 - lib/thumbtack/types/md5.rb
+- lib/thumbtack/types/range_validation.rb
 - lib/thumbtack/types/tags.rb
 - lib/thumbtack/types/text.rb
 - lib/thumbtack/types/title.rb