thumbs_up 0.6.7 → 0.6.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 464148d08066dd7089e51825a2024c8048f727de
-  data.tar.gz: 6d27f12fe8acee4b7fb006549a0d24e820484ccb
+  metadata.gz: 9b4c6157fab12e707bdf8d681ccb3033ab05deba
+  data.tar.gz: 4c13e8131cb4f9d897ff097b756aad21c9cb2fcd
 SHA512:
-  metadata.gz: cec0d3ddfd4102a86b52c116d4f342d8f3c0e5cb323fc761f327744959d6378925ca098a99f1023503c39bef5383e6fd2ed3788b4f82d2cf899ebe362006c5cc
-  data.tar.gz: 7a01b8de0f56bfa0ad9b76fb018c722dd1f5807548dd6ba323bff20591b1447370b09764a2e751ab3eb4ba4b62303aa03cc475a55306f1170910e70e539affcf
+  metadata.gz: e8fd16303bc0b5a878ee487e4872760defb9e83673bae944b75e88ec84773b6adcc9ad428ea75e929cbf0644cf68fe1ad234246be7f0b22e75e38730bd0f1912
+  data.tar.gz: f7a186650adf759f1e0ba58f996f43e204bfc677af28446d9ef9c298735f64bd0c29dac18e88be5d1c7280712f11def965020c5b3a98e03462cda6c91f72e82f

data/LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2014 Brady Bouchard (brady@thewellinspired.com)
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -23,28 +23,31 @@ Installation
 ============
 
 ### Require the gem:
-
-    gem 'thumbs_up'
+```shell
+gem 'thumbs_up'
+```
 
 ### Create and run the ThumbsUp migration:
-
-    rails generate thumbs_up
-    rake db:migrate
+```shell
+rails generate thumbs_up
+rake db:migrate
+```
 
 Configuration
 =============
 
 The relationship setup by the acts_as_voteable and acts_as_voter mixins both default to `votes`.  This causes one to obscure the other if you have a single class that votes on other instances of the same class.  If you have this scenario:
-
-    class User < ActiveRecord::Base
-      acts_as_voter     # relationship :votes will be obscured by the same named relationship from acts_as_voteable :(
-      acts_as_voteable
-    end
-
+```ruby
+class User < ActiveRecord::Base
+  acts_as_voter     # relationship :votes will be obscured by the same named relationship from acts_as_voteable :(
+  acts_as_voteable
+end
+```
 Configure alternate relationship names in an initializer at `config/initializers/thumbs_up.rb`:
-
-    ThumbsUp.configuration.voteable_relationship_name = :votes_on   # defaults to :votes
-    ThumbsUp.configuration.voter_relationship_name =    :votes_by   # defaults to :votes
+```ruby
+ThumbsUp.configuration.voteable_relationship_name = :votes_on   # defaults to :votes
+ThumbsUp.configuration.voter_relationship_name =    :votes_by   # defaults to :votes
+```
 
 
 Usage
@@ -53,84 +56,94 @@ Usage
 ## Getting Started
 
 ### Turn your AR models into something that can be voted upon.
+```ruby
+class SomeModel < ActiveRecord::Base
+  acts_as_voteable
+end
 
-    class SomeModel < ActiveRecord::Base
-      acts_as_voteable
-    end
-
-    class Question < ActiveRecord::Base
-      acts_as_voteable
-    end
+class Question < ActiveRecord::Base
+  acts_as_voteable
+end
+```
 
 ### Turn your Users (or any other model) into voters.
-
-    class User < ActiveRecord::Base
-      acts_as_voter
-      # The following line is optional, and tracks karma (up votes) for questions this user has submitted.
-      # Each question has a submitter_id column that tracks the user who submitted it.
-      # The option :weight value will be multiplied to any karma from that voteable model (defaults to 1).
-      # You can track any voteable model.
-      has_karma :questions, :as => :submitter, :weight => 0.5
-      # Karma by default is only calculated from upvotes. If you pass an array to the weight option, you can count downvotes as well (below, downvotes count for half as much karma against you):
-      has_karma :questions, :as => :submitter, :weight => [ 1, 0.5 ]
-    end
-
-    class Robot < ActiveRecord::Base
-      acts_as_voter
-    end
+```ruby
+class User < ActiveRecord::Base
+  acts_as_voter
+  # The following line is optional, and tracks karma (up votes) for questions this user has submitted.
+  # Each question has a submitter_id column that tracks the user who submitted it.
+  # The option :weight value will be multiplied to any karma from that voteable model (defaults to 1).
+  # You can track any voteable model.
+  has_karma :questions, :as => :submitter, :weight => 0.5
+  # Karma by default is only calculated from upvotes. If you pass an array to the weight option, you can count downvotes as well (below, downvotes count for half as much karma against you):
+  has_karma :questions, :as => :submitter, :weight => [ 1, 0.5 ]
+end
+
+class Robot < ActiveRecord::Base
+  acts_as_voter
+end
+```
 
 ### To cast a vote for a Model you can do the following:
 
 #### Shorthand syntax
-    voter.vote_for(voteable)     	# Adds a +1 vote
-    voter.vote_against(voteable) 	# Adds a -1 vote
-    voter.vote(voteable, vote) 	# Adds either a +1 or -1 vote: vote => true (+1), vote => false (-1)
+```ruby
+voter.vote_for(voteable)     	# Adds a +1 vote
+voter.vote_against(voteable) 	# Adds a -1 vote
+voter.vote(voteable, vote) 	# Adds either a +1 or -1 vote: vote => true (+1), vote => false (-1)
 
-    voter.vote_exclusively_for(voteable)	# Removes any previous votes by that particular voter, and votes for.
-    voter.vote_exclusively_against(voteable)	# Removes any previous votes by that particular voter, and votes against.
+voter.vote_exclusively_for(voteable)	# Removes any previous votes by that particular voter, and votes for.
+voter.vote_exclusively_against(voteable)	# Removes any previous votes by that particular voter, and votes against.
 
-    voter.unvote_for(voteable)  # Clears all votes for that user
+voter.unvote_for(voteable)  # Clears all votes for that user
+```
 
 ### Querying votes
 
 Did the first user vote for the Car with id = 2 already?
-
-    u = User.first
-    u.vote_for(Car.find(2))
-    u.voted_on?(Car.find(2)) #=> true
+```ruby
+u = User.first
+u.vote_for(Car.find(2))
+u.voted_on?(Car.find(2)) #=> true
+```
 
 Did the first user vote for or against the Car with id = 2?
-
-    u = User.first
-    u.vote_for(Car.find(2))
-    u.voted_for?(Car.find(2)) #=> true
-    u.voted_against?(Car.find(2)) #=> false
+```ruby
+u = User.first
+u.vote_for(Car.find(2))
+u.voted_for?(Car.find(2)) #=> true
+u.voted_against?(Car.find(2)) #=> false
+```
 
 Or check directly!
+```ruby
+u = User.first
+u.vote_for(Car.find(2))
+u.voted_how?(Car.find(2)) #=> true, if voted_for
 
-    u = User.first
-    u.vote_for(Car.find(2))
-    u.voted_how?(Car.find(2)) #=> true, if voted_for
-
-    u.vote_against(Car.find(3))
-    u.voted_how?(Car.find(3)) #=> false, if voted_against
+u.vote_against(Car.find(3))
+u.voted_how?(Car.find(3)) #=> false, if voted_against
 
-    u.vote_for(Car.find(4))
-    u.voted_how?(Car.find(4)) #=> nil, if didn't vote for it
+u.vote_for(Car.find(4))
+u.voted_how?(Car.find(4)) #=> nil, if didn't vote for it
+```
 
 in case you use `--unique-voting false` (documented below):
-
-    u.voted_how?(Car.find(2)) #=> [false, true, true, false]
+```ruby
+u.voted_how?(Car.find(2)) #=> [false, true, true, false]
+```
 
 #### Tallying Votes
 
 You can easily retrieve voteable object collections based on the properties of their votes:
-
-    @items = Item.tally.limit(10).where('created_at > ?', 2.days.ago).having('COUNT(votes.id) < 10')
+```ruby
+@items = Item.tally.limit(10).where('created_at > ?', 2.days.ago).having('COUNT(votes.id) < 10')
+```
 
 Or for MySQL:
-
-    @items = Item.tally.limit(10).where('created_at > ?', 2.days.ago).having('vote_count < 10')
+```ruby
+@items = Item.tally.limit(10).where('created_at > ?', 2.days.ago).having('vote_count < 10')
+```
 
 This will select the Items with less than 10 votes, the votes having been cast within the last two days, with a limit of 10 items. *This tallies all votes, regardless of whether they are +1 (up) or -1 (down).* The #tally method returns an ActiveRecord Relation, so you can chain the normal method calls on to it.
 
@@ -139,21 +152,23 @@ This will select the Items with less than 10 votes, the votes having been cast w
 **You most likely want to use this over the normal tally**
 
 This is similar to tallying votes, but this will return voteable object collections based on the sum of the differences between up and down votes (ups are +1, downs are -1). For Instance, a voteable with 3 upvotes and 2 downvotes will have a plusminus_tally of 1.
-
-    @items = Item.plusminus_tally.limit(10).where('created_at > ?', 2.days.ago).having('plusminus_tally > 10')
+```ruby
+@items = Item.plusminus_tally.limit(10).where('created_at > ?', 2.days.ago).having('plusminus_tally > 10')
+```
 
 #### Lower level queries
+```ruby
+positiveVoteCount = voteable.votes_for
+negativeVoteCount = voteable.votes_against
+# Votes for minus votes against. If you want more than a few model instances' worth, use `plusminus_tally` instead.
+plusminus         = voteable.plusminus
 
-    positiveVoteCount = voteable.votes_for
-    negativeVoteCount = voteable.votes_against
-    # Votes for minus votes against. If you want more than a few model instances' worth, use `plusminus_tally` instead.
-    plusminus         = voteable.plusminus
-
-	voter.voted_for?(voteable) # True if the voter voted for this object.
-	voter.vote_count(:up | :down | :all) # returns the count of +1, -1, or all votes
+voter.voted_for?(voteable) # True if the voter voted for this object.
+voter.vote_count(:up | :down | :all) # returns the count of +1, -1, or all votes
 
-	voteable.voted_by?(voter) # True if the voter voted for this object.
-	@voters = voteable.voters_who_voted
+voteable.voted_by?(voter) # True if the voter voted for this object.
+@voters = voteable.voters_who_voted
+```
 
 
 ### One vote per user!
@@ -161,16 +176,18 @@ This is similar to tallying votes, but this will return voteable object collecti
 ThumbsUp by default only allows one vote per user. This can be changed by removing:
 
 #### In vote.rb:
-
-    validates_uniqueness_of :voteable_id, :scope => [:voteable_type, :voter_type, :voter_id]
+```ruby
+validates_uniqueness_of :voteable_id, :scope => [:voteable_type, :voter_type, :voter_id]
+```
 
 #### In the migration, the unique index:
-
-    add_index :votes, ["voter_id", "voter_type", "voteable_id", "voteable_type"], :unique => true, :name => "uniq_one_vote_only"
-
+```ruby
+add_index :votes, ["voter_id", "voter_type", "voteable_id", "voteable_type"], :unique => true, :name => "uniq_one_vote_only"
+```
 You can also use `--unique-voting false` when running the generator command:
-
-    rails generate thumbs_up --unique-voting false
+```shell
+rails generate thumbs_up --unique-voting false
+```
 
 #### Testing ThumbsUp
 
@@ -178,30 +195,30 @@ Testing is a bit more than trivial now as our #tally and #plusminus_tally querie
 
 * mysql
 
-    ```
-    $ mysql -uroot # You may have set a password locally. Change as needed.
-      > CREATE USER 'test'@'localhost' IDENTIFIED BY 'test';
-      > CREATE DATABASE thumbs_up_test;
-      > USE thumbs_up_test;
-      > GRANT ALL PRIVILEGES ON thumbs_up_test TO 'test'@'localhost' IDENTIFIED BY 'test';
-      > exit;
-    ```
+```sql
+$ mysql -uroot # You may have set a password locally. Change as needed.
+  > CREATE USER 'test'@'localhost' IDENTIFIED BY 'test';
+  > CREATE DATABASE thumbs_up_test;
+  > USE thumbs_up_test;
+  > GRANT ALL PRIVILEGES ON thumbs_up_test TO 'test'@'localhost' IDENTIFIED BY 'test';
+  > exit;
+```
 * Postgres
 
-    ```
-    $ psql # You may have set a password locally. Change as needed.
-      > CREATE ROLE test;
-      > ALTER ROLE test WITH SUPERUSER;
-      > ALTER ROLE test WITH LOGIN;
-      > CREATE DATABASE thumbs_up_test;
-      > GRANT ALL PRIVILEGES ON DATABASE thumbs_up_test to test;
-      > \q
-    ```
+```PLpgSQL
+$ psql # You may have set a password locally. Change as needed.
+  > CREATE ROLE test;
+  > ALTER ROLE test WITH SUPERUSER;
+  > ALTER ROLE test WITH LOGIN;
+  > CREATE DATABASE thumbs_up_test;
+  > GRANT ALL PRIVILEGES ON DATABASE thumbs_up_test to test;
+  > \q
+```
 * Run tests
 
-    ```
-    $ rake # Runs the test suite against all adapters.
-    ```
+```shell
+$ rake # Runs the test suite against all adapters.
+```
 
 Credits
 =======

data/Rakefile

@@ -33,10 +33,13 @@ end
 task :test_all_databases do
   # Test MySQL, Postgres and SQLite3
   ENV['DB'] = 'mysql'
+  puts "Testing MySQL..."
   Rake::Task['test'].execute
   ENV['DB'] = 'postgres'
+  puts "Testing Postgres..."
   Rake::Task['test'].execute
   ENV['DB'] = 'sqlite3'
+  puts "Testing SQLite3..."
   Rake::Task['test'].execute
 end
 

data/lib/generators/thumbs_up/thumbs_up_generator.rb

@@ -5,7 +5,7 @@ class ThumbsUpGenerator < Rails::Generators::Base
   include Rails::Generators::Migration
 
   source_root File.expand_path('../templates', __FILE__)
-  
+
   class_option :unique_voting, :type => :boolean, :default => true, :desc => 'Do you want only one vote allowed per voter? (default: true)'
 
   # Implement the required interface for Rails::Generators::Migration.
@@ -18,7 +18,7 @@ class ThumbsUpGenerator < Rails::Generators::Base
     end
   end
 
-  def create_migration
+  def create_thumbs_up_migration
     migration_template 'migration.rb', File.join('db', 'migrate', 'thumbs_up_migration.rb')
   end
 
@@ -26,4 +26,4 @@ class ThumbsUpGenerator < Rails::Generators::Base
     template 'vote.rb', File.join('app', 'models', 'vote.rb')
   end
 
-end
+end

data/lib/thumbs_up/version.rb

@@ -1,3 +1,3 @@
 module ThumbsUp
-	VERSION = '0.6.7'
+	VERSION = '0.6.8'
 end

data/test/test_helper.rb

@@ -1,6 +1,6 @@
 require 'simplecov'
+require 'minitest/autorun'
 SimpleCov.start
-require 'test/unit'
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
@@ -64,7 +64,7 @@ ActiveRecord::Schema.define do
     t.boolean    :vote,     :default => false
     t.references :voteable, :polymorphic => true, :null => false
     t.references :voter,    :polymorphic => true
-    t.timestamps
+    t.timestamps :null => false
   end
 
   add_index :votes, [:voter_id, :voter_type]
@@ -75,7 +75,7 @@ ActiveRecord::Schema.define do
 
   create_table :users, :force => true do |t|
     t.string :name
-    t.timestamps
+    t.timestamps :null => false
   end
 
   create_table :items, :force => true do |t|
@@ -92,7 +92,7 @@ ActiveRecord::Schema.define do
 
   create_table :user_customs, :force => true do |t|
     t.string :name
-    t.timestamps
+    t.timestamps :null => false
   end
 
   create_table :item_customs, :force => true do |t|
@@ -149,7 +149,12 @@ class User < ActiveRecord::Base
   ThumbsUp.configuration.voter_relationship_name = :votes
   acts_as_voter
   has_many :items
-  has_karma(:items)
+  has_karma :items
+
+  def self.default_karma
+    self.karmic_objects = nil
+    has_karma :items, :weight => 1
+  end
 
   def self.weighted_has_karma
     self.karmic_objects = nil
@@ -183,6 +188,3 @@ class UserCustom < ActiveRecord::Base
   has_many :items
   has_karma :items
 end
-
-class Test::Unit::TestCase
-end

data/test/thumbs_up_test.rb

@@ -1,6 +1,6 @@
 require File.join(File.expand_path(File.dirname(__FILE__)), 'test_helper')
 
-class TestThumbsUp < Test::Unit::TestCase
+class TestThumbsUp < Minitest::Test
   def setup
     Vote.delete_all
     User.delete_all
@@ -17,7 +17,7 @@ class TestThumbsUp < Test::Unit::TestCase
     item = Item.create(:name => 'XBOX', :description => 'XBOX console')
     item2= Item.create(:name => 'PS3', :description => 'Playstation 3')
 
-    assert_not_nil user_for.vote_for(item)
+    refute_nil user_for.vote_for(item)
     assert_raises(ActiveRecord::RecordInvalid) do
       user_for.vote_for(item)
     end
@@ -36,7 +36,7 @@ class TestThumbsUp < Test::Unit::TestCase
       user_for.voted_which_way?(item, :foo)
     end
 
-    assert_not_nil user_against.vote_against(item)
+    refute_nil user_against.vote_against(item)
     assert_raises(ActiveRecord::RecordInvalid) do
       user_against.vote_against(item)
     end
@@ -53,10 +53,10 @@ class TestThumbsUp < Test::Unit::TestCase
       user_against.voted_which_way?(item, :foo)
     end
 
-    assert_not_nil user_against.vote_exclusively_for(item)
+    refute_nil user_against.vote_exclusively_for(item)
     assert_equal true, user_against.voted_for?(item)
 
-    assert_not_nil user_for.vote_exclusively_against(item)
+    refute_nil user_for.vote_exclusively_against(item)
     assert_equal true, user_for.voted_against?(item)
 
     user_for.unvote_for(item)
@@ -159,7 +159,7 @@ class TestThumbsUp < Test::Unit::TestCase
       user_for.votes
     end
 
-    assert_not_nil user_for.vote_for(item)
+    refute_nil user_for.vote_for(item)
     assert_raises(ActiveRecord::RecordInvalid) do
       user_for.vote_for(item)
     end
@@ -177,7 +177,7 @@ class TestThumbsUp < Test::Unit::TestCase
       user_for.voted_which_way?(item, :foo)
     end
 
-    assert_not_nil user_against.vote_against(item)
+    refute_nil user_against.vote_against(item)
     assert_raises(ActiveRecord::RecordInvalid) do
       user_against.vote_against(item)
     end
@@ -193,10 +193,10 @@ class TestThumbsUp < Test::Unit::TestCase
       user_against.voted_which_way?(item, :foo)
     end
 
-    assert_not_nil user_against.vote_exclusively_for(item)
+    refute_nil user_against.vote_exclusively_for(item)
     assert_equal true, user_against.voted_for?(item)
 
-    assert_not_nil user_for.vote_exclusively_against(item)
+    refute_nil user_for.vote_exclusively_against(item)
     assert_equal true, user_for.voted_against?(item)
 
     user_for.unvote_for(item)
@@ -293,7 +293,7 @@ class TestThumbsUp < Test::Unit::TestCase
 
     user.vote_for(item2)
 
-    assert_not_nil Item.tally.first.id
+    refute_nil Item.tally.first.id
   end
 
   def test_tally_starts_at
@@ -338,7 +338,7 @@ class TestThumbsUp < Test::Unit::TestCase
   end
 
   def test_tally_count
-    Item.tally.except(:order).count
+    Item.tally.except(:order).to_a.count
   end
 
   def test_tally_any
@@ -403,7 +403,7 @@ class TestThumbsUp < Test::Unit::TestCase
     item = Item.create(:name => 'XBOX', :description => 'XBOX console')
     item_not_included = Item.create(:name => 'Playstation', :description => 'Playstation console')
 
-    assert_not_nil user.vote_for(item)
+    refute_nil user.vote_for(item)
 
     if ActiveRecord::Base.connection.adapter_name == 'MySQL'
       assert(Item.plusminus_tally.having('vote_count > 0').include?(item))
@@ -420,8 +420,8 @@ class TestThumbsUp < Test::Unit::TestCase
     item2 = Item.create(:name => 'Playstation', :description => 'Playstation console')
     item3 = Item.create(:name => 'Wii', :description => 'Wii console')
 
-    assert_not_nil user.vote_for(item1)
-    assert_not_nil user.vote_against(item2)
+    refute_nil user.vote_for(item1)
+    refute_nil user.vote_against(item2)
 
     assert_equal [1, 0, 0], Item.plusminus_tally(:separate_updown => true).map(&:up).map(&:to_i)
   end
@@ -432,8 +432,8 @@ class TestThumbsUp < Test::Unit::TestCase
     item2 = Item.create(:name => 'Playstation', :description => 'Playstation console')
     item3 = Item.create(:name => 'Wii', :description => 'Wii console')
 
-    assert_not_nil user.vote_for(item1)
-    assert_not_nil user.vote_against(item2)
+    refute_nil user.vote_for(item1)
+    refute_nil user.vote_against(item2)
 
     assert_equal [0, 0, 1], Item.plusminus_tally(:separate_updown => true).map(&:down).map(&:to_i)
   end
@@ -444,8 +444,8 @@ class TestThumbsUp < Test::Unit::TestCase
     item2 = Item.create(:name => 'Playstation', :description => 'Playstation console')
     item3 = Item.create(:name => 'Wii', :description => 'Wii console')
 
-    assert_not_nil user.vote_for(item1)
-    assert_not_nil user.vote_against(item2)
+    refute_nil user.vote_for(item1)
+    refute_nil user.vote_against(item2)
 
     assert_equal [1, 0, -1], Item.plusminus_tally.map(&:plusminus_tally).map(&:to_i)
   end
@@ -454,7 +454,7 @@ class TestThumbsUp < Test::Unit::TestCase
     user1 = User.create(:name => 'david')
     item = Item.create(:name => 'Playstation', :description => 'Playstation console')
 
-    assert_not_nil user1.vote_for(item)
+    refute_nil user1.vote_for(item)
 
     # https://github.com/rails/rails/issues/1718
     assert_equal 1, Item.plusminus_tally[0].vote_count.to_i
@@ -466,8 +466,8 @@ class TestThumbsUp < Test::Unit::TestCase
     user2 = User.create(:name => 'john')
     item = Item.create(:name => 'Playstation', :description => 'Playstation console')
 
-    assert_not_nil user1.vote_against(item)
-    assert_not_nil user2.vote_against(item)
+    refute_nil user1.vote_against(item)
+    refute_nil user2.vote_against(item)
 
     # https://github.com/rails/rails/issues/1718
     assert_equal 2, Item.plusminus_tally[0].vote_count.to_i
@@ -481,10 +481,10 @@ class TestThumbsUp < Test::Unit::TestCase
     item_for = Item.create(:name => 'XBOX', :description => 'XBOX console')
     item_against = Item.create(:name => 'Playstation', :description => 'Playstation console')
 
-    assert_not_nil user1.vote_for(item_for)
-    assert_not_nil user1.vote_for(item_twice_for)
-    assert_not_nil user2.vote_for(item_twice_for)
-    assert_not_nil user1.vote_against(item_against)
+    refute_nil user1.vote_for(item_for)
+    refute_nil user1.vote_for(item_twice_for)
+    refute_nil user2.vote_for(item_twice_for)
+    refute_nil user1.vote_against(item_against)
 
     assert_equal item_twice_for, Item.plusminus_tally[0]
     assert_equal item_for, Item.plusminus_tally[1]
@@ -504,8 +504,8 @@ class TestThumbsUp < Test::Unit::TestCase
     item_for = Item.create(:name => 'XBOX', :description => 'XBOX console')
     item_against = Item.create(:name => 'Playstation', :description => 'Playstation console')
 
-    assert_not_nil user.vote_for(item_for)
-    assert_not_nil user.vote_against(item_against)
+    refute_nil user.vote_for(item_for)
+    refute_nil user.vote_against(item_against)
 
     assert_equal item_for, Item.plusminus_tally.reorder('plusminus_tally ASC')[1]
     assert_equal item_against, Item.plusminus_tally.reorder('plusminus_tally ASC')[0]
@@ -524,7 +524,7 @@ class TestThumbsUp < Test::Unit::TestCase
   end
 
   def test_plusminus_tally_count
-    Item.plusminus_tally.except(:order).count
+    Item.plusminus_tally.except(:order).to_a.count
   end
 
   def test_plusminus_tally_any
@@ -532,6 +532,7 @@ class TestThumbsUp < Test::Unit::TestCase
   end
 
   def test_karma
+    User.default_karma
     users = (0..1).map{ |u| User.create(:name => "User #{u}") }
     items = (0..1).map{ |u| users[0].items.create(:name => "Item #{u}", :description => "Item #{u}") }
     users.each{ |u| items.each { |i| u.vote_for(i) } }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: thumbs_up
 version: !ruby/object:Gem::Version
-  version: 0.6.7
+  version: 0.6.8
 platform: ruby
 authors:
 - Brady Bouchard
@@ -13,118 +13,132 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-02 00:00:00.000000000 Z
+date: 2015-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.2.x
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.2.x
 - !ruby/object:Gem::Dependency
   name: statistics2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.3.20
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.3.20
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: ThumbsUp provides dead-simple voting capabilities to ActiveRecord models
@@ -135,24 +149,24 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
+- Gemfile
+- LICENSE
+- README.md
+- Rakefile
 - lib/acts_as_voteable.rb
 - lib/acts_as_voter.rb
 - lib/generators/thumbs_up/templates/migration.rb
 - lib/generators/thumbs_up/templates/vote.rb
 - lib/generators/thumbs_up/thumbs_up_generator.rb
 - lib/has_karma.rb
+- lib/thumbs_up.rb
 - lib/thumbs_up/base.rb
 - lib/thumbs_up/configuration.rb
 - lib/thumbs_up/version.rb
-- lib/thumbs_up.rb
 - rails/init.rb
 - test/test_helper.rb
 - test/thumbs_up_test.rb
-- CHANGELOG.md
-- Gemfile
-- MIT-LICENSE
-- README.md
-- Rakefile
 homepage: http://github.com/bouchard/thumbs_up
 licenses:
 - MIT
@@ -163,17 +177,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Voting for ActiveRecord with multiple vote sources and karma calculation.

data/MIT-LICENSE

@@ -1,66 +0,0 @@
-Copyright (c) 2011 Brady Bouchard (thewellinspired.com)
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-Major portions of this package were adapted from VoteFu, which is subject to the same license. Here is the original copyright notice for VoteFu:
-
-Copyright (c) 2008 Peter Jackson (peteonrails.com)
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-Major portions of this package were adapted from ActsAsVoteable, which is subject to the same license. Here is the original copyright notice for ActsAsVoteable:
-
-Copyright (c) 2006 Cosmin Radoi
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.