thumblemonks-inquisition 0.1.1 → 0.1.2

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 1
-:patch: 1
+:patch: 2
 :major: 0

data/lib/inquisition.rb

@@ -21,10 +21,11 @@ module Inquisition
       class_inheritable_reader(:cleansed_attr_readers)
 
       define_method(:read_attribute_with_cleansing) do |attribute|
-        if cleansed_attr_readers.include?(attribute.to_sym)
-          HTML5libSanitize.sanitize_html(read_attribute_without_cleansing(attribute))
+        value = read_attribute_without_cleansing(attribute)
+        if cleansed_attr_readers.include?(attribute.to_sym) && !value.blank?
+          HTML5libSanitize.sanitize_html(value)
         else
-          read_attribute_without_cleansing(attribute)
+          value
         end
       end
       alias_method_chain :read_attribute, :cleansing
@@ -35,11 +36,11 @@ module Inquisition
       class_inheritable_reader(:cleansed_attr_writers)
 
       define_method(:write_attribute_with_cleansing) do |attribute, value|
-        if cleansed_attr_writers.include?(attribute.to_sym)
-          write_attribute_without_cleansing(attribute, HTML5libSanitize.sanitize_html(value))
-        else
-          write_attribute_without_cleansing(attribute, value)
+        if cleansed_attr_writers.include?(attribute.to_sym) && !value.blank?
+          value = HTML5libSanitize.sanitize_html(value)
         end
+
+        write_attribute_without_cleansing(attribute, value)
       end
       alias_method_chain :write_attribute, :cleansing
     end

data/test/inquisition_test.rb

@@ -33,5 +33,18 @@ class InquisitionTest < Test::Unit::TestCase
       private_origin = @whisky.attributes["origin"]
       assert_equal "<SCRIPT SRC=http://ha.ckers.org/xss.js>Scotland</SCRIPT>", @whisky.origin
     end
+
+    should "not show pain for setting blank attributes" do
+      @whisky.origin = nil
+      @whisky.name = nil
+      assert_equal nil, @whisky.origin
+      assert_equal nil, @whisky.name
+    end
+
+    should "not show pain for getting blank attributes" do
+      @whisky.update_attributes(:origin => nil, :name => nil)
+      assert_equal nil, @whisky.origin
+      assert_equal nil, @whisky.name
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: thumblemonks-inquisition
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - toothrot
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-03-27 00:00:00 -07:00
+date: 2009-03-31 00:00:00 -07:00
 default_executable: 
 dependencies: []