thumblemonks-inquisition 0.1.0 → 0.1.1

data/Rakefile

@@ -0,0 +1,56 @@
+require 'rubygems'
+require 'rake'
+
+begin
+  require 'jeweler'
+  Jeweler::Tasks.new do |gem|
+    gem.name = "inquisition"
+    gem.summary = %Q{TODO}
+    gem.email = "scissorjammer@gmail.com"
+    gem.homepage = "http://github.com/toothrot/inquisition"
+    gem.authors = ["toothrot"]
+
+    # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
+  end
+rescue LoadError
+  puts "Jeweler not available. Install it with: sudo gem install technicalpickles-jeweler -s http://gems.github.com"
+end
+
+require 'rake/testtask'
+Rake::TestTask.new(:test) do |test|
+  test.libs << 'lib' << 'test'
+  test.pattern = 'test/**/*_test.rb'
+  test.verbose = false
+end
+
+begin
+  require 'rcov/rcovtask'
+  Rcov::RcovTask.new do |test|
+    test.libs << 'test'
+    test.pattern = 'test/**/*_test.rb'
+    test.verbose = true
+  end
+rescue LoadError
+  task :rcov do
+    abort "RCov is not available. In order to run rcov, you must: sudo gem install spicycode-rcov"
+  end
+end
+
+
+task :default => :test
+
+require 'rake/rdoctask'
+Rake::RDocTask.new do |rdoc|
+  if File.exist?('VERSION.yml')
+    config = YAML.load(File.read('VERSION.yml'))
+    version = "#{config[:major]}.#{config[:minor]}.#{config[:patch]}"
+  else
+    version = ""
+  end
+
+  rdoc.rdoc_dir = 'rdoc'
+  rdoc.title = "inquisition #{version}"
+  rdoc.rdoc_files.include('README*')
+  rdoc.rdoc_files.include('lib/**/*.rb')
+end
+

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 1
-:patch: 0
+:patch: 1
 :major: 0

data/lib/inquisition.rb

@@ -11,29 +11,37 @@ module Inquisition
   end
 
   module ClassMethods
-
-    # cleanse_attr creates getters and setters for the specified list of attributes.
     def cleanse_attr(*attributes)
       cleanse_attr_reader(*attributes)
       cleanse_attr_writer(*attributes)
     end
 
     def cleanse_attr_reader(*attributes)
-      attributes.each do |attr|
-        alias_method(:"#{attr}_without_cleansing", :"#{attr}")
-        define_method(:"#{attr}") do
-          HTML5libSanitize.sanitize_html(send(:"#{attr}_without_cleansing"))
+      write_inheritable_attribute(:cleansed_attr_readers, attributes)
+      class_inheritable_reader(:cleansed_attr_readers)
+
+      define_method(:read_attribute_with_cleansing) do |attribute|
+        if cleansed_attr_readers.include?(attribute.to_sym)
+          HTML5libSanitize.sanitize_html(read_attribute_without_cleansing(attribute))
+        else
+          read_attribute_without_cleansing(attribute)
         end
       end
+      alias_method_chain :read_attribute, :cleansing
     end
 
     def cleanse_attr_writer(*attributes)
-      attributes.each do |attr|
-        alias_method(:"#{attr}_without_cleansing=", :"#{attr}=")
-        define_method(:"#{attr}=") do |value|
-          send(:"#{attr}_without_cleansing=", HTML5libSanitize.sanitize_html(value))
+      write_inheritable_attribute(:cleansed_attr_writers, attributes)
+      class_inheritable_reader(:cleansed_attr_writers)
+
+      define_method(:write_attribute_with_cleansing) do |attribute, value|
+        if cleansed_attr_writers.include?(attribute.to_sym)
+          write_attribute_without_cleansing(attribute, HTML5libSanitize.sanitize_html(value))
+        else
+          write_attribute_without_cleansing(attribute, value)
         end
       end
+      alias_method_chain :write_attribute, :cleansing
     end
   end #Class Methods
 end #Inquisition

data/test/inquisition_test.rb

@@ -4,7 +4,7 @@ class InquisitionTest < Test::Unit::TestCase
   context "a fine Whisky" do
     setup do
       @whisky = Whisky.new(:name => "<script>alert('Cragganmore')</script>", 
-        :origin => "<SCRIPT SRC=http://ha.ckers.org/xss.js>Scotland</SCRIPT>", :abv => 42.0,
+        :origin => "<SCRIPT SRC=http://ha.ckers.org/xss.js>Scotland</SCRIPT>", :abv => 42,
         :description => %Q['';!--"<XSS>=&{()}a buttery scotch])
     end
 
@@ -19,7 +19,7 @@ class InquisitionTest < Test::Unit::TestCase
 
     should "cleanse heresy before setting" do
       @whisky.name = "<script>alert('Cragganmore')</script>"
-      private_name = @whisky.instance_variable_get(:@name)
+      private_name = @whisky.attributes["name"]
 
       assert_equal "&lt;script&gt;alert('Cragganmore')&lt;/script&gt;", private_name
     end
@@ -30,7 +30,7 @@ class InquisitionTest < Test::Unit::TestCase
 
     should "not cleanse and set fields not targeted for cleansing" do
       @whisky.origin = "<SCRIPT SRC=http://ha.ckers.org/xss.js>Scotland</SCRIPT>"
-      private_origin = @whisky.instance_variable_get(:@origin)
+      private_origin = @whisky.attributes["origin"]
       assert_equal "<SCRIPT SRC=http://ha.ckers.org/xss.js>Scotland</SCRIPT>", @whisky.origin
     end
   end

data/test/models.rb

@@ -0,0 +1,29 @@
+ActiveRecord::Base.establish_connection :adapter => 'sqlite3', :database => File.join(File.dirname(__FILE__), 'test.db')
+ 
+class CreateSchema < ActiveRecord::Migration
+  def self.up
+    create_table :whiskies, :force => true do |t|
+      t.string :name, :origin, :description
+      t.integer :abv
+    end
+    create_table :animals, :force => true do |t|
+      t.string :name, :noise
+    end
+  end
+end
+
+CreateSchema.suppress_messages { CreateSchema.migrate(:up) }
+
+class Animal < ActiveRecord::Base
+  def bark
+    "#{noise.capitalize}! #{noise.capitalize}!"
+  end
+end
+
+class Whisky < ActiveRecord::Base
+  cleanse_attr :name, :description
+
+  def drink
+    "You quaffed #{description}"
+  end
+end

data/test/test_helper.rb

@@ -1,14 +1,9 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'rubygems'
 require 'test/unit'
+require 'activerecord'
+require 'activesupport'
 require 'shoulda'
-
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'inquisition'
-
-#Test models, yeah.
-require 'lib/animal'
-require 'lib/whisky'
-
-class Test::Unit::TestCase
-end
+require 'models'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: thumblemonks-inquisition
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - toothrot
@@ -27,12 +27,11 @@ files:
 - README.rdoc
 - lib/inquisition.rb
 - lib/html5lib_sanitize.rb
-- test/lib
-- test/lib/animal.rb
-- test/lib/whisky.rb
 - test/inquisition_test.rb
 - test/performance.rb
+- test/models.rb
 - test/test_helper.rb
+- Rakefile
 - LICENSE
 has_rdoc: true
 homepage: http://github.com/thumblemonks/inquisition

data/test/lib/animal.rb

@@ -1,13 +0,0 @@
-class Animal
-  attr_accessor :name, :noise
-
-  def initialize(attributes)
-    attributes.each_pair do |k,v|
-      self.send(:"#{k}=",v) 
-    end
-  end
-
-  def bark
-    "#{noise.capitalize}! #{noise.capitalize}!"
-  end
-end

data/test/lib/whisky.rb

@@ -1,14 +0,0 @@
-class Whisky
-  attr_accessor :name, :origin, :abv, :description
-  cleanse_attr :name, :description
-
-  def initialize(attributes)
-    attributes.each_pair do |k,v|
-      self.send(:"#{k}=",v) 
-    end
-  end
-
-  def drink
-    "You quaffed #{description}"
-  end
-end