thumbkit 0.0.5 → 0.0.6

data/.gitignore

@@ -10,3 +10,4 @@ pkg
 rdoc
 spec/reports
 tmp
+spec/fixtures/IMG_RAW_EXAMPLE.CR2

data/README.md

@@ -47,8 +47,12 @@ thumbnail type.
 Thumbkit uses [MiniMagick](https://github.com/probablycorey/mini_magick) to
 resize and crop images.
 
+If you plan to support thumbnails raw files, imagemagick delegate raw processing
+to [ufraw](http://ufraw.sourceforge.net/).
+
 On OS X:
 
+    $ brew install ufraw # Optional, for processing cr2, raw, etc
     $ brew install imagemagick
     $ gem install mini_magick
 
@@ -232,10 +236,10 @@ Adding a processor mapping:
 Thumbkit.processors['jpeg'] = 'Image'
 ```
 
-Adding a processor:
+##### Custom processors
 
 ```ruby
-class Thumbkit::Processors::Doc
+class Thumbkit::Processor::Doc < Thumbkit::Processor
   def write
     # use `path` to generate `outfile`
 
@@ -258,6 +262,12 @@ Thumbkit.processors['doc'] = 'Doc'
   * PDF
   * Video
 
+## Known Issues
+
+* If the output file has an uppercase extension, image processing may break.
+  This will not be an issue if you are not supplying the output filename as
+  `Thumbkit::Image` will always pick a lowercase extension by default.
+
 ## Contributing
 
 1. Fork it

data/lib/thumbkit/adapters/carrierwave.rb

@@ -29,7 +29,7 @@ module Thumbkit::Adapters::CarrierWave
   end
 
   def valid_for_thumbkit?(file)
-    p "valid_for_thumbkit?", file, current_path
+    # p "valid_for_thumbkit?", file, current_path
     !! Thumbkit.new(file.path)
   rescue ArgumentError
     false

data/lib/thumbkit/processor/image.rb

@@ -3,7 +3,8 @@ require 'mini_magick'
 class Thumbkit::Processor::Image < Thumbkit::Processor
 
   def determine_outfile
-    @path
+    ext = File.extname(@path)[1..-1].downcase
+    self.class.force_extension(path, format_conversions[ext] || ext)
   end
 
   def write
@@ -12,7 +13,13 @@ class Thumbkit::Processor::Image < Thumbkit::Processor
     outfile
   end
 
-
+  # Public to allow customization
+  def format_conversions
+    @_format_conversions ||= {
+      'cr2' => 'jpg',
+      'raw' => 'jpg',
+    }
+  end
 
   private
 
@@ -20,7 +27,6 @@ class Thumbkit::Processor::Image < Thumbkit::Processor
     File.extname(outfile)[1..-1]
   end
 
-
   # Copied and adjusted from CarrierWave
   def resize_to_fill
     image = ::MiniMagick::Image.open(path)

data/lib/thumbkit/processor.rb

@@ -10,6 +10,8 @@ class Thumbkit::Processor
       'jpg'   => 'Image',
       'jpeg'  => 'Image',
       'gif'   => 'Image',
+      'cr2'   => 'Image',
+      'raw'   => 'Image',
       'txt'   => 'Text',
       'md'    => 'Text',
       'rb'    => 'Text',

data/lib/thumbkit/version.rb

@@ -1,3 +1,3 @@
 class Thumbkit
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/fixtures/OMG_UPPERCASE_TEXT.TXT

@@ -0,0 +1,15 @@
+An Example Text File
+
+LOREM IPSUM DOLOR SIT AMET, CONSECTETUR ADIPISICING ELIT, SED DO EIUSMOD
+TEMPOR INCIDIDUNT UT LABORE ET DOLORE MAGNA ALIQUA. UT ENIM AD MINIM VENIAM,
+QUIS NOSTRUD EXERCITATION ULLAMCO LABORIS NISI UT ALIQUIP EX EA COMMODO
+CONSEQUAT. DUIS AUTE IRURE DOLOR IN REPREHENDERIT IN VOLUPTATE VELIT ESSE
+CILLUM DOLORE EU FUGIAT NULLA PARIATUR. EXCEPTEUR SINT OCCAECAT CUPIDATAT NON
+PROIDENT, SUNT IN CULPA QUI OFFICIA DESERUNT MOLLIT ANIM ID EST LABORUM.
+
+Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod
+tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,
+quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo
+consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse
+cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non
+proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

data/spec/thumbkit/processor/image_spec.rb

@@ -20,6 +20,16 @@ describe Thumbkit::Processor::Image do
         let(:fixture) { 'jpg_file.jpg' }
         it { should == File.expand_path(path_to_fixture('jpg_file.jpg')) }
       end
+
+      context 'when the fixture is a cr2' do
+        let(:fixture) { 'IMAGE_RAW_EXAMPLE.CR2' }
+        it { should == File.expand_path(path_to_fixture('IMAGE_RAW_EXAMPLE.jpg')) }
+      end
+
+      context 'with an uppercase file' do
+        let(:fixture) { 'OMG_UPPERCASE.PNG' }
+        it { should == File.expand_path(path_to_fixture('OMG_UPPERCASE.png')) }
+      end
     end
 
     # context 'with an extensionless outfile' do
@@ -77,5 +87,23 @@ describe Thumbkit::Processor::Image do
       its_size_should_be('200x200')
       its_mimetype_should_be('image/jpeg')
     end
+
+    context 'with an uppercase file' do
+      let(:fixture) { path_to_fixture('OMG_UPPERCASE.PNG') }
+      let(:outfile) { path_for_output('OMG_UPPERCASE.png').to_s }
+      it { should == path_for_output('OMG_UPPERCASE.png').to_s }
+      its_size_should_be('200x200')
+      its_mimetype_should_be('image/png')
+    end
+
+
+    # Extremely SLOW
+    # context 'with a raw file' do
+    #   let(:fixture) { 'IMG_RAW_EXAMPLE.CR2' }
+    #   let(:outfile) { path_for_output('IMAGE_RAW_EXAMPLE.jpg').to_s }
+    #   it { should == path_for_output('IMAGE_RAW_EXAMPLE.jpg').to_s }
+    #   its_size_should_be('200x200')
+    #   its_mimetype_should_be('image/jpeg')
+    # end
   end
 end

data/spec/thumbkit/processor/text_spec.rb

@@ -104,6 +104,15 @@ describe Thumbkit::Processor::Text do
       # Manually check the file to verify unicode stuff and right-to-left worked
     end
 
+    context 'with an uppercase filename' do
+      let(:options) { { } }
+      let(:fixture) { 'OMG_UPPERCASE_TEXT.TXT' }
+      let(:outfile) { path_for_output('OMG_UPPERCASE_TEXT.PNG').to_s }
+      it('writes a file') { File.should exist(subject) }
+      its_size_should_be('200x200')
+      its_mimetype_should_be('image/png')
+    end
+
 
     context 'with an arabic file to output to jpg' do
       let(:options) { { width: 600, height: 400 } }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: thumbkit
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -35,6 +35,8 @@ files:
 - lib/thumbkit/processor/text.rb
 - lib/thumbkit/version.rb
 - spec/fixtures/16Hz-20kHz-Exp-1f-5sec.mp3
+- spec/fixtures/OMG_UPPERCASE.PNG
+- spec/fixtures/OMG_UPPERCASE_TEXT.TXT
 - spec/fixtures/arabic.txt
 - spec/fixtures/greek.txt
 - spec/fixtures/hebrew.txt
@@ -76,6 +78,8 @@ specification_version: 3
 summary: Thumbkit makes thumbnails from a variety of media types.
 test_files:
 - spec/fixtures/16Hz-20kHz-Exp-1f-5sec.mp3
+- spec/fixtures/OMG_UPPERCASE.PNG
+- spec/fixtures/OMG_UPPERCASE_TEXT.TXT
 - spec/fixtures/arabic.txt
 - spec/fixtures/greek.txt
 - spec/fixtures/hebrew.txt