thrift_server 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9558c4785c5f60c3178add28862c2074d0a45ed9
-  data.tar.gz: af9ce55e5055cca900ff4d32f48558bb21d5a158
+  metadata.gz: 41fa482d2834f442ecc5900d82d3042ac91512a7
+  data.tar.gz: 65b5c1e6814cf096dbe6ab3492d859adad5cbc06
 SHA512:
-  metadata.gz: 3ec3fd8f56101e485a8f03654cbb921f6d1f5f047b1f408e20da258d11231d5b0e77a0124bd614b2af13f224baeb9776abbc4ea18b93d3c8db3f9813a986d05f
-  data.tar.gz: 8696c6d72a71ed0c6307dd88bd722d40109abbcc0761da9033294808f3a0d0c8e9cfc607c818ef29abed3a7c6eb381ea7acaa0b486e2a889dfd27015fcfce38f
+  metadata.gz: 1a51fac841e4c11faa84121d6b13cf20e068c62e323e7bcd4d3fca7d1541818df1417f5fe67951f7f7d22baa73b3d396b051bdf9e1d072abd5ceb584b1665416
+  data.tar.gz: 3dee701b61ca406d448684664ed5ddec2d7e1e02b55b421622d54bbd38676885d1f65e20278b9a44a258fb7d0e1837472c50970911885d911ac0fbc0c8e48a97

data/Makefile

@@ -39,5 +39,5 @@ clean:
 	-docker rm -v server > /dev/null 2>&1
 	@mkdir -p tmp
 	@touch tmp/image
-	cat tmp/image | xargs --no-run-if-empty docker rmi
+	-cat tmp/image | xargs --no-run-if-empty docker rmi
 	rm -rf tmp/image

data/README.md

@@ -48,7 +48,7 @@ available:
 
 * `logger:` - a `Logger` instance
 * `statsd:` - a `Statsd` instance from the [statsd-ruby gem](https://github.com/reinh/statsd)
-* `error_tracker:` object that implement `#track(rpc, error). Use
+* `error_tracker:` object that implement `#track(rpc, error)`. Use
   `ThriftServer::HoneybaderErrorTracker` if unsure
 * `threads:` - number of threads to run. Defaults to `4`
 * `port:` - port to run server on. Defaults to `9090`

data/lib/thrift_server/metrics_middleware.rb

@@ -3,6 +3,8 @@ class ThriftServer
     include Concord.new(:app, :statsd)
 
     def call(rpc)
+      statsd.increment rpc.name
+
       statsd.time rpc.name do
         app.call rpc
       end

data/lib/thrift_server/version.rb

@@ -1,3 +1,3 @@
 class ThriftServer
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/test/metrics_middleware_test.rb

@@ -27,6 +27,25 @@ class MetricsMiddlewareTest < MiniTest::Unit::TestCase
     assert_equal rpc.name, statsd.timer
   end
 
+  def test_increments_a_counter_on_successful_rpcs
+    app = stub call: :result
+
+    statsd = Class.new FakeStatsd do
+      attr_reader :counter
+
+      def increment(*args)
+        @counter = args.first
+      end
+    end.new
+
+    middleware = ThriftServer::MetricsMiddleware.new(app, statsd)
+
+    middleware.call rpc
+
+    assert statsd.counter, 'Counter not updated'
+    assert_equal rpc.name, statsd.counter
+  end
+
   def test_increments_a_counter_on_failed_rpcs
     app = stub
     app.stubs(:call).raises(TestError)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thrift_server
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - ahawkins
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-13 00:00:00.000000000 Z
+date: 2015-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: statsd-ruby