thredded 0.4.0 → 0.5.0

data/app/view_models/thredded/topics_page_view.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 require_dependency 'thredded/topic_view'
-require_dependency 'thredded/private_topic_view'
 module Thredded
   # A view model for a page of BaseTopicViews.
   class TopicsPageView
@@ -17,9 +16,8 @@ module Thredded
     # @param topics_page_scope [ActiveRecord::Relation<Thredded::Topic>]
     def initialize(user, topics_page_scope)
       @topics_page_scope = topics_page_scope
-      topic_view_class = "#{topics_page_scope.klass}View".constantize
-      @topic_views = @topics_page_scope.with_read_states(user).map do |(topic, read_state)|
-        topic_view_class.new(topic, read_state, Pundit.policy!(user, topic))
+      @topic_views = @topics_page_scope.with_read_and_follow_states(user).map do |(topic, read_state, follow)|
+        TopicView.new(topic, read_state, follow, Pundit.policy!(user, topic))
       end
     end
   end

data/app/views/thredded/moderation/_post.html.erb

@@ -0,0 +1,7 @@
+<%# @param post [Thredded::PostView] %>
+<%= content_tag :article, id: dom_id(post), class: 'thredded--post' do %>
+  <%= render 'thredded/posts_common/header', post: post %>
+  <%= render 'thredded/posts_common/content', post: post %>
+  <%= render 'thredded/posts_common/actions', post: post %>
+  <%= render 'post_moderation_actions', post: post %>
+<% end %>

data/app/views/thredded/moderation/_post_moderation_actions.html.erb

@@ -0,0 +1,12 @@
+<div class="thredded--post-moderation-actions">
+  <% unless post.approved? %>
+    <%= button_to t('thredded.moderation.approve_btn'), moderate_post_path,
+                  class:  'thredded--button',
+                  params: { id: post.to_model.id, moderation_state: 'approved' } %>
+  <% end %>
+  <% unless post.blocked? %>
+    <%= button_to t('thredded.moderation.block_btn'), moderate_post_path,
+                  class:  'thredded--button',
+                  params: { id: post.to_model.id, moderation_state: 'blocked' } %>
+  <% end %>
+</div>

data/app/views/thredded/moderation/_post_moderation_record.html.erb

@@ -0,0 +1,43 @@
+<%
+  post = post_moderation_record.post
+  moderation_state_notice_args = {
+      moderator: user_link(post_moderation_record.moderator),
+      time_ago:  time_ago(post_moderation_record.created_at)
+  }
+%>
+<article class="thredded--post-moderation-record thredded--post-moderation-record-<%= post_moderation_record.moderation_state %>">
+  <header class="thredded--post-moderation-record--header">
+    <p class="thredded--post-moderation-record--moderation-state-notice">
+      <% if post_moderation_record.approved? %>
+        <%= t('thredded.moderation.post_approved_html', moderation_state_notice_args) %>
+      <% elsif post_moderation_record.blocked? %>
+        <%= t('thredded.moderation.post_blocked_html', moderation_state_notice_args) %>
+      <% end %>
+    </p>
+    <% if post && post.content != post_moderation_record.post_content %>
+      <p class="thredded--post-moderation-record--content-changed-notice">
+        <%= t('thredded.moderation.posts_content_changed_since_moderation_html', post_url: post_permalink_path(post)) %>
+      </p>
+    <% end %>
+    <%= t 'thredded.moderation.post_deleted_notice' unless post %>
+  </header>
+  <article class="thredded--post">
+    <header>
+      <% if post_moderation_record.post_user %>
+        <%= image_tag Thredded.avatar_url.call(post_moderation_record.post_user), class: 'thredded--post--avatar' %>
+        <h2 class="thredded--post--user"><%= user_link post_moderation_record.post_user %></h2>
+      <% else %>
+        <h2 class="thredded--post--user">
+          <%= post_moderation_record.post_user_name %>, <em><%= t 'thredded.null_user_name' %></em>
+        </h2>
+      <% end %>
+      <% if post %>
+        <p class="thredded--post--created-at"><%= time_ago post.created_at %></p>
+      <% end %>
+    </header>
+    <div class="thredded--post--content">
+      <%= Thredded::ContentFormatter.new(self).format_content(post_moderation_record.post_content) %>
+    </div>
+  </article>
+  <%= render 'post_moderation_actions', post: post if post %>
+</article>

data/app/views/thredded/moderation/history.html.erb

@@ -0,0 +1,19 @@
+<% content_for :thredded_page_title,
+               safe_join([t('thredded.nav.moderation'), t('thredded.nav.moderation_history')], ': ') %>
+<% content_for :thredded_page_id, 'thredded--pending-moderation' %>
+<% content_for :thredded_breadcrumbs do %>
+  <ul class="thredded--navigation-breadcrumbs">
+    <li><%= link_to t('thredded.nav.all_messageboards'), messageboards_path %></li>
+    <li><%= link_to t('thredded.nav.moderation'), pending_moderation_path %></li>
+    <li><%= link_to t('thredded.nav.moderation_history'), moderation_history_path %></li>
+  </ul>
+<% end %>
+
+<%= thredded_page do %>
+  <%= content_tag :section, class: 'thredded--main-section' do %>
+    <% if @post_moderation_records.present? %>
+      <%= render partial: 'post_moderation_record', collection: @post_moderation_records %>
+      <%= paginate @post_moderation_records %>
+    <% end %>
+  <% end %>
+<% end %>

data/app/views/thredded/moderation/pending.html.erb

@@ -0,0 +1,29 @@
+<% content_for :thredded_page_title, t('thredded.nav.moderation') %>
+<% content_for :thredded_page_id, 'thredded--pending-moderation' %>
+<% content_for :thredded_breadcrumbs do %>
+  <ul class="thredded--navigation-breadcrumbs">
+    <li><%= link_to t('thredded.nav.all_messageboards'), messageboards_path %></li>
+    <li><%= link_to t('thredded.nav.moderation'), pending_moderation_path %></li>
+  </ul>
+<% end %>
+
+<%= thredded_page do %>
+  <%= content_tag :section, class: 'thredded--main-section' do %>
+    <%= link_to t('thredded.nav.moderation_history'), moderation_history_path,
+                class: 'thredded--link thredded--moderation--history-link' %>
+    <% if @last_moderated_record %>
+      <div class="thredded--moderated-notice">
+        <%= render 'post_moderation_record', post_moderation_record: @last_moderated_record %>
+      </div>
+    <% end %>
+    <% if @posts.present? %>
+      <%= render partial: 'post', collection: @posts %>
+      <%= paginate @posts %>
+    <% else %>
+      <div class="thredded--empty">
+        <h3 class="thredded--empty--title"><%= t 'thredded.moderation.pending_empty.title' %></h3>
+        <p><%= t 'thredded.moderation.pending_empty.content' %></p>
+      </div>
+    <% end %>
+  <% end %>
+<% end %>

data/app/views/thredded/post_mailer/{at_notification.html.erb → post_notification.html.erb}

@@ -3,7 +3,7 @@
 <hr />
 
 <p>
-  This email was sent to you because <%= @post.user %> mentioned you in
+  This email was sent to you because you are following this topic
   "<%= link_to @post.postable.title, post_permalink_url(@post.id) %>".
   <%= link_to 'View the conversation here', topic_url(@post.postable) %>.
 </p>

data/app/views/thredded/post_mailer/{at_notification.text.erb → post_notification.text.erb}

@@ -2,7 +2,7 @@
 
 ---
 
-This email was sent to you because <%= @post.user %> mentioned you in
+This email was sent to you because you are following this topic
 "<%= @post.postable.title %>". Go here to view the conversation:
 <%= post_permalink_url @post %>
 

data/app/views/thredded/posts/_post.html.erb

@@ -1,3 +1,10 @@
 <% cache(post, expires_in: 1.week) do %>
-  <%= render 'thredded/posts_common/post', post: post %>
+  <%= content_tag :article, id: dom_id(post), class: 'thredded--post' do %>
+    <%= render 'thredded/posts_common/header', post: post %>
+    <%= render 'thredded/posts_common/content', post: post %>
+    <%= render 'thredded/posts_common/actions', post: post %>
+    <% if post.pending_moderation? && !Thredded.content_visible_while_pending_moderation %>
+      <p class="thredded--alert thredded--alert-warning"><%= t 'thredded.posts.pending_moderation_notice' %></p>
+    <% end %>
+  <% end %>
 <% end %>

data/app/views/thredded/posts_common/_actions.html.erb

@@ -0,0 +1,11 @@
+<% if post.can_update? %>
+  <%= link_to t('thredded.posts.edit'), post.edit_path, class: 'thredded--post--edit' %>
+<% end %>
+
+<% if post.can_destroy? %>
+  <%= link_to t('thredded.posts.delete'), post.destroy_path,
+              method: :delete,
+              class:  'thredded--post--delete',
+              data:   { confirm: I18n.t('thredded.posts.delete_confirm') }
+  %>
+<% end %>

data/app/views/thredded/posts_common/_content.html.erb

@@ -0,0 +1,5 @@
+<div class="thredded--post--content">
+  <% cache [post, 'content'], expires_in: 1.week do %>
+    <%= post.filtered_content(self) %>
+  <% end %>
+</div>

data/app/views/thredded/posts_common/_header.html.erb

@@ -0,0 +1,5 @@
+<header>
+  <%= image_tag post.avatar_url, class: 'thredded--post--avatar' if post.user %>
+  <h2 class="thredded--post--user"><%= user_link post.user %></h2>
+  <p class="thredded--post--created-at"><%= time_ago post.created_at %></p>
+</header>

data/app/views/thredded/private_posts/_private_post.html.erb

@@ -1,3 +1,7 @@
 <% cache(private_post, expires_in: 1.week) do %>
-  <%= render 'thredded/posts_common/post', post: private_post %>
+  <%= content_tag :article, id: dom_id(private_post), class: 'thredded--post' do %>
+    <%= render 'thredded/posts_common/header', post: private_post %>
+    <%= render 'thredded/posts_common/content', post: private_post %>
+    <%= render 'thredded/posts_common/actions', post: private_post %>
+  <% end %>
 <% end %>

data/app/views/thredded/shared/_nav.html.erb

@@ -6,6 +6,7 @@
       </li>
     <% end %>
 
+    <%= render 'thredded/shared/nav/moderation' %>
     <%= render 'thredded/shared/nav/notification_preferences', messageboard: messageboard_or_nil %>
     <%= render 'thredded/shared/nav/private_topics' %>
 

data/app/views/thredded/shared/_page.html.erb

@@ -1,4 +1,4 @@
-<div id="thredded--container" class="thredded--main-container <%= yield(:thredded_page_id) %>" data-thredded-page-id="<%= yield(:thredded_page_id) %>">
+<div id="thredded--container" class="thredded--main-container <%= yield(:thredded_page_id) %><%= ' thredded--is-moderator' if moderatable_messageboards_ids.present? %>" data-thredded-page-id="<%= yield(:thredded_page_id) %>">
   <%= render 'thredded/shared/header' %>
   <%= render 'thredded/shared/flash_messages' %>
   <%= yield :thredded_page_content %>

data/app/views/thredded/shared/nav/_moderation.html.erb

@@ -0,0 +1,13 @@
+<% if moderatable_messageboards_ids.present? %>
+  <li class="thredded--user-navigation--item thredded--user-navigation--moderation">
+    <%= link_to pending_moderation_path, rel: 'nofollow' do %>
+      <%= inline_svg 'thredded/moderation.svg',
+                     class: 'thredded--icon',
+                     title: t('thredded.nav.moderation') %>
+      <span class="thredded--nav-text"><%= t 'thredded.nav.moderation' %></span>
+      <% if posts_pending_moderation_count > 0 %>
+        <span class="thredded--user-navigation--moderation--pending-count"><%= posts_pending_moderation_count %></span>
+      <% end %>
+    <% end %>
+  </li>
+<% end %>

data/app/views/thredded/shared/nav/_private_topics.html.erb

@@ -2,8 +2,7 @@
   <%= link_to private_topics_path, rel: 'nofollow' do %>
     <%= inline_svg 'thredded/private-messages.svg',
                    class: 'thredded--icon',
-                   title: safe_join([t('thredded.nav.private_topics'),
-                                     (unread_private_topics_count if unread_private_topics_count > 0)].compact, ' ') %>
+                   title: t('thredded.nav.private_topics') %>
     <span class="thredded--nav-text"><%= t('thredded.nav.private_topics') %></span>
     <% if unread_private_topics_count > 0 -%>
       <span class="thredded--user-navigation--private-topics--unread"><%= unread_private_topics_count %></span>

data/app/views/thredded/topics/_header.html.erb

@@ -9,4 +9,19 @@
     <%= link_to t('thredded.topics.edit'), topic.edit_path,
                 class: 'thredded--topic-header--edit-topic' %>
   <% end %>
+  <% if current_user %>
+    <% if follow = current_user.following?(topic)%>
+      <div class="thredded--topic-follow-info thredded--following">
+        <p>
+          <% # i18n-tasks-use t('thredded.topics.following.manual') t('thredded.topics.following.posted') t('thredded.topics.following.mentioned') %>
+          <%= t("thredded.topics.following.#{follow.reason}") %></p>
+        <%= t('thredded.topics.following_will_receive_emails') %>
+        <%= button_to 'Stop following', topic.unfollow_path %>
+      </div>
+    <% else %>
+      <div class="thredded--topic-follow-info thredded--notfollowing">
+        <%= button_to 'Follow this topic', topic.follow_path %>
+      </div>
+    <% end %>
+  <% end %>
 </header>

data/app/views/thredded/topics/index.html.erb

@@ -1,4 +1,4 @@
-<% content_for :thredded_page_title, 'Topics' %>
+<% content_for :thredded_page_title, messageboard.name %>
 <% content_for :thredded_page_id, 'thredded--topics-index' %>
 <% content_for :thredded_breadcrumbs, render('thredded/shared/breadcrumbs') %>
 
@@ -8,7 +8,7 @@
                messageboard: messageboard,
                topic:        @new_topic,
                css_class:    'thredded--is-compact',
-               placeholder:  'Start a New Topic' if @new_topic %>
+               placeholder:  t('thredded.topics.form.title_placeholder_start') if @new_topic %>
     <%= render @topics %>
   <% end %>
 

data/app/views/thredded/topics/new.html.erb

@@ -7,5 +7,5 @@
              messageboard: messageboard,
              topic:        @new_topic,
              css_class:    'thredded--is-expanded',
-             placeholder:  'Start a New Topic' %>
+             placeholder:  t('thredded.topics.form.title_placeholder_start') %>
 <% end %>

data/config/locales/en.yml

@@ -18,6 +18,16 @@ en:
       updated_notice: Messageboard has been updated
     messageboard_group:
       create: Create a New Messageboard Group
+    moderation:
+      approve_btn: Approve
+      block_btn: Block
+      pending_empty:
+        title: Good job!
+        content: All posts have been moderated.
+      post_approved_html: Post approved by %{moderator} %{time_ago}.
+      post_blocked_html: Post blocked by %{moderator} %{time_ago}.
+      post_deleted_notice: This post has been deleted.
+      posts_content_changed_since_moderation_html: The <a href="%{post_url}">post's</a> content change since it was moderated. Below is the content at the time it was moderated.
     nav:
       all_messageboards: All Messageboards
       edit_messageboard: Edit Messageboard
@@ -26,8 +36,11 @@ en:
       edit_topic: Edit
       private_topics: Private Messages
       settings: Notification Settings
+      moderation: Moderation
+      moderation_history: History
     null_user_name: Deleted user
     posts:
+      pending_moderation_notice: Your post will be published when it has been reviewed by a moderator.
       delete: Delete Post
       delete_confirm: Are you sure you want to delete this post?
       deleted_notice: Your post has been deleted.
@@ -43,15 +56,15 @@ en:
         global_preferences_label: Global Settings
         messageboard_notify_on_mention:
           hint: >-
-            When someone mentions you by your username (eg: @sam) in this messageboard you will receive an email
-            with the contents of that post.
+            When someone mentions you by your username (eg: @sam) in this messageboard you will follow
+            the topic. You will receive emails with the contents of that post and any replies.
           label: :thredded.preferences.form.notify_on_mention.label
         messageboard_preferences_label_html: Notification Settings for <em>%{messageboard}</em>
         notify_on_mention:
           hint: >-
-            When someone mentions you by your username (eg: @sam) you will receive an email with the contents of
-            that post.
-          label: "@ Notifications"
+            When someone mentions you by your username (eg: @sam) you will follow the topic.
+            You will receive emails with the contents of that post and any replies.
+          label: "Follow topics you are mentioned in"
         notify_on_message:
           hint: When you are added to a private conversation you will receive an email with its content.
           label: Private Message Notifications
@@ -92,6 +105,7 @@ en:
         content_label: :thredded.posts.form.content_label
         title_label: Title
         title_placeholder: :thredded.topics.form.title_label
+        title_placeholder_start: Start a New Topic
         update_btn: Update Topic
       search:
         no_results_message: There are no results for your search - %{query}
@@ -99,3 +113,10 @@ en:
         results_message: Search Results for %{query}
       started_by_html: Started %{time_ago} by %{user}
       updated_notice: Topic updated
+      followed_notice: You are now following this topic
+      unfollowed_notice: You are no longer following this topic
+      following:
+        manual: You are following this topic.
+        posted: You are following this topic because you posted to it.
+        mentioned: You are following this topic because you were mentioned on it.
+      following_will_receive_emails: You will receive email updates.

data/config/locales/pt-BR.yml

@@ -18,12 +18,26 @@ pt-BR:
       updated_notice: Fórum de mensagem foi atualizado
     messageboard_group:
       create: Criar um novo grupo de mensagens
+    moderation:
+      approve_btn: Aprovar
+      block_btn: Quadra
+      pending_empty:
+        content: Todas as mensagens têm sido moderadas.
+        title: Bom trabalho!
+      post_approved_html: Pós aprovado por %{moderator} %{time_ago}.
+      post_blocked_html: Pós bloqueado por %{moderator} %{time_ago}.
+      post_deleted_notice: Este post foi apagado.
+      posts_content_changed_since_moderation_html: >-
+        O <a href="%{post_url}">de pós</a> alteração de conteúdo, uma vez que foi moderado. Abaixo está o conteúdo
+        no momento em que foi moderado.
     nav:
       all_messageboards: Todos os Fóruns de Mensagens
       edit_messageboard: Editar Fórum de Mensagem
       edit_post: Editar Post
       edit_private_topic: :thredded.nav.edit_topic
       edit_topic: Editar
+      moderation: Moderação
+      moderation_history: História
       private_topics: Mensagens Privadas
       settings: Configurações de Notificação
     null_user_name: Usuário deletado
@@ -36,6 +50,7 @@ pt-BR:
         content_label: Conteúdo
         create_btn: Enviar Resposta
         update_btn: Atualizar Post
+      pending_moderation_notice: O envio da mensagem será publicada quando foi revisado por um moderador.
     preferences:
       edit:
         page_title: :thredded.nav.settings
@@ -93,6 +108,7 @@ pt-BR:
         content_label: :thredded.posts.form.content_label
         title_label: Título
         title_placeholder: :thredded.topics.form.title_label
+        title_placeholder_start: Iniciar um novo tópico
         update_btn: Atualizar Tópico
       search:
         no_results_message: Nenhum resultado encontrado para sua busca - %{query}
@@ -100,3 +116,10 @@ pt-BR:
         results_message: Resultados de Busca para %{query}
       started_by_html: Iniciado %{time_ago} por %{user}
       updated_notice: Tópico atualizado
+      followed_notice: You are now following this topic
+      unfollowed_notice: You are no longer following this topic
+      following:
+        manual: You are following this topic.
+        posted: You are following this topic because you posted to it.
+        mentioned: You are following this topic because you were mentioned on it.
+      following_will_receive_emails: You will receive email updates.

data/config/routes.rb

@@ -29,6 +29,11 @@ Thredded::Engine.routes.draw do
 
   scope path: 'admin' do
     resources :messageboard_groups, only: [:new, :create]
+    scope controller: :moderation, path: 'moderation' do
+      get '(/page-:page)', action: :pending, as: :pending_moderation, constraints: page_constraint
+      post '', action: :moderate_post, as: :moderate_post
+      get '/history(/page-:page)', action: :history, as: :moderation_history, constraints: page_constraint
+    end
   end
 
   resource :preferences, only: [:edit, :update]
@@ -44,6 +49,8 @@ Thredded::Engine.routes.draw do
       end
       member do
         get '(page-:page)', action: :show, as: '', constraints: page_constraint
+        post 'follow'
+        post 'unfollow'
       end
       resources :posts, except: [:index, :show], path: ''
     end

data/db/migrate/20160329231848_create_thredded.rb

@@ -37,7 +37,9 @@ class CreateThredded < ActiveRecord::Migration
       t.integer :topics_count, default: 0
       t.integer :posts_count, default: 0
       t.boolean :closed, default: false, null: false
+      t.references :messageboard_group
       t.timestamps null: false
+      t.index [:messageboard_group_id], name: :index_thredded_messageboards_on_messageboard_group_id
     end
     add_index :thredded_messageboards, [:closed], name: :index_thredded_messageboards_on_closed
     add_index :thredded_messageboards, [:slug], name: :index_thredded_messageboards_on_slug
@@ -57,7 +59,11 @@ class CreateThredded < ActiveRecord::Migration
       t.string :source, limit: 255, default: 'web'
       t.integer :postable_id, limit: 4
       t.integer :messageboard_id, null: false
+      t.integer :moderation_state, null: false
       t.timestamps null: false
+      t.index [:moderation_state, :updated_at],
+              order: { updated_at: :asc },
+              name:  :index_thredded_posts_for_display
     end
     add_index :thredded_posts, [:messageboard_id], name: :index_thredded_posts_on_messageboard_id
     add_index :thredded_posts, [:postable_id], name: :index_thredded_posts_on_postable_id
@@ -111,7 +117,11 @@ class CreateThredded < ActiveRecord::Migration
       t.boolean :locked, default: false, null: false
       t.string :hash_id, limit: 191, null: false
       t.string :type, limit: 191
+      t.integer :moderation_state, null: false
       t.timestamps null: false
+      t.index %i(moderation_state sticky updated_at),
+              order: { sticky: :desc, updated_at: :desc },
+              name:  :index_thredded_topics_for_display
     end
     add_index :thredded_topics, [:hash_id], name: :index_thredded_topics_on_hash_id
     add_index :thredded_topics, [:messageboard_id, :slug], name: :index_thredded_topics_on_messageboard_id_and_slug, unique: true
@@ -124,11 +134,16 @@ class CreateThredded < ActiveRecord::Migration
       t.datetime :latest_activity_at
       t.integer :posts_count, default: 0
       t.integer :topics_count, default: 0
-      t.timestamps null: false
       t.datetime :last_seen_at
+      t.integer :moderation_state, null: false, default: 0 # pending_moderation
+      t.timestamp :moderation_state_changed_at
+      t.timestamps null: false
+      t.index %i(moderation_state moderation_state_changed_at),
+              order: { moderation_state_changed_at: :desc },
+              name: :index_thredded_user_details_for_moderations
+      t.index %i(latest_activity_at), name: :index_thredded_user_details_on_latest_activity_at
+      t.index %i(user_id), name: :index_thredded_user_details_on_user_id
     end
-    add_index :thredded_user_details, [:latest_activity_at], name: :index_thredded_user_details_on_latest_activity_at
-    add_index :thredded_user_details, [:user_id], name: :index_thredded_user_details_on_user_id
 
     create_table :thredded_messageboard_users do |t|
       t.references :thredded_user_detail, foreign_key: true, null: false
@@ -174,8 +189,28 @@ class CreateThredded < ActiveRecord::Migration
       t.timestamps null: false
     end
 
-    add_column :thredded_messageboards, :messageboard_group_id, :integer
-    add_index :thredded_messageboards, [:messageboard_group_id], name: :index_thredded_messageboards_on_messageboard_group_id
+    create_table :thredded_user_topic_follows do |t|
+      t.integer :user_id, null: false
+      t.integer :topic_id, null: false
+      t.datetime :created_at, null: false
+      t.integer :reason, limit: 1
+    end
+    add_index :thredded_user_topic_follows, [:user_id, :topic_id], name: :thredded_user_topic_follows_user_topic, unique: true
+
+    create_table :thredded_post_moderation_records do |t|
+      t.references :post
+      t.references :messageboard
+      t.text :post_content, limit: 65_535
+      t.references :post_user
+      t.text :post_user_name
+      t.references :moderator
+      t.integer :moderation_state, null: false
+      t.integer :previous_moderation_state, null: false
+      t.timestamp :created_at, null: false
+      t.index [:messageboard_id, :created_at],
+              order: { created_at: :desc },
+              name:  :index_thredded_moderation_records_for_display
+    end
   end
 end
 # rubocop:enable Metrics/LineLength