thredded 0.2.2 → 0.3.0

data/app/models/thredded/user_topic_read_state.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+module Thredded
+  class UserTopicReadState < ActiveRecord::Base
+    include UserTopicReadStateCommon
+    belongs_to :user,
+               class_name: Thredded.user_class,
+               inverse_of: :thredded_topic_read_states
+    belongs_to :postable,
+               class_name: 'Thredded::Topic',
+               inverse_of: :user_read_states
+  end
+end

data/app/policies/thredded/messageboard_policy.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+module Thredded
+  class MessageboardPolicy
+    # @param user [Thredded.user_class]
+    # @param messageboard [Thredded::Messageboard]
+    def initialize(user, messageboard)
+      @user = user
+      @messageboard = messageboard
+    end
+
+    def create?
+      @user.thredded_admin?
+    end
+
+    def read?
+      @user.thredded_admin? || @user.thredded_can_read_messageboards.include?(@messageboard)
+    end
+
+    def post?
+      @user.thredded_admin? || @user.thredded_can_write_messageboards.include?(@messageboard)
+    end
+
+    def moderate?
+      @user.thredded_admin? || @user.thredded_can_moderate_messageboards.include?(@messageboard)
+    end
+  end
+end

data/app/policies/thredded/post_policy.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+module Thredded
+  class PostPolicy
+    # @param user [Thredded.user_class]
+    # @param post [Thredded::Post]
+    def initialize(user, post)
+      @user = user
+      @post = post
+    end
+
+    def create?
+      @user.thredded_admin? || !@post.postable.locked? && messageboard_policy.post?
+    end
+
+    def update?
+      @user.thredded_admin? || own_post? || messageboard_policy.moderate?
+    end
+
+    def destroy?
+      @post.postable.first_post != @post && update?
+    end
+
+    private
+
+    def messageboard_policy
+      @messageboard_policy ||= MessageboardPolicy.new(@user, @post.messageboard)
+    end
+
+    def own_post?
+      @user.id == @post.user_id
+    end
+  end
+end

data/app/policies/thredded/private_post_policy.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+module Thredded
+  class PrivatePostPolicy
+    # @param user [Thredded.user_class]
+    # @param post [Thredded::PrivatePost]
+    def initialize(user, post)
+      @user = user
+      @post = post
+    end
+
+    def create?
+      @user.thredded_admin? || @post.postable.users.include?(@user)
+    end
+
+    def update?
+      @user.thredded_admin? || own_post?
+    end
+
+    def destroy?
+      @post.postable.first_post != @post && update?
+    end
+
+    private
+
+    def own_post?
+      @user.id == @post.user_id
+    end
+  end
+end

data/app/policies/thredded/private_topic_policy.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+module Thredded
+  class PrivateTopicPolicy
+    # @param user [Thredded.user_class]
+    # @param private_topic [Thredded::PrivateTopic]
+    def initialize(user, private_topic)
+      @private_topic = private_topic
+      @user = user
+    end
+
+    def create?
+      !@user.thredded_anonymous?
+    end
+
+    def read?
+      @private_topic.users.include?(@user)
+    end
+
+    def update?
+      @user.id == @private_topic.user_id
+    end
+  end
+end

data/app/policies/thredded/topic_policy.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+module Thredded
+  class TopicPolicy
+    # @param user [Thredded.user_class]
+    # @param topic [Thredded::Topic]
+    def initialize(user, topic)
+      @user = user
+      @topic = topic
+      @messageboard_user_permission = MessageboardPolicy.new(user, topic.messageboard)
+    end
+
+    def create?
+      @messageboard_user_permission.post?
+    end
+
+    def read?
+      @messageboard_user_permission.read?
+    end
+
+    def update?
+      @user.thredded_admin? || @topic.user_id == @user.id || moderate?
+    end
+
+    def destroy?
+      @user.thredded_admin?
+    end
+
+    def moderate?
+      @messageboard_user_permission.moderate?
+    end
+  end
+end

data/app/view_models/thredded/base_topic_view.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+require_dependency 'thredded/urls_helper'
+module Thredded
+  # A view model for TopicCommon.
+  class BaseTopicView
+    delegate :title,
+             :posts_count,
+             :updated_at,
+             :created_at,
+             :user,
+             :last_user,
+             :to_model,
+             to: :@topic
+
+    delegate :read?,
+             to: :@read_state
+
+    # @param topic [TopicCommon]
+    # @param read_state [UserTopicReadStateCommon, nil]
+    # @param policy [#destroy?]
+    def initialize(topic, read_state, policy)
+      @read_state = read_state || Thredded::NullUserTopicReadState.new
+      @topic      = topic
+      @policy     = policy
+    end
+
+    def states
+      [@read_state.read? ? :read : :unread]
+    end
+
+    def can_update?
+      @policy.update?
+    end
+
+    def can_destroy?
+      @policy.destroy?
+    end
+
+    def path
+      Thredded::UrlsHelper.topic_path(@topic, page: @read_state.page)
+    end
+
+    def self.inherited(subclass)
+      subclass.extend ClassMethods
+    end
+
+    module ClassMethods
+      def from_user(topic, user)
+        read_state = if user && !user.thredded_anonymous?
+                       topic.association(:user_read_states).klass.where(user_id: user.id, postable_id: topic.id).first
+                     end
+        new(topic, read_state, Pundit.policy!(user, topic))
+      end
+    end
+  end
+end

data/app/view_models/thredded/post_view.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+require_dependency 'thredded/urls_helper'
+module Thredded
+  # A view model for PostCommon.
+  class PostView
+    delegate :filtered_content,
+             :avatar_url,
+             :created_at,
+             :user,
+             :to_model,
+             to: :@post
+
+    # @param post [Thredded::PostCommon]
+    # @param policy [#update? #destroy?]
+    def initialize(post, policy)
+      @post   = post
+      @policy = policy
+    end
+
+    def can_update?
+      @can_update ||= @policy.update?
+    end
+
+    def can_destroy?
+      @can_destroy ||= @policy.destroy?
+    end
+
+    def edit_path
+      Thredded::UrlsHelper.edit_post_path(@post)
+    end
+
+    def destroy_path
+      Thredded::UrlsHelper.delete_post_path(@post)
+    end
+
+    def cache_key
+      [
+        @post,
+        @post.user,
+        [can_update?, can_destroy?].map { |p| p ? '+' : '-' } * ''
+      ]
+    end
+  end
+end

data/app/view_models/thredded/posts_page_view.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+require_dependency 'thredded/post_view'
+require_dependency 'thredded/topic_view'
+require_dependency 'thredded/private_topic_view'
+module Thredded
+  # A view model for a page of PostViews.
+  class PostsPageView
+    delegate :to_ary,
+             to: :@topic_views
+    delegate :total_pages,
+             :current_page,
+             :limit_value,
+             to: :@topics_page_scope
+
+    # @return [Thredded::BaseTopicView]
+    attr_reader :topic
+
+    # @param user [Thredded.user_class] the user who is viewing the posts page
+    # @param topic [Thredded::TopicCommon]
+    # @param posts_page_scope [ActiveRecord::Relation<Thredded::PostCommon>]
+    def initialize(user, topic, posts_page_scope)
+      @topics_page_scope = posts_page_scope
+      @topic_views = posts_page_scope.map { |post| PostView.new(post, Pundit.policy!(user, post)) }
+      @topic = "#{posts_page_scope.reflect_on_association(:postable).klass}View".constantize.from_user(topic, user)
+    end
+  end
+end

data/app/view_models/thredded/private_topic_view.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+module Thredded
+  # A view model for PrivateTopic.
+  class PrivateTopicView < BaseTopicView
+    def edit_path
+      Thredded::UrlsHelper.edit_private_topic_path(@topic)
+    end
+  end
+end

data/app/{decorators/thredded/topic_email_decorator.rb → view_models/thredded/topic_email_view.rb}

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 module Thredded
-  class TopicEmailDecorator
+  class TopicEmailView
     # @param [Thredded::TopicCommon] topic
     def initialize(topic)
       @topic = topic

data/app/view_models/thredded/topic_view.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+module Thredded
+  # A view model for Topic.
+  class TopicView < BaseTopicView
+    delegate :categories,
+             to: :@topic
+
+    def states
+      super + [
+        (:locked if @topic.locked?),
+        (:sticky if @topic.sticky?),
+      ].compact
+    end
+
+    def edit_path
+      Thredded::UrlsHelper.edit_messageboard_topic_path(@topic.messageboard, @topic)
+    end
+
+    def destroy_path
+      Thredded::UrlsHelper.messageboard_topic_path(@topic.messageboard, @topic)
+    end
+  end
+end

data/app/view_models/thredded/topics_page_view.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+require_dependency 'thredded/topic_view'
+require_dependency 'thredded/private_topic_view'
+module Thredded
+  # A view model for a page of BaseTopicViews.
+  class TopicsPageView
+    delegate :to_ary,
+             :blank?,
+             :empty?,
+             to: :@topic_views
+    delegate :total_pages,
+             :current_page,
+             :limit_value,
+             to: :@topics_page_scope
+
+    # @param user [Thredded.user_class] the user who is viewing the posts page
+    # @param topics_page_scope [ActiveRecord::Relation<Thredded::Topic>]
+    def initialize(user, topics_page_scope)
+      @topics_page_scope = topics_page_scope
+      topic_view_class = "#{topics_page_scope.klass}View".constantize
+      @topic_views = @topics_page_scope.with_read_states(user).map do |(topic, read_state)|
+        topic_view_class.new(topic, read_state, Pundit.policy!(user, topic))
+      end
+    end
+  end
+end

data/app/views/thredded/error_pages/forbidden.html.erb

@@ -0,0 +1,6 @@
+<% content_for :thredded_page_title, @message %>
+<% content_for :thredded_page_id, 'thredded--error-forbidden' %>
+<% content_for :thredded_breadcrumbs, render('thredded/shared/breadcrumbs') %>
+<%= thredded_page do %>
+  <p class="thredded--alert thredded--alert-warning"><%= @message %></p>
+<% end %>

data/app/views/thredded/error_pages/not_found.html.erb

@@ -0,0 +1,6 @@
+<% content_for :thredded_page_title, @message %>
+<% content_for :thredded_page_id, 'thredded--error-not-found' %>
+<% content_for :thredded_breadcrumbs, render('thredded/shared/breadcrumbs') %>
+<%= thredded_page do %>
+  <p class="thredded--alert thredded--alert-danger"><%= @message %></p>
+<% end %>

data/app/views/thredded/messageboards/_messageboard.html.erb

@@ -1,15 +1,22 @@
-<% if current_ability.can? :read, messageboard.original %>
+<% if policy(messageboard).read? %>
   <%= link_to messageboard_topics_path(messageboard), class: 'thredded--messageboard' do %>
     <header>
       <h2 class="thredded--messageboard--title"><%= messageboard.name %></h2>
-      <h3 class="thredded--messageboard--meta"><%= messageboard.meta %></h3>
+      <h3 class="thredded--messageboard--meta">
+        <%= t 'thredded.messageboard.topics_and_posts_counts',
+              topics_count: number_to_human(messageboard.topics_count).downcase,
+              posts_count:  number_to_human(messageboard.posts_count).downcase %>
+      </h3>
     </header>
 
     <p class="thredded--messageboard--description"><%= messageboard.description %></p>
 
-    <p class="thredded--messageboard--byline">
-      Updated <%= time_ago messageboard.latest_topic.updated_at %>
-      <cite>by <%= messageboard.latest_user %></cite>
-    </p>
+    <% if messageboard.latest_topic %>
+      <p class="thredded--messageboard--byline">
+        <%= t 'thredded.messageboard.last_updated_by_html',
+              time_ago: time_ago(messageboard.latest_topic.updated_at),
+              user:     messageboard.latest_user %>
+      </p>
+    <% end %>
   <% end %>
 <% end %>

data/app/views/thredded/messageboards/index.html.erb

@@ -1,18 +1,12 @@
 <% content_for :thredded_page_title, 'Messageboards' %>
 <% content_for :thredded_page_id, 'thredded--messageboards-index' %>
-<% content_for :thredded_breadcrumbs do %>
-  <ul class="thredded--navigation-breadcrumbs">
-    <li>
-      <%= link_to 'All Message Boards', messageboards_path %>
-    </li>
-  </ul>
-<% end %>
+<% content_for :thredded_breadcrumbs, render('thredded/shared/breadcrumbs') %>
 <%= thredded_page do %>
   <section class="thredded--main-section thredded--messageboards">
     <%= render @messageboards %>
   </section>
 
-  <% if current_ability.can? :create, Thredded::Messageboard %>
+  <% if policy(Thredded::Messageboard.new).create? %>
     <div class="thredded--messageboard--create">
       <a class="thredded--button" href="<%= new_messageboard_path %>">Create a New Messageboard</a>
     </div>

data/app/views/thredded/messageboards/new.html.erb

@@ -1,11 +1,17 @@
 <% content_for :thredded_page_title, 'Create a New Messageboard' %>
 <% content_for :thredded_page_id, 'thredded--messageboards-new' %>
+<% content_for :thredded_breadcrumbs do %>
+  <ul class="thredded--navigation-breadcrumbs">
+    <li>Create a New Messageboard</li>
+  </ul>
+<% end %>
+
 <%= thredded_page do %>
-  <%= form_for @messageboard, class: 'thredded--form' do |f| %>
+  <%= form_for @messageboard, html: { class: 'thredded--form' } do |f| %>
     <ul class="thredded--form-list">
       <li>
         <%= f.label :name %>
-        <%= f.text_field :name %>
+        <%= f.text_field :name, required: true %>
       </li>
       <li>
         <%= f.label :description %>