thredded 0.16.14 → 1.0.0

data/app/views/thredded/messageboards/_form.html.erb

@@ -1,16 +1,16 @@
 <%= form_for messageboard, html: { class: 'thredded--form' } do |f| %>
     <ul class="thredded--form-list">
       <li>
-        <%= f.label t('thredded.messageboard.form.title_label') %>
+        <%= f.label :name, t('thredded.messageboard.form.title_label') %>
         <%= f.text_field :name, required: true %>
         <%= render 'thredded/shared/field_errors', messages: f.object.errors[:name] %>
       </li>
       <li>
-        <%= f.label t('thredded.messageboard.form.description_label') %>
+        <%= f.label :description, t('thredded.messageboard.form.description_label') %>
         <%= f.text_field :description %>
       </li>
       <li>
-        <%= f.label t('thredded.messageboard.form.messageboard_group_id_label') %>
+        <%= f.label :messageboard_group_id, t('thredded.messageboard.form.messageboard_group_id_label') %>
         <%= f.collection_select :messageboard_group_id, Thredded::MessageboardGroup.all, :id, :name,
                                 include_blank: t('thredded.messageboard.form.no_group') %>
       </li>

data/app/views/thredded/posts_common/_actions.html.erb

@@ -20,7 +20,7 @@
 
 <%- if actions_html.present? %>
   <div class='thredded--post--dropdown'>
-    <%= inline_svg 'thredded/three-dot-menu.svg', class: 'thredded--post--dropdown--toggle' %>
+    <%= inline_svg_tag 'thredded/three-dot-menu.svg', class: 'thredded--post--dropdown--toggle' %>
     <div class='thredded--post--dropdown--actions'>
       <%= actions_html %>
     </div>

data/app/views/thredded/posts_common/_content.html.erb

@@ -1,3 +1,3 @@
 <div class="thredded--post--content">
-  <%= post.filtered_content(self, local_assigns[:options] || {}) %>
+  <%= post.filtered_content(self, **(local_assigns[:options] || {})) %>
 </div>

data/app/views/thredded/posts_common/actions/_quote.html.erb

@@ -1,4 +1,4 @@
-<%= link_to t('thredded.posts.quote_btn'), url_for(post.quote_url_params),
+<%= link_to t('thredded.posts.quote_btn'), post.quote_url_params,
             'data-thredded-quote-post' => post.quote_path,
             class: 'thredded--post--quote thredded--post--dropdown--actions--item',
             rel: 'nofollow' %>

data/app/views/thredded/shared/_page.html.erb

@@ -8,7 +8,7 @@
 <%# If thredded JS is loaded via an [async] script, the JS may
 run before or after DOMContentLoaded. Expose a flag to Thredded
 so it can initialize correctly. %>
-<%= javascript_tag 'data-turbolinks-eval': 'false', **(Thredded.rails_supports_csp_nonce? ? {nonce: true} : {}) do %>
+<%= javascript_tag 'data-turbolinks-eval': 'false', nonce: true do %>
   document.addEventListener('DOMContentLoaded', function() {
     (window.Thredded = window.Thredded || {}).DOMContentLoadedFired = true;
   });

data/app/views/thredded/shared/nav/_moderation.html.erb

@@ -2,9 +2,9 @@
   <% current = current_page_moderation? %>
   <li class="thredded--user-navigation--item thredded--user-navigation--moderation<%= ' thredded--is-current' if current %>">
     <%= link_to current ? nav_back_path : pending_moderation_path, rel: 'nofollow' do %>
-      <%= inline_svg 'thredded/moderation.svg',
-                     class: 'thredded--icon',
-                     title: t('thredded.nav.moderation') %>
+      <%= inline_svg_tag 'thredded/moderation.svg',
+                         class: 'thredded--icon',
+                         title: t('thredded.nav.moderation') %>
       <span class="thredded--nav-text"><%= t 'thredded.nav.moderation' %></span>
       <% if posts_pending_moderation_count > 0 %>
         <span class="thredded--user-navigation--moderation--pending-count"><%= posts_pending_moderation_count %></span>

data/app/views/thredded/shared/nav/_notification_preferences.html.erb

@@ -1,7 +1,7 @@
 <% current = current_page_preferences? %>
 <li class="thredded--user-navigation--settings thredded--user-navigation--item<%= ' thredded--is-current' if current %>">
   <%= link_to current ? nav_back_path(messageboard) : edit_preferences_path(messageboard), rel: 'nofollow' do %>
-    <%= inline_svg 'thredded/settings.svg', class: 'thredded--icon', title: t('thredded.nav.settings') %>
+    <%= inline_svg_tag 'thredded/settings.svg', class: 'thredded--icon', title: t('thredded.nav.settings') %>
     <span class="thredded--nav-text"><%= t('thredded.nav.settings') %></span>
   <% end %>
 </li>

data/app/views/thredded/shared/nav/_private_topics.html.erb

@@ -1,9 +1,9 @@
 <% current = current_page_private_topics? %>
 <li class="thredded--user-navigation--item thredded--user-navigation--private-topics<%= ' thredded--is-current' if current %>">
   <%= link_to current ? nav_back_path : private_topics_path, rel: 'nofollow' do %>
-    <%= inline_svg 'thredded/private-messages.svg',
-                   class: 'thredded--icon',
-                   title: t('thredded.nav.private_topics') %>
+    <%= inline_svg_tag 'thredded/private-messages.svg',
+                       class: 'thredded--icon',
+                       title: t('thredded.nav.private_topics') %>
     <span class="thredded--nav-text"><%= t('thredded.nav.private_topics') %></span>
     <% if unread_private_topics_count > 0 -%>
       <span class="thredded--user-navigation--private-topics--unread"><%= unread_private_topics_count %></span>

data/app/views/thredded/shared/nav/_standalone.html.erb

@@ -2,11 +2,11 @@
   <% resource_name = Thredded.user_class_name.demodulize.underscore %>
   <% if thredded_signed_in? %>
     <%= link_to main_app.send(:"destroy_#{resource_name}_session_path"), method: :delete do %>
-      Sign Out
+      t('thredded.nav.sign_out')
     <% end %>
   <% else %>
     <%= link_to main_app.send(:"new_#{resource_name}_session_path") do %>
-      Sign In / Register
+      t('thredded.nav.sign_in')
     <% end %>
   <% end %>
 </li>

data/app/views/thredded/topics/_header.html.erb

@@ -20,7 +20,7 @@
         </span>
         <%= button_to topic.unfollow_path, form: {class: 'thredded--topic-header--follow-info--unfollow'} do %>
           <%= t('thredded.topics.unfollow') %>
-          <%= inline_svg 'thredded/follow.svg', class: 'thredded--topic-header--follow-icon' %>
+          <%= inline_svg_tag 'thredded/follow.svg', class: 'thredded--topic-header--follow-icon' %>
         <% end %>
       </div>
     <% else %>

data/bin/create_migration_fixture

@@ -0,0 +1,23 @@
+#!/usr/bin/env bash
+
+# edit constants in lib/thredded/db_tools.rb
+# git checkout v0.x.0 -b create-0.x-migration-fixture
+# bundle
+
+DIR=$(pwd)
+
+cd spec/dummy && DB=sqlite3 rails db:environment:set RAILS_ENV=development
+cd $DIR
+DB=sqlite3 rake db:drop db:create db:migrate db:miniseed_dump
+
+cd spec/dummy && DB=postgresql rails db:environment:set RAILS_ENV=development
+cd $DIR
+DB=postgresql rake db:drop db:create db:migrate db:miniseed_dump
+
+cd spec/dummy && DB=mysql2 rails db:environment:set RAILS_ENV=development
+cd $DIR
+DB=mysql2 rake db:drop db:create db:migrate db:miniseed_dump
+
+git add `pwd`/spec/migration/*.dump
+
+git commit -em "add sample data for 0.8 base for migration spec"

data/config/i18n-tasks.yml

@@ -15,3 +15,8 @@ data:
   yaml:
     write:
       line_width: 110
+
+## Exclude these keys from the `i18n-tasks check-consistent-interpolations` report:
+ignore_inconsistent_interpolations:
+- 'thredded.users.posts_count.one'
+- 'thredded.users.started_topics_count.one'

data/config/locales/de.yml

@@ -128,6 +128,8 @@ de:
       moderation_users: Nutzer
       private_topics: Private Unterhaltungen
       settings: Benachrichtigungseinstellungen
+      sign_in: Anmelden
+      sign_out: Ausloggen
       unread_topics: Ungelesen
     null_user_name: Gelöschte Nutzer
     posts:

data/config/locales/en.yml

@@ -127,6 +127,8 @@ en:
       moderation_users: Users
       private_topics: Private Messages
       settings: Notification Settings
+      sign_in: Sign In / Register
+      sign_out: Sign Out
       unread_topics: Unread
     null_user_name: Deleted user
     posts:
@@ -262,7 +264,7 @@ en:
       last_active_html: Last active %{time_ago}
       posted_in_topic_html: Posted in %{topic_link}
       posts_count:
-        one: Posted %{count} time
+        one: Posted once
         other: Posted %{count} times
       recent_activity: :thredded.recent_activity
       send_private_message: Send private message

data/config/locales/es.yml

@@ -129,6 +129,8 @@ es:
       moderation_users: Usuarios
       private_topics: Mensajes Privados
       settings: Ajuste de Notificaciones
+      sign_in: Registrarse
+      sign_out: Desconectar
       unread_topics: No leído
     null_user_name: Usuario eliminado
     posts:

data/config/locales/fr.yml

@@ -127,6 +127,8 @@ fr:
       moderation_users: Utilisateurs
       private_topics: Messages privés
       settings: Paramètres de notifications
+      sign_in: Se connecter
+      sign_out: Déconnexion
       unread_topics: Non lu
     null_user_name: Utilisateur effacé
     posts:

data/config/locales/it.yml

@@ -127,6 +127,8 @@ it:
       moderation_users: Utenti
       private_topics: Messaggi Privati
       settings: Impostazioni Notifiche
+      sign_in: Entra
+      sign_out: Esci
       unread_topics: Non letto
     null_user_name: Utente cancellato
     posts:
@@ -266,13 +268,13 @@ it:
       last_active_html: Ultima attività %{time_ago}
       posted_in_topic_html: Ha scritto in %{topic_link}
       posts_count:
-        one: Ha commentato %{count} volta
+        one: Ha commentato una volta
         other: Ha commentato %{count} volte
       recent_activity: :thredded.recent_activity
       send_private_message: Invia un messaggio privato
       started_topic_html: Ha iniziato %{topic_link}
       started_topics_count:
-        one: Ha iniziato %{count} discussione
+        one: Ha iniziato una discussione
         other: Ha iniziato %{count} discussioni
       user_posted_in_topic_html: "%{user_link} ha commentato in %{topic_link}"
       user_since_html: Utente da %{time_ago}

data/config/locales/pl.yml

@@ -127,6 +127,8 @@ pl:
       moderation_users: Użytkownicy
       private_topics: Prywatne wiadomości
       settings: Ustawienia powiadomień
+      sign_in: Zaloguj
+      sign_out: Wyloguj się
       unread_topics: Nieprzeczytane
     null_user_name: Usunięci użytkownicy
     posts:

data/config/locales/pt-BR.yml

@@ -129,6 +129,8 @@ pt-BR:
       moderation_users: Usuários
       private_topics: Mensagens Privadas
       settings: Configurações de Notificação
+      sign_in: Entrar / Cadastrar
+      sign_out: Sair
       unread_topics: Não lida
     null_user_name: Usuário deletado
     posts:

data/config/locales/ru.yml

@@ -125,6 +125,8 @@ ru:
       moderation_users: Пользователи
       private_topics: Личное
       settings: Настройки
+      sign_in: Войти / Зарегистрироваться
+      sign_out: Выход
       unread_topics: Непрочитанные
     null_user_name: Пользователь удален
     posts:

data/config/locales/zh-CN.yml

@@ -120,6 +120,8 @@ zh-CN:
       moderation_users: 用户
       private_topics: 私人对话
       settings: 通知设置
+      sign_in: 登录/注册
+      sign_out: 登出
       unread_topics: 未读
     null_user_name: 删除用户
     posts:

data/db/upgrade_migrations/20180110200009_upgrade_thredded_v0_14_to_v0_15.rb

@@ -86,6 +86,6 @@ class UpgradeThreddedV014ToV015 < Thredded::BaseMigration
   def remove_string_limit(table, column, type: :text, indices: [])
     indices.each { |(_, options)| remove_index table, name: options[:name] }
     change_column table, column, type, limit: nil
-    indices.each { |args| add_index table, *args }
+    indices.each { |(columns, options)| add_index table, columns, **options }
   end
 end

data/lib/generators/thredded/install/templates/initializer.rb

@@ -29,8 +29,8 @@ Thredded.user_path = ->(user) {
 # This method is used by Thredded controllers and views to fetch the currently signed-in user
 Thredded.current_user_method = :"current_#{Thredded.user_class_name.demodulize.underscore}"
 
-# User avatar URL. rb-gravatar gem is used by default:
-Thredded.avatar_url = ->(user) { Gravatar.src(user.email, 156, 'mm') }
+# User avatar URL. rails_gravatar gem is used by default:
+Thredded.avatar_url = ->(user) { RailsGravatar.src(user.email, 156, 'mm') }
 
 # ==> Permissions Configuration
 # By default, thredded uses a simple permission model, where all the users can post to all message boards,

data/lib/thredded/arel_compat.rb

@@ -1,27 +1,5 @@
 # frozen_string_literal: true
 
-unless Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR >= 2 || Rails::VERSION::MAJOR > 5
-  require 'thredded/rails_lt_5_2_arel_case_node.rb'
-end
-
-if Rails::VERSION::MAJOR == 4
-  # Make `pluck` compatible with Arel.
-  require 'active_record/relation'
-  ActiveRecord::Relation.prepend(Module.new do
-    def pluck(*column_names)
-      super(*column_names.map do |n|
-        if n.is_a?(Arel::Node)
-          Arel.sql(n.to_sql)
-        elsif n.is_a?(Arel::Attributes::Attribute)
-          n.name
-        else
-          n
-        end
-      end)
-    end
-  end)
-end
-
 module Thredded
   module ArelCompat
     module_function
@@ -37,15 +15,5 @@ module Thredded
         Arel::Nodes::Division.new(a, b)
       end
     end
-
-    if Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR >= 2 || Rails::VERSION::MAJOR > 5
-      def true_value(_engine)
-        true
-      end
-    else
-      def true_value(engine)
-        engine.connection.adapter_name =~ /sqlite|mysql|mariadb/i ? 1 : true
-      end
-    end
   end
 end

data/lib/thredded/base_migration.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Thredded
-  class BaseMigration < (Thredded.rails_gte_51? ? ActiveRecord::Migration[5.1] : ActiveRecord::Migration)
+  class BaseMigration < ActiveRecord::Migration[5.1]
     protected
 
     def user_id_type

data/lib/thredded/collection_to_strings_with_cache_renderer.rb

@@ -22,17 +22,18 @@ module Thredded
     def render_collection_to_strings_with_cache( # rubocop:disable Metrics/ParameterLists
       view_context, collection:, partial:, expires_in:, render_threads: self.class.render_threads, locals: {}, **opts
     )
-      template = @lookup_context.find_template(partial, [], true, locals, {})
+      template = @lookup_context.find_template(partial, [], true, locals.keys, {})
       collection = collection.to_a
-      instrument(:collection, identifier: template.identifier, count: collection.size) do |instrumentation_payload|
+      ActiveSupport::Notifications.instrument(:collection,
+                                              identifier: template.identifier,
+                                              count: collection.size) do |instrumentation_payload|
         return [] if collection.blank?
-        keyed_collection = collection.each_with_object({}) do |item, hash|
-          key = ActiveSupport::Cache.expand_cache_key(
-            view_context.cache_fragment_name(item, virtual_path: template.virtual_path), :views
-          )
-          # #read_multi & #write may require key mutability, Dalli 2.6.0.
-          hash[key.frozen? ? key.dup : key] = item
-        end
+
+        # Result is a hash with the key represents the
+        # key used for cache lookup and the value is the item
+        # on which the partial is being rendered
+        keyed_collection, ordered_keys = collection_by_cache_keys(collection, view_context, template)
+
         cache = collection_cache
         cached_partials = cache.read_multi(*keyed_collection.keys)
         instrumentation_payload[:cache_hits] = cached_partials.size if instrumentation_payload
@@ -44,9 +45,9 @@ module Thredded
           partial: partial, locals: locals, **opts
         ).each
 
-        keyed_collection.map do |cache_key, item|
-          [item, cached_partials[cache_key] || rendered_partials.next.tap do |rendered|
-            cache.write(cache_key, rendered, expires_in: expires_in)
+        ordered_keys.map do |cache_key|
+          [keyed_collection[cache_key], cached_partials[cache_key] || rendered_partials.next.tap do |rendered|
+            cached_partials[cache_key] = cache.write(cache_key, rendered, expires_in: expires_in)
           end]
         end
       end
@@ -54,16 +55,24 @@ module Thredded
 
     private
 
-    def collection_cache
-      if ActionView::PartialRenderer.respond_to?(:collection_cache)
-        # Rails 5.0+
-        ActionView::PartialRenderer.collection_cache
-      else
-        # Rails 4.2.x
-        Rails.application.config.action_controller.cache_store
+    def collection_by_cache_keys(collection, view, template)
+      digest_path = digest_path_from_template(view, template)
+
+      collection.each_with_object([{}, []]) do |item, (hash, ordered_keys)|
+        key = expanded_cache_key(item, view, template, digest_path)
+        ordered_keys << key
+        hash[key] = item
       end
     end
 
+    def expanded_cache_key(key, view, template, digest_path)
+      key = combined_fragment_cache_key(
+        view,
+        cache_fragment_name(view, key, virtual_path: template.virtual_path, digest_path: digest_path)
+      )
+      key.frozen? ? key.dup : key # #read_multi & #write may require mutability, Dalli 2.6.0.
+    end
+
     # @return [Array<String>]
     def render_partials(view_context, collection:, render_threads:, **opts)
       return [] if collection.empty?
@@ -72,25 +81,79 @@ module Thredded
         render_partials_serial(view_context, collection, opts)
       else
         collection.each_slice(collection.size / num_threads).map do |slice|
-          Thread.start { render_partials_serial(view_context.dup, slice, opts) }
+          Thread.start do
+            # `ActionView::PartialRenderer` mutates the contents of `opts[:locals]`, `opts[:locals][:as]` in particular:
+            # https://github.com/rails/rails/blob/v6.0.2.1/actionview/lib/action_view/renderer/partial_renderer.rb#L379
+            # https://github.com/rails/rails/blob/v6.0.2.1/actionview/lib/action_view/renderer/partial_renderer.rb#L348-L356
+            opts[:locals] = opts[:locals].dup if opts[:locals]
+            ActiveRecord::Base.connection_pool.with_connection do
+              render_partials_serial(view_context.dup, slice, opts)
+            end
+          end
         end.flat_map(&:value)
       end
     end
 
-    # @param [Array<Object>] collection
-    # @param [Hash] opts
-    # @param view_context
-    # @return [Array<String>]
-    def render_partials_serial(view_context, collection, opts)
-      partial_renderer = ActionView::PartialRenderer.new(@lookup_context)
-      collection.map { |object| render_partial(partial_renderer, view_context, opts.merge(object: object)) }
+    if Thredded::Compat.rails_gte_61?
+      # @param [Array<Object>] collection
+      # @param [Hash] opts
+      # @param view_context
+      # @return [Array<String>]
+      def render_partials_serial(view_context, collection, opts)
+        # https://github.com/rails/rails/pull/38594
+        collection.map do |object|
+          renderer = ActionView::ObjectRenderer.new(@lookup_context, opts)
+          renderer.render_object_with_partial(object, opts[:partial], view_context, nil).body
+        end
+      end
+    else
+      def render_partials_serial(view_context, collection, opts)
+        partial_renderer = ActionView::PartialRenderer.new(@lookup_context)
+        collection.map { |object| render_partial(partial_renderer, view_context, **opts.merge(object: object)) }
+      end
     end
 
-    if Rails::VERSION::MAJOR >= 6
+    def collection_cache
+      ActionView::PartialRenderer.collection_cache
+    end
+
+    def combined_fragment_cache_key(view, key)
+      view.combined_fragment_cache_key(key)
+    end
+
+    if Thredded::Compat.rails_gte_60?
+      def cache_fragment_name(view, key, virtual_path:, digest_path:)
+        if Thredded::Compat.rails_gte_61?
+          view.cache_fragment_name(key, digest_path: digest_path)
+        else
+          view.cache_fragment_name(key, virtual_path: virtual_path, digest_path: digest_path)
+        end
+      end
+
+      def digest_path_from_template(view, template)
+        view.digest_path_from_template(template)
+      end
+
       def render_partial(partial_renderer, view_context, opts)
         partial_renderer.render(view_context, opts, nil).body
       end
     else
+      def cache_fragment_name(_view, key, virtual_path:, digest_path:)
+        if digest_path
+          ["#{virtual_path}:#{digest_path}", key]
+        else
+          [virtual_path, key]
+        end
+      end
+
+      def digest_path_from_template(view, template)
+        ActionView::Digestor.digest(
+          name: template.virtual_path,
+          finder: @lookup_context,
+          dependencies: view.view_cache_dependencies
+        ).presence
+      end
+
       def render_partial(partial_renderer, view_context, opts)
         partial_renderer.render(view_context, opts, nil)
       end

data/lib/thredded/compat.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Thredded
+  module Compat
+    class << self
+      # @api private
+      def rails_gte_60?
+        @rails_gte_60 = (Rails.gem_version >= Gem::Version.new('6.0.0')) if @rails_gte_60.nil?
+        @rails_gte_60
+      end
+
+      # @api private
+      def rails_gte_61?
+        @rails_gte_61 = (Rails.gem_version >= Gem::Version.new('6.1.0')) if @rails_gte_61.nil?
+        @rails_gte_61
+      end
+
+      if Rails.gem_version >= Gem::Version.new('7.0.0')
+        # @api private
+        def association_preloader(records:, associations:, scope:)
+          ActiveRecord::Associations::Preloader.new(
+            records: records, associations: associations, scope: scope
+          ).call
+        end
+      else
+        # @api private
+        def association_preloader(records:, associations:, scope:)
+          ActiveRecord::Associations::Preloader.new.preload(
+            records, associations, scope
+          )
+        end
+      end
+    end
+  end
+end

data/lib/thredded/database_seeder.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'factory_bot'
-require_relative '../../spec/support/features/fake_content'
+require_relative '../../spec/support/system/fake_content'
 
 # rubocop:disable HandleExceptions
 begin
@@ -40,6 +40,7 @@ module Thredded
     end
 
     include LogTime
+    include Thredded::ApplicationHelper
 
     SKIP_CALLBACKS = [
       [Thredded::Post, :commit, :after, :update_parent_last_user_and_time_from_last_post, on: %i[create destroy]],
@@ -131,7 +132,13 @@ module Thredded
     end
 
     def fake_post_contents
-      @fake_post_contents ? @fake_post_contents.sample : FakeContent.post_content
+      with_mentions(@fake_post_contents ? @fake_post_contents.sample : FakeContent.post_content)
+    end
+
+    def with_mentions(post, mentions_count: rand(3))
+      return post if mentions_count.zero?
+
+      ([post] + Array.new(mentions_count).map { user_mention(@users.sample) }).join(' ')
     end
 
     def first_user
@@ -255,9 +262,9 @@ module Thredded
 
       delegate :log, to: :seeder
 
-      def find_or_create(*args)
+      def find_or_create(*args, **kwargs)
         return @stored if @stored
-        @stored = (find || create(*args))
+        @stored = (find || create(*args, **kwargs))
       end
 
       def range_of_dates_in_order(up_to: Time.zone.now, count: 1)

data/lib/thredded/db_tools.rb

@@ -10,12 +10,10 @@ module Thredded
         verbose_was = ActiveRecord::Migration.verbose
         ActiveRecord::Migration.verbose = !quiet
         migrate =
-          if Rails.gem_version >= Gem::Version.new('6.0.0.rc2')
+          if Thredded::Compat.rails_gte_60?
             -> { ActiveRecord::MigrationContext.new(paths, ActiveRecord::SchemaMigration).migrate(nil, &filter) }
-          elsif Rails::VERSION::STRING >= '5.2'
+          else # Rails 5.2
             -> { ActiveRecord::MigrationContext.new(paths).migrate(nil, &filter) }
-          else
-            -> { ActiveRecord::Migrator.migrate(paths, &filter) }
           end
         if quiet
           silence_active_record(&migrate)

data/lib/thredded/email_transformer.rb

@@ -17,8 +17,8 @@ module Thredded
     end
     @transformers = [Onebox, Spoiler]
 
-    # @param doc [Nokogiri::HTML::Document]
-    def self.call(doc)
+    # @param dom [Nokogiri::HTML::Document]
+    def self.call(doc, *)
       transformers.each { |transformer| transformer.call(doc) }
     end
   end

data/lib/thredded/html_pipeline/onebox_filter.rb

@@ -39,12 +39,10 @@ module Thredded
         # Regardless, always store the onebox in a file cache to enable offline development,
         # persistence between test runs, and to improve performance.
         attr_accessor :onebox_views_cache
-        attr_accessor :onebox_data_cache
       end
 
       if Rails.env.development? || Rails.env.test?
         self.onebox_views_cache = ActiveSupport::Cache::FileStore.new('tmp/cache/onebox-views')
-        self.onebox_data_cache = ActiveSupport::Cache::FileStore.new('tmp/cache/onebox-data')
       end
 
       def call
@@ -84,8 +82,7 @@ module Thredded
       end
 
       def onebox_options(_url)
-        { cache: context[:onebox_data_cache] || self.class.onebox_data_cache || Rails.cache,
-          sanitize_config: SANITIZE_CONFIG }
+        { sanitize_config: SANITIZE_CONFIG }
       end
 
       def onebox_views_cache

data/lib/thredded/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Thredded
-  VERSION = '0.16.14'
+  VERSION = '1.0.0'
 end