thredded-workgroup 0.2.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f28a842a59d912a9783e4e78221ac3e69be33e5f1591c1f797775b0b9a484edd
-  data.tar.gz: ffbe48d420241715d23dbaa34d2a6a71734c10c256532454d57d5e178e71ca66
+  metadata.gz: 5efefc1d7010c94166f28b7c5eef2f1068aed1e7695b7b322e39a51456b6b46b
+  data.tar.gz: 7557fd4b245b16ccabfc6e2c1bacd5d93e2688ba222ddb424330774cbe38d9a8
 SHA512:
-  metadata.gz: ce3484294af2edbe09f9bff0952b528c3714dee4b72623c55e7eab7375c25f9ec745a7cd9a7c7f2fcc0dc7bac4c06a4d1653312c5b3c8099ffb8aef41db52594
-  data.tar.gz: f4c04872bbed1da6e80ef89e2d6dafda15ca070b8fc408d0a19f75110bd5eb2841f83c69449ad177cb0a4d3ae654ac05ef608572e80db9768d59a17adf3295b6
+  metadata.gz: b7c4da998f27f48915f3cc3c55fb85d34f62d754d9adb14e579faa9a88cf24b5932a2d270521955968a8557e3bb33f573f9f75f8fadce867248040a699075ec5
+  data.tar.gz: 4f596f4e2fe49ac827056557a7ec902f7686684ccde0db38c21470726118d12d6ecada6d0857e8906aaad26f00e66c59c4e29a8775b8aef21f726579c5de5342

data/.rubocop.yml

@@ -1,8 +1,19 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rspec
+
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.6
   Exclude:
   - 'spec/dummy/db/**/*'
   - 'vendor/**/*'
+  DisplayCopNames: true
+  NewCops: enable
+  CacheRootDirectory: tmp # ie. tmp/rubocop_cache
+  UseCache: true
 
 Metrics/AbcSize:
   Enabled: false
@@ -10,7 +21,10 @@ Metrics/AbcSize:
 Metrics/ClassLength:
   Max: 125
 
-Metrics/LineLength:
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/factories/*'
+Layout/LineLength:
   Max: 120
 
 Metrics/MethodLength:
@@ -29,10 +43,10 @@ Style/CollectionMethods:
 Style/Documentation:
   Enabled: false
 
-Style/MultilineMethodCallIndentation:
+Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
-Style/PredicateName:
+Naming/PredicateName:
   Exclude:
   - spec/**/*.rb
 
@@ -42,7 +56,10 @@ Style/SignalException:
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+
+Style/TrailingCommaInHashLiteral:
   Enabled: false
 
 Style/TrailingCommaInArguments:
@@ -61,5 +78,5 @@ Rails/FindBy:
   - app/models/**/*.rb
   - app/view_models/**/*.rb
 
-Lint/EndAlignment:
+Layout/EndAlignment:
   AutoCorrect: true

data/.rubocop_todo.yml

@@ -0,0 +1,392 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2022-02-26 17:50:27 UTC using RuboCop version 1.25.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/OrderedGems:
+  Exclude:
+    - 'shared.gemfile'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemspec
+Gemspec/OrderedDependencies:
+  Exclude:
+    - 'thredded-workgroup.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequireMFA:
+  Exclude:
+    - 'thredded-workgroup.gemspec'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'thredded-workgroup.gemspec'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'app/controllers/thredded/application_controller.rb'
+    - 'spec/dummy/app/controllers/application_controller.rb'
+    - 'spec/dummy/app/controllers/concerns/store_location_fullpath.rb'
+    - 'spec/dummy/app/controllers/sessions_controller.rb'
+    - 'spec/support/system/fake_content.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines.
+Layout/EmptyLineBetweenDefs:
+  Exclude:
+    - 'app/controllers/thredded/application_controller.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLines:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceBeforeBlockBraces:
+  Exclude:
+    - 'spec/system/user_marks_topic_as_read_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideBlockBraces:
+  Exclude:
+    - 'spec/system/user_marks_topic_as_read_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'spec/factories/thredded.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'spec/lib/thredded/all_view_hooks_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: MaximumRangeSize.
+Lint/MissingCopEnableDirective:
+  Exclude:
+    - 'thredded-workgroup.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct-all.
+Lint/NonDeterministicRequireOrder:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'thredded-workgroup.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/SendWithMixinArgument:
+  Exclude:
+    - 'lib/thredded/workgroup/route_delegator.rb'
+
+# Offense count: 11
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
+Metrics/BlockLength:
+  Max: 126
+
+# Offense count: 1
+# Configuration parameters: MinSize.
+Performance/CollectionLiteralInLoop:
+  Exclude:
+    - 'spec/support/system/fake_content.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/RegexpMatch:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+RSpec/Capybara/CurrentPathExpectation:
+  Exclude:
+    - 'spec/system/user_adds_post_and_is_redirected_spec.rb'
+    - 'spec/system/user_marks_post_as_unread_spec.rb'
+
+# Offense count: 7
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/controllers/thredded/topics_controller_spec.rb'
+    - 'spec/system/views_navs_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/view_models/topic_view_spec.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: AllowConsecutiveOneLiners.
+RSpec/EmptyLineAfterExample:
+  Exclude:
+    - 'spec/lib/thredded/all_view_hooks_spec.rb'
+    - 'spec/system/views_navs_spec.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+RSpec/EmptyLineAfterFinalLet:
+  Exclude:
+    - 'spec/controllers/thredded/topics_controller_spec.rb'
+    - 'spec/lib/thredded/all_view_hooks_spec.rb'
+    - 'spec/system/main_app_pages_spec.rb'
+    - 'spec/system/user_clicks_to_follow_unfollow_topic_spec.rb'
+    - 'spec/system/views_navs_spec.rb'
+    - 'spec/view_models/topic_view_spec.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+RSpec/EmptyLineAfterHook:
+  Exclude:
+    - 'spec/system/main_app_pages_spec.rb'
+    - 'spec/system/user_clicks_to_follow_unfollow_topic_spec.rb'
+    - 'spec/system/views_navs_spec.rb'
+    - 'spec/view_models/topic_view_spec.rb'
+
+# Offense count: 10
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 9
+
+# Offense count: 18
+# Cop supports --auto-correct.
+# Configuration parameters: Include.
+# Include: spec/factories.rb, spec/factories/**/*.rb, features/support/factories/**/*.rb
+RSpec/FactoryBot/FactoryClassName:
+  Exclude:
+    - 'spec/factories/thredded.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, each, example
+RSpec/HookArgument:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 2
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/lib/thredded/all_view_hooks_spec.rb'
+
+# Offense count: 7
+RSpec/LetSetup:
+  Exclude:
+    - 'spec/controllers/thredded/topics_controller_spec.rb'
+    - 'spec/system/user_adds_post_and_is_redirected_spec.rb'
+    - 'spec/system/user_clicks_to_follow_unfollow_topic_spec.rb'
+    - 'spec/system/views_navs_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 11
+RSpec/MultipleExpectations:
+  Max: 4
+
+# Offense count: 12
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 8
+
+# Offense count: 2
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/view_models/topic_view_spec.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+RSpec/ScatteredLet:
+  Exclude:
+    - 'spec/system/user_adds_post_and_is_redirected_spec.rb'
+    - 'spec/system/user_clicks_to_follow_unfollow_topic_spec.rb'
+    - 'spec/system/views_navs_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Rails/ApplicationRecord:
+  Exclude:
+    - 'spec/dummy/app/models/user.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
+Rails/FilePath:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: spec/**/*.rb, test/**/*.rb
+Rails/I18nLocaleAssignment:
+  Exclude:
+    - 'spec/dummy/app/controllers/concerns/set_locale.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/controllers/**/*.rb
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - 'app/controllers/thredded/workgroup/navs_controller.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct-all.
+# Configuration parameters: Include.
+# Include: **/Rakefile, **/*.rake
+Rails/RakeEnvironment:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: spec/**/*.rb, test/**/*.rb
+Rails/TimeZoneAssignment:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 1
+Style/CombinableLoops:
+  Exclude:
+    - 'spec/lib/thredded/all_view_hooks_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: compact, expanded
+Style/EmptyMethod:
+  Exclude:
+    - 'spec/support/authentication_support.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+    - 'thredded-workgroup.gemspec'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Exclude:
+    - 'Rakefile'
+    - 'bin/rails.rb'
+    - 'spec/dummy/config.ru'
+    - 'spec/gemfiles/rails_5_2.gemfile'
+    - 'spec/spec_helper.rb'
+    - 'thredded-workgroup.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/GlobalStdStream:
+  Exclude:
+    - 'spec/dummy/config/environments/production.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'spec/system/user_clicks_to_follow_unfollow_topic_spec.rb'
+
+# Offense count: 1
+Style/OpenStructUse:
+  Exclude:
+    - 'spec/factories/thredded.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/thredded/workgroup/engine.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct-all.
+# Configuration parameters: Methods.
+Style/RedundantArgument:
+  Exclude:
+    - 'spec/lib/thredded/all_view_hooks_spec.rb'
+    - 'spec/support/system/fake_content.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'Rakefile'
+    - 'spec/dummy/bin/yarn'
+
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# AllowedMethods: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'Rakefile'
+    - 'spec/system/user_adds_post_and_is_redirected_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/StderrPuts:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 2
+# Cop supports --auto-correct-all.
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'spec/support/system/fake_content.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, MinSize.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  Exclude:
+    - 'Rakefile'
+    - 'spec/spec_helper.rb'

data/.travis.yml

@@ -1,45 +1,37 @@
-# use travis defaults from capybara-webkit
-sudo: required
-dist: trusty
-
-addons:
-  apt:
-    sources:
-    - ubuntu-sdk-team
-    packages:
-    - libqt5webkit5-dev
-    - qtdeclarative5-dev
+dist: bionic
 
 language: ruby
 rvm:
-  - 2.3
-#  - 2.4 # not till rails 4.2.8 is released
+  - 2.6
 cache: bundler
 bundler_args: --path ../../vendor/bundle --without debug
 gemfile:
-  - spec/gemfiles/rails_4_2.gemfile
-  - spec/gemfiles/rails_5_0.gemfile
-  - spec/gemfiles/rails_5_1.gemfile
   - spec/gemfiles/rails_5_2.gemfile
 
-env:
-  global:
-    - QMAKE=/usr/lib/x86_64-linux-gnu/qt5/bin/qmake
-  matrix:
-    # Username and password from http://docs.travis-ci.com/user/database-setup/
-    - DB=sqlite3 DBC_VERBOSE=true
-    #  - DB=mysql2     DB_USERNAME=root     DB_PASSWORD=""
-    - DB=postgresql DB_USERNAME=postgres DB_PASSWORD=""
-
-matrix:
+jobs:
   fast_finish: true
   allow_failures:
     - env: DB=sqlite3 DBC_VERBOSE=true
+  include:
+    - name: audit
+      gemfile: spec/gemfiles/rails_5_2.gemfile
+      before_script: ""
+      script:
+        - bundle show rubocop
+        - bundle exec rubocop
+        - cp $BUNDLE_GEMFILE Gemfile.lock
+        - bundle exec bundle-audit check --update -v
+    - gemfile: spec/gemfiles/rails_5_2.gemfile
+      rvm: 2.6
+      env: DB=postgresql DB_USERNAME=postgres DB_PASSWORD=""
+      services: postgresql
+    - gemfile: spec/gemfiles/rails_5_2.gemfile
+      rvm: 2.6
+      env: DB=sqlite3 DBC_VERBOSE=true
+
 
 before_script:
   - RAILS_ENV=test bundle exec rake db:create db:migrate
 
 script:
   - xvfb-run bundle exec rspec
-  - bundle show rubocop
-  - bundle exec rubocop

data/CHANGELOG.md

@@ -1,3 +1,21 @@
+# v0.3.0, v0.3.1
+
+This version supports:
+
+* thredded v1.0 +
+* rails 5.2
+
+v0.3.1 was just a fix to a link in the gem
+
+# v0.2.1
+
+Support sprockets 4
+
+This version supports:
+ 
+ * thredded v0.16.0+
+ * rails 4.2 - 5.2
+
 # v0.2.0
 
 It's the first actual release (the theoretical v0.1.0 was only on github and never released as a gem)

data/Gemfile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 source "https://rubygems.org"
 
 # if you switch rails version gemfile:

data/Guardfile

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
+
 # More info at https://github.com/guard/guard#readme
 
 ## Uncomment and set this to only include directories you want to watch
-# directories %w(app lib config test spec features) \
+# directories %w(app lib config test spec system) \
 #  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
 
 ## Note: if you are using the `directories` clause above and you are not
@@ -15,44 +16,7 @@
 #
 # and, you'll have to watch "config/Guardfile" instead of "Guardfile"
 
-guard "livereload" do
-  extensions = {
-    css: :css,
-    scss: :css,
-    sass: :css,
-    js: :js,
-    coffee: :js,
-    html: :html,
-    png: :png,
-    gif: :gif,
-    jpg: :jpg,
-    jpeg: :jpeg,
-    # less: :less, # uncomment if you want LESS stylesheets done in browser
-  }
-
-  rails_view_exts = %w(erb haml slim)
-
-  # file types LiveReload may optimize refresh for
-  compiled_exts = extensions.values.uniq
-  watch(%r{public/.+\.(#{compiled_exts * '|'})})
-
-  extensions.each do |ext, type|
-    watch(%r{
-          (?:app|vendor)
-          (?:/assets/\w+/(?<path>[^.]+) # path+base without extension
-           (?<ext>\.#{ext})) # matching extension (must be first encountered)
-          (?:\.\w+|$) # other extensions
-          }x) do |m|
-      path = m[1]
-      "/assets/#{path}.#{type}"
-    end
-  end
-
-  # file needing a full reload of the page anyway
-  watch(%r{app/views/.+\.(#{rails_view_exts * '|'})$})
-  watch(%r{app/helpers/.+\.rb})
-  watch(%r{config/locales/.+\.yml})
-end
+interactor :off unless ENV["GUARD_USE_INTERACTOR"]
 
 # Guard-Rails supports a lot options with default values:
 # daemon: false                        # runs the server as a daemon.
@@ -71,7 +35,20 @@ end
 # zeus: false                          # enables zeus gem.
 # CLI: 'rails server'                  # customizes runner command. Omits all options except `pid_file`!
 
-guard "rails", port: 3012, root: "spec/dummy" do
+host = ENV["UNSAFE_DEV"] ? "0.0.0.0" : "localhost"
+port = ENV["RAILS_S_PORT"]&.to_i || 3012
+guard "rails", host: host, port: port, root: "spec/dummy" do
   watch("Gemfile.lock")
   watch(%r{^(config|lib)/.*})
 end
+
+guard "livereload", port: ENV["LIVERELOAD_PORT"]&.to_i || 35_734 do
+  watch(%r{app/views/.+\.(erb|haml|slim)$})
+  watch(%r{app/helpers/.+\.rb})
+  watch(%r{public/.+\.(css|js|html)})
+  watch(%r{config/locales/.+\.yml})
+  # Rails Assets Pipeline
+  watch(%r{(app|vendor)/assets/\w+/(.+\.(js|html)).*}) { |m| "/assets/#{m[2]}" }
+  watch(%r{(app|vendor)/assets/\w+/(.+)\.scss.*}) { |m| "/assets/#{m[2]}.css" }
+  watch(%r{spec/javascripts/(.+\.js)}) { |m| "/assets/#{m[1]}" }
+end