thoughtbot-shoulda 2.10.2 → 2.11.1

data/test/matchers/active_record/ensure_inclusion_of_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class EnsureInclusionOfMatcherTest < ActiveSupport::TestCase # :nodoc:
 
@@ -56,7 +56,8 @@ class EnsureInclusionOfMatcherTest < ActiveSupport::TestCase # :nodoc:
   context "an attribute with custom range validations" do
     setup do
       define_model :example, :attr => :integer do
-        def validate
+        validate :custom_validation
+        def custom_validation
           if attr < 2
             errors.add(:attr, 'too low')
           elsif attr > 5

data/test/matchers/active_record/ensure_length_of_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class EnsureLengthOfMatcher < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/active_record/have_db_column_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class HaveDbColumnMatcherTest < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/active_record/have_db_index_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class HaveDbIndexMatcherTest < ActiveSupport::TestCase # :nodoc:
   

data/test/matchers/active_record/have_readonly_attributes_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class HaveReadonlyAttributesMatcherTest < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/active_record/validate_acceptance_of_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class ValidateAcceptanceOfMatcherTest < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/active_record/validate_format_of_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class ValidateFormatOfMatcherTest < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/active_record/validate_numericality_of_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class ValidateNumericalityOfMatcherTest < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/active_record/validate_presence_of_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class ValidatePresenceOfMatcherTest < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/active_record/validate_uniqueness_of_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class ValidateUniquenessOfMatcherTest < ActiveSupport::TestCase # :nodoc:
 

data/test/matchers/controller/assign_to_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class AssignToMatcherTest < ActionController::TestCase # :nodoc:
 
@@ -30,6 +30,16 @@ class AssignToMatcherTest < ActionController::TestCase # :nodoc:
     should "reject assigning to another variable" do
       assert_rejects assign_to(:other), @controller
     end
+
+    should "accept assigning to the same value in the test context" do
+      @expected = 'value'
+      assert_accepts assign_to(:var).with { @expected }, @controller
+    end
+
+    should "reject assigning to the another value in the test context" do
+      @expected = 'other'
+      assert_rejects assign_to(:var).with { @expected }, @controller
+    end
   end
 
 end

data/test/matchers/controller/filter_param_matcher_test.rb

@@ -1,9 +1,12 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class FilterParamMatcherTest < ActionController::TestCase # :nodoc:
 
   context "a controller that filters no parameters" do
     setup do
+      if Rails.respond_to?(:application)
+        Rails.application.config.filter_parameters = []
+      end
       @controller = define_controller(:examples).new
     end
 
@@ -14,8 +17,13 @@ class FilterParamMatcherTest < ActionController::TestCase # :nodoc:
 
   context "a controller that filters a parameter" do
     setup do
+      if Rails.respond_to?(:application)
+        Rails.application.config.filter_parameters = [:password]
+      end
       @controller = define_controller :examples do
-        filter_parameter_logging :password
+        unless Rails.respond_to?(:application)
+          filter_parameter_logging :password
+        end
       end.new
     end
 

data/test/matchers/controller/redirect_to_matcher_test.rb

@@ -0,0 +1,37 @@
+require 'test_helper'
+
+class RedirectToMatcherTest < ActionController::TestCase # :nodoc:
+
+  context "a controller that redirects" do
+    setup do
+      @controller = build_response { redirect_to '/some/url' }
+    end
+
+    should "accept redirecting to that url" do
+      assert_accepts redirect_to('/some/url'), @controller
+    end
+
+    should "reject redirecting to a different url" do
+      assert_rejects redirect_to('/some/other/url'), @controller
+    end
+
+    should "accept redirecting to that url in a block" do
+      assert_accepts redirect_to('somewhere') { '/some/url' }, @controller
+    end
+
+    should "reject redirecting to a different url in a block" do
+      assert_rejects redirect_to('somewhere else') { '/some/other/url' }, @controller
+    end
+  end
+
+  context "a  controller that doesn't redirect" do
+    setup do
+      @controller = build_response { render :text => 'hello' }
+    end
+
+    should "reject redirecting to a url" do
+      assert_rejects redirect_to('/some/url'), @controller
+    end
+  end
+
+end

data/test/matchers/controller/render_template_matcher_test.rb

@@ -0,0 +1,37 @@
+require 'test_helper'
+
+class RenderTemplateMatcherTest < ActionController::TestCase # :nodoc:
+
+  context "a controller that renders a template" do
+    setup do
+      @controller = build_response(:action => 'show') { render }
+    end
+
+    should "accept rendering that template" do
+      assert_accepts render_template(:show), @controller
+    end
+
+    should "reject rendering a different template" do
+      assert_rejects render_template(:index), @controller
+    end
+
+    should "accept rendering that template in the given context" do
+      assert_accepts self.class.render_template(:show).in_context(self), @controller
+    end
+
+    should "reject rendering a different template in the given context" do
+      assert_rejects self.class.render_template(:index).in_context(self), @controller
+    end
+  end
+
+  context "a  controller that doesn't render a template" do
+    setup do
+      @controller = build_response { render :nothing => true }
+    end
+
+    should "reject rendering a template" do
+      assert_rejects render_template(:show), @controller
+    end
+  end
+
+end

data/test/matchers/controller/render_with_layout_matcher_test.rb

@@ -1,9 +1,10 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class RenderWithLayoutMatcherTest < ActionController::TestCase # :nodoc:
 
   context "a controller that renders with a layout" do
     setup do
+      create_view('layouts/wide.html.erb', 'some content, <%= yield %>')
       @controller = build_response { render :layout => 'wide' }
     end
 
@@ -30,4 +31,17 @@ class RenderWithLayoutMatcherTest < ActionController::TestCase # :nodoc:
     end
   end
 
+  context "given a context with layouts" do
+    setup do
+      @layout = 'happy'
+      @controller = build_response { render :layout => false }
+      @layouts = Hash.new(0)
+      @layouts[@layout] = 1
+    end
+
+    should "accept that layout in that context" do
+      assert_accepts render_with_layout(@layout).in_context(self), @controller
+    end
+  end
+
 end

data/test/matchers/controller/respond_with_content_type_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class RespondWithContentTypeMatcherTest < ActionController::TestCase # :nodoc:
 

data/test/matchers/controller/respond_with_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class RespondWithMatcherTest < ActionController::TestCase # :nodoc:
 
@@ -91,16 +91,6 @@ class RespondWithMatcherTest < ActionController::TestCase # :nodoc:
       assert_rejects respond_with(:success), @controller
     end
   end
-  
-  context "a controller raising an error" do
-    setup do
-      @controller = build_response { raise RailsError }
-    end
-
-    should "reject responding with any status" do
-      assert_rejects respond_with(:success), @controller
-    end
-  end
 
 end
 

data/test/matchers/controller/route_matcher_test.rb

@@ -1,7 +1,24 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class RouteToMatcherTest < ActionController::TestCase # :nodoc:
 
+  context "given a controller with a defined glob url" do
+    setup do
+      @controller = define_controller('Examples').new
+      define_routes do |map|
+        map.connect 'examples/*id', :controller => 'examples',
+                                    :action     => 'example'
+      end
+    end
+
+    should "accept glob route" do
+      assert_accepts route(:get, '/examples/foo/bar').
+                      to(:action => 'example', :id => ['foo', 'bar']),
+                    @controller
+    end
+
+  end
+
   context "given a controller with a defined route" do
     setup do
       @controller = define_controller('Examples').new

data/test/matchers/controller/set_session_matcher_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class SetSessionMatcherTest < ActionController::TestCase # :nodoc:
 
@@ -33,6 +33,16 @@ class SetSessionMatcherTest < ActionController::TestCase # :nodoc:
     should "accept assigning false to that variable" do
       assert_accepts set_session(:false_var).to(false), @controller
     end
+
+    should "accept assigning to the same value in the test context" do
+      @expected = 'value'
+      assert_accepts set_session(:var).to { @expected }, @controller
+    end
+
+    should "reject assigning to the another value in the test context" do
+      @expected = 'other'
+      assert_rejects set_session(:var).to { @expected }, @controller
+    end
   end
 
 end

data/test/matchers/controller/set_the_flash_matcher.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', 'test_helper')
+require 'test_helper'
 
 class SetTheFlashMatcherTest < ActionController::TestCase # :nodoc:
 

data/test/other/autoload_macro_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', 'test_helper')
+require 'test_helper'
 
 class AutoloadMacroTest < ActiveSupport::TestCase # :nodoc:
   context "The macro auto-loader" do

data/test/other/context_test.rb

@@ -1,12 +1,12 @@
-require File.join(File.dirname(__FILE__), '..', 'test_helper')
+require 'test_helper'
 
 class ContextTest < ActiveSupport::TestCase # :nodoc:
-  
+
   def self.context_macro(&blk)
     context "with a subcontext made by a macro" do
       setup { @context_macro = :foo }
 
-      merge_block &blk 
+      merge_block &blk
     end
   end
 
@@ -21,11 +21,11 @@ class ContextTest < ActiveSupport::TestCase # :nodoc:
     setup do
       @blah = "blah"
     end
-    
+
     should "run the setup block" do
       assert_equal "blah", @blah
     end
-    
+
     should "have name set right" do
       assert_match(/^test: context with setup block/, self.to_s)
     end
@@ -34,11 +34,11 @@ class ContextTest < ActiveSupport::TestCase # :nodoc:
       setup do
         @blah = "#{@blah} twice"
       end
-      
+
       should "be named correctly" do
         assert_match(/^test: context with setup block and a subcontext should be named correctly/, self.to_s)
       end
-      
+
       should "run the setup blocks in order" do
         assert_equal @blah, "blah twice"
       end
@@ -64,7 +64,7 @@ class ContextTest < ActiveSupport::TestCase # :nodoc:
     setup do
       @blah = "foo"
     end
-    
+
     should "have @blah == 'foo'" do
       assert_equal "foo", @blah
     end
@@ -73,12 +73,12 @@ class ContextTest < ActiveSupport::TestCase # :nodoc:
       assert_match(/^test: another context with setup block/, self.to_s)
     end
   end
-  
+
   context "context with method definition" do
     setup do
       def hello; "hi"; end
     end
-    
+
     should "be able to read that method" do
       assert_equal "hi", hello
     end
@@ -87,52 +87,52 @@ class ContextTest < ActiveSupport::TestCase # :nodoc:
       assert_match(/^test: context with method definition/, self.to_s)
     end
   end
-  
+
   context "another context" do
     should "not define @blah" do
       assert_nil @blah
     end
   end
-    
+
   context "context with multiple setups and/or teardowns" do
-    
+
     cleanup_count = 0
-        
+
     2.times do |i|
       setup { cleanup_count += 1 }
       teardown { cleanup_count -= 1 }
     end
-    
+
     2.times do |i|
       should "call all setups and all teardowns (check ##{i + 1})" do
         assert_equal 2, cleanup_count
       end
     end
-    
+
     context "subcontexts" do
-      
+
       2.times do |i|
         setup { cleanup_count += 1 }
         teardown { cleanup_count -= 1 }
       end
-                  
+
       2.times do |i|
         should "also call all setups and all teardowns in parent and subcontext (check ##{i + 1})" do
           assert_equal 4, cleanup_count
         end
       end
-      
+
     end
-    
+
   end
-  
+
   should_eventually "pass, since it's unimplemented" do
     flunk "what?"
   end
 
   should_eventually "not require a block when using should_eventually"
   should "pass without a block, as that causes it to piggyback to should_eventually"
-  
+
   context "context for testing should piggybacking" do
     should "call should_eventually as we are not passing a block"
   end
@@ -158,18 +158,176 @@ class ContextTest < ActiveSupport::TestCase # :nodoc:
       assert_kind_of SomeModel, subject
     end
 
-    should "return an existing instance of the described type as the subject" do
-      @some_model = SomeModel.new
-      assert_equal @some_model, subject
-    end
-
     context "with an explicit subject block" do
       setup { @expected = SomeModel.new }
       subject { @expected }
       should "return the result of the block as the subject" do
         assert_equal @expected, subject
       end
+
+      context "nested context block without a subject block" do
+        should "return the result of the parent context's subject block" do
+          assert_equal @expected, subject
+        end
+      end
+    end
+  end
+end
+
+class ShouldMatcherTest < Test::Unit::TestCase
+  class FakeMatcher
+    attr_reader :subject
+    attr_accessor :fail
+
+    def description
+      "do something"
+    end
+
+    def matches?(subject)
+      @subject = subject
+      !@fail
+    end
+
+    def failure_message
+      "a failure message"
+    end
+
+    def negative_failure_message
+      "not a failure message"
+    end
+  end
+
+  def run_test
+    @test_suite.run(@test_result) { |event, name |}
+  end
+
+  def setup
+    @matcher = FakeMatcher.new
+    @test_result = Test::Unit::TestResult.new
+    class << @test_result
+      def failure_messages
+        @failures.map { |failure| failure.message }
+      end
+    end
+  end
+
+  def create_test_suite(&definition)
+    test_class = Class.new(Test::Unit::TestCase, &definition)
+    test_class.suite
+  end
+
+  def assert_failed_with(message, test_result)
+    assert_equal 1, test_result.failure_count
+    assert_equal [message], test_result.failure_messages
+  end
+
+  def assert_passed(test_result)
+    assert_equal 0, test_result.failure_count
+  end
+
+  def assert_test_named(expected_name, test_suite)
+    name = test_suite.tests.map { |test| test.method_name }.first
+    assert name.include?(expected_name), "Expected #{name} to include #{expected_name}"
+  end
+
+  def self.should_use_positive_matcher
+    should "generate a test using the matcher's description" do
+      assert_test_named "should #{@matcher.description}", @test_suite
+    end
+
+    should "pass with a passing matcher" do
+      @matcher.fail = false
+      run_test
+      assert_passed @test_result
+    end
+
+    should "fail with a failing matcher" do
+      @matcher.fail = true
+      run_test
+      assert_failed_with @matcher.failure_message, @test_result
+    end
+
+    should "provide the subject" do
+      @matcher.fail = false
+      run_test
+      assert_equal 'a subject', @matcher.subject
+    end
+  end
+
+  def self.should_use_negative_matcher
+    should "generate a test using the matcher's description" do
+      assert_test_named "should not #{@matcher.description}", @test_suite
+    end
+
+    should "pass with a failing matcher" do
+      @matcher.fail = true
+      run_test
+      assert_passed @test_result
+    end
+
+    should "fail with a passing matcher" do
+      @matcher.fail = false
+      run_test
+      assert_failed_with @matcher.negative_failure_message, @test_result
+    end
+
+    should "provide the subject" do
+      @matcher.fail = false
+      run_test
+      assert_equal 'a subject', @matcher.subject
+    end
+  end
+
+  context "a should block with a matcher" do
+    setup do
+      matcher = @matcher
+      @test_suite = create_test_suite do
+        subject { 'a subject' }
+        should matcher
+      end
+    end
+
+    should_use_positive_matcher
+  end
+
+  context "a should block with a matcher within a context" do
+    setup do
+      matcher = @matcher
+      @test_suite = create_test_suite do
+        context "in context" do
+          subject { 'a subject' }
+          should matcher
+        end
+      end
     end
+
+    should_use_positive_matcher
+  end
+
+  context "a should_not block with a matcher" do
+    setup do
+      matcher = @matcher
+      @test_suite = create_test_suite do
+        subject { 'a subject' }
+        should_not matcher
+      end
+    end
+
+    should_use_negative_matcher
+  end
+
+  context "a should_not block with a matcher within a context" do
+    setup do
+      matcher = @matcher
+      @test_suite = create_test_suite do
+        context "in context" do
+          subject { 'a subject' }
+          should_not matcher
+        end
+      end
+    end
+
+    should_use_negative_matcher
   end
 end
 
@@ -187,3 +345,28 @@ class SubjectTest < ActiveSupport::TestCase
     assert_equal @expected, subject
   end
 end
+
+class SubjectLazinessTest < ActiveSupport::TestCase
+  subject { Subject.new }
+
+  should "only build the subject once" do
+    assert_equal subject, subject
+  end
+end
+
+class SomeController < ActionController::Base
+end
+
+class ControllerSubjectTest < ActionController::TestCase
+  tests SomeController
+
+  should "use the controller as the subject outside a context" do
+    assert_equal @controller, subject
+  end
+
+  context "in a context" do
+    should "use the controller as the subject" do
+      assert_equal @controller, subject
+    end
+  end
+end