thoughtbot-clearance 0.4.0 → 0.4.1

data/README.textile

@@ -153,9 +153,9 @@ To specify where to redirect a user (say you want to have a sign in form on ever
 
     <% form_for :session, :url => session_path(:return_to => request.request_uri) do |form| %>
 
-h2. Hooks: url_after_create, url_after_destroy
+h2. Hooks: url_after_create, url_after_update, url_after_destroy
     
-Actions that redirect (create and destroy) in Clearance controllers are customizable. If you want to redirect a user to a specific route after signing in, overwrite the "url_after_create" method in the SessionsController:
+Actions that redirect (create, update, and destroy) in Clearance controllers are customizable. If you want to redirect a user to a specific route after signing in, overwrite the "url_after_create" method in the SessionsController:
 
     class SessionsController < ApplicationController
       include Clearance::App::Controllers::SessionsController
@@ -173,6 +173,7 @@ There are similar methods in other controllers as well:
     SessionsController#url_after_create (sign in)
     SessionsController#url_after_destroy (sign out)
     PasswordsController#url_after_create (password request)
+    PasswordsController#url_after_update (password)
     ConfirmationsController#url_after_create (confirmation)
 
 h2. Hooks: sign_user_in
@@ -197,8 +198,8 @@ h2. Authors
 
 * thoughtbot, inc.
 * Dan Croak
-* Jason Morrison
 * Mike Burns
+* Jason Morrison
+* Eugene Bolshakov
 * Josh Nichols
 * Mike Breen
-* Eugene Bolshakov

data/Rakefile

@@ -20,7 +20,6 @@ namespace :generator do
     
     FileUtils.rm_rf("test/rails_root/db/migrate")
     FileUtils.rm_rf("test/rails_root/vendor/plugins/clearance")
-    system "cp generators/clearance/templates/config/routes.rb test/rails_root/config"      
     system "mkdir -p test/rails_root/vendor/plugins/clearance"
     system "cp -R generators test/rails_root/vendor/plugins/clearance"  
   end
@@ -36,8 +35,8 @@ task :default => 'test:all'
 
 gem_spec = Gem::Specification.new do |gem_spec|
   gem_spec.name        = "clearance"
-  gem_spec.version     = "0.4.0"
-  gem_spec.summary     = "Simple, complete Rails authentication."
+  gem_spec.version     = "0.4.1"
+  gem_spec.summary     = "Rails authentication for developers who write tests."
   gem_spec.email       = "support@thoughtbot.com"
   gem_spec.homepage    = "http://github.com/thoughtbot/clearance"
   gem_spec.description = "Simple, complete Rails authentication scheme."

data/TODO.textile

@@ -3,6 +3,6 @@
 # refactor password controller test
 # existing_user? methods ... if salt is wrong, user may not be found b/c of invalid credentials. is :not_found the correct code to return in that use case? if not, method probably needs to be split into another conditional.
 # document shoulda macros
-# will SHA512 hashes fit in all the places they are being used? (db columns, sessions) 128 characters
+# will SHA512 hashes fit in all the places they are being used? (db columns - fit now, sessions) 128 characters
 
 http://adam.speaksoutofturn.com/post/57615195/entication-vs-orization

data/generators/clearance/templates/db/migrate/create_users_with_clearance_columns.rb

@@ -2,8 +2,8 @@ class CreateOrUpdateUsersWithClearanceColumns < ActiveRecord::Migration
   def self.up
     create_table(:users) do |t|
       t.string :email
-      t.string :encrypted_password, :limit => 40
-      t.string :salt, :limit => 40
+      t.string :encrypted_password, :limit => 128
+      t.string :salt, :limit => 128
       t.string :remember_token
       t.datetime :remember_token_expires_at
       t.boolean :email_confirmed, :default => false, :null => false

data/generators/clearance/templates/db/migrate/update_users_with_clearance_columns.rb

@@ -4,8 +4,8 @@ class CreateOrUpdateUsersWithClearanceColumns < ActiveRecord::Migration
       existing_columns = ActiveRecord::Base.connection.columns(:users).collect { |each| each.name }
       columns = [
         [:email,                     't.string :email'],
-        [:encrypted_password,        't.string :encrypted_password, :limit => 40'],
-        [:salt,                      't.string :salt, :limit => 40'],
+        [:encrypted_password,        't.string :encrypted_password, :limit => 180'],
+        [:salt,                      't.string :salt, :limit => 180'],
         [:remember_token,            't.string :remember_token'],
         [:remember_token_expires_at, 't.datetime :remember_token_expires_at'],
         [:email_confirmed,           't.boolean :email_confirmed, :default => false, :null => false']

data/lib/clearance/app/controllers/application_controller.rb

@@ -5,12 +5,14 @@ module Clearance
     
         def self.included(controller)
           controller.class_eval do
-            
+                      
             helper_method :current_user
             helper_method :signed_in?
+            
+            hide_action :current_user, :signed_in?
         
             def current_user
-              user_from_session || user_from_cookie
+              @_current_user ||= (user_from_session || user_from_cookie)
             end
 
             def signed_in?

data/lib/clearance/app/models/user.rb

@@ -29,7 +29,7 @@ module Clearance
             end
 
             def encrypt(string)
-              Digest::SHA512.hexdigest("--#{salt}--#{string}--")
+              hash("--#{salt}--#{string}--")
             end
 
             def remember?
@@ -56,10 +56,14 @@ module Clearance
             end
         
             protected
+            
+            def hash(string)
+              Digest::SHA512.hexdigest(string)
+            end
 
             def initialize_salt
               if new_record?
-                self.salt = encrypt("--#{Time.now.utc.to_s}--#{password}--")
+                self.salt = hash("--#{Time.now.utc.to_s}--#{password}--")
               end
             end
 

data/lib/clearance/test/functional/passwords_controller_test.rb

@@ -9,7 +9,7 @@ module Clearance
             should_route :get, '/users/1/password/edit', 
               :action  => 'edit', :user_id => '1'
 
-            context 'with a user' do
+            context "with a user" do
               setup { @user = Factory(:registered_user) }
 
               context 'A GET to #new' do

data/lib/clearance/test/functional/users_controller_test.rb

@@ -50,19 +50,6 @@ module Clearance
             
                 should_create_user_successfully
               end
-              
-              context "Given valid email confirmation attributes when creating a new user" do
-                setup do
-                  user_attributes = Factory.attributes_for(:email_confirmed_user)
-                  post :create, :user => user_attributes
-                end
-            
-                should_create_user_successfully
-                
-                should "not confirm email" do
-                  assert ! assigns(:user).email_confirmed
-                end
-              end
             end
 
             signed_in_user_context do

data/lib/clearance/test/unit/user_test.rb

@@ -5,11 +5,15 @@ module Clearance
     
         def self.included(unit_test)
           unit_test.class_eval do
+          
+            should_protect_attributes :email_confirmed, 
+              :salt, :encrypted_password, 
+              :remember_token, :remember_token_expires_at
             
             # registering
             
             context "When registering" do
-              should_require_attributes        :email
+              should_require_attributes        :email, :password
               should_allow_values_for          :email, "foo@example.com"
               should_not_allow_values_for      :email, "foo"
               should_not_allow_values_for      :email, "example.com"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: thoughtbot-clearance
 version: !ruby/object:Gem::Version 
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors: 
 - thoughtbot, inc.
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-17 21:00:00 -08:00
+date: 2009-01-26 21:00:00 -08:00
 default_executable: 
 dependencies: []
 
@@ -28,30 +28,26 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
-- LICENSE
 - Rakefile
 - README.textile
+- LICENSE
 - TODO.textile
 - generators/clearance
-- generators/clearance/clearance_generator.rb
-- generators/clearance/lib
-- generators/clearance/lib/insert_commands.rb
-- generators/clearance/lib/rake_commands.rb
 - generators/clearance/templates
+- generators/clearance/templates/README
+- generators/clearance/templates/test
+- generators/clearance/templates/test/factories
+- generators/clearance/templates/test/factories/clearance.rb
+- generators/clearance/templates/test/functional
+- generators/clearance/templates/test/functional/confirmations_controller_test.rb
+- generators/clearance/templates/test/functional/passwords_controller_test.rb
+- generators/clearance/templates/test/functional/sessions_controller_test.rb
+- generators/clearance/templates/test/functional/users_controller_test.rb
+- generators/clearance/templates/test/unit
+- generators/clearance/templates/test/unit/clearance_mailer_test.rb
+- generators/clearance/templates/test/unit/user_test.rb
 - generators/clearance/templates/app
-- generators/clearance/templates/app/controllers
-- generators/clearance/templates/app/controllers/application.rb
-- generators/clearance/templates/app/controllers/confirmations_controller.rb
-- generators/clearance/templates/app/controllers/passwords_controller.rb
-- generators/clearance/templates/app/controllers/sessions_controller.rb
-- generators/clearance/templates/app/controllers/users_controller.rb
-- generators/clearance/templates/app/models
-- generators/clearance/templates/app/models/clearance_mailer.rb
-- generators/clearance/templates/app/models/user.rb
 - generators/clearance/templates/app/views
-- generators/clearance/templates/app/views/clearance_mailer
-- generators/clearance/templates/app/views/clearance_mailer/change_password.html.erb
-- generators/clearance/templates/app/views/clearance_mailer/confirmation.html.erb
 - generators/clearance/templates/app/views/passwords
 - generators/clearance/templates/app/views/passwords/edit.html.erb
 - generators/clearance/templates/app/views/passwords/new.html.erb
@@ -61,44 +57,48 @@ files:
 - generators/clearance/templates/app/views/users/_form.html.erb
 - generators/clearance/templates/app/views/users/edit.html.erb
 - generators/clearance/templates/app/views/users/new.html.erb
+- generators/clearance/templates/app/views/clearance_mailer
+- generators/clearance/templates/app/views/clearance_mailer/change_password.html.erb
+- generators/clearance/templates/app/views/clearance_mailer/confirmation.html.erb
+- generators/clearance/templates/app/models
+- generators/clearance/templates/app/models/user.rb
+- generators/clearance/templates/app/models/clearance_mailer.rb
+- generators/clearance/templates/app/controllers
+- generators/clearance/templates/app/controllers/application.rb
+- generators/clearance/templates/app/controllers/passwords_controller.rb
+- generators/clearance/templates/app/controllers/users_controller.rb
+- generators/clearance/templates/app/controllers/sessions_controller.rb
+- generators/clearance/templates/app/controllers/confirmations_controller.rb
 - generators/clearance/templates/db
 - generators/clearance/templates/db/migrate
 - generators/clearance/templates/db/migrate/create_users_with_clearance_columns.rb
 - generators/clearance/templates/db/migrate/update_users_with_clearance_columns.rb
-- generators/clearance/templates/README
-- generators/clearance/templates/test
-- generators/clearance/templates/test/factories
-- generators/clearance/templates/test/factories/clearance.rb
-- generators/clearance/templates/test/functional
-- generators/clearance/templates/test/functional/confirmations_controller_test.rb
-- generators/clearance/templates/test/functional/passwords_controller_test.rb
-- generators/clearance/templates/test/functional/sessions_controller_test.rb
-- generators/clearance/templates/test/functional/users_controller_test.rb
-- generators/clearance/templates/test/unit
-- generators/clearance/templates/test/unit/clearance_mailer_test.rb
-- generators/clearance/templates/test/unit/user_test.rb
+- generators/clearance/lib
+- generators/clearance/lib/insert_commands.rb
+- generators/clearance/lib/rake_commands.rb
 - generators/clearance/USAGE
+- generators/clearance/clearance_generator.rb
 - lib/clearance
-- lib/clearance/app
-- lib/clearance/app/controllers
-- lib/clearance/app/controllers/application_controller.rb
-- lib/clearance/app/controllers/confirmations_controller.rb
-- lib/clearance/app/controllers/passwords_controller.rb
-- lib/clearance/app/controllers/sessions_controller.rb
-- lib/clearance/app/controllers/users_controller.rb
-- lib/clearance/app/models
-- lib/clearance/app/models/clearance_mailer.rb
-- lib/clearance/app/models/user.rb
 - lib/clearance/test
+- lib/clearance/test/test_helper.rb
 - lib/clearance/test/functional
 - lib/clearance/test/functional/confirmations_controller_test.rb
 - lib/clearance/test/functional/passwords_controller_test.rb
 - lib/clearance/test/functional/sessions_controller_test.rb
 - lib/clearance/test/functional/users_controller_test.rb
-- lib/clearance/test/test_helper.rb
 - lib/clearance/test/unit
 - lib/clearance/test/unit/clearance_mailer_test.rb
 - lib/clearance/test/unit/user_test.rb
+- lib/clearance/app
+- lib/clearance/app/models
+- lib/clearance/app/models/user.rb
+- lib/clearance/app/models/clearance_mailer.rb
+- lib/clearance/app/controllers
+- lib/clearance/app/controllers/application_controller.rb
+- lib/clearance/app/controllers/passwords_controller.rb
+- lib/clearance/app/controllers/users_controller.rb
+- lib/clearance/app/controllers/sessions_controller.rb
+- lib/clearance/app/controllers/confirmations_controller.rb
 - lib/clearance.rb
 - shoulda_macros/clearance.rb
 - rails/init.rb
@@ -127,6 +127,6 @@ rubyforge_project:
 rubygems_version: 1.2.0
 signing_key: 
 specification_version: 2
-summary: Simple, complete Rails authentication.
+summary: Rails authentication for developers who write tests.
 test_files: []