thornbed 0.1.0 → 0.2.0

data/README.md

@@ -52,3 +52,8 @@ You should inherit from `Thornbed::Providers::Provider`. See imgur.rb for an exa
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+
+## Contributors
+
+[frodsan](https://github.com/frodsan)

data/lib/thornbed/provider.rb

@@ -10,21 +10,29 @@ module Thornbed
       end
 
       def self.inherited(subclass)
-        @providers << subclass
+        providers << subclass
+      end
+
+      def pattern
+        raise NotImplementedError,
+          'Subclasses must implement a pattern method'
       end
 
       def valid?(url)
-        !!@pattern.match(url)
+        !!pattern.match(url)
       end
 
       def provider_name
         self.class.to_s.split('::')[-1]
       end
+
+      def get(url)
+        raise NotImplementedError, "Subclasses must implement a get method."
+      end
     end
 
     def self.get(url)
-      providers = Thornbed::Providers::Provider.providers
-      provider = providers.detect { |p| p.new.valid?(url) }
+      provider = Provider.providers.detect { |p| p.new.valid?(url) }
       raise Thornbed::NotFound, url if provider.nil?
       provider.new.get(url)
     end

data/lib/thornbed/providers/9gag.rb

@@ -0,0 +1,32 @@
+require "uri"
+require "thornbed"
+
+module Thornbed::Providers
+  class NineGag < Thornbed::Providers::Provider
+    attr_accessor :pattern
+
+    def initialize
+      self.pattern = /^http(s)?:\/\/(\w+\.)?(9gag\.com\/|d24w6bsrhbeh9d\.cloudfront\.net\/photo\/)(gag\/|fast#)?(\d+)(\?[\w=]+)?(_\d+b\.jpg)?$/
+    end
+
+    def get(url)
+      raise Thornbed::NotValid, url if !valid?(url)
+      url = URI.parse(url)
+      ptype = "jpg"
+
+      pic_id = url.path == '/fast' ? url.fragment : /(\d+)/.match(url.path)[0]
+
+      {
+        url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/#{pic_id}_700b.#{ptype}",
+        type: "photo",
+        provider_name: provider_name,
+        provider_url: "http://9gag.com",
+        thumbnail_url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/#{pic_id}_fbthumbnail.#{ptype}",
+        version: "1.0",
+        page: "http://9gag.com/gag/#{pic_id}",
+        width: nil,
+        height: nil
+      }
+    end
+  end
+end

data/lib/thornbed/providers/imgur.rb

@@ -3,14 +3,14 @@ require "thornbed"
 
 module Thornbed::Providers
   class Imgur < Thornbed::Providers::Provider
+    attr_accessor :pattern
+
     def initialize
-      @pattern = /^http(s)?:\/\/((i\.)|(www\.))?imgur.com\/(gallery\/)?(\w){5}(s|l|b|m|t)?(\.gif|\.jpg|.jpeg|\.png)?(\?full)?$/
-      @type = "photo"
-      @provider_url = "http://imgur.com"
+      self.pattern = /^http(s)?:\/\/((i\.)|(www\.))?imgur.com\/(gallery\/)?(\w){5}(s|l|b|m|t)?(\.gif|\.jpg|.jpeg|\.png)?(\?full)?$/
     end
 
     def get(url)
-      raise Thornbed::NotValid, url if !self.valid?(url)
+      raise Thornbed::NotValid, url if !valid?(url)
       url = URI.parse(url)
       gallery = /gallery/ =~ url.path
       direct = /\/(\w){5}(\.gif|\.jpg|\.jpeg|\.png)$/.match(url.path)
@@ -31,9 +31,9 @@ module Thornbed::Providers
 
       {
         url: "http://i.imgur.com/#{pic_id}.#{ptype}",
-        type: "#{@type}",
-        provider_name: self.provider_name,
-        provider_url: @provider_url,
+        type: "photo",
+        provider_name: provider_name,
+        provider_url: "http://imgur.com",
         thumbnail_url: "http://i.imgur.com/#{pic_id}s.#{ptype}",
         version: "1.0",
         page: "http://imgur.com/#{pic_id}",

data/lib/thornbed/providers/memegenerator.rb

@@ -3,22 +3,22 @@ require "thornbed"
 
 module Thornbed::Providers
   class Memegenerator < Thornbed::Providers::Provider
+    attr_accessor :pattern
+
     def initialize
-      @pattern = /^http(s)?:\/\/(cdn\.)?memegenerator\.net\/instance(s)?\/(\d+x\/)?\d+(\.jpg)?(\?[\w\W]*)?$/
-      @type = "photo"
-      @provider_url = "http://memegenerator.com"
+      self.pattern = /^http(s)?:\/\/(cdn\.)?memegenerator\.net\/instance(s)?\/(\d+x\/)?\d+(\.jpg)?(\?[\w\W]*)?$/
     end
 
     def get(url)
-      raise Thornbed::NotValid, url if !self.valid?(url)
+      raise Thornbed::NotValid, url if !valid?(url)
       url = URI.parse(url)
       ptype = "jpg"
       pic_id = /(\d+x\/)?\d+(\.jpg)?(\?[\w\W]*)?$/.match(url.path)
       {
         url: "http://cdn.memegenerator.net/instances/400x/#{pic_id}.#{ptype}",
-        type: "#{@type}",
-        provider_name: self.provider_name,
-        provider_url: @provider_url,
+        type: "photo",
+        provider_name: provider_name,
+        provider_url: "http://memegenerator.com",
         thumbnail_url: "http://cdn.memegenerator.net/instances/100x/#{pic_id}.#{ptype}",
         version: "1.0",
         page: "http://memegenerator.net/instance/#{pic_id}",

data/lib/thornbed/providers/quickmeme.rb

@@ -3,14 +3,14 @@ require "thornbed"
 
 module Thornbed::Providers
   class QuickMeme < Thornbed::Providers::Provider
+    attr_accessor :pattern
+
     def initialize
-      @pattern = /http(s)?:\/\/(i|t)?(\.)?(www\.)?(quickmeme.com|qkme.me)\/(meme\/)?(\w){6}(\/)?(.jpg)?((\?|#).*)?$/
-      @type = "photo"
-      @provider_url = "http://quickmeme.com"
+      self.pattern = /http(s)?:\/\/(i|t)?(\.)?(www\.)?(quickmeme.com|qkme.me)\/(meme\/)?(\w){6}(\/)?(.jpg)?((\?|#).*)?$/
     end
 
     def get(url)
-      raise Thornbed::NotValid, url if !self.valid?(url)
+      raise Thornbed::NotValid, url if !valid?(url)
       url = URI.parse(url)
       normal = /quickmeme.com/ =~ url.to_s
       direct = /qkme.me/ =~ url.to_s
@@ -25,9 +25,9 @@ module Thornbed::Providers
 
       {
         url: "http://i.qkme.me/#{pic_id}.#{ptype}",
-        type: "#{@type}",
-        provider_name: self.provider_name,
-        provider_url: @provider_url,
+        type: "photo",
+        provider_name: provider_name,
+        provider_url: "http://quickmeme.com",
         thumbnail_url: "http://t.qkme.me/#{pic_id}.#{ptype}",
         version: "1.0",
         page: "http://quickmeme.com/#{pic_id}/",

data/lib/thornbed/version.rb

@@ -1,3 +1,3 @@
 module Thornbed
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/provider_spec.rb

@@ -0,0 +1,8 @@
+require 'spec_helper'
+
+describe Thornbed::Providers::Provider do
+  it "raises NotImplementedError when pattern is not implemented in a subclass" do
+    klass = Class.new(Thornbed::Providers::Provider)
+    -> { klass.new.pattern }.should raise_error(NotImplementedError)
+  end
+end

data/spec/providers/9gag_spec.rb

@@ -0,0 +1,44 @@
+require "spec_helper"
+
+describe "NineGag" do
+  it "should have NineGag as a provider" do
+    Thornbed::Providers.constants.should include(:NineGag)
+  end
+
+  it "should accept different NineGag urls" do
+    ninegag = Thornbed::Providers::NineGag.new
+    ninegag.valid?("http://9gag.com/gag/5931764").should be_true
+    ninegag.valid?("http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_700b.jpg").should be_true
+    ninegag.valid?("http://9gag.com/gag/5929873?ref=popular").should be_true
+    ninegag.valid?("http://9gag.com/fast#5931764").should be_true
+  end
+
+  it "should return OEmbed hash for NineGag urls" do
+    ninegag = Thornbed::Providers::NineGag.new
+    res = ninegag.get("http://9gag.com/gag/5931764")
+    res.should include(url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_700b.jpg")
+
+    res = ninegag.get("http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_700b.jpg")
+    res.should include(url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_700b.jpg")
+
+    res = ninegag.get("http://9gag.com/gag/5929873?ref=popular")
+    res.should include(url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5929873_700b.jpg")
+
+    res = ninegag.get("http://9gag.com/fast#5931764")
+    res.should include(url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_700b.jpg")
+  end
+
+  it "should discover NineGag provider" do
+    res = Thornbed.get("http://9gag.com/gag/5931764")
+    res.should include(url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_700b.jpg")
+    res.should include(thumbnail_url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_fbthumbnail.jpg")
+    res.should include(page: "http://9gag.com/gag/5931764")
+    res.should include(provider_name: "NineGag")
+
+    res = Thornbed.get("http://9gag.com/fast#5931764")
+    res.should include(url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_700b.jpg")
+    res.should include(thumbnail_url: "http://d24w6bsrhbeh9d.cloudfront.net/photo/5931764_fbthumbnail.jpg")
+    res.should include(page: "http://9gag.com/gag/5931764")
+    res.should include(provider_name: "NineGag")
+  end
+end

data/spec/thornbed_spec.rb

@@ -29,4 +29,9 @@ describe Thornbed do
     imgur = Thornbed::Providers::Imgur.new
     lambda { imgur.get('http://imgur.com/none.jpg') }.should raise_error(Thornbed::NotValid)
   end
+
+  it "should raise an error when pattern is not set" do
+    foo = Thornbed::Providers::Provider.new
+    lambda { foo.get('http://imgur.com/none.jpg') }.should raise_error(NotImplementedError)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: thornbed
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-24 00:00:00.000000000 Z
+date: 2012-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-oembed
@@ -141,10 +141,13 @@ files:
 - lib/thornbed/errors.rb
 - lib/thornbed/provider.rb
 - lib/thornbed/providers.rb
+- lib/thornbed/providers/9gag.rb
 - lib/thornbed/providers/imgur.rb
 - lib/thornbed/providers/memegenerator.rb
 - lib/thornbed/providers/quickmeme.rb
 - lib/thornbed/version.rb
+- spec/provider_spec.rb
+- spec/providers/9gag_spec.rb
 - spec/providers/imgur_spec.rb
 - spec/providers/memegenerator_spec.rb
 - spec/providers/quickmeme_spec.rb
@@ -165,7 +168,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -793414226059006888
+      hash: -965882264884968861
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -174,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -793414226059006888
+      hash: -965882264884968861
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -183,6 +186,8 @@ specification_version: 3
 summary: Thornbed provides a single interface to get embeddable content from many
   sites, even sites with no OEmbed support.
 test_files:
+- spec/provider_spec.rb
+- spec/providers/9gag_spec.rb
 - spec/providers/imgur_spec.rb
 - spec/providers/memegenerator_spec.rb
 - spec/providers/quickmeme_spec.rb