thorero 0.9.4.4 → 0.9.4.5

data/spec/public/controller/controllers/redirect.rb

@@ -0,0 +1,30 @@
+module Merb::Test::Fixtures::Controllers
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+  class SimpleRedirect < Testing
+    def index
+      redirect("/")
+    end
+  end
+  
+  class RedirectWithMessage < Testing
+    def index
+      redirect("/", :notice => "what?")
+    end
+  end
+  
+  class ConsumesMessage < Testing
+    def index
+      message[:notice].inspect
+    end
+  end
+  
+  class SetsMessage < Testing
+    def index
+      message[:notice] = "Hello"
+      message[:notice]
+    end
+  end
+end

data/spec/public/controller/controllers/responder.rb

@@ -0,0 +1,93 @@
+module Merb::Test::Fixtures::Controllers
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+
+  class Responder < Testing
+    def index
+      render
+    end
+  end
+
+
+  class HtmlDefault < Responder; end
+
+
+  class ClassProvides < Responder
+    provides :xml
+  end
+
+
+  class LocalProvides < Responder
+    def index
+      provides :xml
+      render
+    end
+  end
+
+
+  class MultiProvides < Responder
+    def index
+      provides :html, :js
+      render
+    end
+  end
+
+  class ClassAndLocalProvides < Responder
+    provides :html    
+    def index
+      provides :xml
+      render
+    end
+  end
+
+  class ClassOnlyProvides < Responder
+    only_provides :text, :xml
+
+    def index
+      "nothing"
+    end
+  end
+
+
+  class OnlyProvides < Responder
+    def index
+      only_provides :text, :xml
+      "nothing"
+    end
+  end
+
+  class ClassDoesntProvides < Responder
+    provides :xml
+    does_not_provide :html
+
+    def index
+      "nothing"
+    end
+  end
+
+
+  class DoesntProvide < Responder
+    def index
+      provides :xml
+      does_not_provide :html
+      "nothing"
+    end
+  end
+
+
+  class FooFormatProvides < Responder
+    only_provides :foo
+
+    def index
+      render "nothing"
+    end
+
+    def show
+      headers["Content-Language"] = 'nl'
+      headers["Biz"] = "buzz"
+      render "nothing"
+    end
+  end
+end

data/spec/public/controller/controllers/url.rb

@@ -0,0 +1,7 @@
+module Merb::Test::Fixtures::Controllers
+  class Url < Testing
+    def index
+      'index'
+    end
+  end
+end

data/spec/public/controller/controllers/views/layout/custom.html.erb

@@ -0,0 +1 @@
+Custom: <%= catch_content(:for_layout) %>

data/spec/public/controller/controllers/views/layout/custom_arg.html.erb

@@ -0,0 +1 @@
+Custom Arg: <%= catch_content(:for_layout) %>

data/spec/public/controller/controllers/views/layout/custom_arg.json.erb

@@ -0,0 +1 @@
+{custom_arg: <%= catch_content(:for_layout) %>}

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/class_and_local_provides/index.html.erb

@@ -0,0 +1 @@
+HTML: Class and Local

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/class_and_local_provides/index.xml.erb

@@ -0,0 +1 @@
+<XML:ClassAndLocalProvides provides='true' />

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/class_provides/index.html.erb

@@ -0,0 +1 @@
+This should not be rendered

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/class_provides/index.xml.erb

@@ -0,0 +1 @@
+<XML:Class provides='true' />

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/display_with_template/index.html.erb

@@ -0,0 +1 @@
+Template

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/display_with_template/no_layout.html.erb

@@ -0,0 +1 @@
+No layoutz eva!

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/display_with_template_argument/index.html.erb

@@ -0,0 +1 @@
+Template

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/html_default/index.html.erb

@@ -0,0 +1 @@
+HTML: Default

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/layout/custom.html.erb

@@ -0,0 +1 @@
+Custom: <%= catch_content(:for_layout) %>

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/local_provides/index.html.erb

@@ -0,0 +1 @@
+This should not render

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/local_provides/index.xml.erb

@@ -0,0 +1 @@
+<XML:Local provides='true' />

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/multi_provides/index.html.erb

@@ -0,0 +1 @@
+HTML: Multi

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/multi_provides/index.js.erb

@@ -0,0 +1 @@
+JS: Multi

data/spec/public/controller/display_spec.rb

@@ -0,0 +1,84 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+
+describe Merb::Controller, " displaying objects based on mime type" do
+
+  before do
+    Merb::Router.prepare do |r|
+      r.default_routes
+    end
+  end
+
+  it "should default the mime-type to HTML (and raise since there's no to_html)" do
+    running { dispatch_to(Merb::Test::Fixtures::Controllers::DisplayHtmlDefault, :index) }.should raise_error(Merb::ControllerExceptions::NotAcceptable)
+  end
+
+  it "should set headers['Location'] to string provided by :location" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithStringLocation, :index, {}, :http_accept => "application/json").headers['Location'].should =~ /some_resources/
+  end
+
+  it "should set the status to a code provided by :status" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithStatus, :index, {}, :http_accept => "application/json").status.should == 500
+  end
+
+  it "should use a template if specified" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplate, :index).body.should match(/Custom: Template/)
+  end
+
+  it "overrides layout settings with render :layout => false" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplate, :no_layout).body.should_not match(/Custom: Template/)
+  end
+  
+  it "should accept an absolute template path argument - with the mimetype extension" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplate, :absolute_with_mime).body.should == "Custom: HTML: Default"
+  end
+  
+  it "should accept an absolute template path argument - without the mimetype extension" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplate, :absolute_without_mime).body.should == "Custom: HTML: Default"
+  end
+  
+  it "should accept a relative template path argument - with the mimetype extension" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplate, :relative_with_mime).body.should == "Custom: HTML: Default"
+  end
+  
+  it "should accept a relative template path argument - without the mimetype extension" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplate, :relative_without_mime).body.should == "Custom: HTML: Default"
+  end
+
+  it "should accept a layout argument when calling to_*" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithLayout, :index, {}, 
+      :http_accept => "application/json").body.should == "{custom_arg: { 'include': '', 'exclude': '' }}"
+  end
+  
+  it "should accept a layout argument with a template" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplateArgument, :index).body.should == "Custom Arg: Template"
+  end
+
+  it "should accept a template path argument" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithTemplateArgument, :index_by_arg).body.should == "Template"
+  end
+  
+  it "should use other mime-types if they are provided on the class level" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::DisplayClassProvides, :index, {}, :http_accept => "application/xml")
+    controller.body.should == "<XML:Model />"
+  end
+
+  it "should fail if none of the acceptable mime-types are available" do
+    calling { dispatch_to(Merb::Test::Fixtures::Controllers::DisplayClassProvides, :index, {}, :http_accept => "application/json") }.
+      should raise_error(Merb::ControllerExceptions::NotAcceptable)
+  end
+
+  it "should use mime-types that are provided at the local level" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::DisplayLocalProvides, :index, {}, :http_accept => "application/xml")
+    controller.body.should == "<XML:Model />"
+  end
+
+  it "passes all options to serialization method like :to_json" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithSerializationOptions, :index, {}, :http_accept => "application/json")
+    controller.body.should == "{ 'include': 'beer, jazz', 'exclude': 'idiots' }"
+  end
+
+  it "passes single argument to serialization method like :to_json" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::DisplayWithSerializationOptions, :index_that_passes_empty_hash, {}, :http_accept => "application/json")
+    controller.body.should == "{ 'include': '', 'exclude': '' }"
+  end
+end

data/spec/public/controller/redirect_spec.rb

@@ -0,0 +1,27 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+
+describe Merb::Controller, " redirects" do
+  it "redirects with simple URLs" do
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::SimpleRedirect, :index)
+    @controller.status.should == 302
+    @controller.headers["Location"].should == "/"
+  end
+  
+  it "redirects with messages" do
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::RedirectWithMessage, :index)
+    @controller.status.should == 302
+    expected_url = Merb::Request.escape([Marshal.dump(:notice => "what?")].pack("m"))
+    @controller.headers["Location"].should == "/?_message=#{expected_url}"
+  end
+  
+  it "consumes redirects with messages" do
+    message = Merb::Request.escape([Marshal.dump(:notice => "what?")].pack("m"))
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConsumesMessage, :index, {:_message => message})
+    @controller.body.should == "\"what?\""
+  end
+  
+  it "supports setting the message for use immediately" do
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::SetsMessage, :index)
+    @controller.body.should == "Hello"
+  end
+end

data/spec/public/controller/responder_spec.rb

@@ -0,0 +1,163 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+
+describe Merb::Controller, " responds" do
+  
+  before do
+    Merb.push_path(:layout, File.dirname(__FILE__) / "controllers" / "views" / "layouts")    
+    Merb::Router.prepare do |r|
+      r.default_routes
+    end
+  end
+  
+  it "should default the mime-type to HTML" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::HtmlDefault, :index).body.should == "HTML: Default"
+  end
+
+  it "should use other mime-types if they are provided on the controller-level" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassProvides, :index, {}, :http_accept => "application/xml")
+    controller.body.should == "<XML:Class provides='true' />"
+  end
+
+  it "should fail if none of the acceptable mime-types are available" do
+    calling { dispatch_to(Merb::Test::Fixtures::Controllers::ClassProvides, :index, {}, :http_accept => "application/json") }.
+      should raise_error(Merb::ControllerExceptions::NotAcceptable)
+  end
+
+  it "should use mime-types that are provided at the action-level" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::LocalProvides, :index, {}, :http_accept => "application/xml")
+    controller.body.should == "<XML:Local provides='true' />"
+  end
+  
+  it "should use mime-types that are provided at the controller-level as well as the action-level (controller)" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassAndLocalProvides, :index, {}, :http_accept => "text/html")
+    controller.class_provided_formats.should == [:html]
+    controller._provided_formats.should == [:html, :xml]
+    controller.body.should == "HTML: Class and Local"
+  end  
+  
+  it "should use mime-types that are provided at the controller-level as well as the action-level (action)" do  
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassAndLocalProvides, :index, {}, :http_accept => "application/xml")
+    controller.class_provided_formats.should == [:html]
+    controller._provided_formats.should == [:html, :xml]
+    controller.body.should == "<XML:ClassAndLocalProvides provides='true' />"
+  end
+
+  it "should use the first mime-type when accepting anything */*" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::MultiProvides, :index, {}, :http_accept => "*/*")
+    controller.body.should == "HTML: Multi"
+  end
+
+  it "should use the first mime-type when accepting anything */*, even if something unprovidable comes first" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::HtmlDefault, :index, {}, :http_accept => "application/json, */*")
+    controller.body.should == "HTML: Default"
+  end
+
+  it "should use the pick the first mime-type from the list not the */*" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::MultiProvides, :index, {}, :http_accept => "text/javascript, */*")
+    controller.body.should == "JS: Multi"
+  end
+  
+  it "should pick the first mime-type if no specific supported content-type matches are *available*" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::MultiProvides, :index, {}, :http_accept => "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, */*")
+    controller.body.should == "HTML: Multi"
+  end
+
+  it "should pick the first mime-type if no specific supported content-type matches are actually *provided*" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::MultiProvides, :index, {}, :http_accept => "application/json, */*")
+    controller.body.should == "HTML: Multi"
+  end
+  
+  it "should select the format based on params supplied to it with controller-level provides" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassProvides, :index, :format => "xml")
+    controller.content_type.should == :xml    
+  end
+  
+  it "should select the format based on params supplied to it with action-level provides" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::LocalProvides, :index, :format => "xml")
+    controller.content_type.should == :xml    
+  end
+  
+  it "should select the format based on params supplied to it with controller and action provides (controller)" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassAndLocalProvides, :index, :format => "html")
+    controller.content_type.should == :html
+  end
+  
+  it "should select the format based on params supplied to it with controller and action provides (action)" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassAndLocalProvides, :index, :format => "xml")
+    controller.content_type.should == :xml
+  end
+  
+  it "should properly add formats when only_provides is called in action" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::OnlyProvides, :index, {}, :http_accept => "application/xml")
+    controller._provided_formats.should == [:text, :xml]
+    controller.content_type.should == :xml
+  end
+
+  it "should properly remove formats when only_provides is called in action" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::OnlyProvides, :index, {}, :http_accept => "text/html")
+    lambda { controller.content_type }.should raise_error(Merb::ControllerExceptions::NotAcceptable)
+  end
+
+  it "should properly add formats when only_provides is called in controller" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassOnlyProvides, :index, {}, :http_accept => "application/xml")
+    controller._provided_formats.should == [:text, :xml]
+    controller.content_type.should == :xml
+  end
+
+  it "should properly remove formats when only_provides is called in controller" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassOnlyProvides, :index, {}, :http_accept => "text/html")
+    lambda { controller.content_type }.should raise_error(Merb::ControllerExceptions::NotAcceptable)
+  end
+  
+  it "should properly remove formats when does_not_provide is called in controller" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassDoesntProvides, :index, {}, :http_accept => "text/html")
+    controller._provided_formats.should == [:xml]
+    lambda { controller.content_type }.should raise_error(Merb::ControllerExceptions::NotAcceptable)
+  end
+
+  it "should properly remove formats when does_not_provide is called in action" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::DoesntProvide, :index, {}, :http_accept => "text/html")
+    controller._provided_formats.should == [:xml]
+    lambda { controller.content_type }.should raise_error(Merb::ControllerExceptions::NotAcceptable)
+  end
+  
+  it "should return the correct default HTTP headers for a format" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ClassProvides, :index, :format => "xml")
+    controller.headers.keys.sort.should == ["Content-Type"]
+    controller.headers["Content-Type"].should == "application/xml; charset=utf-8"
+  end
+  
+  it "should append the correct charset which was set when the format was added" do
+    Merb.add_mime_type(:foo, nil, %w[application/foo], :charset => "iso-8859-1")
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::FooFormatProvides, :index, :format => "foo")
+    controller.headers["Content-Type"].should == "application/foo; charset=iso-8859-1"
+  end
+  
+  it "should return the correct HTTP headers which were set when the format was added" do
+    Merb.add_mime_type(:foo, nil, %w[application/foo], "Foo" => 'bar', "Content-Language" => "en", :charset => "utf-8")
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::FooFormatProvides, :index, :format => "foo")
+    controller.headers.keys.should_not include(:charset)
+    controller.headers["Content-Type"].should == "application/foo; charset=utf-8"
+    controller.headers["Content-Language"].should == "en"
+    controller.headers["Foo"] = "bar"
+  end
+  
+  it "should return the correct HTTP headers using the block given when the format was added" do
+    Merb.add_mime_type(:foo, nil, %w[application/foo], "Foo" => "bar") do |controller|
+      controller.headers["Action-Name"] = controller.action_name
+    end
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::FooFormatProvides, :index, :format => "foo")
+    controller.headers["Content-Type"].should == "application/foo"
+    controller.headers["Action-Name"].should == "index"
+    controller.headers["Foo"] = "bar"
+  end
+  
+  it "should not overwrite runtime-set headers with default format response headers" do
+    Merb.add_mime_type(:foo, nil, %w[application/foo], "Foo" => "bar", "Content-Language" => "en")
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::FooFormatProvides, :show, :format => "foo")
+    controller.headers["Content-Language"].should == "nl"
+    controller.headers["Biz"] = "buzz"
+    controller.headers["Foo"] = "bar"
+  end
+  
+end