this_feature 0.7.0 → 0.9.0

data/lib/this_feature/adapters/split_io.rb

@@ -3,8 +3,9 @@ require 'splitclient-rb'
 class ThisFeature
   module Adapters
     class SplitIo < Base
-      # used as treatment key when none is given, it's required by split
-      UNDEFINED_KEY = 'undefined_key'
+      # Used as the context key when none is given. This arg is required by
+      # Split, but it's nice not to have to pass it when the context is empty.
+      EMPTY_CONTEXT = 'undefined_key'.freeze
 
       def initialize(client: nil, context_key_method: nil)
         @client = client || default_split_client
@@ -17,28 +18,29 @@ class ThisFeature
         !control?(flag_name)
       end
 
-      def control?(flag_name, context: UNDEFINED_KEY, data: {})
-        treatment(flag_name, context: context, data: data).include?('control')
+      def control?(flag_name, context: EMPTY_CONTEXT, data: {}, record: nil)
+        treatment(flag_name, context: context, data: data, record: record).include?('control')
       end
 
-      def on?(flag_name, context: UNDEFINED_KEY, data: {})
-        treatment(flag_name, context: context, data: data).eql?('on')
+      def on?(flag_name, context: EMPTY_CONTEXT, data: {}, record: nil)
+        treatment(flag_name, context: context, data: data, record: record).eql?('on')
       end
 
-      def off?(flag_name, context: UNDEFINED_KEY, data: {})
-        treatment(flag_name, context: context, data: data).eql?('off')
+      def off?(flag_name, context: EMPTY_CONTEXT, data: {}, record: nil)
+        treatment(flag_name, context: context, data: data, record: record).eql?('off')
       end
 
       private
 
       attr_reader :client, :context_key_method
 
-      def treatment(flag_name, context: UNDEFINED_KEY, data: {})
-        client.get_treatment(context_key(context), flag_name, data)
+      def treatment(flag_name, context: EMPTY_CONTEXT, data: {}, record: nil)
+        base_data = record ? ThisFeature.base_data_lambda.call(record) : {}
+        client.get_treatment(context_key(context), flag_name, base_data.merge(data))
       end
 
       def context_key(context)
-        return UNDEFINED_KEY if context.nil? || context.eql?(UNDEFINED_KEY)
+        return EMPTY_CONTEXT if context.nil? || context.eql?(EMPTY_CONTEXT)
         return context.send(context_key_method) unless context_key_method.nil?
         return context.to_s if context.respond_to?(:to_s)
 

data/lib/this_feature/adapters.rb

@@ -1,5 +1,5 @@
-require_relative './adapters/base.rb'
-require_relative './adapters/memory.rb'
+require_relative './adapters/base'
+require_relative './adapters/memory'
 
 class ThisFeature
   module Adapters

data/lib/this_feature/configuration.rb

@@ -1,16 +1,16 @@
 class ThisFeature
   class Configuration
-    attr_writer :adapters, :default_adapter, :test_adapter
+    attr_writer :adapters, :default_adapter, :test_adapter, :base_data_lambda
 
     def init
       validate_adapters!
     end
 
     def validate_adapters!
-      raise(NoAdaptersError.new) unless adapters.any?
+      raise NoAdaptersError unless adapters.any?
 
       adapters.each do |adapter|
-        raise BadAdapterError.new(adapter) unless adapter.class < Adapters::Base
+        raise BadAdapterError, adapter unless adapter.class < Adapters::Base
       end
     end
 
@@ -25,5 +25,9 @@ class ThisFeature
     def test_adapter
       @test_adapter ||= Adapters::Memory.new
     end
+
+    def base_data_lambda
+      @base_data_lambda ||= ->(_record) { {} }
+    end
   end
 end

data/lib/this_feature/errors.rb

@@ -1,10 +1,9 @@
 class ThisFeature
-
   class Error < StandardError; end
 
   class UnimplementedError < Error
     def initialize(adapter_instance, fn_name)
-      super("class #{adapter_instance.class.name} doesnt implement method .#{fn_name}")
+      super("class #{adapter_instance.class.name} doesn't implement method .#{fn_name}")
     end
   end
 
@@ -16,8 +15,7 @@ class ThisFeature
 
   class NoAdaptersError < Error
     def initialize
-      super("No adapters configured.")
+      super('No adapters configured.')
     end
   end
-
 end

data/lib/this_feature/flag.rb

@@ -1,24 +1,25 @@
 class ThisFeature
   class Flag
-    attr_reader :flag_name, :context, :data, :adapter
+    attr_reader :flag_name, :context, :data, :adapter, :record
 
-    def initialize(flag_name, adapter:, context: nil, data: {})
+    def initialize(flag_name, adapter:, context: nil, data: {}, record: nil)
       @flag_name = flag_name
       @adapter = adapter
       @context = context
       @data = data
+      @record = record
     end
 
     def on?
-      adapter.on?(flag_name, context: context, data: data)
+      adapter.on?(flag_name, context: context, data: data, record: record)
     end
 
     def off?
-      adapter.off?(flag_name, context: context, data: data)
+      adapter.off?(flag_name, context: context, data: data, record: record)
     end
 
     def control?
-      adapter.control?(flag_name, context: context, data: data)
+      adapter.control?(flag_name, context: context, data: data, record: record)
     end
   end
 end

data/lib/this_feature/version.rb

@@ -1,3 +1,3 @@
 class ThisFeature
-  VERSION = "0.7.0"
+  VERSION = '0.9.0'.freeze
 end

data/lib/this_feature.rb

@@ -5,13 +5,13 @@ require 'this_feature/configuration'
 require 'this_feature/flag'
 
 class ThisFeature
-  def self.flag(flag_name, context: nil, data: {})
-    adapter = adapter_for(flag_name, context: nil, data: {})
+  def self.flag(flag_name, context: nil, data: {}, record: nil)
+    adapter = adapter_for(flag_name)
 
-    Flag.new(flag_name, adapter: adapter, context: context, data: data)
+    Flag.new(flag_name, adapter: adapter, context: context, data: data, record: record)
   end
 
-  def self.adapter_for(flag_name, context: nil, data: {})
+  def self.adapter_for(flag_name)
     matching_adapter = adapters.find do |adapter|
       adapter.present?(flag_name)
     end
@@ -38,4 +38,8 @@ class ThisFeature
   def self.test_adapter
     configuration.test_adapter
   end
+
+  def self.base_data_lambda
+    configuration.base_data_lambda
+  end
 end

data/this_feature-adapters-flipper.gemspec

@@ -1,24 +1,31 @@
-# encoding: utf-8
-
-$:.unshift File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('lib', __dir__)
 
 require 'this_feature/version'
 
-Gem::Specification.new do |s|
-  s.name          = 'this_feature-adapters-flipper'
-  s.version       = ThisFeature::VERSION
-  s.authors       = ['Max Pleaner']
-  s.email         = ['maxpleaner@gmail.com']
-  s.homepage      = 'http://hover.to'
-  s.licenses      = ['MIT']
-  s.summary       = '[summary]'
-  s.description   = '[description]'
-
-  s.files         = Dir.glob('{bin/*,lib/**/*,[A-Z]*}')
-  s.platform      = Gem::Platform::RUBY
-  s.require_paths = ['lib']
-
-  s.add_runtime_dependency "this_feature"
-  s.add_runtime_dependency "flipper", "~> 0.16"
-  s.add_runtime_dependency "flipper-active_record", "~> 0.16"
+Gem::Specification.new do |spec|
+  spec.name    = 'this_feature-adapters-flipper'
+  spec.version = ThisFeature::VERSION
+
+  spec.required_ruby_version = '>= 3.2'
+
+  spec.authors  = ['Max Pleaner', 'Matt Fong']
+  spec.email    = ['maxpleaner@gmail.com', 'matthewjf@gmail.com']
+  spec.homepage = 'http://hover.to'
+
+  spec.metadata['homepage_uri']          = spec.homepage
+  spec.metadata['source_code_uri']       = spec.homepage
+  spec.metadata['rubygems_mfa_required'] = 'true'
+
+  spec.licenses    = ['MIT']
+  spec.summary     = 'A ThisFeature adapter to Flipper'
+  spec.description = ''
+  spec.homepage    = 'https://github.com/hoverinc/this_feature'
+
+  spec.files         = Dir.glob('{bin/*,lib/**/*,[A-Z]*}')
+  spec.platform      = Gem::Platform::RUBY
+  spec.require_paths = ['lib']
+
+  spec.add_runtime_dependency 'flipper'
+  spec.add_runtime_dependency 'flipper-active_record'
+  spec.add_runtime_dependency 'this_feature'
 end

data/this_feature-adapters-split_io.gemspec

@@ -1,23 +1,30 @@
-# encoding: utf-8
-
-$:.unshift File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('lib', __dir__)
 
 require 'this_feature/version'
 
-Gem::Specification.new do |s|
-  s.name          = 'this_feature-adapters-split_io'
-  s.version       = ThisFeature::VERSION
-  s.authors       = ['Max Pleaner', 'Matt Fong']
-  s.email         = ['maxpleaner@gmail.com', 'matthewjf@gmail.com']
-  s.homepage      = 'http://hover.to'
-  s.licenses      = ['MIT']
-  s.summary       = '[summary]'
-  s.description   = '[description]'
-
-  s.files         = Dir.glob('{bin/*,lib/**/*,[A-Z]*}')
-  s.platform      = Gem::Platform::RUBY
-  s.require_paths = ['lib']
-
-  s.add_runtime_dependency "this_feature"
-  s.add_runtime_dependency "splitclient-rb"
+Gem::Specification.new do |spec|
+  spec.name    = 'this_feature-adapters-split_io'
+  spec.version = ThisFeature::VERSION
+
+  spec.required_ruby_version = '>= 3.2'
+
+  spec.authors  = ['Max Pleaner', 'Matt Fong']
+  spec.email    = ['maxpleaner@gmail.com', 'matthewjf@gmail.com']
+  spec.homepage = 'http://hover.to'
+
+  spec.metadata['homepage_uri']          = spec.homepage
+  spec.metadata['source_code_uri']       = spec.homepage
+  spec.metadata['rubygems_mfa_required'] = 'true'
+
+  spec.licenses    = ['MIT']
+  spec.summary     = 'A ThisFeature adapter to Split.io'
+  spec.description = ''
+  spec.homepage    = 'https://github.com/hoverinc/this_feature'
+
+  spec.files         = Dir.glob('{bin/*,lib/**/*,[A-Z]*}')
+  spec.platform      = Gem::Platform::RUBY
+  spec.require_paths = ['lib']
+
+  spec.add_runtime_dependency 'splitclient-rb'
+  spec.add_runtime_dependency 'this_feature'
 end

data/this_feature.gemspec

@@ -1,34 +1,38 @@
-lib = File.expand_path("lib", __dir__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "this_feature/version"
+require 'this_feature/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "this_feature"
-  spec.version       = ThisFeature::VERSION
-  spec.authors       = ["Max Pleaner"]
-  spec.email         = ["max.pleaner@hover.to"]
+  spec.name    = 'this_feature'
+  spec.version = ThisFeature::VERSION
 
-  spec.summary       = %q{Feature flag control}
-  spec.description   = spec.summary
-  spec.homepage      = "https://github.com/hoverinc/this_feature"
+  spec.required_ruby_version = '>= 3.2'
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = spec.homepage
+  contributors = {
+    'Max Pleaner' => 'max.pleaner@hover.to',
+    'Matt Fong' => 'matt.fong@hover.to',
+    'Shane Becker' => 'shane.becker@hover.to',
+    'Daniel Deutsch' => 'daniel.deutsch@hover.to'
+  }
+  spec.authors = contributors.keys
+  spec.email   = contributors.values
+
+  spec.licenses    = ['MIT']
+  spec.summary     = 'A common interface to interact with many feature flag providers'
+  spec.description = ''
+  spec.homepage    = 'https://github.com/hoverinc/this_feature'
+
+  spec.metadata['homepage_uri']          = spec.homepage
+  spec.metadata['source_code_uri']       = spec.homepage
+  spec.metadata['rubygems_mfa_required'] = 'true'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake", "~> 13.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "sqlite3"
-  spec.add_development_dependency "database_cleaner-active_record"
-  spec.add_development_dependency "gem-release"
+  spec.bindir        = 'exe'
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ['lib']
 end

metadata

@@ -1,123 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: this_feature
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Max Pleaner
+- Matt Fong
+- Shane Becker
+- Daniel Deutsch
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-09 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: database_cleaner-active_record
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: gem-release
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-description: Feature flag control
+date: 2023-05-31 00:00:00.000000000 Z
+dependencies: []
+description: ''
 email:
 - max.pleaner@hover.to
+- matt.fong@hover.to
+- shane.becker@hover.to
+- daniel.deutsch@hover.to
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/linter-rubocop.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".ruby-version"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -127,7 +39,6 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- docs/flipper.html
 - docs/flipper.md
 - docs/memory.md
 - docs/splitio.md
@@ -146,10 +57,12 @@ files:
 - this_feature-adapters-split_io.gemspec
 - this_feature.gemspec
 homepage: https://github.com/hoverinc/this_feature
-licenses: []
+licenses:
+- MIT
 metadata:
   homepage_uri: https://github.com/hoverinc/this_feature
   source_code_uri: https://github.com/hoverinc/this_feature
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -158,15 +71,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.4.13
 signing_key:
 specification_version: 4
-summary: Feature flag control
+summary: A common interface to interact with many feature flag providers
 test_files: []