this_feature-adapters-flipper 0.5.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0847ea9efa6fbb2220fde21f3ceb9bc0afc2ab346cdad21bc31baeba8b63be16'
-  data.tar.gz: 9ab147e60b74ce5c218b774faea6ab4cf42b22b953527cfd6ac98dacd0d185e2
+  metadata.gz: 59fad6c074fe4555362a332da9c2be41ee793da92a4c4d4b9569b5dcc02043df
+  data.tar.gz: d73ef69e4524b58b890db551f63caee673bb66b1e87aaef0f260951a1e7d0c1c
 SHA512:
-  metadata.gz: 5e80169640735a7f5cf5b1cf914a7151d1f7141a130d85c1e1db28b9bf12d6c7283852460a4c670687b4590931798bc7ebe1f650b0ef931fb4ed25a35a712165
-  data.tar.gz: 9d41296adb7c33692ca93244a0debe2470cfb8a4322dd5d598c0f4578ab53e4600c333d22786616c7c776b130000a608c50cc7f6450fe7e3e008b06b7f58db32
+  metadata.gz: aaaa6a00c083509395ee5c21acfc6475cc3291273d41a3d3d16026c985680444e02ed3000a26232e3eebf577adb0a9a1ae01344ddf39fce5c7987130c7bce575
+  data.tar.gz: a8e3e946918977ae9c34af2233bd46efcab168f6e54381b5ceda0418f03044b01554cd378ad1a04ac303f1c9d812601eda662fd93e64cfc1aedcc1f7cd6febd1

data/Gemfile.lock

@@ -1,55 +1,58 @@
 PATH
   remote: .
   specs:
-    this_feature (0.5.0)
-    this_feature-adapters-flipper (0.5.0)
+    this_feature (0.6.1)
+    this_feature-adapters-flipper (0.6.1)
       flipper (~> 0.16)
       flipper-active_record (~> 0.16)
       this_feature
-    this_feature-adapters-split_io (0.5.0)
+    this_feature-adapters-split_io (0.6.1)
       splitclient-rb
       this_feature
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.0.3.2)
-      activesupport (= 6.0.3.2)
-    activerecord (6.0.3.2)
-      activemodel (= 6.0.3.2)
-      activesupport (= 6.0.3.2)
-    activesupport (6.0.3.2)
+    activemodel (6.1.3)
+      activesupport (= 6.1.3)
+    activerecord (6.1.3)
+      activemodel (= 6.1.3)
+      activesupport (= 6.1.3)
+    activesupport (6.1.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
     byebug (11.1.2)
     coderay (1.1.2)
-    concurrent-ruby (1.1.6)
+    concurrent-ruby (1.1.8)
     connection_pool (2.2.3)
     database_cleaner (1.8.4)
     database_cleaner-active_record (1.8.0)
       activerecord
       database_cleaner (~> 1.8.0)
     diff-lcs (1.3)
-    faraday (1.0.1)
+    faraday (1.3.0)
+      faraday-net_http (~> 1.0)
       multipart-post (>= 1.2, < 3)
-    flipper (0.19.0)
-    flipper-active_record (0.19.0)
+      ruby2_keywords
+    faraday-net_http (1.0.1)
+    flipper (0.20.3)
+    flipper-active_record (0.20.3)
       activerecord (>= 5.0, < 7)
-      flipper (~> 0.19.0)
-    gem-release (2.1.1)
+      flipper (~> 0.20.3)
+    gem-release (2.2.1)
     hitimes (1.3.1)
-    i18n (1.8.5)
+    i18n (1.8.9)
       concurrent-ruby (~> 1.0)
-    json (2.3.1)
+    json (2.5.1)
     jwt (2.2.2)
     lru_redux (1.1.0)
     method_source (1.0.0)
-    minitest (5.14.1)
+    minitest (5.14.4)
     multipart-post (2.1.1)
-    net-http-persistent (4.0.0)
+    net-http-persistent (4.0.1)
       connection_pool (~> 2.2)
     pry (0.13.1)
       coderay (~> 1.1)
@@ -58,7 +61,7 @@ GEM
       byebug (~> 11.0)
       pry (~> 0.13.0)
     rake (13.0.1)
-    redis (4.2.2)
+    redis (4.2.5)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -72,23 +75,24 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
+    ruby2_keywords (0.0.4)
     socketry (0.5.1)
       hitimes (~> 1.2)
-    splitclient-rb (7.1.3)
+    splitclient-rb (7.2.3)
       concurrent-ruby (~> 1.0)
       faraday (>= 0.8)
       json (>= 1.8)
       jwt (>= 2.2.1)
       lru_redux
       net-http-persistent (>= 2.9)
-      redis (>= 3.2)
+      redis (>= 4.2.2)
       socketry (~> 0.5.1)
       thread_safe (>= 0.3)
     sqlite3 (1.4.2)
     thread_safe (0.3.6)
-    tzinfo (1.2.7)
-      thread_safe (~> 0.1)
-    zeitwerk (2.4.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby

data/README.md

@@ -63,7 +63,7 @@ These adapters do behave slightly differently, so make sure to read the followin
 
 - [Flipper adapter](./docs/flipper.md)
 - [Split.io adapter](./docs/splitio.md)
-- [Memory adapter](./docs/memory.md) - **very helpful to use in tests**
+- [Memory adapter](./docs/memory.md) - **designed for use in tests**
 
 ## Development
 

data/lib/this_feature/adapters/flipper.rb

@@ -19,17 +19,11 @@ class ThisFeature
       end
 
       def on?(flag_name, context: nil, data: {})
-        return unless present?(flag_name)
-
         client[flag_name].enabled?(*[context].compact)
       end
 
       def off?(flag_name, context: nil, data: {})
-        on_result = on?(flag_name, context: context)
-
-        return if on_result.nil?
-
-        !on_result
+        !on?(flag_name, context: context)
       end
 
       private

data/lib/this_feature/adapters/memory.rb

@@ -15,7 +15,7 @@ class ThisFeature
       end
 
       def on?(flag_name, context: nil, data: {})
-        return unless present?(flag_name)
+        return false unless present?(flag_name)
 
         flag_data = storage[flag_name]
 
@@ -28,11 +28,11 @@ class ThisFeature
       end
 
       def off?(flag_name, context: nil, data: {})
-        on_result = on?(flag_name, context: context)
-
-        return if on_result.nil?
+        !on?(flag_name, context: context, data: data)
+      end
 
-        !on_result
+      def control?(flag_name, **kwargs)
+        !present?(flag_name)
       end
 
       def on!(flag_name, context: nil, data: {})

data/lib/this_feature/adapters/split_io.rb

@@ -6,8 +6,9 @@ class ThisFeature
       # used as treatment key when none is given, it's required by split
       UNDEFINED_KEY = 'undefined_key'
 
-      def initialize(client: nil)
+      def initialize(client: nil, context_key_method: nil)
         @client = client || default_split_client
+        @context_key_method = context_key_method
 
         @client.block_until_ready
       end
@@ -30,18 +31,18 @@ class ThisFeature
 
       private
 
-      attr_reader :client
+      attr_reader :client, :context_key_method
 
       def treatment(flag_name, context: UNDEFINED_KEY, data: {})
-        key = if context.nil?
-          UNDEFINED_KEY
-        elsif context.respond_to?(:to_s)
-          context.to_s
-        else
-          context
-        end
-
-        client.get_treatment(key, flag_name, data)
+        client.get_treatment(context_key(context), flag_name, data)
+      end
+
+      def context_key(context)
+        return UNDEFINED_KEY if context.nil? || context.eql?(UNDEFINED_KEY)
+        return context.send(context_key_method) unless context_key_method.nil?
+        return context.to_s if context.respond_to?(:to_s)
+
+        context
       end
 
       def default_split_client

data/lib/this_feature/configuration.rb

@@ -7,6 +7,8 @@ class ThisFeature
     end
 
     def validate_adapters!
+      raise(NoAdaptersError.new) unless adapters.any?
+
       adapters.each do |adapter|
         raise BadAdapterError.new(adapter) unless adapter.class < Adapters::Base
       end

data/lib/this_feature/errors.rb

@@ -14,9 +14,9 @@ class ThisFeature
     end
   end
 
-  class NoWriteAdapter < Error
+  class NoAdaptersError < Error
     def initialize
-      super("Use the `ThisFeature.write_adapter=` setter before calling #enable or #disable")
+      super("No adapters configured.")
     end
   end
 

data/lib/this_feature/version.rb

@@ -1,3 +1,3 @@
 class ThisFeature
-  VERSION = "0.5.0"
+  VERSION = "0.6.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: this_feature-adapters-flipper
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Max Pleaner
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-25 00:00:00.000000000 Z
+date: 2021-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: this_feature
@@ -78,6 +78,7 @@ files:
 - lib/this_feature/flag.rb
 - lib/this_feature/version.rb
 - memory
+- this_feature-0.6.0.gem
 - this_feature-adapters-flipper.gemspec
 - this_feature-adapters-split_io.gemspec
 - this_feature.gemspec
@@ -85,7 +86,7 @@ homepage: http://hover.to
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -100,8 +101,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: "[summary]"
 test_files: []