thinking-sphinx 3.1.4 → 6.0.0

data/spec/thinking_sphinx/active_record/property_sql_presenter_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ThinkingSphinx::ActiveRecord::PropertySQLPresenter do
@@ -7,7 +9,7 @@ describe ThinkingSphinx::ActiveRecord::PropertySQLPresenter do
   let(:path)         { double :aggregate? => false, :model => model }
 
   before :each do
-    adapter.stub(:quote) { |column| column }
+    allow(adapter).to receive(:quote) { |column| column }
 
     stub_const 'Joiner::Path', double(:new => path)
   end
@@ -25,95 +27,95 @@ describe ThinkingSphinx::ActiveRecord::PropertySQLPresenter do
 
     describe '#to_group' do
       it "returns the column name as a string" do
-        presenter.to_group.should == 'articles.title'
+        expect(presenter.to_group).to eq('articles.title')
       end
 
       it "gets the column's table alias from the associations object" do
-        column.stub!(:__stack => [:users, :posts])
+        allow(column).to receive_messages(:__stack => [:users, :posts])
 
-        associations.should_receive(:alias_for).with([:users, :posts]).
+        expect(associations).to receive(:alias_for).with([:users, :posts]).
           and_return('posts')
 
         presenter.to_group
       end
 
       it "returns nil if the property is an aggregate" do
-        path.stub! :aggregate? => true
+        allow(path).to receive_messages :aggregate? => true
 
-        presenter.to_group.should be_nil
+        expect(presenter.to_group).to be_nil
       end
 
       it "returns nil if the field is sourced via a separate query" do
-        field.stub :source_type => 'query'
+        allow(field).to receive_messages :source_type => 'query'
 
-        presenter.to_group.should be_nil
+        expect(presenter.to_group).to be_nil
       end
     end
 
     describe '#to_select' do
       it "returns the column name as a string" do
-        presenter.to_select.should == 'articles.title AS title'
+        expect(presenter.to_select).to eq('articles.title AS title')
       end
 
       it "gets the column's table alias from the associations object" do
-        column.stub!(:__stack => [:users, :posts])
+        allow(column).to receive_messages(:__stack => [:users, :posts])
 
-        associations.should_receive(:alias_for).with([:users, :posts]).
+        expect(associations).to receive(:alias_for).with([:users, :posts]).
           and_return('posts')
 
         presenter.to_select
       end
 
       it "returns the column name with an alias when provided" do
-        field.stub!(:name => :subject)
+        allow(field).to receive_messages(:name => :subject)
 
-        presenter.to_select.should == 'articles.title AS subject'
+        expect(presenter.to_select).to eq('articles.title AS subject')
       end
 
       it "groups and concatenates aggregated columns" do
-        adapter.stub :group_concatenate do |clause, separator|
+        allow(adapter).to receive :group_concatenate do |clause, separator|
           "GROUP_CONCAT(#{clause} SEPARATOR '#{separator}')"
         end
 
-        path.stub! :aggregate? => true
+        allow(path).to receive_messages :aggregate? => true
 
-        presenter.to_select.
-          should == "GROUP_CONCAT(articles.title SEPARATOR ' ') AS title"
+        expect(presenter.to_select).
+          to eq("GROUP_CONCAT(articles.title SEPARATOR ' ') AS title")
       end
 
       it "concatenates multiple columns" do
-        adapter.stub :concatenate do |clause, separator|
+        allow(adapter).to receive :concatenate do |clause, separator|
           "CONCAT_WS('#{separator}', #{clause})"
         end
 
-        field.stub!(:columns => [column, column])
+        allow(field).to receive_messages(:columns => [column, column])
 
-        presenter.to_select.
-          should == "CONCAT_WS(' ', articles.title, articles.title) AS title"
+        expect(presenter.to_select).
+          to eq("CONCAT_WS(' ', articles.title, articles.title) AS title")
       end
 
       it "does not include columns that don't exist" do
-        adapter.stub :concatenate do |clause, separator|
+        allow(adapter).to receive :concatenate do |clause, separator|
           "CONCAT_WS('#{separator}', #{clause})"
         end
 
-        field.stub!(:columns => [column, double('column', :string? => false,
+        allow(field).to receive_messages(:columns => [column, double('column', :string? => false,
           :__stack => [], :__name => 'body')])
 
-        presenter.to_select.
-          should == "CONCAT_WS(' ', articles.title) AS title"
+        expect(presenter.to_select).
+          to eq("CONCAT_WS(' ', articles.title) AS title")
       end
 
       it "returns nil for query sourced fields" do
-        field.stub :source_type => :query
+        allow(field).to receive_messages :source_type => :query
 
-        presenter.to_select.should be_nil
+        expect(presenter.to_select).to be_nil
       end
 
       it "returns nil for ranged query sourced fields" do
-        field.stub :source_type => :ranged_query
+        allow(field).to receive_messages :source_type => :ranged_query
 
-        presenter.to_select.should be_nil
+        expect(presenter.to_select).to be_nil
       end
     end
   end
@@ -131,131 +133,131 @@ describe ThinkingSphinx::ActiveRecord::PropertySQLPresenter do
       :__name => 'created_at') }
 
     before :each do
-      adapter.stub :cast_to_timestamp do |clause|
+      allow(adapter).to receive :cast_to_timestamp do |clause|
         "UNIX_TIMESTAMP(#{clause})"
       end
     end
 
     describe '#to_group' do
       it "returns the column name as a string" do
-        presenter.to_group.should == 'articles.created_at'
+        expect(presenter.to_group).to eq('articles.created_at')
       end
 
       it "gets the column's table alias from the associations object" do
-        column.stub!(:__stack => [:users, :posts])
+        allow(column).to receive_messages(:__stack => [:users, :posts])
 
-        associations.should_receive(:alias_for).with([:users, :posts]).
+        expect(associations).to receive(:alias_for).with([:users, :posts]).
           and_return('posts')
 
         presenter.to_group
       end
 
       it "returns nil if the column is a string" do
-        column.stub!(:string? => true)
+        allow(column).to receive_messages(:string? => true)
 
-        presenter.to_group.should be_nil
+        expect(presenter.to_group).to be_nil
       end
 
       it "returns nil if the property is an aggregate" do
-        path.stub! :aggregate? => true
+        allow(path).to receive_messages :aggregate? => true
 
-        presenter.to_group.should be_nil
+        expect(presenter.to_group).to be_nil
       end
 
       it "returns nil if the attribute is sourced via a separate query" do
-        attribute.stub :source_type => 'query'
+        allow(attribute).to receive_messages :source_type => 'query'
 
-        presenter.to_group.should be_nil
+        expect(presenter.to_group).to be_nil
       end
     end
 
     describe '#to_select' do
       it "returns the column name as a string" do
-        presenter.to_select.should == 'articles.created_at AS created_at'
+        expect(presenter.to_select).to eq('articles.created_at AS created_at')
       end
 
       it "gets the column's table alias from the associations object" do
-        column.stub!(:__stack => [:users, :posts])
+        allow(column).to receive_messages(:__stack => [:users, :posts])
 
-        associations.should_receive(:alias_for).with([:users, :posts]).
+        expect(associations).to receive(:alias_for).with([:users, :posts]).
           and_return('posts')
 
         presenter.to_select
       end
 
       it "returns the column name with an alias when provided" do
-        attribute.stub!(:name => :creation_timestamp)
+        allow(attribute).to receive_messages(:name => :creation_timestamp)
 
-        presenter.to_select.
-          should == 'articles.created_at AS creation_timestamp'
+        expect(presenter.to_select).
+          to eq('articles.created_at AS creation_timestamp')
       end
 
       it "ensures datetime attributes are converted to timestamps" do
-        attribute.stub :type => :timestamp
+        allow(attribute).to receive_messages :type => :timestamp
 
-        presenter.to_select.
-          should == 'UNIX_TIMESTAMP(articles.created_at) AS created_at'
+        expect(presenter.to_select).
+          to eq('UNIX_TIMESTAMP(articles.created_at) AS created_at')
       end
 
       it "does not include columns that don't exist" do
-        adapter.stub :concatenate do |clause, separator|
+        allow(adapter).to receive :concatenate do |clause, separator|
           "CONCAT_WS('#{separator}', #{clause})"
         end
-        adapter.stub :cast_to_string do |clause|
+        allow(adapter).to receive :cast_to_string do |clause|
           "CAST(#{clause} AS varchar)"
         end
 
-        attribute.stub!(:columns => [column, double('column',
+        allow(attribute).to receive_messages(:columns => [column, double('column',
           :string? => false, :__stack => [], :__name => 'updated_at')])
 
-        presenter.to_select.should == "CONCAT_WS(',', CAST(articles.created_at AS varchar)) AS created_at"
+        expect(presenter.to_select).to eq("CONCAT_WS(',', CAST(articles.created_at AS varchar)) AS created_at")
       end
 
       it "casts and concatenates multiple columns for attributes" do
-        adapter.stub :concatenate do |clause, separator|
+        allow(adapter).to receive :concatenate do |clause, separator|
           "CONCAT_WS('#{separator}', #{clause})"
         end
-        adapter.stub :cast_to_string do |clause|
+        allow(adapter).to receive :cast_to_string do |clause|
           "CAST(#{clause} AS varchar)"
         end
 
-        attribute.stub!(:columns => [column, column])
+        allow(attribute).to receive_messages(:columns => [column, column])
 
-        presenter.to_select.should == "CONCAT_WS(',', CAST(articles.created_at AS varchar), CAST(articles.created_at AS varchar)) AS created_at"
+        expect(presenter.to_select).to eq("CONCAT_WS(',', CAST(articles.created_at AS varchar), CAST(articles.created_at AS varchar)) AS created_at")
       end
 
       it "double-casts and concatenates multiple columns for timestamp attributes" do
-        adapter.stub :concatenate do |clause, separator|
+        allow(adapter).to receive :concatenate do |clause, separator|
           "CONCAT_WS('#{separator}', #{clause})"
         end
-        adapter.stub :cast_to_string do |clause|
+        allow(adapter).to receive :cast_to_string do |clause|
           "CAST(#{clause} AS varchar)"
         end
 
-        attribute.stub :columns => [column, column], :type => :timestamp
+        allow(attribute).to receive_messages :columns => [column, column], :type => :timestamp
 
-        presenter.to_select.should == "CONCAT_WS(',', CAST(UNIX_TIMESTAMP(articles.created_at) AS varchar), CAST(UNIX_TIMESTAMP(articles.created_at) AS varchar)) AS created_at"
+        expect(presenter.to_select).to eq("CONCAT_WS(',', CAST(UNIX_TIMESTAMP(articles.created_at) AS varchar), CAST(UNIX_TIMESTAMP(articles.created_at) AS varchar)) AS created_at")
       end
 
       it "does not split attribute clause for timestamp casting if it looks like a function call" do
-        column.stub :__name => "COALESCE(articles.updated_at, articles.created_at)", :string? => true
+        allow(column).to receive_messages :__name => "COALESCE(articles.updated_at, articles.created_at)", :string? => true
 
-        attribute.stub :name => 'mod_date', :columns => [column],
+        allow(attribute).to receive_messages :name => 'mod_date', :columns => [column],
           :type => :timestamp
 
-        presenter.to_select.should == "UNIX_TIMESTAMP(COALESCE(articles.updated_at, articles.created_at)) AS mod_date"
+        expect(presenter.to_select).to eq("UNIX_TIMESTAMP(COALESCE(articles.updated_at, articles.created_at)) AS mod_date")
       end
 
       it "returns nil for query sourced attributes" do
-        attribute.stub :source_type => :query
+        allow(attribute).to receive_messages :source_type => :query
 
-        presenter.to_select.should be_nil
+        expect(presenter.to_select).to be_nil
       end
 
       it "returns nil for ranged query sourced attributes" do
-        attribute.stub :source_type => :ranged_query
+        allow(attribute).to receive_messages :source_type => :ranged_query
 
-        presenter.to_select.should be_nil
+        expect(presenter.to_select).to be_nil
       end
     end
   end