therubyracer 0.9.0beta7 → 0.9.0

data/Changelog.md

@@ -1,7 +1,9 @@
 # Changelog  
 
-## Edge
+## 0.9.0 - 2011/06/10
 
+* extract libv8 into installable binary for most platforms
+* fix numerous memory leaks
 * expose the V8 debugger via V8::C::Debug::EnableAgent()
 * force UTf-8 encoding on strings returned from javascript in ruby 1.9
 * remove deprecated evaluate() methods

data/ext/v8/v8_string.cpp

@@ -24,7 +24,8 @@ namespace {
   }
   VALUE Utf8Value(VALUE self) {
     HandleScope handles;
-    return rb_str_new2(*String::Utf8Value(unwrap(self)));
+    Handle<String> str = unwrap(self);
+    return rb_str_new(*String::Utf8Value(str), str->Utf8Length());
   }
   VALUE Utf16Value(VALUE self) {
     //How are UTF16 strings represented in ruby 1.8, 1.9
@@ -32,7 +33,8 @@ namespace {
   }
   VALUE AsciiValue(VALUE self) {
     HandleScope handles;
-    return rb_str_new2(*String::AsciiValue(unwrap(self)));
+    Handle<String> str = unwrap(self);
+    return rb_str_new(*String::AsciiValue(str), str->Length());
   }
 }
 

data/lib/v8/portal/caller.rb

@@ -16,6 +16,8 @@ module V8
             raise e
           else
             error = V8::C::Exception::Error(V8::C::String::New(e.message))
+            #TODO: This is almost certainly a crash here.
+            #we need to hold onto `error` while it bubbles up the javascript stack.
             error.SetHiddenValue("TheRubyRacer::Cause", C::External::New(e))
             V8::C::ThrowException(error)
           end

data/lib/v8/portal/proxies.rb

@@ -46,10 +46,16 @@ module V8
         V8::C::V8::AdjustAmountOfExternalAllocatedMemory(16 * 1024)
       end
 
+      # Lookup the JavaScript proxy for a natively Ruby object
+      # @param [Object] object the Ruby object
+      # @return [V8::C::Handle] the JavaScript proxy representing `object`
       def rb_object_2_js_proxy(object)
         @js_proxies_rb2js[object]
       end
 
+      # Look up a natively Ruby object given its JavaScript proxy
+      # @param [V8::C::Handle] proxy the JavaScript proxy
+      # @return [Object] the Ruby object represented by `proxy`
       def js_proxy_2_rb_object(proxy)
         @js_proxies_js2rb[proxy]
       end
@@ -63,12 +69,25 @@ module V8
         V8::C::V8::AdjustAmountOfExternalAllocatedMemory(8 * 1024)
       end
 
+      # Looks up the Ruby proxy for an object that is natively JavaScript
+      # @param [V8::C::Handle] object the JavaScript whose proxy we want
+      # @return [Object] the Ruby proxy for `object`
       def js_object_2_rb_proxy(object)
         if id = @rb_proxies_js2rb[object]
           ObjectSpace._id2ref id
         end
+      rescue RangeError => e
+        # sometimes, the Ruby proxy has been garbage collected, but
+        # the finalizer which runs has not been called. That's OK
+        # we just clear out the entry, and return nil so that a new
+        # proxy can be created.
+        @clear_rb_proxy.call(id)
+        return nil
       end
 
+      # Looks up a native JavaScript object by its Ruby proxy
+      # @param [Object] proxy the Ruby proxy
+      # @return [V8::C::Handle] the native JavaScript object
       def rb_proxy_2_js_object(proxy)
         @rb_proxies_rb2js[proxy.object_id]
       end
@@ -100,16 +119,35 @@ module V8
         end
       end
 
+      # @Private
+      # Remove the linkage between a Ruby proxy and a native
+      # JavaScript object. In general, this object is registered
+      # as a finalizer on the Ruby proxy itself, so that when it is
+      # garbage collected, it releases the back reference to the
+      # native JavaScript object.
+      #
+      # It is important to do this as soon as is reasonably possible
+      # so that the native JavaScript object can itself be garbage 
+      # collected (provided there are no other references to it)
       class ClearRubyProxy
         def initialize(rb2js, js2rb)
           @rb2js, @js2rb = rb2js, js2rb
         end
 
+        # takes the object id of a Ruby proxy that has been garbage collected
+        # and releases the reference to the native JavaScript object that
+        # it was bound to.
+        # @param[Fixnum] proxy_id the proxy id of the garbage collected Ruby proxy
         def call(proxy_id)
-          js = @rb2js[proxy_id]
-          @rb2js.delete(proxy_id)
-          @js2rb.delete(js)
-          V8::C::V8::AdjustAmountOfExternalAllocatedMemory(-8 * 1024)
+          # TODO: this if-check should be synchronized, so that if called manually
+          # it will not conflict with the finalization thread. It's not so heinous
+          # if the refererence gets cleared twice, but we definiteily dont't want
+          # to double-decrement the v8 GC hint.
+          if js = @rb2js[proxy_id]
+            @rb2js.delete(proxy_id)
+            @js2rb.delete(js)
+            V8::C::V8::AdjustAmountOfExternalAllocatedMemory(-8 * 1024)
+          end
         end
       end
     end

data/lib/v8/version.rb

@@ -1,3 +1,3 @@
 module V8
-  VERSION = "0.9.0beta7"
+  VERSION = "0.9.0"
 end

data/spec/ext/string_spec.rb

@@ -0,0 +1,11 @@
+
+require 'spec_helper'
+
+describe V8::C::String do
+  include V8::ExtSpec
+  
+  describe "a string with null bytes" do
+    subject {c::String::New("foo\0bar")}
+    its(:Utf8Value) {should eql "foo\0bar"}
+  end
+end

data/specmem/proxies_memspec.rb

@@ -12,11 +12,12 @@ describe V8::Portal::Proxies do
     end
 
     it "releases the hard reference if its corresponding javascript object has been garbage collected" do
-      rb_object = Object.new
-      js_proxy = c::Object::New()
-      subject.register_javascript_proxy js_proxy, :for => rb_object
-      rb_object = nil
       ruby_gc do
+        rb_object = Object.new
+        js_proxy = c::Object::New()
+        subject.should be_empty
+        subject.register_javascript_proxy js_proxy, :for => rb_object
+        rb_object = nil
         subject.should_not be_empty
         v8_gc()
       end

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: therubyracer
 version: !ruby/object:Gem::Version 
-  prerelease: 5
-  version: 0.9.0beta7
+  prerelease: 
+  version: 0.9.0
 platform: ruby
 authors: 
 - Charles Lowell
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-02 00:00:00 -05:00
+date: 2011-06-10 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -140,6 +140,7 @@ files:
 - spec/ext/ext_spec_helper.rb
 - spec/ext/func_spec.rb
 - spec/ext/object_spec.rb
+- spec/ext/string_spec.rb
 - spec/ext/try_catch_spec.rb
 - spec/redjs_helper.rb
 - spec/spec_helper.rb
@@ -169,16 +170,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -1276092600140141733
+      hash: -3759778087038355586
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version 
-      version: 1.3.1
+      hash: -3759778087038355586
+      segments: 
+      - 0
+      version: "0"
 requirements: []
 
 rubyforge_project: therubyracer