therubyracer 0.8.0.pre3 → 0.8.0

data/History.txt

@@ -1,3 +1,13 @@
+=== 0.8.0 2010-12-02
+* 3 major enhancements
+  * every V8 Context gets its own unique access strategy
+  * ruby methods and procs embedded in javascript always return the same function per context.
+  * ruby classes and subclasses are now all connected via the javascript prototype chain
+* 3 minor enhancements
+  * better error reporting on syntax errors
+  * upgrade to rspec 2
+  * several bug fixes and stability fixes
+
 === 0.7.5 1010-08-03
 * 4 major enhancements
   * upgrade to V8 2.3.3

data/Rakefile

@@ -7,7 +7,7 @@ manifest.exclude "lib/v8/*.bundle", "lib/v8/*.so", "ext/**/test/*", "ext/**/test
 Gem::Specification.new do |gemspec|
   $gemspec = gemspec
   gemspec.name = gemspec.rubyforge_project = "therubyracer"
-  gemspec.version = "0.8.0.pre3"
+  gemspec.version = "0.8.0"
   gemspec.summary = "Embed the V8 Javascript interpreter into Ruby"
   gemspec.description = "Call javascript code and manipulate javascript objects from ruby. Call ruby code and manipulate ruby objects from javascript."
   gemspec.email = "cowboyd@thefrontside.net"

data/ext/v8/rr.cpp

@@ -8,6 +8,7 @@
 #include "v8_date.h"
 #include "v8_msg.h"
 #include "v8_external.h"
+#include "v8_exception.h"
 
 using namespace v8;
 
@@ -75,6 +76,13 @@ VALUE rr_v82rb(Handle<Value> value) {
 VALUE rr_v82rb(Handle<Message> value) {
   return rr_reflect_v8_message(value);
 }
+VALUE rr_v82rb(Handle<StackTrace> value) {
+  return rr_reflect_v8_stacktrace(value);
+}
+VALUE rr_v82rb(Handle<StackFrame> value) {
+  return rr_reflect_v8_stackframe(value);
+}
+
 VALUE rr_v82rb(Handle<Boolean> value) {
   return rr_v82rb((Handle<Value>)value);
 }
@@ -87,6 +95,9 @@ VALUE rr_v82rb(Handle<String> value) {
 VALUE rr_v82rb(Handle<Object> value) {
   return rr_v82rb((Handle<Value>)value);
 }
+VALUE rr_v82rb(Handle<Array> value) {
+  return rr_v82rb((Handle<Value>)value);
+}
 VALUE rr_v82rb(v8::Handle<v8::Function> value) {
   return rr_v82rb((Handle<Value>)value);
 }

data/ext/v8/rr.h

@@ -16,11 +16,15 @@ VALUE rr_v82rb(v8::Handle<v8::Boolean> value);
 VALUE rr_v82rb(v8::Handle<v8::Number> value);
 VALUE rr_v82rb(v8::Handle<v8::String> value);
 VALUE rr_v82rb(v8::Handle<v8::Object> value);
+VALUE rr_v82rb(v8::Handle<v8::Array> value);
 VALUE rr_v82rb(v8::Handle<v8::Function> value);
 VALUE rr_v82rb(v8::Handle<v8::Integer> value);
 VALUE rr_v82rb(v8::Handle<v8::Uint32> value);
 VALUE rr_v82rb(v8::Handle<v8::Int32> value);
 VALUE rr_v82rb(v8::Handle<v8::Message> value);
+VALUE rr_v82rb(v8::Handle<v8::StackTrace> value);
+VALUE rr_v82rb(v8::Handle<v8::StackFrame> value);
+
 VALUE rr_v82rb(bool value);
 VALUE rr_v82rb(double value);
 VALUE rr_v82rb(int64_t value);

data/ext/v8/v8_exception.cpp

@@ -1,5 +1,6 @@
 #include "v8_exception.h"
 #include "rr.h"
+#include "v8_ref.h"
 #include "execinfo.h"
 #include "signal.h"
 
@@ -38,19 +39,90 @@ namespace {
     HandleScope scope;
     return rr_v82rb(Exception::Error(rr_rb2v8(value)->ToString()));
   }
+
+  VALUE StackTraceClass;
+  VALUE StackFrameClass;
+  namespace Trace {
+
+    Local<StackTrace> trace(VALUE value) {
+      return V8_Ref_Get<StackTrace>(value);
+    }
+    VALUE GetFrame(VALUE self, VALUE index) {
+      HandleScope scope;
+      return rr_v82rb(trace(self)->GetFrame(NUM2UINT(index)));
+    }
+    VALUE GetFrameCount(VALUE self) {
+      HandleScope scope;
+      Local<StackTrace> t = trace(self);
+      return rr_v82rb(t->GetFrameCount());
+    }
+    VALUE AsArray(VALUE self) {
+      return rr_v82rb(trace(self)->AsArray());
+    }
+    VALUE CurrentStackTrace(VALUE self, VALUE frame_limit) {
+      return rr_v82rb(StackTrace::CurrentStackTrace(NUM2INT(frame_limit)));
+    }
+  }
+
+  namespace Frame {
+    Local<StackFrame> frame(VALUE value) {
+     return V8_Ref_Get<StackFrame>(value);
+    }
+    VALUE GetLineNumber(VALUE self) {
+      return rr_v82rb(frame(self)->GetLineNumber());
+    }
+    VALUE GetColumn(VALUE self) {
+      return rr_v82rb(frame(self)->GetColumn());
+    }
+    VALUE GetScriptName(VALUE self) {
+      return rr_v82rb(frame(self)->GetScriptName());
+    }
+    VALUE GetFunctionName(VALUE self) {
+      return rr_v82rb(frame(self)->GetFunctionName());
+    }
+    VALUE IsEval(VALUE self) {
+      return rr_v82rb(frame(self)->IsEval());
+    }
+    VALUE IsConstructor(VALUE self) {
+      return rr_v82rb(frame(self)->IsConstructor());
+    }
+  }
+
 }
 
 void rr_init_v8_exception() {
   VALUE V8 = rb_define_module("V8");
   VALUE V8_C = rb_define_module_under(V8, "C");
   rr_define_singleton_method(V8_C, "ThrowException", _ThrowException, 1);
+
   VALUE ExceptionClass = rr_define_class("Exception");
   rr_define_singleton_method(ExceptionClass, "RangeError", RangeError, 1);
   rr_define_singleton_method(ExceptionClass, "ReferenceError", ReferenceError, 1);
   rr_define_singleton_method(ExceptionClass, "SyntaxError", SyntaxError, 1);
   rr_define_singleton_method(ExceptionClass, "Error", Error, 1);
-  
+
+  StackTraceClass = rr_define_class("StackTrace");
+  rr_define_singleton_method(StackTraceClass, "CurrentStackTrace", Trace::CurrentStackTrace, 0);
+  rr_define_method(StackTraceClass, "GetFrame", Trace::GetFrame, 1);
+  rr_define_method(StackTraceClass, "GetFrameCount", Trace::GetFrameCount, 0);
+  rr_define_method(StackTraceClass, "AsArray", Trace::AsArray, 0);
+
+  StackFrameClass = rr_define_class("StackFrame");
+  rr_define_method(StackFrameClass, "GetLineNumber", Frame::GetLineNumber, 0);
+  rr_define_method(StackFrameClass, "GetColumn", Frame::GetColumn, 0);
+  rr_define_method(StackFrameClass, "GetScriptName", Frame::GetScriptName, 0);
+  rr_define_method(StackFrameClass, "GetFunctionName", Frame::GetFunctionName, 0);
+  rr_define_method(StackFrameClass, "IsEval", Frame::IsEval, 0);
+  rr_define_method(StackFrameClass, "IsConstructor", Frame::IsConstructor, 0);
+
   v8::V8::SetFatalErrorHandler(fatal);
   //comment this in for debugging.
   // signal(SIGSEGV, segfault);
-}
+}
+
+VALUE rr_reflect_v8_stacktrace(Handle<StackTrace> value) {
+  return rr_v8_ref_create(StackTraceClass, value);
+}
+VALUE rr_reflect_v8_stackframe(Handle<StackTrace> value) {
+  return rr_v8_ref_create(StackFrameClass, value);
+}

data/ext/v8/v8_exception.h

@@ -1,6 +1,11 @@
 #ifndef _RR_V8_EXCEPTION_
 #define _RR_V8_EXCEPTION_
 
+#include "v8.h"
+#include "ruby.h"
+
 void rr_init_v8_exception();
+VALUE rr_reflect_v8_stacktrace(v8::Handle<v8::StackTrace> value);
+VALUE rr_reflect_v8_stackframe(v8::Handle<v8::StackFrame> value);
 
 #endif

data/ext/v8/v8_msg.cpp

@@ -23,6 +23,11 @@ namespace {
     return rr_v82rb(unwrap(self)->GetScriptResourceName());
   }
 
+  VALUE GetStackTrace(VALUE self) {
+    Handle<StackTrace> trace = unwrap(self)->GetStackTrace();
+    return trace.IsEmpty() ? Qnil : rr_v82rb(trace);
+  }
+
   VALUE GetLineNumber(VALUE self) {
     return rr_v82rb(unwrap(self)->GetLineNumber());
   }
@@ -49,6 +54,7 @@ void rr_init_msg() {
   rr_define_method(MessageClass, "Get", Get, 0);
   rr_define_method(MessageClass, "GetSourceLine", GetSourceLine, 0);
   rr_define_method(MessageClass, "GetScriptResourceName", GetScriptResourceName, 0);
+  rr_define_method(MessageClass, "GetStackTrace", GetStackTrace, 0);
   rr_define_method(MessageClass, "GetLineNumber", GetLineNumber, 0);
   rr_define_method(MessageClass, "GetStartPosition", GetStartPosition, 0);
   rr_define_method(MessageClass, "GetEndPosition", GetEndPosition, 0);

data/lib/v8/error.rb

@@ -41,7 +41,6 @@ module V8
       else
         @value = ex
         message = ex.to_s
-        @boundaries.first.jsframes << 'at [???].js'
       end
       return message
     end
@@ -88,13 +87,31 @@ module V8
     end
 
     def parse_js_frames(try)
+      #I can't figure out why V8 is not capturing the stacktrace here
+      #in terms of StackTrace and StackFrame objects, so we have to
+      #parse the string.
       raw = @to.rb(try.StackTrace())
-      if raw && !raw.empty?
+      if raw && !raw.empty? && !syntax_error?(try)
         raw.split("\n")[1..-1].tap do |frames|
           frames.each {|frame| frame.strip!.chomp!(",")}
         end
       else
-        []
+        msg = try.Message()
+        ["at #{@to.rb(msg.GetScriptResourceName())}:#{msg.GetLineNumber()}:#{msg.GetStartColumn() + 1}"]
+      end
+    end
+
+    #Syntax errors are weird in that they have a non-empty stack trace
+    #but it does not contain any source location information, so
+    #in these instances, we have to pull it out of the Message object
+    #in the TryCatch. Is there a better way to detect a syntax error
+    def syntax_error?(try)
+      ex = try.Exception()
+      if ex && ex.kind_of?(V8::C::Object)
+        type = ex.Get("constructor")
+        type && type.kind_of?(V8::C::Function) && type.GetName().AsciiValue == "SyntaxError"
+      else
+        false
       end
     end
 

data/lib/v8.rb

@@ -2,7 +2,7 @@ $:.unshift(File.dirname(__FILE__)) unless
   $:.include?(File.dirname(__FILE__)) || $:.include?(File.expand_path(File.dirname(__FILE__)))
 
 module V8
-  VERSION = '0.8.0.pre3'
+  VERSION = '0.8.0'
   require 'v8/v8' #native glue
   require 'v8/portal'
   require 'v8/portal/functions'

data/spec/v8/error_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe V8::JSError do
-  
+
   before(:each) do
     @cxt = V8::Context.new
     @cxt['one'] = lambda do
@@ -11,13 +11,13 @@ describe V8::JSError do
       @cxt.eval('three()', 'two.js')
     end
   end
-  
+
   it "captures a message without over nesting when the error is an error" do
     throw! do |e|
       e.message.should == "BOOM!"
     end
   end
-  
+
   it "captures the js message without over nesting when the error is a normal object" do
     throw!('{foo: "bar"}') do |e|
       e.message.should == "[object Object]"
@@ -26,7 +26,7 @@ describe V8::JSError do
       e.message.should == "bar"
     end
   end
-  
+
   it "captures a thrown value as the message" do
     throw!('"BOOM!"') do |e|
       e.message.should == "BOOM!"
@@ -35,7 +35,7 @@ describe V8::JSError do
       e.message.should == '6'
     end
   end
-  
+
   it "has a reference to the root javascript cause" do
     throw!('"I am a String"') do |e|
       e.should_not be_in_ruby
@@ -43,7 +43,7 @@ describe V8::JSError do
       e.value.should == "I am a String"
     end
   end
-  
+
   it "has a reference to the root ruby cause if one exists" do
     StandardError.new("BOOM!").tap do |bomb|
       @cxt['boom'] = lambda do
@@ -58,9 +58,9 @@ describe V8::JSError do
       end)
     end
   end
-  
+
   describe "backtrace" do
-    
+
     it "is mixed with ruby and javascript" do
       throw! do |e|
         e.backtrace.first.should == "at three.js:1:7"
@@ -89,10 +89,23 @@ describe V8::JSError do
     
     it "includes a mystery marker when the original frame is unavailable because what got thrown wasn't an error" do
       throw!("6") do |e|
-        e.backtrace.first.should == 'at [???].js'
+        e.backtrace.first.should == 'at three.js:1:1'
       end
     end
     
+    it "has a source name and line number when there is a javascript SyntaxError" do
+      lambda do
+        @cxt.eval(<<-INVALID, 'source.js')
+"this line is okay";
+"this line has a syntax error because it ends with a colon":
+"this line is also okay";
+"how do I find out that line 2 has the syntax error?";
+INVALID
+      end.should raise_error(V8::JSError) {|error|
+        error.backtrace.first.should == 'at source.js:2:60'
+      }
+    end
+
     it "can start with ruby at the bottom" do
       @cxt['boom'] = lambda do
         raise StandardError, "Bif!"

data/therubyracer.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{therubyracer}
-  s.version = "0.8.0.pre3"
+  s.version = "0.8.0"
 
-  s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Charles Lowell", "Bill Robertson"]
-  s.date = %q{2010-11-01}
+  s.date = %q{2010-12-03}
   s.description = %q{Call javascript code and manipulate javascript objects from ruby. Call ruby code and manipulate ruby objects from javascript.}
   s.email = %q{cowboyd@thefrontside.net}
   s.executables = ["therubyracer", "v8"]

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: therubyracer
 version: !ruby/object:Gem::Version 
-  hash: -1876988226
-  prerelease: true
+  hash: 63
+  prerelease: false
   segments: 
   - 0
   - 8
   - 0
-  - pre3
-  version: 0.8.0.pre3
+  version: 0.8.0
 platform: ruby
 authors: 
 - Charles Lowell
@@ -17,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-01 00:00:00 -05:00
+date: 2010-12-03 00:00:00 -06:00
 default_executable: 
 dependencies: []
 
@@ -790,14 +789,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version 
-      hash: 25
+      hash: 3
       segments: 
-      - 1
-      - 3
-      - 1
-      version: 1.3.1
+      - 0
+      version: "0"
 requirements: []
 
 rubyforge_project: therubyracer