therubyracer 0.8.0.pre → 0.8.0.pre2

data/Rakefile

@@ -7,7 +7,7 @@ manifest.exclude "lib/v8/*.bundle", "lib/v8/*.so", "ext/**/test/*", "ext/**/test
 Gem::Specification.new do |gemspec|
   $gemspec = gemspec
   gemspec.name = gemspec.rubyforge_project = "therubyracer"
-  gemspec.version = "0.8.0.pre"
+  gemspec.version = "0.8.0.pre2"
   gemspec.summary = "Embed the V8 Javascript interpreter into Ruby"
   gemspec.description = "Call javascript code and manipulate javascript objects from ruby. Call ruby code and manipulate ruby objects from javascript."
   gemspec.email = "cowboyd@thefrontside.net"

data/ext/v8/v8_date.cpp

@@ -6,18 +6,27 @@
 using namespace v8;
 
 namespace {
-  
+
   VALUE DateClass;
-  
+
   VALUE New(VALUE self, VALUE time) {
     HandleScope scope;
-    return rr_v8_ref_create(self, Date::New(NUM2DBL(rb_funcall(time, rb_intern("to_f"), 0))));
+    return rr_v8_ref_create(self, Date::New(NUM2DBL(time)));
+  }
+
+  // Override Value::NumberValue in order to ensure that we call the more specific and optimized
+  // Number Value in v8::Date
+  VALUE NumberValue(VALUE self) {
+    HandleScope scope;
+    Local<Date> date = V8_Ref_Get<Date>(self);
+    return rr_v82rb(date->NumberValue());
   }
 }
 
 void rr_init_v8_date() {
   DateClass = rr_define_class("Date", rr_cV8_C_Value);
   rr_define_singleton_method(DateClass, "New", New, 1);
+  rr_define_method(DateClass, "NumberValue", NumberValue, 0);
 }
 
 VALUE rr_reflect_v8_date(Handle<Value> value) {

data/lib/v8.rb

@@ -2,7 +2,7 @@ $:.unshift(File.dirname(__FILE__)) unless
   $:.include?(File.dirname(__FILE__)) || $:.include?(File.expand_path(File.dirname(__FILE__)))
 
 module V8
-  VERSION = '0.8.0.pre'
+  VERSION = '0.8.0.pre2'
   require 'v8/v8' #native glue
   require 'v8/portal'
   require 'v8/portal/functions'

data/lib/v8/portal.rb

@@ -82,7 +82,7 @@ module V8
       when V8::C::Array     then peer(value) {V8::Array}
       when V8::C::Object    then peer(value) {V8::Object}
       when V8::C::String    then value.Utf8Value()
-      when V8::C::Date      then Time.at(value.NumberValue())
+      when V8::C::Date      then Time.at(value.NumberValue() / 1000)
       when V8::C::Value     then nil if value.IsEmpty()
       else
         value
@@ -112,7 +112,7 @@ module V8
           end
         end
       when ::Time
-        C::Date::New(value)
+        C::Date::New(value.to_f * 1000)
       when ::Class
         @embedded_constructors[value].GetFunction().tap do |f|
           f.SetHiddenValue(C::String::NewSymbol("TheRubyRacer::RubyObject"), C::External::New(value))

data/spec/redjs/jsapi_spec.rb

@@ -52,6 +52,18 @@ describe "Ruby Javascript API" do
       @cxt.eval("'#{lorem}'").should == lorem
     end
 
+    it "translates JavaScript dates properly into ruby Time objects" do
+      now = Time.now
+      @cxt.eval('new Date()').tap do |time|
+        time.should be_kind_of(Time)
+        time.year.should == now.year
+        time.day.should == now.day
+        time.month.should == now.month
+        time.min.should == now.min
+        time.sec.should == now.sec
+      end
+    end
+
     it "can pass objects back to ruby" do
       @cxt.eval("({foo: 'bar', baz: 'bang', '5': 5, embedded: {badda: 'bing'}})").tap do |object|
         object.should_not be_nil
@@ -129,14 +141,19 @@ describe "Ruby Javascript API" do
     end
 
     it "translates ruby Time to Javascript Date" do
+      now = Time.now
       class_eval do
+        @@now = now
         def ruby_time
-          Time.new
+          @@now
         end
       end
       evaljs('o.ruby_time instanceof Date').should == true
-      evaljs('o.ruby_time.valueOf()').should == Time.new.to_i
-      evaljs('new Date()').should be_kind_of(Time)
+      evaljs('o.ruby_time.getFullYear()').should == now.year
+      evaljs('o.ruby_time.getMonth() + 1').should == now.month
+      evaljs('o.ruby_time.getDate()').should == now.day
+      evaljs('o.ruby_time.getMinutes()').should == now.min
+      evaljs('o.ruby_time.getSeconds()').should == now.sec
     end
 
     it "translates ruby true to Javascript true" do

data/therubyracer.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{therubyracer}
-  s.version = "0.8.0.pre"
+  s.version = "0.8.0.pre2"
 
   s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
   s.authors = ["Charles Lowell", "Bill Robertson"]
-  s.date = %q{2010-09-14}
+  s.date = %q{2010-10-11}
   s.description = %q{Call javascript code and manipulate javascript objects from ruby. Call ruby code and manipulate ruby objects from javascript.}
   s.email = %q{cowboyd@thefrontside.net}
   s.executables = ["therubyracer", "v8"]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: therubyracer
 version: !ruby/object:Gem::Version 
-  hash: 961915908
+  hash: -1876988255
   prerelease: true
   segments: 
   - 0
   - 8
   - 0
-  - pre
-  version: 0.8.0.pre
+  - pre2
+  version: 0.8.0.pre2
 platform: ruby
 authors: 
 - Charles Lowell
@@ -17,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-14 00:00:00 -05:00
+date: 2010-10-11 00:00:00 -05:00
 default_executable: 
 dependencies: []