themoviedb 0.1.0 → 1.0.0

data/spec/find_spec.rb

@@ -3,29 +3,26 @@ require 'spec_helper'
 require 'vcr'
 
 describe Tmdb::Find do
-
-  describe "For a search" do
+  describe 'For a search' do
     before(:each) do
       @find = Tmdb::Find
     end
 
-    it "should return results for imdb_id" do
+    it 'should return results for imdb_id' do
       VCR.use_cassette 'find/search_imdb' do
-        find = @find.imdb_id("tt1375666")
-        find['movie_results'].should be_true
-        find['person_results'].should be_true
-        find['tv_results'].should be_true
+        find = @find.imdb_id('tt1375666')
+        expect(find['movie_results']).to be_truthy
+        expect(find['person_results']).to be_truthy
+        expect(find['tv_results']).to be_truthy
       end
     end
 
-    it "should return results for tvdb_id" do
+    it 'should return results for tvdb_id' do
       VCR.use_cassette 'find/search_tvdb' do
-        find = @find.tvdb_id("81189")
-        find['tv_results'].first['name'].should == 'Breaking Bad'
-        find['tv_results'].should be_true
+        find = @find.tvdb_id('81189')
+        expect(find['tv_results'].first['name']).to eq 'Breaking Bad'
+        expect(find['tv_results']).to be_truthy
       end
     end
-
   end
-
 end

data/spec/movie_spec.rb

@@ -1,316 +1,311 @@
-#encoding: utf-8
+# encoding: utf-8
 require 'rspec'
 require 'spec_helper'
 require 'vcr'
 
 describe Tmdb::Movie do
-
-  @fields = [:id,:adult,:backdrop_path,:belongs_to_collection,
-             :budget,:genres,:homepage,:imdb_id,:original_title,
-             :overview,:popularity,:poster_path,:production_companies,
-             :production_countries,:release_date,:revenue,:runtime,
-             :spoken_languages,:status,:tagline,:title,:vote_average,
-             :vote_count,:alternative_titles,:credits,:images,:keywords,
-             :releases,:trailers,:translations,:reviews,:lists]
+  @fields = [:id, :adult, :backdrop_path, :belongs_to_collection,
+             :budget, :genres, :homepage, :imdb_id, :original_title,
+             :overview, :popularity, :poster_path, :production_companies,
+             :production_countries, :release_date, :revenue, :runtime,
+             :spoken_languages, :status, :tagline, :title, :vote_average,
+             :vote_count, :alternative_titles, :credits, :images, :keywords,
+             :releases, :trailers, :translations, :reviews, :lists]
 
   @fields.each do |field|
     it { should respond_to field }
   end
 
-  describe "For a movie" do
+  describe 'For a movie' do
     before(:each) do
       @movie = Tmdb::Movie
     end
 
-    it "should return the latest movies" do
+    it 'should return the latest movies' do
       VCR.use_cassette 'movie/return_latest_movie' do
-        @movie.latest.should be_true
+        expect(@movie.latest).to be_truthy
       end
     end
 
-    it "should return the upcoming movies" do
+    it 'should return the upcoming movies' do
       VCR.use_cassette 'movie/return_upcoming_movie' do
-        @movie.upcoming.should be_true
+        expect(@movie.upcoming).to be_truthy
       end
     end
 
-    it "should show movies that are now playing" do
+    it 'should show movies that are now playing' do
       VCR.use_cassette 'movie/now_playing' do
-        @movie.now_playing.should be_true
+        expect(@movie.now_playing).to be_truthy
       end
     end
 
-    it "should return popular movies" do
+    it 'should return popular movies' do
       VCR.use_cassette 'movie/popular' do
-        @movie.popular.should be_true
+        expect(@movie.popular).to be_truthy
       end
     end
 
-    it "should return top rated movies" do
+    it 'should return top rated movies' do
       VCR.use_cassette 'movie/top_rated' do
-        @movie.top_rated.should be_true
+        expect(@movie.top_rated).to be_truthy
       end
     end
 
-    it "should return alternative titles for an ID" do
+    it 'should return alternative titles for an ID' do
       VCR.use_cassette 'movie/alternative_titles_for_id' do
-        @movie.alternative_titles(5).should be_true
+        expect(@movie.alternative_titles(5)).to be_truthy
       end
     end
 
-    it "should return cast information for an ID" do
+    it 'should return cast information for an ID' do
       VCR.use_cassette 'movie/cast_information_for_id' do
-        @movie.casts(5).should be_true
+        expect(@movie.casts(5)).to be_truthy
       end
     end
 
-    it "should return crew for an ID" do
+    it 'should return crew for an ID' do
       VCR.use_cassette 'movie/crew_for_id' do
-        @movie.crew(5).should be_true
+        expect(@movie.crew(5)).to be_truthy
       end
     end
 
-    it "should return keywords for an ID" do
+    it 'should return keywords for an ID' do
       VCR.use_cassette 'movie/keywords_for_id' do
-        @movie.keywords(5).should be_true
+        expect(@movie.keywords(5)).to be_truthy
       end
     end
 
-    it "should return releases for an ID" do
+    it 'should return releases for an ID' do
       VCR.use_cassette 'movie/releases_for_id' do
-        @movie.releases(5).should be_true
+        expect(@movie.releases(5)).to be_truthy
       end
     end
 
-    it "should return trailers for an ID" do
+    it 'should return trailers for an ID' do
       VCR.use_cassette 'movie/trailers_for_id' do
-        @movie.trailers(5).should be_true
+        expect(@movie.trailers(5)).to be_truthy
       end
     end
 
-    it "should return translations for an ID" do
+    it 'should return translations for an ID' do
       VCR.use_cassette 'movie/translations_for_id' do
-        @movie.translations(5).should be_true
+        expect(@movie.translations(5)).to be_truthy
       end
     end
 
-    it "should return similar_movies for an ID" do
+    it 'should return similar_movies for an ID' do
       VCR.use_cassette 'movie/similar_for_id' do
-        @movie.similar_movies(5).should be_true
+        expect(@movie.similar_movies(5)).to be_truthy
       end
     end
 
-    it "should return the list the movie belongs to" do
+    it 'should return the list the movie belongs to' do
       VCR.use_cassette 'movie/movie_belongs_for_id' do
-        @movie.lists(5).should be_true
+        expect(@movie.lists(5)).to be_truthy
       end
     end
 
-    it "should return the changes made" do
+    it 'should return the changes made' do
       VCR.use_cassette 'movie/changes_made' do
-        @movie.changes(5).should be_true
+        expect(@movie.changes(5)).to be_truthy
       end
     end
 
-    it "should return credits for an ID" do
+    it 'should return credits for an ID' do
       VCR.use_cassette 'movie/credits_for_id' do
-        @movie.credits(5).should be_true
+        expect(@movie.credits(5)).to be_truthy
       end
     end
   end
 
-  describe "For a movie detail" do
-
+  describe 'For a movie detail' do
     before(:each) do
       VCR.use_cassette 'movie/detail' do
-        @movie = Tmdb::Movie.detail(22855)
+        @movie = Tmdb::Movie.detail(22_855)
       end
     end
 
-    it "should return a id" do
-      @movie['id'].should == 22855
+    it 'should return a id' do
+      expect(@movie['id']).to eq 22_855
     end
 
-    it "should return a adult" do
-      @movie['adult'].should == false
+    it 'should return a adult' do
+      expect(@movie['adult']).to eq false
     end
 
-    it "should return a backdrop_path" do
-      @movie['backdrop_path'].should == "/mXuqM7ksHW1AJ30AInwJvJTAwut.jpg"
+    it 'should return a backdrop_path' do
+      expect(@movie['backdrop_path']).to eq '/mXuqM7ksHW1AJ30AInwJvJTAwut.jpg'
     end
 
-    it "should return a belongs_to_collection" do
-      @movie['belongs_to_collection']['name'].should == "DC Universe Animated Original Movies"
+    it 'should return a belongs_to_collection' do
+      expect(@movie['belongs_to_collection']['name']).to eq 'DC Universe Animated Original Movies'
     end
 
-    it "should return a budget" do
-      @movie['budget'].should == 0
+    it 'should return a budget' do
+      expect(@movie['budget']).to eq 0
     end
 
-    it "should return genres" do
-      @movie['genres'].should_not == []
+    it 'should return genres' do
+      expect(@movie['genres']).not_to eq []
     end
 
-    it "should return homepage" do
-      @movie['homepage'].should == "http://www.warnervideo.com/supermanbatmandvd/"
+    it 'should return homepage' do
+      expect(@movie['homepage']).to eq 'http://www.warnervideo.com/supermanbatmandvd/'
     end
 
-    it "should return a imdb_id" do
-      @movie['imdb_id'].should == "tt1398941"
+    it 'should return a imdb_id' do
+      expect(@movie['imdb_id']).to eq 'tt1398941'
     end
 
-    it "should return a original_title" do
-      @movie['original_title'].should == "Superman/Batman: Public Enemies"
+    it 'should return a original_title' do
+      expect(@movie['original_title']).to eq 'Superman/Batman: Public Enemies'
     end
 
-    it "should return a overview" do
-      @movie['overview'].should == "United States President Lex Luthor uses the oncoming trajectory of a Kryptonite meteor to frame Superman and declare a $1 billion bounty on the heads of the Man of Steel and his ‘partner in crime’, Batman. Heroes and villains alike launch a relentless pursuit of Superman and Batman, who must unite—and recruit help—to try and stave off the action-packed onslaught, stop the meteor Luthors plot."
+    it 'should return a overview' do
+      expect(@movie['overview']).to eq "United States President Lex Luthor uses the oncoming trajectory of a Kryptonite meteor to frame Superman and declare a $1 billion bounty on the heads of the Man of Steel and his ‘partner in crime’, Batman. Heroes and villains alike launch a relentless pursuit of Superman and Batman, who must unite—and recruit help—to try and stave off the action-packed onslaught, stop the meteor Luthors plot."
     end
 
-    it "should return popularity" do
-      @movie['popularity'].should == 1.15974723131612
+    it 'should return popularity' do
+      expect(@movie['popularity']).to eq 1.15974723131612
     end
 
-    it "should return poster_path" do
-      @movie['poster_path'].should == "/7eaHkUKAzfstt6XQCiXyuKiZUAw.jpg"
+    it 'should return poster_path' do
+      expect(@movie['poster_path']).to eq '/7eaHkUKAzfstt6XQCiXyuKiZUAw.jpg'
     end
 
-    it "should return production_companies" do
-      @movie['production_companies'].should_not == []
+    it 'should return production_companies' do
+      expect(@movie['production_companies']).not_to eq []
     end
 
-    it "should return production_countries" do
-      @movie['production_countries'].should_not == []
+    it 'should return production_countries' do
+      expect(@movie['production_countries']).not_to eq []
     end
 
-    it "should return release_date" do
-      @movie['release_date'].should == "2009-09-29"
+    it 'should return release_date' do
+      expect(@movie['release_date']).to eq '2009-09-29'
     end
 
-    it "should return revenue" do
-      @movie['revenue'].should == 0
+    it 'should return revenue' do
+      expect(@movie['revenue']).to eq 0
     end
 
-    it "should return a runtime" do
-      @movie['runtime'].should == 67
+    it 'should return a runtime' do
+      expect(@movie['runtime']).to eq 67
     end
 
-    it "should return spoken_languages" do
-      @movie['spoken_languages'].first['name'].should == "English"
+    it 'should return spoken_languages' do
+      expect(@movie['spoken_languages'].first['name']).to eq 'English'
     end
 
-    it "should return status" do
-      @movie['status'].should == "Released"
+    it 'should return status' do
+      expect(@movie['status']).to eq 'Released'
     end
 
-    it "should return vote_average" do
-      @movie['vote_average'].should == 7.4
+    it 'should return vote_average' do
+      expect(@movie['vote_average']).to eq 7.4
     end
 
-    it "should return vote_count" do
-      @movie['vote_count'].should == 23
+    it 'should return vote_count' do
+      expect(@movie['vote_count']).to eq 23
     end
   end
 
   describe 'For a movie detail with appended response' do
-    let(:append_fields) { %w{ alternative_titles credits images keywords releases
-                            trailers translations reviews lists changes }.join(',') }
+    let(:append_fields) do
+      %w( alternative_titles credits images keywords releases
+          trailers translations reviews lists changes ).join(',')
+    end
     before(:each) do
       VCR.use_cassette 'movie/detail_with_appended_response' do
-        @movie = Tmdb::Movie.detail(22855, append_to_response: append_fields)
+        @movie = Tmdb::Movie.detail(22_855, append_to_response: append_fields)
       end
     end
 
     it 'should return alternative_titles' do
-      @movie['alternative_titles']['titles'].size.should == 4
-      @movie['alternative_titles']['titles'].first['title'].should == 'Superman und Batman Public Enemies'
+      expect(@movie['alternative_titles']['titles'].size).to eq 4
+      expect(@movie['alternative_titles']['titles'].first['title']).to eq 'Superman und Batman Public Enemies'
     end
 
     it 'should return credits' do
-      @movie['credits']['cast'].size.should == 20
-      @movie['credits']['cast'].first['id'].should == 34947
-      @movie['credits']['crew'].size.should == 3
-      @movie['credits']['crew'].first['id'].should == 90367
+      expect(@movie['credits']['cast'].size).to eq 20
+      expect(@movie['credits']['cast'].first['id']).to eq 34_947
+      expect(@movie['credits']['crew'].size).to eq 3
+      expect(@movie['credits']['crew'].first['id']).to eq 90_367
     end
 
     it 'should return images' do
-      @movie['images']['backdrops'].size.should == 6
-      @movie['images']['backdrops'].first['file_path'].should == '/mXuqM7ksHW1AJ30AInwJvJTAwut.jpg'
-      @movie['images']['posters'].size.should == 9
-      @movie['images']['posters'].first['file_path'].should == '/7eaHkUKAzfstt6XQCiXyuKiZUAw.jpg'
+      expect(@movie['images']['backdrops'].size).to eq 6
+      expect(@movie['images']['backdrops'].first['file_path']).to eq '/mXuqM7ksHW1AJ30AInwJvJTAwut.jpg'
+      expect(@movie['images']['posters'].size).to eq 9
+      expect(@movie['images']['posters'].first['file_path']).to eq '/7eaHkUKAzfstt6XQCiXyuKiZUAw.jpg'
     end
 
     it 'should return keywords' do
-      @movie['keywords']['keywords'].size.should == 2
-      @movie['keywords']['keywords'].first['id'].should == 9715
+      expect(@movie['keywords']['keywords'].size).to eq 2
+      expect(@movie['keywords']['keywords'].first['id']).to eq 9715
     end
 
     it 'should return releases' do
-      @movie['releases']['countries'].size.should == 1
-      @movie['releases']['countries'].first['release_date'].should == '2009-09-29'
+      expect(@movie['releases']['countries'].size).to eq 1
+      expect(@movie['releases']['countries'].first['release_date']).to eq '2009-09-29'
     end
 
     it 'should return trailers' do
-      @movie['trailers']['quicktime'].should == []
-      @movie['trailers']['youtube'].size.should == 1
-      @movie['trailers']['youtube'].first['name'].should == 'Official Preview Trailer'
+      expect(@movie['trailers']['quicktime']).to eq []
+      expect(@movie['trailers']['youtube'].size).to eq 1
+      expect(@movie['trailers']['youtube'].first['name']).to eq 'Official Preview Trailer'
     end
 
     it 'should return translations' do
-      @movie['translations']['translations'].size.should == 13
-      @movie['translations']['translations'].first['name'].should == 'English'
+      expect(@movie['translations']['translations'].size).to eq 13
+      expect(@movie['translations']['translations'].first['name']).to eq 'English'
     end
 
     it 'should return reviews' do
-      @movie['reviews']['results'].should == []
+      expect(@movie['reviews']['results']).to eq []
     end
 
     it 'should return lists' do
-      @movie['lists']['results'].size.should == 4
-      @movie['lists']['results'].first['id'].should == '51d6b52219c295172912ff1e'
+      expect(@movie['lists']['results'].size).to eq 4
+      expect(@movie['lists']['results'].first['id']).to eq '51d6b52219c295172912ff1e'
     end
 
     it 'should return changes' do
-      @movie['changes']['changes'].should == []
+      expect(@movie['changes']['changes']).to eq []
     end
   end
 
-  describe "For a movies images" do
-
+  describe 'For a movies images' do
     before(:each) do
       VCR.use_cassette 'movie/images' do
-        @movie = Tmdb::Movie.images(22855)
+        @movie = Tmdb::Movie.images(22_855)
       end
     end
 
-    it "should return backdrops" do
+    it 'should return backdrops' do
       @movie['backdrops'].length == 4
     end
 
-    it "should return posters" do
-      @movie['posters'].should be_true
+    it 'should return posters' do
+      expect(@movie['posters']).to be_truthy
     end
-
   end
 
-  describe "For other languages" do
-
+  describe 'For other languages' do
     before(:each) do
-      Tmdb::Api.language("de")
+      Tmdb::Api.language('de')
       VCR.use_cassette 'movie/language_german' do
         @movie = Tmdb::Movie.detail(562)
       end
       Tmdb::Api.language(nil)
     end
 
-    it "should return the german name" do
-      @movie['title'].should == "Stirb Langsam"
+    it 'should return the german name' do
+      expect(@movie['title']).to eq 'Stirb Langsam'
     end
 
-    it "should return the german description" do
-      @movie['overview'].should == "Eigentlich möchte der New Yorker Polizist John McClane dieses Weihnachten nur seine Noch-Ehefrau Holly, welche in Los Angeles in einer großen, erfolgreichen Firma Karriere gemacht hat, besuchen und das Fest mit den beiden gemeinsamen Kinder verbringen. Als die Feierlichkeiten im Nakatomi Plaza beginnen sollen, stürmt eine Gruppe von Terroristen das Hochhaus und nur John McClane schafft es ihnen zu entwischen. Lediglich bewaffnet mit ein paar Zigaretten und einem Walkie-Talkie, wodurch er den Funk der Geiselnehmer mithören kann, und mit Waffen, welche die Terroristen gelegentlich so rumliegen lassen, muss John nun nicht nur sein eigenes Leben retten, sondern möglichst auch das aller anderen Beteiligten. Und so beschließt er, die äußerst brutale Truppe auszumerzen und sich einen Terroristen nach dem anderen vorzuknöpfen. Während draußen dann schon die Polizei und das FBI stümperhaft versucht, das Gebäude zu stürmen, kämpft McClane ohne Schuhe gegen die 12 Aggressoren..."
+    it 'should return the german description' do
+      expect(@movie['overview']).to eq "Eigentlich möchte der New Yorker Polizist John McClane dieses Weihnachten nur seine Noch-Ehefrau Holly, welche in Los Angeles in einer großen, erfolgreichen Firma Karriere gemacht hat, besuchen und das Fest mit den beiden gemeinsamen Kinder verbringen. Als die Feierlichkeiten im Nakatomi Plaza beginnen sollen, stürmt eine Gruppe von Terroristen das Hochhaus und nur John McClane schafft es ihnen zu entwischen. Lediglich bewaffnet mit ein paar Zigaretten und einem Walkie-Talkie, wodurch er den Funk der Geiselnehmer mithören kann, und mit Waffen, welche die Terroristen gelegentlich so rumliegen lassen, muss John nun nicht nur sein eigenes Leben retten, sondern möglichst auch das aller anderen Beteiligten. Und so beschließt er, die äußerst brutale Truppe auszumerzen und sich einen Terroristen nach dem anderen vorzuknöpfen. Während draußen dann schon die Polizei und das FBI stümperhaft versucht, das Gebäude zu stürmen, kämpft McClane ohne Schuhe gegen die 12 Aggressoren..."
     end
-
   end
-
 end