theme-check 1.9.1 → 1.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39a4bbf1f8a394045deecb8e3b4ccf5cb94f0cfac1e36de7761670a2bb817f7a
-  data.tar.gz: 66cd6e3ae2087b468019a8257e0dd8eded88ff2f2732fa2b1902328ef837ce10
+  metadata.gz: c667ad2be8d10ffe3ded0b949e5ceb4372350462addcfa0f4ecc30b575b3a1cf
+  data.tar.gz: 0ce4f520a0992413b151d2a2d607d81848ed151e6bb0d71ebd154978b44ffd28
 SHA512:
-  metadata.gz: 59144f60da497b0c067218c7408e217fc9af86dbc7b150d7c4aedd06fd07a16442a270e21f0dfba048cb3a85de423efcaea4db67eecc0b7ebc14a3293bcf23e2
-  data.tar.gz: f27e64b460ef9d30ef11b01a4638bb32184a5b1ade3f7279043e2bb6de1749c2778d25d4e056012f6a90f4628acd05d2e35d81c697cb01c3898de081022766e4
+  metadata.gz: 4a3b48d0bc8e896385bdf838e6e6e722e7a960f20af11987a51771c8203da2c39fc76ac97c9621da3c807efe2eca13b7599466f12c086785b3c3812cdd5351dc
+  data.tar.gz: 39daf33306825516b5316356c1ea8a2523cbe7c0b1406fa988d46d50d94356815d817b9a24f6e2c373a3041f6ac0856e186d160104590948c27291333a1c2a03

data/CHANGELOG.md

@@ -1,4 +1,9 @@
 
+v1.9.2 / 2021-12-13
+===================
+
+  * Improve HTML parsing errors
+
 v1.9.1 / 2021-12-09
 ===================
 

data/lib/theme_check/html_node.rb

@@ -140,9 +140,32 @@ module ThemeCheck
     end
 
     def parseable_markup
+      return @parseable_source if @value.name == "#document-fragment"
+
       start_index = from_row_column_to_index(@parseable_source, line_number - 1, 0)
       @parseable_source
-        .match(/<\s*#{@value.name}[^>]*>/im, start_index)[0]
+        .match(/<\s*#{name}[^>]*>/im, start_index)[0]
+    rescue NoMethodError
+      # Don't know what's up with the following issue. Don't think
+      # null check is correct approach. This should give us more info.
+      # https://github.com/Shopify/theme-check/issues/528
+      ThemeCheck.bug(<<~MSG)
+        Can't find a parseable tag of name #{name} inside the parseable HTML.
+
+        Tag name:
+          #{@value.name.inspect}
+
+        File:
+          #{@theme_file.relative_path}
+
+        Line number:
+          #{line_number}
+
+        Excerpt:
+          ```
+          #{@parseable_source.lines[line_number - 1...line_number + 5]}
+          ```
+      MSG
     end
 
     def content

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "1.9.1"
+  VERSION = "1.9.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.9.2
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-12-09 00:00:00.000000000 Z
+date: 2021-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid